summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2014-12-18extensions: Use appropriate OUString functions on string constantsStephan Bergmann4-7/+6
Change-Id: I4f117b3339753af254768724c38167f3595fbe69
2014-12-17Introduce rtl::OUStringLiteral1Stephan Bergmann1-1/+1
...to use single ASCII character literals "more directly" in the OUString API (instead of having to go via an intermediary OUString ctor call). Especially useful for character literals that are defined as const variables or via macros ("direct" uses of character literals in the OUString API can often simply be replaced with single-character string literals, for improved readability). (The functions overloaded for OUStringLiteral1 are those that are actually used by the existing LO code; more could potentially be added. The asymmetry in the operator ==/!= parameter types is by design, though---writing code like 'x' == s is an abomination that shall not be abetted.) Change-Id: Ic5264714be7439eed56b5dfca6ccaee277306f1f
2014-12-15java: remove more test skeleton codeNoel Grandin1-58/+0
Change-Id: I37a82554de4f77be7e0fb3e42245a70b53beb83c Reviewed-on: https://gerrit.libreoffice.org/13476 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15fdo#39440 reduce scope of local variablesMichael Weghorn5-7/+8
This addresses some cppcheck warnings. Change-Id: I026999d6e995185c42df6770a1a700094540d08a Reviewed-on: https://gerrit.libreoffice.org/13454 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-12extensions: Use appropriate OUString functions on string constantsStephan Bergmann10-47/+47
Change-Id: I2476f409604d69e8e8ea1a132cd0a9169b5d435e
2014-12-10java: simplify the getMSF() methodsNoel Grandin1-2/+1
Change-Id: Ib459799f4a3224f8c9683ac4b6cf37982d2077a3 Reviewed-on: https://gerrit.libreoffice.org/13406 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-09changed timers to idlesTobias Madl5-14/+14
Change-Id: I223026ce7676a3f8fcda7eb33326cd4ee949c6f0
2014-12-05fdo#38835 strip out OUString globalsNoel Grandin1-3/+4
Change-Id: I8bc386ffa88e31988bdc778a845403bec0772799
2014-12-04fdo#65163 reintroduce embedded picture for form componentsLionel Elie Mamane1-2/+13
but not for report components (fdo#53001) Change-Id: Ie07e1c2993304d4deb2124e72baa7a326b587918
2014-12-04Revert "coverity#735424 Logically dead code"Lionel Elie Mamane1-3/+22
This reverts commit 1f22e2f954baeec825190ded03510cb6c8069d93. in preparation for fix for fdo#65163 Conflicts: extensions/source/propctrlr/formcomponenthandler.cxx Change-Id: Ifa252ac66724dd3e4b257e3bb6679d9503f8a9db
2014-12-01WaE: -Werror=switchCaolán McNamara1-48/+44
Change-Id: I2cd8ef48620bdd70554658b7468183e902ed8b45
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl8-12/+12
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-25-Werror,-WuninitializedStephan Bergmann1-2/+2
(in PropertyComposer ctor: base class 'comphelper::OBaseMutex' is uninitialized when used here to access 'comphelper::OBaseMutex::m_aMutex') Change-Id: I41ede9ab34e89c8dde23ce2e4fd6393b05c979c6
2014-11-23capitalize e-mail in list of types in bibliographyStanislav Horacek1-1/+1
Change-Id: Ie72627e708f257e7272618d90abf7b54957112b9 Reviewed-on: https://gerrit.libreoffice.org/13076 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl7-0/+7
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18java: make fields final where possibleNoel Grandin4-13/+6
found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl8-0/+9
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14coverity#705989 silence Insecure temporary fileCaolán McNamara2-1/+5
and coverity#705983 Insecure temporary file Change-Id: I2a501f8114ddf8968381e1880263abaf9d1bdc6f
2014-11-14coverity#1242860 Unused valueCaolán McNamara1-1/+1
Change-Id: Id0bb878464fa6df5ed23d4abf5748ed21cb30506
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava6-8/+8
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini3-4/+4
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12java: convert fields to local variables where possibleNoel Grandin1-8/+4
found by PMD Change-Id: I05b45382b8fb1b734657ce9421a20e6ef6fbe542 Reviewed-on: https://gerrit.libreoffice.org/12376 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-11cleanup improper SOLARIS linker libs and optionsRichard PALO2-20/+1
and, most importantly, forget MOTIF! Change-Id: I0230932618b396ec4d5bf7638a13e5a80a4fada0 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2014-11-09fdo#86050 Let LibreOffice add scrollbars to widgets only when necessaryAdolfo Jayme Barrientos1-1/+0
Change-Id: I1a930a413c071d4d0c8855315dc85339e01b7d9b Reviewed-on: https://gerrit.libreoffice.org/12322 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-07fdo#84938: replace MOUSE_ modifier constants with enumNoel Grandin1-1/+1
and make the two categories of constants non-overlapping, we really don't need to risk confusion in order to save 6 bits in a data structure like this. Change-Id: I2251195d8e45ed04e2a89e47ae9c3e52cf0475c0
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann6-9/+9
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin6-9/+9
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin5-26/+13
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-04-Werror,-Winconsistent-missing-overrideStephan Bergmann1-1/+1
(loplugin:saloverride does not warn about them because they depend on template args) Change-Id: I41a1dbfd7db24e58154f6f3810781219119418ba
2014-11-01coverity#703954 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ifc8a4c2a3f22fc12b620a3bd0dd8ace57a99629c
2014-10-31Removed duplicated includesAndrea Gelmini1-8/+9
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-30nothing to see here, move alongCaolán McNamara1-1/+1
brown bag fix for commit cdbfbd0f7c3ed3bd3235f97197d279c41913245b Date: Thu Oct 30 09:21:40 2014 +0000 coverity#735608 Division or modulo by float zero and coverity#735607 Division or modulo by float zero Change-Id: I8e04765cf5354d57a54b166a5e2af71b40b670bb
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini1-1/+1
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#735608 Division or modulo by float zeroCaolán McNamara1-2/+6
and coverity#735607 Division or modulo by float zero Change-Id: Iceeab702e183d291d7b1b6ded9113d1a15163c94
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin7-7/+1
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29ref-counting vcl::Window subclassesNoel Grandin3-3/+1
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin1-1/+1
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27coverity#982164 silence Unchecked return value from libraryCaolán McNamara1-2/+2
Change-Id: Ie2479e3dc73a7c7e8d2d0c5c979bde2ea5d05a1e
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-3/+3
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-25coverity#982164 silence Unchecked return value from libraryCaolán McNamara1-2/+2
Change-Id: Ibec38a7e7846c463601b0a876778f53003cf0441
2014-10-25coverity#982163 silence Unchecked return value from libraryCaolán McNamara1-1/+1
Change-Id: I6b9a3c6ce75472da551706b1c1555eff4ba1abc8
2014-10-17java: final fields that can be staticNoel Grandin1-1/+1
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann1-6/+2
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin1-1/+1
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-11convert vcl StateChangedType to enum classNoel Grandin1-1/+1
Change-Id: Ifa46523619ae7fb8d112525b8df594836e51bb8f Reviewed-on: https://gerrit.libreoffice.org/11843 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-02MWERKS etc. are not supported toolchainsMichael Stahl1-5/+0
Change-Id: I449fe34be396114529357388c87162aaf8976292
2014-10-02coverity#1242860 Unused valueCaolán McNamara1-5/+1
Change-Id: Ibd6d737cf117af0c2fdda7768da6a173c59bd346
2014-10-01loplugin: cstylecastNoel Grandin10-16/+16
Change-Id: I6ea98852ba775d85ccd54823b67224ea7f587c65
2014-10-01fdo#82577: Handle TimeNoel Grandin2-2/+2
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-30extensions: std::auto_ptr -> std::unique_ptrStephan Bergmann17-26/+20
Change-Id: I2d9d2e145584013d8e94f5aea2ec7732452b240c
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 13:40:45 +0000