summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2018-08-01Add missing sal/log.hxx headersGabor Kelemen19-0/+19
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it. This is a continuation of commit 6ff2d84ade299cb3d14d4110e4cf1a4b8070c030 to be able to remove those unneeded includes. This commit adds missing headers to every file found by: grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG') to directories from dbaccess to extensions Change-Id: I4d15aa35e11664ef78c836ffc2937c7e0bb6ea59 Reviewed-on: https://gerrit.libreoffice.org/58165 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-29loplugin:stringloop in variousNoel Grandin3-10/+10
Change-Id: Ic2436c6d94729211cd5bc72fee18af228381e4a3 Reviewed-on: https://gerrit.libreoffice.org/58250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23Fix typosAndrea Gelmini2-2/+2
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2 Reviewed-on: https://gerrit.libreoffice.org/57810 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-22Fix typosAndrea Gelmini1-1/+1
Change-Id: I326827c394347cbe9fad242e9da5702cba7a4d95 Reviewed-on: https://gerrit.libreoffice.org/57761 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-18Fix typosAndrea Gelmini1-1/+1
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-14tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorUlkem Kasapoglu1-4/+1
Change-Id: I09016a06110772379ddf8b15f14446346b850cd6 Reviewed-on: https://gerrit.libreoffice.org/57339 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-09loplugin:oncevarNoel Grandin1-2/+1
Change-Id: Id295dc0db174a448ef73db9de34f2de07d47f09a Reviewed-on: https://gerrit.libreoffice.org/57108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-26Fix typoAndrea Gelmini1-1/+1
Change-Id: I47cf4db535562e4db505b44981d86d40171e7630 Reviewed-on: https://gerrit.libreoffice.org/56424 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-26tdf#96099 Remove some trivial container iterator typedefsArkadiy Illarionov2-4/+2
Change-Id: Ifec98748d55ff6aca64c425c50c2cf2650f61591 Reviewed-on: https://gerrit.libreoffice.org/56422 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-25Add a FIXMETor Lillqvist1-0/+4
Change-Id: I3771d6f4703bbd1f012389f5699928464875290f
2018-06-20move SvColorDialog to welded argumentsCaolán McNamara1-2/+3
Change-Id: Ieb04fc4684caa6df47b123ab06e280f2d204375a Reviewed-on: https://gerrit.libreoffice.org/56162 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-15menubar sbibliography: finish menubar and fix a bug in the toolbarandreas kainz2-28/+24
Change-Id: I08a6e29aeac8c16bbb987c5513cbf3d0777d4b3a Reviewed-on: https://gerrit.libreoffice.org/55835 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-06-14menubar: sync file bibliography menubarandreas kainz1-18/+0
Change-Id: I40726ace2cb8c1c5e02d4c68154d920d079bdf93 Reviewed-on: https://gerrit.libreoffice.org/55546 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Jenkins
2018-06-12simplify calls to *DialogFactory::Create methodsNoel Grandin3-4/+0
we don't need to check for nullptr here, it's never null. Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56 Reviewed-on: https://gerrit.libreoffice.org/55114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-12Support named arguments in InterfaceOleWrapper::Invoke()Tor Lillqvist1-6/+91
Convert a DISPPARAMS with named arguments into one with just positional ones. If there are gaps, use markers for them (VARIANTs with VT_ERROR:DISP_E_PARAMNOTFOUND). Those are then passed on as empty UNO Anys. Change-Id: Iad1197ba2559567a9c0eca4524e76389c2048fec Reviewed-on: https://gerrit.libreoffice.org/55646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-11Show also args in the SAL_INFO in InterfaceOleWrapper::Invoke()Tor Lillqvist1-1/+15
Change-Id: I8d1d3273fcafe1ce750e66e55712eac607722717 Reviewed-on: https://gerrit.libreoffice.org/55643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-11Fix typoAndrea Gelmini1-1/+1
Change-Id: I22eb441313c2f06ecbbbe86a8b2c4dc602861cff Reviewed-on: https://gerrit.libreoffice.org/55611 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-10Start of work on supporting named argumentsTor Lillqvist1-11/+50
In InterfaceOleWrapper::GetIDsOfNames(), look up also the parameter names, if present (if cNames > 1, rgszNames entries after the first). Return S_OK only if *all* the names were found, i.e. both the first (method or property) name, *and* all the parameter names. Change-Id: Ie04bc0558a7e2044ef527fc18f99230c71985a22 Reviewed-on: https://gerrit.libreoffice.org/55549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-08Fix glitch in SAL_INFO loggingTor Lillqvist1-3/+4
Change-Id: I421d3980c50706f927a0611e48c33a43267dd01b Reviewed-on: https://gerrit.libreoffice.org/55477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-08Log all the names being looked up in GetIDsOfNames()Tor Lillqvist1-3/+11
Change-Id: Ia116021ecc9f20c82622a4bc8ee40e7a9a1508fa Reviewed-on: https://gerrit.libreoffice.org/55479 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-08look for unnecessary calls to Reference::is() after an UNO_QUERY_THROWNoel Grandin1-9/+6
Since the previous call would throw if there was nothing to be assigned to the value. Idea from tml. Used the following script to find places: git grep -A3 -n UNO_QUERY_THROW | grep -B3 -F 'is()' Change-Id: I36ba7b00bcd014bdf16c0455ab91056f82194969 Reviewed-on: https://gerrit.libreoffice.org/55417 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-06-07Fix off-by-one error: The XCollection loop index is one-basedTor Lillqvist1-2/+2
We must compare the index against the number of entries with '>' and not '>='. Change-Id: I2de9e53b2a0d923d4136ee5e093baa955c8301da Reviewed-on: https://gerrit.libreoffice.org/55405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-07Improve logging in CXEnumVariantTor Lillqvist1-5/+26
Change-Id: Ia0c3f9f1e95980b14415a030fc40268629ae06f3 Reviewed-on: https://gerrit.libreoffice.org/55399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-06tdf#118026: Use ooo::vba::XCollection instead of css::container::XEnumerationTor Lillqvist1-13/+20
An object returned by XCollection::Item() is of the right "VBA" kind that we want. One returned by XEnumeration::nextElement() is not. Change-Id: I26132a7d0f2638a61f2711b941386a889fabea72 Reviewed-on: https://gerrit.libreoffice.org/55392 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke8-6/+5
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04Various clang-cl/loplugin errors in extensions/source/ole/unoobjw.cxxStephan Bergmann1-226/+209
-Werror,-Wnon-virtual-dtor: made various dtors virtual -Werror,-Winconsistent-missing-override in END_COM_MAP: silenced the same way as in other places across the code base loplugin:unreffun in BEGIN_COM_MAP and END_COM_MAP: silence with -Wunused-function various -Werror in atlbase.h and atlcom.h: silenced the same way as in e.g. embedserv/source/inc/stdafx.h -Werror,-Wshadow -Werror,-Wunused-function loplugin:casttovoid loplugin:cstylecast loplugin:nullptr loplugin:salbool loplugin:subtlezeroinit Change-Id: Ifefdc930a1d3ecf5366523dea509bfaca1f4e001 Reviewed-on: https://gerrit.libreoffice.org/55186 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-03tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov1-4/+2
Change-Id: I21171bd90b5e19fe8e5b8f2d125b6dfcb9a8b766 Reviewed-on: https://gerrit.libreoffice.org/55198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-01Improve handling of _SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNINGStephan Bergmann2-6/+0
_SILENCE_CXX17_CODECVT_HEADER_DEPRECATION_WARNING turned into a global -D..., same as existing _SILENCE_CXX17_OLD_ALLOCATOR_MEMBERS_DEPRECATION_WARNING. Change-Id: Ifefdc930a1d3ecf5366523dea509bfaca1f4e002 Reviewed-on: https://gerrit.libreoffice.org/55188 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-06-01Fix typosAndrea Gelmini1-3/+3
Change-Id: Icc6fd609d3e57277822c4de76bd3baf4b1900840 Reviewed-on: https://gerrit.libreoffice.org/55176 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-01loplugin:unoany (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I2a27c41ed2045cca8b8efb5f9d07f3015c67f8a1 Reviewed-on: https://gerrit.libreoffice.org/55169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-01tdf#96099 Remove some trivial typedef std::vectorArkadiy Illarionov3-7/+5
Change-Id: Iaba48932dde059c88401ee60f7aac0048a79e9eb Reviewed-on: https://gerrit.libreoffice.org/55045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-01Fix typosAndrea Gelmini1-1/+1
Change-Id: I17d6a674fbe7b5eebd21cad5a9491c129679e5c1 Reviewed-on: https://gerrit.libreoffice.org/55117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-05-31Run soffice frpm instdir (but CustomTarget_automationtest still can't work)Tor Lillqvist2-3/+11
WScript.CreateObject() takes the symbolic name of the object class that it then looks up from the Registry to find the CLSID of the class. I don't really know how we could make this unit test work at build time. Keep it still commented out in the module makefile. Change-Id: I73418754db9ccc3f5d384754d4d3be74ae1f9dca
2018-05-31Log the call to CoRegisterClassObject()Tor Lillqvist1-0/+3
Change-Id: Idfca38ec2c931572b6978440862c7bfca8d536e6
2018-05-31Revert "Simplify: Use AutomationInvokedZone::isActive()"Tor Lillqvist1-1/+2
Can't have the URE library 'stoc' depend on the non-URE library 'comphelper'. This reverts commit 3c041720304ec77202741b5d5c8df9b93bc70a70.
2018-05-31Comment out CustomTarget_automationtest for now, it can't work properlyTor Lillqvist1-3/+3
Can't assume that the necessary entries are in the Registry. Need to fix it to start soffice explcitly before running the VBScript. Change-Id: I809be88a2fe2afbda1f087501785ec7a9e2a358b
2018-05-31Add a SAL_INFOTor Lillqvist1-0/+2
Change-Id: Ic197a9573968fb252cb52cc5089f9140d5375d3a
2018-05-31Add a unit test for the Automation client servicesTor Lillqvist3-0/+155
Written in VBScript, yay. Change-Id: Ibbdba804939c2646aef8f8a2bb3781eaf1a6d208
2018-05-31Simplify: Use AutomationInvokedZone::isActive()Tor Lillqvist1-2/+1
Don't need the mbFromOLE boolean flag and the special "FromOLE" parameter passed to the InvocationService:: createInstanceWithArguments(). Change-Id: I05e10a78955d87cb7c37e198c60c3ddcfdbc4275
2018-05-31Need to enter the AutomationInvokedZone here, tooTor Lillqvist1-0/+3
Change-Id: I2723146f2c549c630dfa0e5da330af228cb305a0
2018-05-31Enter AutomationInvokedZone appropriatelyTor Lillqvist1-0/+46
Change-Id: Ic76fc43fc521a6fd6642e22b71c311370788d4aa
2018-05-31Make convertDispparamsArgs() handle mismatch in number of parameters sanelyTor Lillqvist1-13/+53
Parameters come in in reverse order in pdispparams. There might be less parameters than expected. In that case, assume the missing ones are "optional" (but can't be marked as such in UNO IDL), and fill in the rest with empty Anys. There might also be more parameters than expected. In that case, assume the oovbaapi UNO IDL hasn't kept up with added optional parameters in MSO, and just ignore the extra ones, as long as they are empty. An example: incoming parameters: <12, 13, "foo/bar.tem"> Expected paramters: (string filename, int something, int somethingElse, Any whatever, Any whateverElse) Here the existing incoming parameters are placed in reverse order in the first three outgoing parameters, and the rest of the outgoing paramters are passed as empty Anys. Another example: incoming parameters: <EMPTY, TRUE> Expected parameters: (bool flag) Here the TRUE is passed as the sole outgoing parameter, and the incoming EMPTY is ignored. Still an example: incoming parameters: <"foo.doc", TRUE> Expected parameters: (bool flag) This throws an error as the incoming non-empty extra parameter presumably indicates something important, but there is no corresponding outgoing parameter to pass it in. Change-Id: Ib04f9701099ecb899e792d99ff86588022b3bbf6
2018-05-31Implement EnumConnections, and fix handling of mismatched parameter numberTor Lillqvist1-36/+159
If we have too few parameters, fill with empty ones, as before. If we have more paramters than the called method expects, but the extra ones are empty anyway, ignore them. Do all of this in convertDispparamsArgs(). This improves interoperability with typical Automation clients. Change-Id: I47376993dc10b401e4c349e19b2bbe4be9f8f444
2018-05-31Make SAL_INFO logging style more usefulTor Lillqvist1-51/+51
Make it easier to search for a specific class and function in the output by outputting the 'this' pointer first, not between the class and function name. Change-Id: Ia6e087e3a4be9e701c418aedb9b6af5fd4f6e828
2018-05-31Initial steps to make also Calc usable from Automation clientsTor Lillqvist1-0/+16
Largely parallel to what we do for Writer. Yes, there is a fair amount of duplicated code now for the outgoing ("sink") stuff in sw and sc, that should be factored out (to vbahelper, probably). Change-Id: I8df4a81c3b9043e8d6b0b206e3c04660205987c7
2018-05-31Use correct index for incoming Arguments sequenceTor Lillqvist1-4/+4
Change-Id: I1c706a2139cb2596969c6c1d166d3f9fe9f91d39
2018-05-31Initialise mxMSF in all casesTor Lillqvist1-3/+6
Change-Id: Ib7fcdbe934b66971995574226f982a6865faab1b
2018-05-31Add informative commentTor Lillqvist1-0/+10
Change-Id: I428c2bbaa273d893fa5a3cc42bb7f3d060f375ad
2018-05-31First attempt at passing arguments, also in and inout, to Automation callbacksTor Lillqvist1-6/+120
Change-Id: Iff629243888153250b655a5e942ced024e3338a7
2018-05-31A few SAL_INFO tweaksTor Lillqvist1-1/+2
Change-Id: I4a9c6341891bc80d8ab7648ed972d57739aa4f4a
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 06:31:13 +0000