summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2015-08-31loplugin:stringconstant: OUStringBuffer: appendAscii -> appendStephan Bergmann9-44/+44
Change-Id: Iea6b497b91b8874bfaded494a114cbeef4417b70
2015-08-28Bin a few leftover (?) stderr printoutsTor Lillqvist2-9/+0
If they are truly needed, use SAL_INFO then.
2015-08-28make PostUserEvent Link<> typedNoel Grandin20-47/+32
Change-Id: I13f10bda985d55d419a5bff481130a456ae2db8a
2015-08-26Convert vcl Button Link<> click handler to typed Link<Button*,void>Noel Grandin31-79/+51
Change-Id: Ie80dfb003118d40741549c41ebcc7eda4819f05b
2015-08-21tdf#39440 reduce scope of local variablesMichael Weghorn1-4/+4
This addresses some cppcheck warnings. Change-Id: I97726ed32e5aa92e7da7d248380a78b1b201e46e Reviewed-on: https://gerrit.libreoffice.org/17912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-21loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I900ddfbba7f58d4ed78a709170506222a1feb320
2015-08-19Remove two silly typedefsStephan Bergmann9-17/+17
Change-Id: Ia7de1cebf6009e770ca1b96bab6d5e121573ccc1
2015-08-19Consolidate isFileUrl checksStephan Bergmann3-4/+7
Change-Id: I1b74fdfaa09c4d0d6c296253958e83e78b546a9a
2015-08-17o3tl: rename compat_functional headerThorsten Behrens3-3/+3
After the cleanup, the stuff there really stands on its own (and the remaining usage of select1st/2nd is more descriptive than lambdas). Change-Id: I0aba131d5dc550189f8130d167dc94167e404540 Reviewed-on: https://gerrit.libreoffice.org/17806 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud1-5/+5
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-14loplugin: defaultparamsNoel Grandin15-26/+26
Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
2015-08-11tdf#92459 Cleanup unclear lambdasDaniel Robertson3-4/+6
Replace lambdas used to select the first/second member of a pair with the new simplified select1st/2nd from o3tl/compat_functional. There should be no side effects due to this change. Change-Id: I17f37796e0c4defe96a10aa491d192adb9eebb89 Reviewed-on: https://gerrit.libreoffice.org/17656 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-08Explicit capture annotationsStephan Bergmann1-1/+1
Change-Id: I7be1a36196a07a80a7b7173c3869621f5d707204
2015-08-08tdf#92459 remove compat_functional from extensionsDaniel Robertson3-7/+5
Replace all uses of deprecated features from the o3tl in compat_functional.hxx with lambda expressions in extensions. There should be no side effects due to this patch. Change-Id: Ib9a217c1d61593eaba82431ab047e5b899c74568 Reviewed-on: https://gerrit.libreoffice.org/17587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-08-06tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe54-109/+101
with the variadic variants in extensions. Change-Id: I45e9dc5769150181df88791b3f748002ca713c02 Reviewed-on: https://gerrit.libreoffice.org/17517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05loplugin:unusedmethodsNoel Grandin16-121/+5
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin1-6/+6
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24loplugin:unusedmethodsNoel Grandin10-31/+1
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-23Bin pointless #ifndef #define danceTor Lillqvist1-5/+0
Change-Id: I0f7a3183a16a56f831a828af9de6c8f8c459339a
2015-07-17formatting of public/private/protected section qualifiersNoel Grandin1-1/+1
make it consistent across the codebase, no space between keyword and the colon Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5 Reviewed-on: https://gerrit.libreoffice.org/17148 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-16loplugin:simplifyboolStephan Bergmann1-2/+2
Change-Id: Ib1af2097743f81c0bdd237941eab017a5d463b37
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann3-19/+6
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-10extensions: convert boost::bindMichael Stahl1-3/+2
Change-Id: I7922140eaaeb428da0f268cac41f7a227693c25a
2015-07-10do not include boost/utility.hppMichael Stahl1-1/+1
It just includes a bunch of other boost headers; mostly we need boost/noncopyable.hpp so include that directly. This eliminates 831 MB(!) of boost/preprocessor/seq/fold_left.hpp completely, which is the 2nd biggest header after ustring.hxx. Change-Id: I3df55770adcb46e56f389af828e8ba80da2dc1f2
2015-07-09tdf#92611 - unwind UNO lifecycle snafu.Michael Meeks3-7/+10
Introduced in commit 1c4025babd7037a3292aa530c7d45ab8d6ef6dcb. Was using UNO reference counting on a member allocated as part of another object. Change-Id: Ic86b2aa30359dc202c8bc2f1a0de476167a1e561 Reviewed-on: https://gerrit.libreoffice.org/16889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-09remove obsolete check for pre-MSVC2013 ATL library nameMichael Stahl3-3/+3
Change-Id: I52bba4d4c0558e6b87530e4577f4b1ef458b7012 Reviewed-on: https://gerrit.libreoffice.org/16888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-07-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-03Fix typosAndrea Gelmini4-5/+5
Change-Id: Id884946cae0687d0b71c967e236e58df17567884 Reviewed-on: https://gerrit.libreoffice.org/16707 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-03typo: therfore -> thereforeAndras Timar2-2/+2
Change-Id: I9dcc0ce882dfd533d98a4f71625bb85e44084283
2015-07-01tdf#67343 Arrange Help button in a seconday group (extensions)Adolfo Jayme Barrientos5-196/+74
Change-Id: I516c8e7a33d0d05a619971b387352f8360d4765c
2015-06-30Fix typosAndrea Gelmini1-1/+1
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin2-4/+4
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann1-2/+3
Change-Id: I6f877a3b58686e037a48e2b594c58b6502c2ef78
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-2/+2
Change-Id: Ia4f844e0e9249f54d134fbbde11aa1f7e250e8af
2015-06-18Fix typosAndrea Gelmini1-1/+1
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe9-38/+36
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f Reviewed-on: https://gerrit.libreoffice.org/16309 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15more untranslatable UI stringsAndras Timar1-4/+4
Change-Id: I4c02d7613743a1b11594fd96f6131219afd102ef
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin2-4/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-15cppcheck:redundantAssignmentNoel Grandin1-3/+2
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-13use VclPtr<>::CreateDavid Tardon1-1/+1
Change-Id: I4b3abbd390e7b6cb449ccd7f0fb956266fd0b5c8
2015-06-09dbaccess: gcc-4.7 error: '<::' cannot begin a template-argument listMiklos Vajna1-1/+1
Change-Id: I27547009862b50a1cb0244c144c46c0aadef65f3
2015-06-09extensions: gcc-4.7 error: '<::' cannot begin a template-argument listMiklos Vajna1-1/+1
Change-Id: I005d398c1c9bdcf84815340e83e826740c1fc651
2015-06-09loplugin:unnecessaryvirtualsNoel Grandin1-1/+1
Improve the plugin a little. Create a python script to process the output. Run it again. Change-Id: I05c21d8a21c8f4243af739c412fda0a521f9b5f0
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann9-22/+22
Change-Id: I4c3c6bfce836ddc35ba6b277e240f5ed7e652e57
2015-06-06Apply new VclPtr clang plugin to catch potential problems.Noel Grandin1-2/+2
Omit the plugin, and sw's FrameControlsManager for now. Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f Reviewed-on: https://gerrit.libreoffice.org/16117 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-05abpilot: fix relative reference of embedded data sourceMiklos Vajna1-1/+2
With this, not only the MM wizard, but the address book data source wizard can create relative references correctly. Change-Id: Id7357dbcc4503ca69595992ee7ebd6b1234d386a
2015-06-04abpilot: refer embedded data source from doc settingsMiklos Vajna1-0/+6
So that even if the address book data source wizard creates the embedded data source, next time the document is loaded, we can find it. Change-Id: Ibb11fa119fb27976437e54bed1d590cfd9863236
2015-06-04abpilot: embed the data source definition, if possible + requestedMiklos Vajna3-5/+52
Change-Id: I0e70459e331995388b36c77c351bff89ece004a6