summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2018-05-22Bin dead codeTor Lillqvist2-181/+0
OleServer::provideService() was not called anywhere. That means the ProviderOleWrapper class is unused, too. Which is good, as it seemed to largely be identical to OneInstanceOleWrapper anyway. Change-Id: If8782d56ed1ec1bb173cfc18be585be4c331f335 Reviewed-on: https://gerrit.libreoffice.org/54647 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21In fact it's simpler to not have m_guid fields in these two classes at allTor Lillqvist2-22/+16
We can just pass the GUID as parameter to the single member function registerClass() that needs it. This perhaps means the same class can be used in more cases, also for objects/classes that aren't going to be registered and don't need any GUID. Change-Id: I28703190c52b14236c6f613dd4acbe359c075f5c Reviewed-on: https://gerrit.libreoffice.org/54622 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-21There is nothing called o2u_anyToVariantTor Lillqvist1-1/+1
Change-Id: I7118843fde87a2d587f0e4ec99d146c379da618e
2018-05-21These fields can be constTor Lillqvist1-2/+2
Change-Id: I103f06b9c7f14ac7eff9911ab5bebc4c98e7d41f Reviewed-on: https://gerrit.libreoffice.org/54614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-19Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie0c9f168759a625d78668cd57838b208fbc9dc56 Reviewed-on: https://gerrit.libreoffice.org/54458 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-17No need for this #pragma onceTor Lillqvist1-5/+0
Change-Id: I219226060ebf4b8b86c8f0487fc679f22f73812a Reviewed-on: https://gerrit.libreoffice.org/54468 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-17We only support MSVC anyway for our Windows-specific codeTor Lillqvist1-4/+0
Change-Id: I68dfd0832747c7c319e40ee28a4461623e95102f Reviewed-on: https://gerrit.libreoffice.org/54482 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-17loplugin:unusedfields in editeng..filterNoel Grandin2-3/+1
Change-Id: I42e41ec69667a5560c5f31c85eb05074666a7bab Reviewed-on: https://gerrit.libreoffice.org/54455 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16Drop _Impl class name suffix where pointlessTor Lillqvist8-260/+242
I.e. where there is no other LibreOffice, or system, or 3rd-party library thing with just the un-suffixed name that they would be a pimpl of, etc. Why bother calling something InterfaceOleWrapper_Impl when there is nothing that would be called InterfaceOleWrapper? It just makes the code seem more complicated and harder to read. An "implementation" of something is what everything that is not fully abstract *is*. We don't suffix the name of every non-abstract class with _Impl elsewhere either. Also drop two unused structs. Change-Id: I2755e6da78d8e4ded5291688dc90510b5f8b498b Reviewed-on: https://gerrit.libreoffice.org/54411 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-15loplugin:unnecessaryoverride, loplugin:cstylecast (clang-cl)Stephan Bergmann1-3/+3
Change-Id: I316965219f70a87b59b731e4d5e6b67d2010c2b9 Reviewed-on: https://gerrit.libreoffice.org/54350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-14loplugin:useuniqueptr in SaneDlgNoel Grandin4-22/+12
Change-Id: I712b733c9c24db2e2fcdc4b6ce16e38eaf0b27f0 Reviewed-on: https://gerrit.libreoffice.org/54167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-14tdf#117282 Do not set property 'Name' at ControlShapeArmin Le Grand1-2/+9
Formally property 'Name' was set at com.sun.star.drawing.ControlShape, but this Shape does not (and never did) support that Property. It should have thrown an UnknownPropertyException in the past, but did not do that by error. It was just ignored in SvxShape::_setPropertyValue and lost. Solution is to just not set it anymore. This loses nothing (was never set, see above), but avoids the (now correctly thrown) exception. Change-Id: Id6bdc545862f91692213afe6fb706b98d3fce211 Reviewed-on: https://gerrit.libreoffice.org/54145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-05-13Translate German commentsJohnny_M1-2/+2
Change-Id: I6a03e921b28da5ac26235f32f547f36e00a47e46 Reviewed-on: https://gerrit.libreoffice.org/54079 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-11coverity#705646 Resource leakCaolán McNamara1-1/+1
Change-Id: I709b16f720cf97c05207cfb22d0c0ea15622367a Reviewed-on: https://gerrit.libreoffice.org/54139 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-09Don't throw in LdapUserProfileBe ctor on LDAP misconfigurationMike Kaganski2-21/+21
Otherwise LO crashes e.g. at opening Expert Configuration dialog. Instead, log the event, create an empty backend, and return empty values. Change-Id: I433fc89c003e7886dfc5242a4ef8defa46d643d3 Reviewed-on: https://gerrit.libreoffice.org/53958 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-07loplugin:useuniqueptr in SaneNoel Grandin2-8/+5
Change-Id: I06e9423e667ee87d767bbc17e62798ae0586e975 Reviewed-on: https://gerrit.libreoffice.org/53877 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02WinUserInfoBe: a new config backend for user data provided by WindowsMike Kaganski6-0/+683
This backend provides Active Directory details for current user. If the system is not part of Active Directory domain, GetUserNameEx is used instead, so at least user (given) name is configured. Unlike ldap backend, this one doesn't need connection configuration, as the used API works with current user security context. Change-Id: I74bcc79591a658dc5121df1f09caa15d272fbe12 Reviewed-on: https://gerrit.libreoffice.org/53590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-22Iceweasel and Icedove are dead…Adolfo Jayme Barrientos1-2/+2
… since 2016 and 2017, respectively. Change-Id: Ic4e501ceee198d9a802e7a5e7732fda3b899a8cb
2018-04-22Don’t use frames to group only one set of controlsAdolfo Jayme Barrientos1-188/+151
Just add a simple label to them. Change-Id: I5382d521ac744a6760c572599489589f49b303d6
2018-04-21Get rid of GraphicObject URL in extensions - PropertyControllerTomaž Vajngerl2-8/+4
Instead of that, use "Graphic" property and set an XGraphic. Change-Id: Ib3084d22b422b82b69be3d410560caac303e780d Reviewed-on: https://gerrit.libreoffice.org/53240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-04-17loplugin:constparamsNoel Grandin1-1/+1
Change-Id: I3d1b88dbd0ff73fddc08d52f50e0efb42daab89b Reviewed-on: https://gerrit.libreoffice.org/52756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16Fix typosAndrea Gelmini1-2/+2
Change-Id: Ife28cd9399cfcb375bad764dac7424eda50d430d Reviewed-on: https://gerrit.libreoffice.org/52198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-15remove some unused comphelper includesJochen Nitschke6-9/+0
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-14look for check buttons without underlinesCaolán McNamara3-0/+5
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: https://gerrit.libreoffice.org/52847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-14look for radio buttons without underlinesCaolán McNamara2-0/+9
Change-Id: I0ed97515a03a5633628a492ec7797fc3ade8a3d8 Reviewed-on: https://gerrit.libreoffice.org/52846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-11new loplugin:unusedvariablemoreNoel Grandin1-3/+0
collection of heuristics to look for local variables that are never read from i.e. do not contribute to the surrounding logic This is an expensive plugin, since it walks up the parent tree, so it is off by default. Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06 Reviewed-on: https://gerrit.libreoffice.org/52450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-06weld linkeditdialogCaolán McNamara2-4/+7
which enables changing FileDialogHelper over to welded Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c Reviewed-on: https://gerrit.libreoffice.org/52388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-03new loplugin:dbgunhandledexceptionNoel Grandin1-9/+9
enforce that DBG_UNHANDLED_EXCEPTION is called first in a catch block, otherwise it cannot do it's job properly Change-Id: I906436c6861212c44f8f21552ccbceb54f15c6e1 Reviewed-on: https://gerrit.libreoffice.org/52303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-03pass area param to DBG_UNHANDLED_EXCEPTIONNoel Grandin23-84/+84
and update sallogareas plugin to enforce this Change-Id: Id0782c8a1f619372e10d931aec3c6a4743a4c86a Reviewed-on: https://gerrit.libreoffice.org/52249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-02use https links for api.libreoffice.org and opengrokdennisroczek1-1/+1
Change-Id: I74dd0142562cb8698f19b2715fa1d514f82bd749 Reviewed-on: https://gerrit.libreoffice.org/52262 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-02drop the spurious invisible_char[_set] propertiesCaolán McNamara5-5/+0
Change-Id: I8264a4f6035fd19c7a892902c41127615eaf6dd3 Reviewed-on: https://gerrit.libreoffice.org/52265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke8-9/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-31Added includes that are only used in DEBUG buildshimajin1000001-0/+4
Change-Id: I80f835ce31d44c1df32955fdc48f0accfb062747 Reviewed-on: https://gerrit.libreoffice.org/52162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-21support both vcl and weld in genericunodialog for interimCaolán McNamara9-31/+26
Change-Id: Ife85dd7a4bd27260514b390ca3928152db0d688f Reviewed-on: https://gerrit.libreoffice.org/51699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop msgbox includeCaolán McNamara2-2/+2
Change-Id: Ic7872adf8a7e8e4a8e1503dd21e22ec69509efaf Reviewed-on: https://gerrit.libreoffice.org/51652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-20drop unnecessary includesCaolán McNamara11-11/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-18unify the message dialogs with extra widgets casesCaolán McNamara1-17/+19
Change-Id: I9ad3573b15d24c3d1737b9f450792952ae20a31b Reviewed-on: https://gerrit.libreoffice.org/51476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-15filedialog: use isGraphicObjectUniqueIdURL instead of constantTomaž Vajngerl1-1/+2
Change-Id: I54f5a1dae10219b3d6f06640488eded7f6840767 Reviewed-on: https://gerrit.libreoffice.org/51327 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-13Modernize a bit extensionsJulien Nabet16-269/+164
mainly by using for-range loops Change-Id: I297275748ffdce0576e51f63294d7e5b21729af7 Reviewed-on: https://gerrit.libreoffice.org/51182 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-09Fix typoAndrea Gelmini1-1/+1
Change-Id: I59f1f2e83ecec5b2f7aa57255a52c99794d27596 Reviewed-on: https://gerrit.libreoffice.org/51002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-09Make the CoInitializeEx() (non-)error reporting ludicrously verboseTor Lillqvist1-2/+26
Tell in the SAL_WARN what apartment mode the thread is in. It's a bit unclear to me why the code insists on calling this o2u_attachCurrentThread() function even in cases where it perhaps should know that it is in the main thread, which has been initialised as STA by the CoInitialize() in InitSalData(). Change-Id: Ia69e67f8b17ee153d3bcf8ae450d5f413dea2e1a Reviewed-on: https://gerrit.libreoffice.org/50985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-08loplugin:cstylecast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ia9184268ed734bb0cee94c5eb870d3425bc47ac4 Reviewed-on: https://gerrit.libreoffice.org/50942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-08loplugin:constantparam in desktop..i18npoolNoel Grandin6-34/+23
Change-Id: Ie2e1004c1ccc03777a8da9cb1144e89eb28ff313 Reviewed-on: https://gerrit.libreoffice.org/50928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-07make all the .ui message dialogs explicitly modalCaolán McNamara1-0/+2
Change-Id: I1e197fbec92d5369394f036171af9018afea7f15 Reviewed-on: https://gerrit.libreoffice.org/50910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-07use more Color in editeng..formsNoel Grandin3-13/+10
Change-Id: If6c862e7bb61cd78c3379afde11b528a74162900 Reviewed-on: https://gerrit.libreoffice.org/50860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara26-26/+26
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01drop old tools/gen methods in accessibility..formulaNoel Grandin1-1/+4
Change-Id: I075e29173945200854f2ef8e420867871659766a Reviewed-on: https://gerrit.libreoffice.org/50446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin2-2/+2
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke4-4/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin2-5/+5
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 22:13:18 +0000