summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2017-12-18vcl: rename Window::Notify to EventNotifyMichael Stahl4-6/+6
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49 (cherry picked from commit 6bb20609a2fd1d591cedc7fa2b9cabb589c346c7) (cherry picked from commit 03bfafb36107d18c0cccf53efdd550c0b7a81b8f)
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin4-4/+4
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-18convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin1-1/+1
(cherry picked from commit 803215142efa6437515348f63bd70ffdcf5d45f1) (cherry picked from commit 736cd289d4cdb0db61d92134bcc9d48aa7e79613) Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2017-12-05remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2887aefa4d4f60ba8b0cd7efd5d3a73ffb209781)
2017-10-26tdf#113225 - hold the solar mutex when entering from UNO.Michael Meeks1-0/+1
http://crashreport.libreoffice.org/stats/crash_details/dff57662-1693-47f6-8b09-88f180d2e706 Change-Id: I4322c2113c300af97fb5854aac4a741b7027e6b1 Reviewed-on: https://gerrit.libreoffice.org/43623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 254c49dcceaa8b181b2cb3338e34e5637be277b9) Reviewed-on: https://gerrit.libreoffice.org/43637 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit b2bb871b9b91d1a22f4db2edd5cb93a2011318ec)
2017-08-11desktop,extensions: updater: only allow redirects to HTTP/HTTPSMichael Stahl1-0/+2
Configure curl to prevent redirects to other protocols. Change-Id: Ied73b3d9a062ea6e0a1d594f4c12162dffd6c4a7 (cherry picked from commit bd60bbfbdfbeb2687297e4512ddbea62a394ae67) Reviewed-on: https://gerrit.libreoffice.org/40940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 3dceaeee4ff511f4c4b67846bdc5b87fda4a3633)
2017-05-30Resolves: tdf#107981 SID_FM_CTL_PROPERTIES colorbox needs a 'default' entryCaolán McNamara1-28/+8
we don't need MakeHexStr either, the colorbox will do that on its own Reviewed-on: https://gerrit.libreoffice.org/37898 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7539c77fd49889015ad3a952009e33fac5324df6) Change-Id: Ifad523092c0f15cd51d0d829790c0cec1c96bb53 Reviewed-on: https://gerrit.libreoffice.org/37905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c05f35f4f56a1e65b92f4b1bc43b0fa6138d209c)
2017-05-07Collabora Office: remove Safe Mode from menus and Windows start menuAndras Timar1-2/+0
Change-Id: I9eaf6ef76597be6bc35462308f1cee61cb9bae5a
2017-03-28Resolves: tdf#106461 use a row height of max of edit and listbox heightCaolán McNamara1-4/+5
not just take the listbox because edits can be taller and result in overlaps Change-Id: I6067b384484d933727220febda723bc9e8c5e90b (cherry picked from commit 5013abeb191cdc6f8375f107a4d30abd802547d2) Reviewed-on: https://gerrit.libreoffice.org/35596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 910582360d2a2f0455841b2cd0c3cc2c7ed08344)
2017-02-20ERROR ITMS-90511: CFBundleIdentifier CollisionAndras Timar1-2/+2
(cherry picked from commit 5c70145805eb3bc4968f1aed8695fdc4468705ab) (cherry picked from commit 345e3c7843e1cae01080548568fb6eaa6930a2b9) Change-Id: I4413853a2e8c23af770323a1e7b21cedb637cfb1
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin4-5/+5
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-01-26tdf#105467 new color widget doesn't support XStringListControlCaolán McNamara1-1/+1
so this threw and mangled the dialog. New color dialog doesn't need to be told the name of colors, it figures that out itself. Change-Id: I89382b6b26312fc90c967620c654ea611cbd9616 (cherry picked from commit d92b12604b644195328b89cb9355cd4fc4bc3e2d) Reviewed-on: https://gerrit.libreoffice.org/33501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-18loplugin:datamembershadowNoel Grandin1-1/+0
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin4-5/+5
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin4-5/+5
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin2-6/+2
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:expandablemethods in extensionsNoel Grandin18-138/+47
Change-Id: I93a770933de86146de1d25db9d596615916c3e28 Reviewed-on: https://gerrit.libreoffice.org/30689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Revert "Reverts a commit series that cripple windows ci."Caolán McNamara4-121/+36
with addition of... - svxlo-SvxColorListBox + svxcorelo-SvxColorListBox This reverts commit db380aab1063e8a5e40111c40ee9f7921aa82601. Change-Id: I3af7aa0abb1a430bce64188244404fcbd480b128 Reviewed-on: https://gerrit.libreoffice.org/30598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-05Reverts a commit series that cripple windows ci.Norbert Thiebaud4-36/+121
Revert "SvxShadowTabPage::Construct was removed" f9a2c1c12ecad833c63b894c89d6008907477eb5. Revert "replace OColorPopup with SvxColorWindow" f300754bb1c6a347c92bb9548be7a65237176542. Revert "drop AutoColorInvalid/SID_ATTR_AUTO_COLOR_INVALID" 347c2c334589b18cc62af292674bb3df1dd54b71. Revert "replace last ColorLB use with a listbox of colors" 604b35bf55351751a396e34dcca3f85e75860fd5. Revert "simplify, its just a vector of colors" 351a97ce6bda3075677b59fa1387ba3d1ab17d7a. Revert "replace user draw with an Image of the color" df738e0f8ceedb4bad756960be14d9c41adc165d. Revert "strip down to the used pieces" commit 08d6cd788f2584ce10ab8fa10665245e953c59d9. Revert "move now combined ColorLB to location of last user" a19b18ad7c9eb0197c10e6d7e451ec4542e4bc9e. Revert "fold ColorListBox and ColorLB together" a989a0b1f2b425f05b58d0e44ce2de31c842ed65. Revert "move ColorListBox beside sole thing that uses it" 760a198e697f3070a5e0e029e4eff7be220eb9cd. Revert "extensions leaks out details of Color Selector, patch it up" 8bea644d6117a49405e6426dc97214220fc869d1. Revert "inherit FillAttrLB from ListBox not ColorListBox" d2ce812f1d3a7a2aad89ca0bd11948b63d2db7b0. Revert "unify color selectors" 43bc3031483d172eccd72c3804e2d4fc2ef37de4.
2016-11-04extensions leaks out details of Color Selector, patch it upCaolán McNamara4-121/+36
and rebase it on SvxColorListBox Change-Id: I3afef689ab0dc3c34e465810d82bf21797907558
2016-11-04loplugin:oncevar in desktop..filterNoel Grandin3-15/+6
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee Reviewed-on: https://gerrit.libreoffice.org/30564 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-04tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu2-16/+2
Change-Id: I619cb50c3475519921ffd318b32875ae4ff2c0b8 Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke4-6/+6
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31update vclwidgets plugin to check local variablesNoel Grandin1-1/+1
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin1-1/+1
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin1-1/+1
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-27loplugin:expandablemethods in svtoolsNoel Grandin1-3/+0
Change-Id: I126cc87c890867c3e762f86969a20d64aef63108 Reviewed-on: https://gerrit.libreoffice.org/30314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21Adapt Windows-only code to deletion of the "Any-to-Any" specializatiosStephan Bergmann1-4/+4
...upcoming with <https://gerrit.libreoffice.org/#/c/30022/> "Delete the 'Any- to-Any' template specializations for LIBO_INTERNAL_ONLY" Change-Id: If070825d88ffa7bb49e645b3bfeae9dfa387f000
2016-10-19tdf#96015 (part) link to Doc'tation in Help menuOlivier Hallot1-0/+1
Add the entry "Documentation" to the modules Help menu. on click, the system browser opens http://hub.libreoffice.org/documentation/?&LOlang=<locale> <locale> is obtained from .getLocale() Patch2: create a member with try/catch for external URLs Patch3 Use sfx2::openUriExternally Revert to User Guides.. in UI. Change-Id: I8332253c31bd3be330cdd794f9e056b632b38037 Patch4: remove 1st '&' in URLs Reviewed-on: https://gerrit.libreoffice.org/28817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-10-19loplugin:expandablemethodds in editeng..extensionsNoel Grandin10-35/+6
Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08 Reviewed-on: https://gerrit.libreoffice.org/30013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18replace <<= with assign for <<= with rhs AnyJochen Nitschke1-1/+1
found by deleting specialization of '<<=' template Change-Id: I253f15177ab20fd3ef9baf4158da8c662cb47e6c Reviewed-on: https://gerrit.libreoffice.org/29956 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-18so_activex_x64: Avoid warning LNK4070Mike Kaganski1-1/+1
Don't specify optional library name in DEF file that is used both for 32-bit and 64-bit library: it's explicitly specified in command line. Change-Id: I20e732f2095367ec3648741dde26cf7ec101f28f Reviewed-on: https://gerrit.libreoffice.org/30008 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke1-17/+17
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: extensionsStephan Bergmann28-717/+836
Change-Id: I659d8a3b098c7417235006c86ea60e7fe1e56a44 Reviewed-on: https://gerrit.libreoffice.org/29867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-13drop unused RID_RSC_BUTTON_IMAGES resourceCaolán McNamara6-45/+1
Change-Id: If85a3491c3cb6ebb05a82e1c732083d99e91d6e8
2016-10-13move this monstrosity to the last place its usedCaolán McNamara5-5/+0
Change-Id: I4691f20143406249afc8da1a6dfa901224f4a62d
2016-10-13remove (yet yet another) StringListResource implementationCaolán McNamara3-464/+216
Change-Id: Ifaf89badfc339f8253a629c6960df8a943b8cce5
2016-10-12remove StringListResource in favour of ResStringArray...Caolán McNamara6-41/+67
and turn local resources used as lists of strings into string array resources Change-Id: I9d67a790659963bca87aacba1c052d7b244b4e21
2016-10-12tdf#70979 make conference proceedings strings uniqueYousuf Philips1-2/+2
Change-Id: I8386651390ba753108577ced29050585b72c5e78 Reviewed-on: https://gerrit.libreoffice.org/28813 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-10-12loplugin:unnecessaryoverride in extensions..filterNoel Grandin2-8/+0
Change-Id: Ifd954bf48291cdc43c66fd44b4029e47eb7589f6 Reviewed-on: https://gerrit.libreoffice.org/29690 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10safemode: Add uno command and menu entrySamuel Mehrbrodt1-0/+2
Change-Id: I1843767160b79041c42e506eff0cf39399c74f26 Reviewed-on: https://gerrit.libreoffice.org/29668 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-06I can't see any evidence of any remaining magenta mask using image resourcesCaolán McNamara2-15/+10
Change-Id: I12865d743daa3e6479edb60584d5bd01f88e818d
2016-10-06ImageList just reads and discards the MaskColor, so drop itCaolán McNamara2-5/+0
Change-Id: I243e739fea28e3f38b91534182cc54c2aa660f0e
2016-10-05convert the last two lonely FixedInfos to FixedTextCaolán McNamara1-1/+0
Change-Id: Ia6ed5f71931a6141efb3d5e5eb329149d6850342
2016-10-05convert MapUnit to scoped enumNoel Grandin10-23/+23
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann63-167/+167
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-02cppcheck invalidPrintfArgTypeJochen Nitschke1-7/+7
signedness and long vs int corrections Change-Id: I67c6b9e05b16f5d8d4693879f1656db50dc7ec48 Reviewed-on: https://gerrit.libreoffice.org/29355 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-09-25remove unused parameterJochen Nitschke1-1/+1
bTotalRanges is never used. SFX_ITEMSET_NO_DEFAULT_CTOR is no where else used. Change-Id: Ia35ea875f16a8ca04c2173b01074113f1825f565 Reviewed-on: https://gerrit.libreoffice.org/29248 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-23-Werror,-Wignored-attributesStephan Bergmann1-0/+1
(__declspec attribute 'allocator' in MSVC 2015 atlalloc.h; clang-cl) Change-Id: I88d2bc4667ded75a545c95f428e654be787b03f8
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin2-11/+5
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>