summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin2-4/+4
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11sd: remove pointless micro-optimizationMichael Stahl1-1/+0
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann7-9/+9
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin1-1/+1
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04Better fix for Windows-only codeStephan Bergmann1-1/+1
Change-Id: I8437ec66b615754d71c726f715a6beeb4a0f7dda
2016-05-04Fix Windows-only code, part 3Stephan Bergmann1-2/+1
Change-Id: I1a87cb1b8c5b5603c4043cd2d5de37a336ad88b6
2016-05-04Fix Windows-only code, part 2Stephan Bergmann1-1/+1
Change-Id: I5e860cd88e851b7bce5fa503108ffe61a36c0817
2016-05-04Fix Windows-only codeStephan Bergmann1-2/+1
Change-Id: Iaf6d668f65e31c60dba8140d789f6578ef461264
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann1-2/+2
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03NULL -> nullptrStephan Bergmann1-1/+1
Change-Id: I94d0df867b6ef59cf6485e4cee7ac655155f9b87
2016-05-03NULL -> nullptrStephan Bergmann1-4/+4
Change-Id: I0bd2dc2e2ed1f699133e3e7753359b969fbee322
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann1-3/+1
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin1-3/+1
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-01Typo: OAddessBookSourcePilot->OAddressBookSourcePilotJulien Nabet15-53/+53
Change-Id: I26587b761c91433fe80b9439e7e7c5e420db6192 Reviewed-on: https://gerrit.libreoffice.org/24552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28tdf#97087 Give comprehensible, unique names to idlesMuhammet Kara1-1/+2
Timers and idles should have programmer comprehensible, unique names Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101 Reviewed-on: https://gerrit.libreoffice.org/24388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-27-Werror,-WvarargsStephan Bergmann1-12/+8
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just drop the variadic overload and use the one taking a WizardPath (i.e., a vector) Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26clang-tidy modernize-loop-convert in e*Noel Grandin13-76/+60
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de Reviewed-on: https://gerrit.libreoffice.org/24384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-4/+4
Change-Id: I2dcc7bb0c8d5a6e205d627330735237f85fd9f9f
2016-04-22Avoid reserved identifiersStephan Bergmann8-34/+34
Change-Id: I5a68cac4f923218a000c79a01c436bf1dc897971
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann27-97/+97
Change-Id: Ief96e7038461f514d8fe5bf16b7181b122715775
2016-04-18Avoid reserved identifierStephan Bergmann1-6/+6
Change-Id: Ic1f02173e268934df2edbbb2ed752b4736c6e959
2016-04-18cppcheck: noExplicitConstructorCaolán McNamara3-3/+3
Change-Id: Iee9d28c9630a144e4da8e46e58f01a4be99aa961
2016-04-18Fix unconditional seek in sanedlgRohan Kumar1-0/+2
I fixed my previous mistake of keeping that xTransporter->getStream().Seek( STREAM_SEEK_TO_END ); in live code by wrapping it under OSL_DEBUG_LEVEL > 0 . Change-Id: I3f3bd3308e90610ab3d14f112e4da8bf46ecd25c Reviewed-on: https://gerrit.libreoffice.org/24188 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin5-18/+13
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke15-36/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin6-6/+6
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin6-7/+7
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifiersStephan Bergmann4-12/+12
Change-Id: I10be69e36c79c15d2e02457558e37ec3efbf80c1
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar3-39/+16
I removed OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFO(..)s or OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the build Change-Id: I3eccdd769ff32e57e12209706e5fbbdd9638de54 Reviewed-on: https://gerrit.libreoffice.org/23068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke9-12/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable ...Jochen Nitschke7-19/+21
... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:constantparamNoel Grandin6-16/+11
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04tdf#97499 Fixed containers parameters clearing #4tymyjan1-1/+1
Change-Id: I7c96181399f4d7e62d4aceca404b22d68f903513 Reviewed-on: https://gerrit.libreoffice.org/23754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke6-7/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01fix brown paper bag in extensionsNoel Grandin1-1/+0
from my commit 8c8fdb0a668d759adac11bd83203c8eeded390d5 "sequence->vector in extensions" Change-Id: I85432c50915bf9cd663e1c22c20766cd00bbfc4b
2016-04-01sequence->vector in extensionsNoel Grandin13-159/+134
Change-Id: Iaf7feae5927795e8b5508f9ef49369fad802a57f Reviewed-on: https://gerrit.libreoffice.org/23689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-01tdf#97966 Drop 'static' keywordsWastack3-4/+4
Including no keywords from extern "C" blocks Change-Id: I8bcd7e8a492ee4dbfa5141416c7c038a1391cf20 Reviewed-on: https://gerrit.libreoffice.org/23673 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-30loplugin:staticanonymousStephan Bergmann1-3/+3
cf. <https://gerrit.libreoffice.org/#/c/23630/> "tdf#97966 Compiler plugin"; in code not covered by Tamás's pending "tdf#97966 Drop 'static' keywords" changes. Change-Id: Ifbaef83fdb1fde7e25fafd5746cdbf99c334c5be
2016-03-23loplugin:constantparam in extensinsNoel Grandin4-7/+6
Change-Id: Iab77bb089e77460f75466259d7b63ed49453b8f4
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin1-17/+17
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-15loplugin:constantparamNoel Grandin2-7/+6
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14remove some unused Java codeNoel Grandin1-2/+2
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-11tdf#97966: Remove 'static' keywordsWastack1-1/+1
Change-Id: I0d9837a7ccecd606e0d43b53f8b920547b0d0bcd Reviewed-on: https://gerrit.libreoffice.org/23132 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11work on sane lifecylce for SfxFilterMarkus Mohrhard3-5/+5
all SfxFilter instances should now be hold inside of a std::shared_ptr. This fixes a number of huge memory leaks in the test framework and removes one huge source of memory issue in sfx2. SfxMedium contains a pointer to the SfxFilter but does not own. Therefore it is required that any SfxFilter belonging to a SfxMedium lives longer. However this seems to work mostly by hoping that all SfxFilter instances are stored in a global array. As we have seen with the tests this is not true (there are also some cases inside of sd that seem to not follow that pattern as well). Change-Id: I12fd04a504cc4efc0a94967abd91c6fe2c6a8ce8 Reviewed-on: https://gerrit.libreoffice.org/23140 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-10Remove unused tag type name (that happens to be reserved) in typedefStephan Bergmann1-1/+1
Change-Id: I593e7f711c108b273f7a9d0bdcf90c84e97c4d29
2016-03-10loplugin:constantparam in extensionsNoel Grandin2-7/+7
Change-Id: Icdfde86b1291a9b831f6eac4d8c00faa326106b7