summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2017-08-09Change all Idle* LINKs to be Timer*Jan-Marek Glogowski5-10/+10
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Conflicts: avmedia/inc/mediacontrol.hxx avmedia/source/framework/mediacontrol.cxx avmedia/source/framework/soundhandler.cxx avmedia/source/framework/soundhandler.hxx basctl/source/basicide/baside2.hxx basctl/source/basicide/baside2b.cxx basctl/source/dlged/dlged.cxx basctl/source/inc/dlged.hxx chart2/source/view/charttypes/GL3DBarChart.cxx chart2/source/view/inc/GL3DBarChart.hxx cui/source/dialogs/cuigaldlg.cxx cui/source/dialogs/linkdlg.cxx cui/source/dialogs/thesdlg.cxx cui/source/inc/backgrnd.hxx cui/source/inc/chardlg.hxx cui/source/inc/cuigaldlg.hxx cui/source/inc/linkdlg.hxx cui/source/inc/macroass.hxx cui/source/inc/thesdlg.hxx cui/source/options/optjava.cxx cui/source/options/optjava.hxx cui/source/tabpages/backgrnd.cxx cui/source/tabpages/chardlg.cxx cui/source/tabpages/macroass.cxx dbaccess/source/ui/inc/JoinTableView.hxx dbaccess/source/ui/querydesign/JoinTableView.cxx dbaccess/source/ui/tabledesign/TEditControl.cxx desktop/source/app/app.cxx desktop/source/deployment/gui/dp_gui_dialog2.cxx desktop/source/deployment/gui/dp_gui_dialog2.hxx editeng/source/editeng/impedit.hxx editeng/source/editeng/impedit3.cxx extensions/source/bibliography/bibcont.cxx extensions/source/bibliography/bibcont.hxx extensions/source/bibliography/toolbar.cxx extensions/source/bibliography/toolbar.hxx extensions/source/update/ui/updatecheckui.cxx forms/source/component/ListBox.cxx forms/source/component/ListBox.hxx formula/source/ui/dlg/formula.cxx formula/source/ui/dlg/funcutl.cxx fpicker/source/office/iodlg.cxx framework/source/services/autorecovery.cxx include/formula/formula.hxx include/formula/funcutl.hxx include/sfx2/basedlgs.hxx include/sfx2/dinfdlg.hxx include/sfx2/dispatch.hxx include/sfx2/dockwin.hxx include/svtools/asynclink.hxx include/svtools/filechangedchecker.hxx include/svtools/treelistbox.hxx include/svtools/wizdlg.hxx include/svx/fontwork.hxx include/svx/graphctl.hxx include/svx/imapdlg.hxx include/svx/modctrl.hxx include/svx/numvset.hxx include/svx/sidebar/PanelLayout.hxx include/svx/svdpntv.hxx include/vcl/dockwin.hxx include/vcl/syswin.hxx include/vcl/texteng.hxx include/vcl/toolbox.hxx include/vcl/window.hxx linguistic/source/lngsvcmgr.cxx linguistic/source/lngsvcmgr.hxx reportdesign/source/ui/inc/DesignView.hxx reportdesign/source/ui/report/DesignView.cxx sc/inc/chartlis.hxx sc/inc/document.hxx sc/inc/scmod.hxx sc/source/core/data/documen2.cxx sc/source/core/tool/chartlis.cxx sc/source/ui/app/scmod.cxx sc/source/ui/dbgui/filtdlg.cxx sc/source/ui/dbgui/sfiltdlg.cxx sc/source/ui/docshell/autostyl.cxx sc/source/ui/inc/acredlin.hxx sc/source/ui/inc/anyrefdg.hxx sc/source/ui/inc/autostyl.hxx sc/source/ui/inc/conflictsdlg.hxx sc/source/ui/inc/filtdlg.hxx sc/source/ui/inc/navipi.hxx sc/source/ui/inc/tphfedit.hxx sc/source/ui/miscdlgs/acredlin.cxx sc/source/ui/miscdlgs/anyrefdg.cxx sc/source/ui/miscdlgs/conflictsdlg.cxx sc/source/ui/navipi/navipi.cxx sc/source/ui/pagedlg/tphfedit.cxx sd/inc/drawdoc.hxx sd/source/core/drawdoc4.cxx sd/source/ui/dlg/brkdlg.cxx sd/source/ui/dlg/filedlg.cxx sd/source/ui/framework/configuration/ConfigurationUpdater.cxx sd/source/ui/framework/module/ShellStackGuard.cxx sd/source/ui/framework/module/ShellStackGuard.hxx sd/source/ui/inc/BreakDlg.hxx sd/source/ui/inc/View.hxx sd/source/ui/slidesorter/controller/SlsAnimator.cxx sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx sd/source/ui/view/sdview4.cxx sfx2/source/appl/appcfg.cxx sfx2/source/appl/newhelp.cxx sfx2/source/appl/newhelp.hxx sfx2/source/control/dispatch.cxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/basedlgs.cxx sfx2/source/dialog/dinfdlg.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx sfx2/source/dialog/filedlgimpl.hxx sfx2/source/dialog/templdlg.cxx sfx2/source/doc/new.cxx sfx2/source/inc/templdgi.hxx sfx2/source/view/ipclient.cxx starmath/inc/edit.hxx starmath/source/edit.cxx svtools/source/contnr/imivctl.hxx svtools/source/contnr/imivctl1.cxx svtools/source/contnr/svimpbox.cxx svtools/source/contnr/treelistbox.cxx svtools/source/control/asynclink.cxx svtools/source/control/tabbar.cxx svtools/source/dialogs/wizdlg.cxx svtools/source/graphic/grfmgr.cxx svtools/source/inc/svimpbox.hxx svtools/source/misc/filechangedchecker.cxx svx/inc/sdr/overlay/overlaymanagerbuffered.hxx svx/inc/svdibrow.hxx svx/source/dialog/_contdlg.cxx svx/source/dialog/contimp.hxx svx/source/dialog/fontwork.cxx svx/source/dialog/graphctl.cxx svx/source/dialog/imapdlg.cxx svx/source/dialog/svxbmpnumvalueset.cxx svx/source/form/datanavi.cxx svx/source/form/formcontroller.cxx svx/source/inc/datanavi.hxx svx/source/inc/formcontroller.hxx svx/source/sdr/overlay/overlaymanagerbuffered.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx svx/source/sidebar/media/MediaPlaybackPanel.hxx svx/source/stbctrls/modctrl.cxx svx/source/svdraw/svdibrow.cxx svx/source/svdraw/svdpntv.cxx svx/source/tbxctrls/grafctrl.cxx sw/inc/doc.hxx sw/qa/extras/uiwriter/uiwriter.cxx sw/source/core/doc/DocumentStatisticsManager.cxx sw/source/core/doc/DocumentTimerManager.cxx sw/source/core/doc/docdesc.cxx sw/source/core/docnode/threadmanager.cxx sw/source/core/inc/DocumentTimerManager.hxx sw/source/core/inc/threadmanager.hxx sw/source/ui/dbui/mmoutputtypepage.cxx sw/source/ui/envelp/labfmt.cxx sw/source/ui/envelp/labfmt.hxx sw/source/ui/inc/mmresultdialogs.hxx sw/source/uibase/docvw/edtwin.cxx sw/source/uibase/docvw/srcedtw.cxx sw/source/uibase/inc/edtwin.hxx sw/source/uibase/inc/navipi.hxx sw/source/uibase/inc/srcedtw.hxx sw/source/uibase/inc/unotools.hxx sw/source/uibase/utlui/navipi.cxx sw/source/uibase/utlui/unotools.cxx vcl/backendtest/VisualBackendTest.cxx vcl/inc/svdata.hxx vcl/inc/unx/gtk/gtksalmenu.hxx vcl/source/app/svapp.cxx vcl/source/edit/texteng.cxx vcl/source/window/dockmgr.cxx vcl/source/window/dockwin.cxx vcl/source/window/paint.cxx vcl/source/window/syswin.cxx vcl/source/window/toolbox.cxx vcl/source/window/window.cxx vcl/unx/generic/print/genprnpsp.cxx vcl/unx/gtk/gtksalmenu.cxx Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-08-09Refactor Scheduler to add Task classJan-Marek Glogowski3-3/+3
Moves all the "task-specific" stuff into a Task class and just keeps the "real" static Scheduler functions in the original Scheduler class. Conflicts: desktop/source/lib/init.cxx include/vcl/scheduler.hxx sfx2/source/control/itemdel.cxx sfx2/source/dialog/dockwin.cxx sfx2/source/dialog/filedlghelper.cxx svx/source/sdr/event/eventhandler.cxx svx/source/sidebar/PanelLayout.cxx svx/source/sidebar/media/MediaPlaybackPanel.cxx sw/source/uibase/docvw/srcedtw.cxx toolkit/source/awt/vclxtoolkit.cxx vcl/backendtest/VisualBackendTest.cxx vcl/source/app/scheduler.cxx vcl/source/window/window.cxx Change-Id: I9eb02d46e2bcf1abb06af5bab1fa0ee734d1984c
2016-09-09it is possible that Sources is emptyMarkus Mohrhard1-0/+6
See e.g. http://crashreport.libreoffice.org/stats/crash_details/570429b8-21e3-494e-9677-ea95fa8a5293 Change-Id: I8c05efd61fa5a91511c06c660c49a0c470a96c88 Reviewed-on: https://gerrit.libreoffice.org/27947 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/28753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-03masses of MessBoxes not being disposed promptlyCaolán McNamara3-3/+3
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X (cherry picked from commit a860df25dd7bf62ecb6b3d3ed38803b981f56d52) Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f Reviewed-on: https://gerrit.libreoffice.org/27537 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-17Resolves: tdf#96251 address wizard crash when run from start centerCaolán McNamara1-1/+2
Change-Id: I20de1fbdd3ca609a1818dfe8f81ba66b1cb15281 (cherry picked from commit d6665da4eae15cf21eecaf048d1c9eb7381b3b99)
2016-06-14Resolves: tdf#92478 avoid crash on using scanner on windows x64Caolán McNamara1-1/+4
which appears to correspond to backtrace http://crashreport.libreoffice.org/stats/crash_details/ad46ef89-6b98-44f9-b060-ccb25015269d (prevents the crash only, does not enable scanning on x64) Change-Id: Ic5a4b66028db6ba4aea08baf5bf4a672f71745a0 Reviewed-on: https://gerrit.libreoffice.org/26197 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 7c983445656e1f1942cf2d7398a77342004ed168) Reviewed-on: https://gerrit.libreoffice.org/26247 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-06-07tdf#99643 OLE automation bridge: fix 64-bit pointer conversionsMichael Stahl5-10/+12
XBridgeSupplier2::createBridge() is always called in-process and should therefore expect and create Anys with native-sized encoded pointers, so use sal_uIntPtr. Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63 Note: Currently all calls in LO code are with source=UNO, target=OLE. (cherry picked from commit c11e60f11f34b12bf73a08a96634202a8d3aef0c) Reviewed-on: https://gerrit.libreoffice.org/25985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-25(nearly) nothing uses GetUniqueId anymore, so remove it.Caolán McNamara6-13/+4
The odd one out is the usage in Formula, which attempts to restore focus to a particular window identified by an unique id. In this case restore focus by keeping a VclPtr to the desired window. Change-Id: I1dc335325c109d75745c6bba2e12662e6ae50638
2016-05-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I860cc4aa04b4e5cd1437b2f24176ee2ccdec3266 Reviewed-on: https://gerrit.libreoffice.org/25420 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-24Revert "remove some manual ref-counting"Noel Grandin2-11/+13
until I have a better understanding of the UNO reference counting. This reverts commit 111de438ea3e512a541281dc0716cc728ea8d152.
2016-05-24remove some manual ref-countingNoel Grandin2-13/+11
triggered when I noticed a class doing acquire() in the constructor and then release() in the destructor. found mostly by git grep -n -B5 -e '->release()' Change-Id: Ie1abeaed75c1f861df185e3bde680272dbadc97f Reviewed-on: https://gerrit.libreoffice.org/25363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-21tdf#97221 restore original message for failed check of updateStanislav Horacek1-1/+1
the message is not specific for server errors Change-Id: If282acfaefa4fc5843757dff730dd84ece528210 Reviewed-on: https://gerrit.libreoffice.org/25217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2016-05-19clang-tidy misc-unused-alias-declsNoel Grandin2-2/+0
Change-Id: Iabde7a84b9c2758e0d2b2ffe0fb99fcfa51ff124 Reviewed-on: https://gerrit.libreoffice.org/25075 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18update unusedmethods plugin to deal with constructorsNoel Grandin3-7/+0
and fix the operator< implementations in some of the other plugins too. Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035 Reviewed-on: https://gerrit.libreoffice.org/25057 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18clang-tidy modernize-make-sharedNoel Grandin1-1/+1
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a Reviewed-on: https://gerrit.libreoffice.org/25056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-16Fix typosAndrea Gelmini1-1/+1
Change-Id: If7262e114b5b4cd40e9c0a8929940199ea747595 Reviewed-on: https://gerrit.libreoffice.org/25025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin2-4/+4
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-11sd: remove pointless micro-optimizationMichael Stahl1-1/+0
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann7-9/+9
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin1-1/+1
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-04Better fix for Windows-only codeStephan Bergmann1-1/+1
Change-Id: I8437ec66b615754d71c726f715a6beeb4a0f7dda
2016-05-04Fix Windows-only code, part 3Stephan Bergmann1-2/+1
Change-Id: I1a87cb1b8c5b5603c4043cd2d5de37a336ad88b6
2016-05-04Fix Windows-only code, part 2Stephan Bergmann1-1/+1
Change-Id: I5e860cd88e851b7bce5fa503108ffe61a36c0817
2016-05-04Fix Windows-only codeStephan Bergmann1-2/+1
Change-Id: Iaf6d668f65e31c60dba8140d789f6578ef461264
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann1-2/+2
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03NULL -> nullptrStephan Bergmann1-1/+1
Change-Id: I94d0df867b6ef59cf6485e4cee7ac655155f9b87
2016-05-03NULL -> nullptrStephan Bergmann1-4/+4
Change-Id: I0bd2dc2e2ed1f699133e3e7753359b969fbee322
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann1-3/+1
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-03use Any constructor for bool values, instead of temporary varsNoel Grandin1-3/+1
mostly found with: git grep -n 'setValue.*cppu.*UnoType.*bool.*get' Change-Id: Ie8e5aa6402d25dbe90b0f492031a245bb222c1a5 Reviewed-on: https://gerrit.libreoffice.org/24464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-01Typo: OAddessBookSourcePilot->OAddressBookSourcePilotJulien Nabet15-53/+53
Change-Id: I26587b761c91433fe80b9439e7e7c5e420db6192 Reviewed-on: https://gerrit.libreoffice.org/24552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28tdf#97087 Give comprehensible, unique names to idlesMuhammet Kara1-1/+2
Timers and idles should have programmer comprehensible, unique names Change-Id: Id0f2c0a77cd28c3ec5473e8432569739b58d2101 Reviewed-on: https://gerrit.libreoffice.org/24388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-27-Werror,-WvarargsStephan Bergmann1-12/+8
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just drop the variadic overload and use the one taking a WizardPath (i.e., a vector) Change-Id: I6e389f60f8b7cb0633bf173bde69af1c5af86048
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin1-2/+2
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26clang-tidy modernize-loop-convert in e*Noel Grandin13-76/+60
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de Reviewed-on: https://gerrit.libreoffice.org/24384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-25Some more sal_Bool -> boolStephan Bergmann1-4/+4
Change-Id: I2dcc7bb0c8d5a6e205d627330735237f85fd9f9f
2016-04-22Avoid reserved identifiersStephan Bergmann8-34/+34
Change-Id: I5a68cac4f923218a000c79a01c436bf1dc897971
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann27-97/+97
Change-Id: Ief96e7038461f514d8fe5bf16b7181b122715775
2016-04-18Avoid reserved identifierStephan Bergmann1-6/+6
Change-Id: Ic1f02173e268934df2edbbb2ed752b4736c6e959
2016-04-18cppcheck: noExplicitConstructorCaolán McNamara3-3/+3
Change-Id: Iee9d28c9630a144e4da8e46e58f01a4be99aa961
2016-04-18Fix unconditional seek in sanedlgRohan Kumar1-0/+2
I fixed my previous mistake of keeping that xTransporter->getStream().Seek( STREAM_SEEK_TO_END ); in live code by wrapping it under OSL_DEBUG_LEVEL > 0 . Change-Id: I3f3bd3308e90610ab3d14f112e4da8bf46ecd25c Reviewed-on: https://gerrit.libreoffice.org/24188 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin5-18/+13
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke15-36/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin6-6/+6
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin6-7/+7
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12Avoid reserved identifiersStephan Bergmann4-12/+12
Change-Id: I10be69e36c79c15d2e02457558e37ec3efbf80c1
2016-04-12tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionalsRohan Kumar3-39/+16
I removed OSL_DEBUG_LEVEL > 1 conditionals by SAL_INFO(..)s or OSL_DEBUG_LEVEL > 0 and made sure that it doesn't break the build Change-Id: I3eccdd769ff32e57e12209706e5fbbdd9638de54 Reviewed-on: https://gerrit.libreoffice.org/23068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke9-12/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11tdf#94306 replace boost::noncopyable ...Jochen Nitschke7-19/+21
... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-09-21 03:54:14 +0000