summaryrefslogtreecommitdiff
path: root/extensions
AgeCommit message (Collapse)AuthorFilesLines
2021-04-06tdf#141084 don't notify that the control has changed content until focus-outCaolán McNamara2-4/+12
while also keeping tdf#140239 working too Change-Id: I42833f6a4d2440781cf3f2297b78c6e313b3d239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113474 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit d0628bd6813de2685f4367118dc0f9ca036d1eaf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113477 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-25tdf#139070 format entry view of multilines with final formattingCaolán McNamara1-1/+10
so during editing of a multiline the singleline entry shows what it will show when editing is finished, so we suppress the default behaviour of gtk to show a newline symbol and the default behaviour of vcl to strip newlines Change-Id: Id7d384efc8b737c463f1bd44ca61376f342edb25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111417 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-02-13tdf#140239 leave current cursor valid if the contents won't changeCaolán McNamara1-10/+8
Change-Id: I854e8e94c7415d9046088e364f966390c4fb762f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110772 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-26tdf#139486 also listen to the Entry to determine if the SpinButton was changedCaolán McNamara1-1/+3
the Window::FocusOut handler the browser installs is called before the Control::FocusOut handler, built-into vcl::Control, is called and the Control::FocusOut handler is the one that calls the (speculative) ValueChanged so the browser determines that the SpinButton is unchanged at the time of focus out. If we additionally listen to Changed at the Entry level we will correctly know that widget is modified in some way at the Window::FocusOut time. Change-Id: I540d917fc7375fa61662aa69397bcbaa04a91f26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109881 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2020-12-17tdf#138701 leave current combobox cursor valid if the contents won't changeCaolán McNamara1-1/+4
Change-Id: I6d7f5de7b79d447590fcfa325f4be7430eaffd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107708 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-12-07Remove remaining bogus use of objc_msgSend()Tor Lillqvist4-13/+4
Follow-up to 5bf61e98b0746a4afeb68a80e54b4eb4bf4ea89f. Should avoid crashes when running as arm64 code on macOS on arm64. Change-Id: Id05d182684df82c8a7bf09f6bb7e8ccb01997b62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107259 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107327 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-19Resolves: tdf#138271 flag formatted spinbuttons as modified on any entry changeCaolán McNamara1-0/+2
formattedspinbuttons should send value-changed on losing focus, but this is sufficient for this use case and safe to backport Change-Id: Ie0cf5ab22152d95169dc5579423a4173be678a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105999 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-16tdf#138131 don't set enabled if container is already enabledCaolán McNamara1-6/+8
Change-Id: I46556c7242ad9b5c4c7a8fb923dc87458e56494e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105538 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-15tdf#135526 ranges overflowing to become negativeCaolán McNamara1-2/+6
the properties panel uses huge min/maxes which can overflow when the number of digits changes Change-Id: Idbb998a065ce8f2b918fceea2076b794cbde3368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100696 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-14set max rangeCaolán McNamara1-1/+3
Change-Id: I8fc58f27060636209017f5b0e35844b96693eb21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98712 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-24Revert "Fix leak in extensions/updatecheck"Julien Nabet1-7/+3
This reverts commit 05ab836cf3001093a6e375bcb3e4654bbedcfa52 since it's wrong Reason for revert: <INSERT REASONING HERE> Change-Id: Ibdc97c6507fb081e34fdaabd65f61a01057300f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94676 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-23nospin hack no longer in useCaolán McNamara2-3/+3
Change-Id: Ib855c429ac936f9b7bb219ad4729f99b0625ec37 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94734 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-23Fix leak in extensions/updatecheckJulien Nabet1-3/+7
Change-Id: I693d32c6f1136dbe500b5390954fc77444144dbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94658 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-22Prefer CoInitializeEx instead of CoInitializeJulien Nabet7-11/+11
As https://docs.microsoft.com/fr-fr/windows/win32/api/objbase/nf-objbase-coinitialize?redirectedfrom=MSDN advised. Moreover, it'll make concurrency model explicit Change-Id: I247a49248bf45beb64a7985a7c0d078ee48efe2d Change-Id: I6e755fd516d9fb2dd2a9df0c66d9afd6070447ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94669 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-05-22move InterimItemWindow to vclCaolán McNamara1-1/+1
Change-Id: If0a4a14708810c44d087b51961f2ecb3fda4df23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94649 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-21loplugin:sequenceloopNoel Grandin1-1/+1
Change-Id: Ib785e6c581785fc4a477be38788a6544032b6ff0
2020-05-20use for-range on Sequence in e*Noel Grandin4-20/+18
Change-Id: I77dc12356ee45b1dee9acaf8a73dea81588822d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-13Fix translation domains in .ui filesGabor Kelemen6-6/+6
Found with bin/ui-checkdomain.sh Change-Id: I2a3ec2593b9ce0a19efced9020b95dff796e4702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94153 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2020-05-13weld bibliography EditBox control ItemWindowCaolán McNamara5-46/+104
Change-Id: I17859c10714afa387f47385d2abd8b8827770038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94099 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-13weld bibliography ComboBox control ItemWindowCaolán McNamara5-53/+113
Change-Id: I6d944225188d2c4bdf36b5a9c730ab770d07a246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94096 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-13the returned awt::XControlModel is just used as a flagCaolán McNamara2-5/+5
Change-Id: I4167be9e6b14b6a3454652fed86e785c1ea0d4b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-10new loplugin:simplifypointertoboolNoel Grandin3-5/+5
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-08compact namespace in editeng..extensionsNoel Grandin10-23/+23
Change-Id: Ie93ac69592c3625b8e2e5db3619ce24597a07a7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93722 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-06Move all public Java classes to libreoffice.jarSamuel Mehrbrodt1-1/+1
This moves the classes from juh.jar and ridl.jar to libreoffice.jar The goal is to have one single jar (and Java module, will be added later) which developers can include to work with LO. juh.jar and ridl.jar are kept as basically empty jars with libreoffice.jar on its classpath to keep backwards compatibility. This is a continuation of ae855bf48163ff64d94cfc34aff8e37abdb5518d and a preparation to have Java 9 module support. Change-Id: Ifbbfb97f60373d14256e62ae3122913bd17d5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-27Make upcasting css::uno::Reference ctor require complete typesStephan Bergmann3-1/+3
The main reason for the "home-grown" UpCast introduced with 904b3d1fceee5827076758ed2a81f80cb73493ca "Up-cast conversion constructor for css::uno::Reference" in 2013 was probably that we could not yet rely on C++11 std::is_base_of back then. A (welcome) side effect was that the derived class could be incomplete. However, specializations of UpCast relying on whether or not T2 is incomplete are obviously an ODR violation if the type is incomplete in some TUs and complete (and derived from T1) in others. And even if UpCast had internal linkage, it would still be brittle that its behavior depends on the completeness of T2 at the point of the template's instantiation, and not necessarily at the point of use. That means we should better base that ctor on std::is_base_of (which we can do now since 39a1edd6fec902ef378acce8af42c4d7fba280d0 "Make css::uno::Reference upcast ctor LIBO_INTERNAL_ONLY"), which causes a compilation error at least on Clang and GCC if the completeness requirements are not met. This change fixes all the cases where types need to be complete now, plus any resulting loplugin:referencecasting warnings ("the source reference is already a subtype of the destination reference"). Change-Id: Ieb9e3552e90adbf2c5a5af933dcb872e20661a2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92950 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-04-22Typo kServerDefiniton->kServerDefinition (extensions/ldap)Julien Nabet1-2/+2
Change-Id: I7d6ad76de91243e5f5d278bab5df171a5924d3d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92672 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-04-22tdf#42949 Simplify use of rtl::math::approxEqual in include/basegfx/Gabor Kelemen1-0/+1
Turns out we can save about 500Mb of preprocessor input if we use rtl_math_approxEqual from rtl/math.h instead of its C++ wrapper rtl::math::approxEqual from rtl/math.hxx and manage the fallout accordingly. Before: bin/includebloat.awk | head sum total bytes included (excluding system headers): 19017296671 After: $ bin/includebloat.awk | head sum total bytes included (excluding system headers): 18535432672 Change-Id: I1691171f3a309405a7099882ad9989d147f59118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-04-15loplugin:buriedassign in e*Noel Grandin1-4/+8
Change-Id: Ibbf5b576296bb73e7066f2426bf2fa28739bb761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92238 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-14loplugin:flatten in extensionsNoel Grandin19-915/+914
Change-Id: I58b5a2c12e464e568c4f66d398bbf0b1d8afc154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-07new loplugin:unusedvariableplusNoel Grandin1-1/+0
a particularly aggressive checker, which is why it is off by default Change-Id: Id5a0faa50b3ecc75e01f4aedc6579c5209e585da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-04-02tdf#117101 Make Spreadsheet the default new data source typeGabor Kelemen3-5/+6
instead of DBase. It's more likely that people are having those as data source for Mail Merge Also change method name to mirror the "Other" option that was selected in the firs step of the wizard Change-Id: I12b7fa98ada3af4fd39614a77b47cb587743b614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91541 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-03-25Resolves: tdf#131522 sync textview from edit when edit changesCaolán McNamara4-1/+17
Change-Id: I9a127f5066405225d35dd0590e84168b3bd86790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91049 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-03-20Silence -Werror,-Wvoid-pointer-to-int-cast (LLVM 10 trunk clang-cl)Stephan Bergmann1-1/+1
Change-Id: I14a10a34036f0ffdecc16f05f4bbc4ffaed18900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90801 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-03-11tdf#42949 Fix IWYU warnings in extensions/*/*cxxGabor Kelemen75-223/+81
Except for Windows-specific parts Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I36c81bced6c8b1567e52ba3a4a688a963f294bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90179 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-09improve loplugin:unusedfieldsNoel Grandin1-3/+1
noticed something that wasn't being picked up, wrote some tests, and found an unhandled case in Plugin::getParentFunctionDecl Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06tdf#42949 Fix IWYU warnings in extensions/source/*/*hxxGabor Kelemen78-96/+63
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2becc34174bdb5507180df6aa1a3c55a55f394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89859 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-03-04Fix more crashes after 1efeb17837c22499f00299c033ae59ba3910f7d7Mike Kaganski1-5/+10
E.g., trying to open time control properties in test file in https://gerrit.libreoffice.org/c/core/+/89895 See commit b9d6ea1dd7541c4bd866571f9e3f0aa894687c07 for explanation Change-Id: Icfa5d940cd595937e3bc83c752719d76d55d4081 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89944 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-17drop unneeded includeCaolán McNamara1-1/+0
Change-Id: I656a37b65f051d3a773c3b7c6b965038b99b354a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88881 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák2-1/+5
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-16clang-format c*,d*,e* with under 5-percent lines of changeMuhammet Kara9-17/+9
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I06087a1385ca9da6a28d36ea4c0d2e40bdbf8f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88774 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-10Resolves: tdf#130541 null-deref on detaching already-detached pageCaolán McNamara1-1/+3
Change-Id: Ib48ab91232b8ff624a1387ab82701938eef58ded Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-10android hunspell: Turn on the hunspell build on Android...Jan Holesovsky1-1/+6
...and try to register it for use - it's a bundled extension. The attempt to use the Android's native spell checking failed because the combination of gboard + google's spell checker makes every word in the app appear as if spelled correctly. I haven't found any easy way around that, so let's use hunspell instead; but for that, we need to make the bundled extensions work on Android. Change-Id: If6563e497f1d3085c26eda571567242b2c1f6181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88217 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88364 Tested-by: Jenkins
2020-02-07rename URLBox back to SvtURLBoxCaolán McNamara5-6/+6
Change-Id: Icd90eeb492002c45ddd8ff562a6da411abead122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88185 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-04tdf#117331 Merge jurt and unoil into ridlSamuel Mehrbrodt1-2/+2
jurt.jar and unoil.jar are kept as effectively empty jars, each with a Class-Path: ridl.jar in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or without also loading ridl.jar) will still have access to their content. Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi) are not part of the URE, but are now made available by URE's ridl.jar. This should probably not cause problems in practice. At least for now, we seal exactly those packages in ridl.jar that were originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now, but that would be mildly incompatible, as it would prevent 3rd-party code from introducing additional UNOIDL entities in the relevant namespaces (even if that is something we do not want 3rd-party code to do anyway). However, some JunitTest_jurt_* define classes in those sealed packages. In the past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt. Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets leave that for a follow-up clean up.) As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/. Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:unsignedcompare (clang-cl)Stephan Bergmann1-2/+3
Change-Id: I69cc1b352221ca053ccd0c5b78e926480a8c9ccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin2-4/+4
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-28tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorOnur Yilmaz1-2/+1
Change-Id: Ie5a381fc5e5b73490ab8b2036ef2a1164e475e8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87557 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-01-28New loplugin:unsignedcompareStephan Bergmann3-7/+11
"Find explicit casts from signed to unsigned integer in comparison against unsigned integer, where the cast is presumably used to avoid warnings about signed vs. unsigned comparisons, and could thus be replaced with o3tl::make_unsigned for clairty." (compilerplugins/clang/unsignedcompare.cxx) o3tl::make_unsigned requires its argument to be non-negative, and there is a chance that some original code like static_cast<sal_uInt32>(n) >= c used the explicit cast to actually force a (potentially negative) value of sal_Int32 to be interpreted as an unsigned sal_uInt32, rather than using the cast to avoid a false "signed vs. unsigned comparison" warning in a case where n is known to be non-negative. It appears that restricting this plugin to non- equality comparisons (<, >, <=, >=) and excluding equality comparisons (==, !=) is a useful heuristic to avoid such false positives. The only remainging false positive I found was 0288c8ffecff4956a52b9147d441979941e8b87f "Rephrase cast from sal_Int32 to sal_uInt32". But which of course does not mean that there were no further false positivies that I missed. So this commit may accidentally introduce some false hits of the assert in o3tl::make_unsigned. At least, it passed a full (Linux ASan+UBSan --enable-dbgutil) `make check && make screenshot`. It is by design that o3tl::make_unsigned only accepts signed integer parameter types (and is not defined as a nop for unsigned ones), to avoid unnecessary uses which would in general be suspicious. But the STATIC_ARRAY_SELECT macro in include/oox/helper/helper.hxx is used with both signed and unsigned types, so needs a little oox::detail::make_unsigned helper function for now. (The ultimate fix being to get rid of the macro in the first place.) Change-Id: Ia4adc9f44c70ad1dfd608784cac39ee922c32175 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87556 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin4-5/+4
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-27tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorMehmet Emin Başoğlu1-4/+2
Change-Id: Iffb8512c530b33f87076aec9f85b45219c7d07e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87528 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 19:30:58 +0000