summaryrefslogtreecommitdiff
path: root/embedserv
AgeCommit message (Collapse)AuthorFilesLines
2018-03-17Use for-range loops in embeddedobj, embedserv and formulaJulien Nabet2-19/+12
Change-Id: I56e1bace8ab8312524e681d3865a1a89d523812d Reviewed-on: https://gerrit.libreoffice.org/51459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-01embedserv: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski15-59/+0
Change-Id: I0abd5662648b09f31164d919688e17a651bf78c8 Reviewed-on: https://gerrit.libreoffice.org/48976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-24loplugin:emptyif (clang-cl)Stephan Bergmann2-7/+0
Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179 Reviewed-on: https://gerrit.libreoffice.org/48483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann4-26/+26
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15loplugin:salcall (clang-cl)Stephan Bergmann1-4/+4
Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:salcall (clang-cl)Stephan Bergmann3-8/+8
Change-Id: I31018af8d992c9496f01a72925e24d9b362e340d Reviewed-on: https://gerrit.libreoffice.org/46204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-27loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-2/+2
Change-Id: I5452235287fd5986de25ee542edd57bf1abded52 Reviewed-on: https://gerrit.libreoffice.org/45338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-07Remove unnecessary state checks and the variablesMuhammet Kara1-8/+0
Change-Id: I5dffeb9a05195085b6aa503421f65467d0b741a9 Reviewed-on: https://gerrit.libreoffice.org/44375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27loplugin:includeform: embedserv (Windows)Stephan Bergmann15-30/+30
Change-Id: I98bd95a46e645cf61f81d66faa1f700675e538bd
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski2-22/+24
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05loplugin:blockblock (clang-cl)Stephan Bergmann1-27/+25
Change-Id: I210c322ab44057e45e2b75b3ce3d13529fb62d13
2017-09-30Use SAL_W/SAL_U instead of reinterpret_cast btwn wchar_t* and sal_Unicode*Mike Kaganski2-25/+22
This is type-safe, and allows to catch cases where a source type is changed for some reason, but reinterpret_cast masks that Change-Id: Ib64b6fa2e22d94a6bba890f0ccc3e20325c6f0a1 Reviewed-on: https://gerrit.libreoffice.org/42961 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski6-51/+50
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara992-7/+7
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Better not modify const RECTs passed inStephan Bergmann1-11/+13
...through IOleInPlaceObject::SetObjectRects, via EmbedDocument_Impl::SetObjectRects Change-Id: Ia2533822795776d18132a457dc41f80fadb7c809 Reviewed-on: https://gerrit.libreoffice.org/42615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski4-1/+15
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-14loplugin:redundantpointerops (clang-cl)Stephan Bergmann2-2/+2
Change-Id: I5d4a1c3746b0eec02e022e5ffefd1a30a01948cd
2017-08-31loplugin:constparams: embedserv (clang-cl)Stephan Bergmann2-6/+6
Change-Id: I6faa8df32e57a846968423cfbe026ce96f6ca7e8
2017-08-21loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-2/+2
Change-Id: I11a535a5271ec15965877986f15adc0804c00a4f
2017-08-18loplugin:oncevar (clang-cl)Stephan Bergmann1-6/+6
Change-Id: I0cbd9a87880070e2c1381ecd385c1fe4c3ad7505
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin2-2/+2
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-03loplugin:oncevar (clang-cl): embedservStephan Bergmann2-5/+2
Change-Id: Icc9d01b46975505c54a6395edfbeb15cf25c8700
2017-06-12cleanup unused css/frame/* includesJochen Nitschke3-5/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-5/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin3-5/+5
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10Clean up uses of SAL_U/SAL_W: embedservStephan Bergmann6-41/+50
Change-Id: I5a73acf6ccfc1709e95e55fa15c32ec6dda2657a
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann2-6/+6
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-04loplugin:redundantcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie096d75c1bc774e77c589845f61276d1478234ef Reviewed-on: https://gerrit.libreoffice.org/36065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-25Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2 Reviewed-on: https://gerrit.libreoffice.org/35629 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-21tdf#96505 - Get rid of cargo cult long integer literalsudaycoder1-1/+1
Change-Id: I56fbc7cd9c879b18ac65c5e6adf80f01c6b95b84 Reviewed-on: https://gerrit.libreoffice.org/35176 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist1-1/+1
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-10Remove MinGW supportStephan Bergmann6-42/+5
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08Add missing #includesStephan Bergmann1-0/+2
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-01loplugin:stringconstantStephan Bergmann1-6/+6
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-01-26Remove dynamic exception specificationsStephan Bergmann7-134/+29
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25embedserv/source/embed/xwin.cxx is goneStephan Bergmann2-237/+0
...since f2abfdb94e111ba551bb97ec06fa5b57be3f6299 "embedserv: convert to gbuild" Change-Id: I932da3595e0d7150ef320c2fa892ea8d5286991c
2017-01-23loplugin:useuniqueptrStephan Bergmann2-10/+12
Change-Id: I510731d7364a9fb670782a743cdefc4582e8c593
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann2-6/+6
Change-Id: Ic7e4ba1ada97a0fff1ae6d209b22e372431cc6e7
2016-10-16clang-cl loplugin: embedservStephan Bergmann27-814/+798
Change-Id: I9901dac882a74453015881ded2355ff0a51b50d5 Reviewed-on: https://gerrit.libreoffice.org/29868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-1464-bit Windows fix: InsertMenu takes a UINT_PTRStephan Bergmann1-1/+1
Change-Id: Id14c9ac30d52fdeb6b9157df7f57202e94838909 Reviewed-on: https://gerrit.libreoffice.org/29817 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-25-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann3-2/+3
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-06-01tdf#99643 OLE automation bridge: fix 64-bit pointer conversionsMichael Stahl1-1/+1
XBridgeSupplier2::createBridge() is always called in-process and should therefore expect and create Anys with native-sized encoded pointers, so use sal_uIntPtr. Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63 Note: Currently all calls in LO code are with source=UNO, target=OLE.
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann2-1/+7
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-04use Any constructor instead of temporariesNoel Grandin1-20/+9
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04-Werror,-WshadowStephan Bergmann1-3/+3
In the second part, looks odd that those two lines are a perfect copy of what is already done near the start of the function, but I have no insight at all into that code, so just leave it at that. Change-Id: I6b1d973f77a3d9389880ddec500968144ba615f2
2016-03-04Silence -Werror,-Wnon-virtual-dtor in external includesStephan Bergmann2-0/+2
Change-Id: I2ef42eca934588b219de52dfc7c373395118cc32
2016-03-04-Werror,-WshadowStephan Bergmann1-1/+1
Change-Id: Ie6a35ce1fece5de31f455d88ab3e12010b8047f5
2016-03-04-Werror,-Wunused-macrosStephan Bergmann1-1/+0
According to <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383681%28v=vs.85%29.aspx> ("Enabling STRICT"), it is used in combination with including windows.h, so maybe this #define STRICT (which was there ever since a934115b3ea90d7883681a6ca8922a4b859be36f "Initial revision," w/o also including windows.h) was always unnecessary (as reported by clang-cl). Change-Id: I02cf2584fe2fd52e9513791b18fdf6e7982e89b3
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-25 15:38:19 +0000