summaryrefslogtreecommitdiff
path: root/embedserv/source/embed
AgeCommit message (Collapse)AuthorFilesLines
2017-02-10Remove MinGW supportStephan Bergmann2-7/+0
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08Add missing #includesStephan Bergmann1-0/+2
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-01loplugin:stringconstantStephan Bergmann1-6/+6
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-01-26Remove dynamic exception specificationsStephan Bergmann4-55/+1
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25embedserv/source/embed/xwin.cxx is goneStephan Bergmann1-2/+0
...since f2abfdb94e111ba551bb97ec06fa5b57be3f6299 "embedserv: convert to gbuild" Change-Id: I932da3595e0d7150ef320c2fa892ea8d5286991c
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann2-6/+6
Change-Id: Ic7e4ba1ada97a0fff1ae6d209b22e372431cc6e7
2016-10-16clang-cl loplugin: embedservStephan Bergmann14-369/+388
Change-Id: I9901dac882a74453015881ded2355ff0a51b50d5 Reviewed-on: https://gerrit.libreoffice.org/29868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-1464-bit Windows fix: InsertMenu takes a UINT_PTRStephan Bergmann1-1/+1
Change-Id: Id14c9ac30d52fdeb6b9157df7f57202e94838909 Reviewed-on: https://gerrit.libreoffice.org/29817 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-08-25-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ia468adf0bea2f7fca9b370ef0ff8b05e34b3ac19
2016-06-01tdf#99643 OLE automation bridge: fix 64-bit pointer conversionsMichael Stahl1-1/+1
XBridgeSupplier2::createBridge() is always called in-process and should therefore expect and create Anys with native-sized encoded pointers, so use sal_uIntPtr. Change-Id: Ia757ff38568b07de8085a1a9d323d806bcca0f63 Note: Currently all calls in LO code are with source=UNO, target=OLE.
2016-05-25SAL_FALLTRHOUGH in Windows-only codeStephan Bergmann2-1/+7
Change-Id: If35da46c209746a86687e1c3f60f72f2f08aa681
2016-05-04use Any constructor instead of temporariesNoel Grandin1-20/+9
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-04-21Fix typosAndrea Gelmini1-1/+1
Change-Id: Ic4fbc8e7220eb4641f67ef4f85d4853608a369f4 Reviewed-on: https://gerrit.libreoffice.org/24257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-04-Werror,-WshadowStephan Bergmann1-3/+3
In the second part, looks odd that those two lines are a perfect copy of what is already done near the start of the function, but I have no insight at all into that code, so just leave it at that. Change-Id: I6b1d973f77a3d9389880ddec500968144ba615f2
2016-03-04-Werror,-WshadowStephan Bergmann1-1/+1
Change-Id: Ie6a35ce1fece5de31f455d88ab3e12010b8047f5
2016-03-04-Werror,-Wunused-macrosStephan Bergmann1-1/+0
According to <https://msdn.microsoft.com/en-us/library/windows/desktop/aa383681%28v=vs.85%29.aspx> ("Enabling STRICT"), it is used in combination with including windows.h, so maybe this #define STRICT (which was there ever since a934115b3ea90d7883681a6ca8922a4b859be36f "Initial revision," w/o also including windows.h) was always unnecessary (as reported by clang-cl). Change-Id: I02cf2584fe2fd52e9513791b18fdf6e7982e89b3
2016-03-04-Werror,-WshadowStephan Bergmann1-2/+1
Change-Id: I40f92daa60a08d93ea7bbe309fd16fa7ef27e78b
2016-02-09Remove excess newlinesChris Sherlock8-25/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-26Silence -Werror,-Wmissing-field-initializers in END_OBJECT_MAP (clang-cl)Stephan Bergmann1-1/+7
Change-Id: Ia9ba7fc6cd94e2d726cd9b1dc72c140af16dd700
2016-01-25more Windows build fixesNoel Grandin1-1/+1
after my OInterfaceContainer2 change Change-Id: Ic365cf09631ff58c7d1b54795e7024923ebe02d1
2016-01-25more Windows build fixesNoel Grandin1-1/+1
after my OInterfaceContainer2 change Change-Id: Idc8d9aa218fbeea0e6b00216bb12b0e50efea57c
2016-01-25more Windows build fixesNoel Grandin1-1/+1
after my OInterfaceContainer2 change Change-Id: I8dabb07088c03795d6ac1989ad5ef318d011ccff
2016-01-25more Windows build fixesNoel Grandin1-1/+1
after my OInterfaceContainer2 change Change-Id: I2d59fd166672a2d0b6c05e5bf9368c8fa5cf111c
2016-01-25more Windows build fixesNoel Grandin1-0/+1
after my OInterfaceContainer2 change Change-Id: I869126a90e67bd00e953182ccafa6569009316ea
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin1-2/+2
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2015-12-02-Werror,-Wint-to-pointer-castStephan Bergmann1-4/+4
Appart from the by-design type-punned use in CreateWindowEx, m_uID is (only) used in a call to MAKEWPARAM (to create a WPARAM to pass into a SendMessage call), so the most realistic type to use seems to be WORD. And CHatchWindow::Init is only called with a value of 2000 (from docholder.cxx), anyway. Change-Id: I4b6554d1ca9bb3926378c9e25a5473609f5951c5
2015-11-28-Werror,-Wunused-variableStephan Bergmann1-1/+0
Change-Id: I6800b97cfbf2e986c341d8893658f511951bc8f0
2015-11-24-Werror,-Wunused-variableStephan Bergmann1-10/+0
Change-Id: If674f0a3199a43cec84eb8cfb3b3c1d334a288ca
2015-11-24Use Get/SetWindowLongPtr, for 64-bit buildStephan Bergmann1-2/+2
Change-Id: I02e5ca8dad87c24f8bf6e192a6b37ffc82a5a04a
2015-11-24-Werror,-Wbitwise-op-parenthesesStephan Bergmann1-1/+1
Change-Id: I36bd91dc2bb77a09f59e865527db1e9c6724a652
2015-11-24Expand single use of SendCommand macroStephan Bergmann1-6/+4
Change-Id: I8af259f55e8fc318ccdbc69bba00ae0d7d3aacdb
2015-11-24-Werror,-WreorderStephan Bergmann1-1/+1
Change-Id: I8350b7e60e54eb0f0be5fa33a4ca4de40551618c
2015-11-24-Werror,-Wlogical-op-parenthesesStephan Bergmann1-1/+1
Change-Id: I39f59a88c34c37bad520dd44f3e8fcaf4a016eee
2015-11-24-Werror,-WreorderStephan Bergmann1-1/+1
Change-Id: I71e3d8878a8c7190ef239e4529d23eccaadc80d6
2015-11-24-Werror,-Wint-to-pointer-castStephan Bergmann1-2/+2
Change-Id: I6db7d7595fda972e7c5d5c24d235678671478975
2015-11-18Fix css.awt.XSystemDependentMenuPeer.getMenuHandleStephan Bergmann1-1/+1
...to return an ANY containing a 64-bit HYPER instead of a 32-bit LONG for SYSTEM_WIN32 (which covers both 32-bit and 64-bit versions of Windows), so that the HMENU value (which is effectively a void*) is not truncated for the 64-bit build. This should effectively be URE ABI compatible for the 32-bit build, as there the HYPER value will fit into 32 bits, so extracting a LONG from the ANY should still work. Change-Id: Ief3de5924f672e8f6bbe6df08c15439456ca036f Reviewed-on: https://gerrit.libreoffice.org/20045 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-11-18-Werror,-Wlogical-op-parenthesesStephan Bergmann1-2/+3
Change-Id: I8e22b6399bbdb07c376299d5a23c8061af18578d
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-01no need to use OUString constructor in call to createInstanceNoel Grandin1-3/+1
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296 Reviewed-on: https://gerrit.libreoffice.org/19704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-31use uno::Reference::set method instead of assignmentNoel Grandin2-15/+15
Change-Id: I150f213ab033f5fc1b50abe4e1529292206c9feb Reviewed-on: https://gerrit.libreoffice.org/19689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-01com::sun::star->css in embedserv/Noel Grandin2-21/+9
Change-Id: Iaf1e30ae7dc9710a16a031ea623d531e9e65a6a5 Reviewed-on: https://gerrit.libreoffice.org/19025 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-13cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-06-29Revert "return and use std::vector from OInterfaceContainerHelper"Noel Grandin1-5/+7
This reverts commit e57314f61f67b093510c5a8a8f34a62126ba8734.
2015-06-29return and use std::vector from OInterfaceContainerHelperNoel Grandin1-7/+5
since most of the time we don’t need a heavyweight uno::Sequence. Adds a new method getElementsAsVector(). Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a Reviewed-on: https://gerrit.libreoffice.org/15747 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-5/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-05-04css::uno::Reference can automatically up-cast nowStephan Bergmann1-1/+1
follow-up to 8568c7226cfb732e17fa42b365b9fce3a8264691 "tdf#66232: Cannot open files by COM2" Change-Id: I5a0858dd6f48136f9f07b0d04c5634a6173dd154
2015-05-03tdf#66232: Cannot open files by COM2Mike Kaganski1-4/+6
As suggested by comment 13 of the bug, the problem is caused by commit b248624126c271c88381d3dad6e04fc954f65779 by Noel Grandin. 1. DocumentHolder::DocumentFrame(): XDesktop2 cannot be directly queried for XFrame2. And in this case, simple XFrame is enough. 2. DocumentHolder::CloseFrame(): m_xFrame->dispose() violates an assert because of NULL reference. Reverted to previous code. 3. Following commit debde4fdc443f522562ee29def4c27512d64609a by Andras Timar (supposed to fix the bug), found two places where previously used to be UNO_QUERY, but now UNO_QUERY_THROW is used. These places are reverted to use UNO_QUERY. Change-Id: Ifb9e74367d5dd99ba12166abdd443b29a8018aeb Reviewed-on: https://gerrit.libreoffice.org/15607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin4-15/+15
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
2015-03-24Fix various Windows-only XServiceInfo implementationsStephan Bergmann1-49/+11
...to match what is recorded in the .component files Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc