summaryrefslogtreecommitdiff
path: root/embeddedobj
AgeCommit message (Collapse)AuthorFilesLines
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin3-5/+5
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin2-3/+3
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke2-2/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin8-46/+46
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock8-11/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini2-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-25more Windows build fixesNoel Grandin2-3/+3
after my OInterfaceContainer2 change Change-Id: I4adb4a1937c12c1f6cb9183d567afb729d4e78ea
2016-01-25InterfaceContainer2 with vector instead of SequenceNoel Grandin5-5/+7
create an InterfaceContainer2 class to replace InterfaceContainer. It uses a std::vector instead of a Sequence for the mutable listener list, which provides far better performance. Switch all our internal use-sites to the new class. Change-Id: I6b56cfa511ded2395faa22e68fab3b2f16c3cb88
2016-01-13Fix memory leakStephan Bergmann2-8/+11
Change-Id: I82ce013a42ac1cd9bb4f3842e9fba8fbc6056b3c
2016-01-10Fix typosAndrea Gelmini3-3/+3
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-07cppcheck: noExplicitConstructorCaolán McNamara6-6/+6
Change-Id: Ifdcb1cc12645d6cdba81d16f94f0268696187cde Reviewed-on: https://gerrit.libreoffice.org/21201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-23loplugin:unusedfields in desktopNoel Grandin1-2/+0
Change-Id: Ic816a7faf4d357d16c13f67533b3b409a531d14c
2015-12-20embeddedobj: do not automatically convert alien objects to ownMichael Stahl1-11/+0
OleEmbeddedObject::changeState() calls TryToConvertToOOo() on non-WNT platforms, which appears highly questionable to me, added in commit 0c3d5fb0ad35ff7fc18917fc86fa58d9312fe3ae. What this does effectively is load the embedded object, store it as ODF, and then load it again as ODF. For one, it doesn't work in all cases currently. If changeState() is not called from the UI but from some filter code, then no m_xClient may be set on the OleEmbeddedObject, hence no m_xClient will be set on the new m_xWrappedObject. Then loading the embedded object will raise errors due to missing BaseURL, and storing it will fail in SfxObjectShell::SaveTo_Impl(). (It would be possible to solve that by copying the "DefaultParentBaseURL" handling code from OCommonEmbeddedObject.) The only reason why the previous code in ShapeExport::WriteOLE2Shape() was able to export the object despite the error is that it does not call SfxBaseModel functions but directly invokes the export filter, so the sfx2 code does not get an opportunity to check its error status. For another, doing this only on non-WNT platforms is also hazardous. It's probably better to leave conversion to own formats to an explicit UI action, as the OleEmbeddedObject::doVerb(-9) magic currently does, where it can hopefully be assumed that the caller at least established the client connection first. Change-Id: Ice3d8f8ceabe81b6e9025957c3eb87de9dbfe61a
2015-12-08consolidate MSO format ClassID magic numbers in msfilter/classids.hxxMichael Stahl1-2/+2
Change-Id: I673eeaa4168f769cb002995c43d986ee5f2030b2
2015-11-28-Werror,-Wunused-functionStephan Bergmann1-0/+2
Change-Id: I6103a8539c4d788fff1a7e3c3530a6ec7cd1f0c6
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin1-1/+0
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin1-2/+1
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann11-44/+44
Change-Id: I225d5fe2e3476121e2ca307d815d5615e32311d7
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann5-13/+13
Change-Id: I5528b17c106aefde4c58dfef00e30fdcf62f7db7
2015-11-04yyyyyNoel Grandin4-8/+7
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-10-31use uno::Reference::set method instead of assignmentNoel Grandin11-58/+50
Change-Id: I150f213ab033f5fc1b50abe4e1529292206c9feb Reviewed-on: https://gerrit.libreoffice.org/19689 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin4-10/+8
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-21remove untyped Link<>Noel Grandin3-6/+3
Change-Id: I809f9e10309ceadda0a82c3818277323b34ec61b Reviewed-on: https://gerrit.libreoffice.org/19491 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann12-192/+192
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-01com::sun::star->css in embeddedobj/Noel Grandin26-845/+845
Change-Id: Ia04fc28ce8e1d70f86520edf2df8c98f7b455465 Reviewed-on: https://gerrit.libreoffice.org/19024 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-30Fix typosAndrea Gelmini2-2/+2
Change-Id: Iaa9dd3f02f21947742643349d3b878126017477d Reviewed-on: https://gerrit.libreoffice.org/18947 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-13cppcheck: noExplicitConstructorCaolán McNamara3-14/+11
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-08-14loplugin: defaultparamsNoel Grandin1-1/+1
Change-Id: I455b200febc9939f3fb81597938b26c0e9eb5f74
2015-08-03tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe15-30/+30
with the variadic variants in embeddedobj. Change-Id: I60aad1267b664825f781c085fb33612bce3f7221 Reviewed-on: https://gerrit.libreoffice.org/17474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24loplugin:unusedmethodsNoel Grandin6-92/+12
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-21Miscellaneous typosAdolfo Jayme Barrientos1-8/+8
Change-Id: I5187364d420ab78c36a91632efab9c32951d867a
2015-07-16for now show chart sidebarMarkus Mohrhard1-2/+3
This is a hack that needs to be cleaned up later. Change-Id: I2772fe6ff8a4792d746a29653635d3eca4088e68
2015-07-16fix indentationMarkus Mohrhard1-3/+3
Change-Id: I4bceb79ed4adda085727dfcee1ba3573811e53b3
2015-07-16fix indentationMarkus Mohrhard1-2/+2
Change-Id: Ifda010d2a8f51c6981cac889bfaa1edaacd22df2
2015-06-29coverity#1308586 Uncaught exceptionCaolán McNamara2-2/+3
Change-Id: I86097e94dd47153a919bb7721376c5b98b50354e
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-23Resolves: tdf#91683 Revert avoid activating chart objects...Caolán McNamara2-15/+6
just to get their mapunit or set visual size. Will have to try something different here apparently This reverts commit 757f461ef12548af0be470f7c05ff67df3dc1314. (cherry picked from commit f2b3519c6b2aceacbe2fd9d53eb52dd36a356ecc)
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe1-2/+2
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-17More helpful exception messageLionel Elie Mamane1-1/+1
Change-Id: I63dcc98667ebfc94cc16407d283e65e1514d89fb
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-15remove unnecessary check for null when calling deleteNoel Grandin1-5/+2
Idea originally from caolan. Found using the following command: find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;' Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
2015-06-08loplugin:cstylecast: deal with remaining pointer castsStephan Bergmann2-22/+22
Change-Id: Ie55f464ef2eca344d3c1292713ded2710c47cc53
2015-05-19tdf#67421: Prevent unloading objects due to cache fullMike Kaganski1-1/+0
When an object is added to OLE objects cache, when cache is full, old objects are tried to be unloaded. This triggers notifications that cause all loaded objects to become active, and to be added to cache (moved to front). As the new object already was added to front of the cache, later activity pushes it to back, until it is the last object in cache. The cache in this process is overfilled, so each next refresh tries to unload current last OLE object. So, in the end, this effectively unloads all cached OLE objects. This patch prevents this by first unloading last object, and then adding new object to front of cache. Also, removed needless creation of reference (makes at least 200 function calls for no reason). Change-Id: Ia903f4df101971df1b0b0148320fc8e45ac1e79c Reviewed-on: https://gerrit.libreoffice.org/15772 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-05-10Use IMPL_LINK_NOARG[_TYPED] where applicableStephan Bergmann1-1/+1
Change-Id: I70598072c1d492e360ef46dd7b5ef5a2fa4be495
2015-05-10NOINSTANCE is implied now in IMPL_STATIC_LINK...Stephan Bergmann1-1/+1
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann1-1/+1
Change-Id: Ic91c8126b8e9a5a7eeed4c356b783c8bebccecf3
2015-05-04embeddedobj: allow creating objects lacking a FileFormatVersion=6800 filterMiklos Vajna3-0/+17
dbaccess::ODatabaseDocument::loadFromStorage() is still not implemented, though. Change-Id: I1be11f2a2274f67dd0a11f96a718394d5f72605f
2015-04-30embeddedobj: allow embedding objects lacking a FileFormatVersion=6800 filterMiklos Vajna1-0/+4
The "own" filter of Base has FileFormatVersion=6200. Change-Id: I3bbd28ebcf4d517ea9cefe692b01b688358c51e8
2015-04-29Remove unnecessary STATIC_LINK macroStephan Bergmann1-1/+1
Change-Id: I4788824667c8e0d1d4e0717b7ae7737bb0fd2c90
2015-04-15remove unnecessary use of void in function declarationsNoel Grandin4-15/+15
ie. void f(void); becomes void f(); I used the following command to make the changes: git grep -lP '\(\s*void\s*\)' -- *.cxx \ | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;' and ran it for both .cxx and .hxx files. Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-24 23:47:16 +0000