summaryrefslogtreecommitdiff
path: root/embeddedobj
AgeCommit message (Collapse)AuthorFilesLines
2017-07-13Show document title for embedded documentsSzymon Kłos4-0/+20
Embedded documents had "Untitled" name. This patch shows "<root document> (Embedded document)" string in the title bar. Change-Id: I6283240415f9e0c07c4c69672732a7c14eea9f5d Reviewed-on: https://gerrit.libreoffice.org/39835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-13use more OUString::operator== in dbaccess..filterNoel Grandin7-17/+17
Change-Id: Ib7b4f2b2403ce766a7db2f6ffc118468e7677776 Reviewed-on: https://gerrit.libreoffice.org/39889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-13tdf#108545 tdf#108544: DOCX, XLSX embedded in DOCSzymon Kłos2-19/+48
When on Windows the MSO wasn't installed DOCX and XLSX embedded documents weren't accessible. General OLE error was shown after doubleclick on the object. Linux solution is reused, OLE storage is extracted to get the document inside. Change-Id: If4d00fddad8e127fcf1a222836896d2907549d0c Reviewed-on: https://gerrit.libreoffice.org/39814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-12strip some linefeeds from the end of debug outputNoel Grandin2-2/+2
Change-Id: I2821969d86b7f8cee53404e6a0acfbebbe53b3ac Reviewed-on: https://gerrit.libreoffice.org/39824 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-07loplugin:unnecessaryparen handle parens inside call exprNoel Grandin2-2/+2
stick to single-arg function calls, sometimes parens in multi-arg calls might be there for clarity Change-Id: Ib80190c571ce65b5d219a88056687042de749e74 Reviewed-on: https://gerrit.libreoffice.org/39676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26Resolves: tdf#108643 don't restore orig size on first chart activateCaolán McNamara1-1/+3
Change-Id: Ibe51eb81ea1b0874fc1a9018871f07c9af38e8d2 Reviewed-on: https://gerrit.libreoffice.org/39268 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke5-10/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-02convert GRFILTER constants to ERRCODE_GRFILTER_Noel Grandin1-1/+1
since various code mixes these constants in with ErrCode values from other code, let us just make it into real ErrCode values. Change-Id: Ifa3d0f7526172609a44e6749bed9f730ab6b1a95 Reviewed-on: https://gerrit.libreoffice.org/38313 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-31clang-tidy readability-redundant-control-flowNoel Grandin2-2/+0
Change-Id: I832f7ef0f1bd55e365db7e49823fe8bc30390c04 Reviewed-on: https://gerrit.libreoffice.org/38215 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin1-4/+0
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09Related: tdf#62702 also try various other known streams for object contentCaolán McNamara1-15/+17
Change-Id: I5b5fa61e9930ba0eaa5ac86e4231050c9ebebf8a
2017-05-09Related: tdf#62702 handle EmbeddedOdf like CONTENTS on ole activate attemptCaolán McNamara1-0/+13
Change-Id: I11f1d6ad049cada1cadfe97a440b7ae562ba4ced
2017-05-03remove empty namespacesJochen Nitschke1-3/+0
Change-Id: I3eae0ecc1ffc5500d3c55abc6554822f5432a50a Reviewed-on: https://gerrit.libreoffice.org/37173 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky2-2/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin18-49/+49
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10Clean up uses of SAL_U/SAL_W: embeddedobjStephan Bergmann1-2/+3
Change-Id: I02c9ed6b4bd92346bbeee1138c49b4bf5b39ad56
2017-04-04Finally switch MSVC to sal_Unicode = char16_t, tooStephan Bergmann1-1/+1
There is lots of (Windows-only) code that relied on sal_Unicode being the same as wchar_t, and the best change may be different in each case (and doing the changes may be somewhat error prone). So for now add SAL_U/SAL_W scaffolding functions to sal/types.h, remove their uses one by one again, and finally drop those functions again. Change-Id: I2cc791bd941d089901abb5f6fc2f05fbc49e65ea Reviewed-on: https://gerrit.libreoffice.org/36077 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna1-1/+1
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-25Fix typosAndrea Gelmini2-2/+2
Change-Id: Ic823a46019138b8bbcacd7b52b48d7d7ead2fde2 Reviewed-on: https://gerrit.libreoffice.org/35629 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-18Typo: BimapPainter->BitmapPainterJulien Nabet1-2/+2
Change-Id: I2176e0050ca92de0f2effb7257dd7ebba2a4f439 Reviewed-on: https://gerrit.libreoffice.org/35411 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I338dacd3cfe915714a9038e1dea4a60d586e9394 Reviewed-on: https://gerrit.libreoffice.org/34806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist1-1/+1
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann10-171/+55
Change-Id: Ieee649609a7f01b4d51ed6ed78a8ae809ca61d9e Reviewed-on: https://gerrit.libreoffice.org/34268 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-13Remove misguided commentStephan Bergmann1-1/+1
...introduced with 7757a18cfd77996f4ce8aef2cbb8c70425ae92da "INTEGRATION: CWS oj14", but for one !xDoc.is() is explicitly handled below, and for another xLoadable is only used if !xDoc.is(). So the requirement is apparently that not both are null, indeed. Change-Id: I1b59e99c86c88c5266b33e9ff782054fa40dd34d
2017-02-08Add missing #includesStephan Bergmann2-0/+4
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann15-1/+28
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01loplugin:stringconstantStephan Bergmann3-14/+14
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin4-8/+8
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann36-1095/+249
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-23Ole10Native payload truncatedCaolán McNamara1-5/+5
Change-Id: If2c0c2788e54eb01a1b6998c81df016061a0ad6b
2017-01-23use rtl::Reference in DocumentHolderNoel Grandin2-12/+10
instead of manual acquire/release Change-Id: Id795dca5ff9e392fa2649f4721a73ce3ffd6de2c
2017-01-23use rtl::Reference in OCommonEmbeddedObjectNoel Grandin7-76/+70
instead of manual acquire/release Change-Id: Ie641f72687a05e1cd3cf697d551f9c6d21ac4487
2017-01-20loplugin:dynexcspec (clang-cl), embeddedobjStephan Bergmann2-0/+3
Change-Id: Iccb2a91319f8cbc300f0e428b06b0580432089a6
2017-01-19New loplugin:dynexcspec: Add @throws documentation, embeddedobjStephan Bergmann3-2/+11
Change-Id: Icf9a507a2b1eec0ace22e727bdf7220bfe7096b8
2017-01-19fix windows buildNoel Grandin1-1/+0
Change-Id: I69da07e0e12d9bd03534b60a2ecd9a6c0cc61239
2017-01-19use rtl::Reference in OleEmbeddedObjectNoel Grandin3-11/+8
instead of raw pointer and manual acquire/release Change-Id: If626f34f3e0d7689567e2d64f94a84e5c8aae28f
2017-01-16new loplugin: useuniqueptr: embeddedobjNoel Grandin2-8/+5
Change-Id: I4c1302061a3607540af7de7a45ba060d3c0b403b Reviewed-on: https://gerrit.libreoffice.org/33153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12in extremis dump Ole10Native payload and launch system viewer on itCaolán McNamara1-4/+57
so embedded plain text documents/source code/etc in word documents can be viewed by us under Linux Change-Id: I19e19619070841fe097c70297adc2e8b96d1c581
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I034eeb9525bbb8fdc39e176a2433f1b3dfff566a
2017-01-01Typo: GetReccomendedExtent->GetRecommendedExtentJulien Nabet3-3/+3
Change-Id: Ic04a9ff115827558f9bc528c100b53bd7ca23486 Reviewed-on: https://gerrit.libreoffice.org/32587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-05loplugin:unnecessaryoverride (dtors) in embeddedobjStephan Bergmann1-6/+0
Change-Id: I5a65a8816438b7e777cabeb334a8cd7bcf4c814e
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke2-2/+2
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: embeddedobjStephan Bergmann18-344/+356
Change-Id: Id8359ff2bc2ae177837f5c58f949d40b818a8684 Reviewed-on: https://gerrit.libreoffice.org/29869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann3-3/+3
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-27SAL_WARN in case bBackToLoaded failedStephan Bergmann1-1/+4
Change-Id: I3ee3801ae36b7394a97f46e76116cfd11c74de2d
2016-09-27Resolves: tdf#98946 too many running MathTypes...Caolán McNamara1-0/+16
causes mathtype to display a warning dialog, so try restoring them back to loaded after loading them in order to get their preferred size Change-Id: Idff714efa228a739f380dbae429d852a8f8c5298 Reviewed-on: https://gerrit.libreoffice.org/29234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23Resolves: tdf#101971 OleLoad under structured exception guardsCaolán McNamara1-2/+15
sample pptx crashes down in the depths of (apparently pre-installed on 32bit Windows 10) Flash.ocx Change-Id: I4e083d492e56e72df47b2c172d7f07f0e39b82ea Reviewed-on: https://gerrit.libreoffice.org/29199 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-16embeddedobj: add a comment why the original size is restoredMichael Stahl1-0/+2
... in OCommonEmbeddedObject::getPreferredVisualRepresentation() Change-Id: I326b7df4350f34fc9a1c363ea0e9bc77d8f1e976
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin2-4/+0
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>