summaryrefslogtreecommitdiff
path: root/embeddedobj
AgeCommit message (Collapse)AuthorFilesLines
2017-03-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I338dacd3cfe915714a9038e1dea4a60d586e9394 Reviewed-on: https://gerrit.libreoffice.org/34806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist1-1/+1
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-15Some simplifications, using UNO_QUERY_THROWStephan Bergmann10-171/+55
Change-Id: Ieee649609a7f01b4d51ed6ed78a8ae809ca61d9e Reviewed-on: https://gerrit.libreoffice.org/34268 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-13Remove misguided commentStephan Bergmann1-1/+1
...introduced with 7757a18cfd77996f4ce8aef2cbb8c70425ae92da "INTEGRATION: CWS oj14", but for one !xDoc.is() is explicitly handled below, and for another xLoadable is only used if !xDoc.is(). So the requirement is apparently that not both are null, indeed. Change-Id: I1b59e99c86c88c5266b33e9ff782054fa40dd34d
2017-02-08Add missing #includesStephan Bergmann2-0/+4
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann15-1/+28
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01loplugin:stringconstantStephan Bergmann3-14/+14
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-01-31teach lolugin:stringconstant about calling constructorsNoel Grandin4-8/+8
so we can remove unnecessary calls to the OUString(literal) constructor when calling constructors like this: Foo(OUString("xxx"), 1) Change-Id: I1de60ef561437c86b27dc9cb095a5deb2e103b36 Reviewed-on: https://gerrit.libreoffice.org/33698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann36-1095/+249
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-23Ole10Native payload truncatedCaolán McNamara1-5/+5
Change-Id: If2c0c2788e54eb01a1b6998c81df016061a0ad6b
2017-01-23use rtl::Reference in DocumentHolderNoel Grandin2-12/+10
instead of manual acquire/release Change-Id: Id795dca5ff9e392fa2649f4721a73ce3ffd6de2c
2017-01-23use rtl::Reference in OCommonEmbeddedObjectNoel Grandin7-76/+70
instead of manual acquire/release Change-Id: Ie641f72687a05e1cd3cf697d551f9c6d21ac4487
2017-01-20loplugin:dynexcspec (clang-cl), embeddedobjStephan Bergmann2-0/+3
Change-Id: Iccb2a91319f8cbc300f0e428b06b0580432089a6
2017-01-19New loplugin:dynexcspec: Add @throws documentation, embeddedobjStephan Bergmann3-2/+11
Change-Id: Icf9a507a2b1eec0ace22e727bdf7220bfe7096b8
2017-01-19fix windows buildNoel Grandin1-1/+0
Change-Id: I69da07e0e12d9bd03534b60a2ecd9a6c0cc61239
2017-01-19use rtl::Reference in OleEmbeddedObjectNoel Grandin3-11/+8
instead of raw pointer and manual acquire/release Change-Id: If626f34f3e0d7689567e2d64f94a84e5c8aae28f
2017-01-16new loplugin: useuniqueptr: embeddedobjNoel Grandin2-8/+5
Change-Id: I4c1302061a3607540af7de7a45ba060d3c0b403b Reviewed-on: https://gerrit.libreoffice.org/33153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12in extremis dump Ole10Native payload and launch system viewer on itCaolán McNamara1-4/+57
so embedded plain text documents/source code/etc in word documents can be viewed by us under Linux Change-Id: I19e19619070841fe097c70297adc2e8b96d1c581
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I034eeb9525bbb8fdc39e176a2433f1b3dfff566a
2017-01-01Typo: GetReccomendedExtent->GetRecommendedExtentJulien Nabet3-3/+3
Change-Id: Ic04a9ff115827558f9bc528c100b53bd7ca23486 Reviewed-on: https://gerrit.libreoffice.org/32587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-05loplugin:unnecessaryoverride (dtors) in embeddedobjStephan Bergmann1-6/+0
Change-Id: I5a65a8816438b7e777cabeb334a8cd7bcf4c814e
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke2-2/+2
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: embeddedobjStephan Bergmann18-344/+356
Change-Id: Id8359ff2bc2ae177837f5c58f949d40b818a8684 Reviewed-on: https://gerrit.libreoffice.org/29869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann3-3/+3
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-27SAL_WARN in case bBackToLoaded failedStephan Bergmann1-1/+4
Change-Id: I3ee3801ae36b7394a97f46e76116cfd11c74de2d
2016-09-27Resolves: tdf#98946 too many running MathTypes...Caolán McNamara1-0/+16
causes mathtype to display a warning dialog, so try restoring them back to loaded after loading them in order to get their preferred size Change-Id: Idff714efa228a739f380dbae429d852a8f8c5298 Reviewed-on: https://gerrit.libreoffice.org/29234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23Resolves: tdf#101971 OleLoad under structured exception guardsCaolán McNamara1-2/+15
sample pptx crashes down in the depths of (apparently pre-installed on 32bit Windows 10) Flash.ocx Change-Id: I4e083d492e56e72df47b2c172d7f07f0e39b82ea Reviewed-on: https://gerrit.libreoffice.org/29199 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-16embeddedobj: add a comment why the original size is restoredMichael Stahl1-0/+2
... in OCommonEmbeddedObject::getPreferredVisualRepresentation() Change-Id: I326b7df4350f34fc9a1c363ea0e9bc77d8f1e976
2016-09-16loplugin:singlevalfields in basic..idlNoel Grandin2-4/+0
Also fix obvious bug in the initialisation of the connectivity::odbc::OConnection::m_bClosed field. Probably closes some kind of connection leak there. Change-Id: I04579cf91bcd6d6c51c697d83971da4142743a82 Reviewed-on: https://gerrit.libreoffice.org/28932 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-15disable generation of ole previews in ODF format until after loadCaolán McNamara1-1/+4
so the user update links dialog can control their generation SdrEmbedObjectLink becomes exposed to calc so it can detect if the link dialog needs to be used to update ole links. Change-Id: Id1dd7ea17342140eab9307d546528747e3a98090 Reviewed-on: https://gerrit.libreoffice.org/28879 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann7-7/+7
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (embeddedobj)Stephan Bergmann1-1/+1
Change-Id: I4d1d29155c09b15514f96a8b53f9865eefc78704
2016-08-16loplugin:salboolTakeshi Abe1-1/+1
Change-Id: Ib758a0b1c33173097aee80bff49b7c4937cf9fdf
2016-08-15Resolves: tdf#96451 do magic to enable embedded chart sidebar only for chartCaolán McNamara1-2/+9
objects, and do the normal thing for other objects, e.g. math Change-Id: Ifb786a841b843b0317713769cb214a44dceaf546
2016-07-29Fix typo: completelly -> completelyTakeshi Abe2-3/+3
Change-Id: I566c5554bf32ea18121c5a186365b97c91667c5d
2016-07-27improve passstuffbyref return analysisNoel Grandin4-4/+4
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11tdf#56818, use SolarMutex instead of own MutexMarkus Mohrhard1-10/+12
There is a SolarMutexReleaser in the call chain so that using an own mutex can deadlock. Change-Id: I1dd0b0c78ce6cf436a470319e616099cb947b6e0 Reviewed-on: https://gerrit.libreoffice.org/27085 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-06-15Resolves: tdf#100140 crash on exit of report designCaolán McNamara1-2/+2
This was triggered by This appears to be triggered by 08cf2fd01064306eef7fdbb5b62320947c4d1089 commit 08cf2fd01064306eef7fdbb5b62320947c4d1089 Author: Thorsten Behrens <Thorsten.Behrens@CIB.de> Date: Fri May 20 16:48:00 2016 +0200 which changed the order that things registered through registerDispatchProviderInterceptor are used by, so swap the order of registerDispatchProviderInterceptor calls here to sync with that Change-Id: I047e4c7f6cb488c646df717e22c8ac91864c3938
2016-05-24Fix tdf#99506: Insert OLE object with icon failedGuillaume Smaha1-0/+2
Change-Id: I7fe5814b268e4c70977699edaa89926ca3fda92e Reviewed-on: https://gerrit.libreoffice.org/25080 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-05-10Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann1-0/+1
Change-Id: I49c216ed6e1e401fcc2029c047d7a7feeb767b36
2016-05-10Replace fallthrough comments with new SAL_FALLTHROUGH macroStephan Bergmann1-1/+1
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in preparation of enabling -Wimplicit-fallthrough. (This is only relevant for C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.) Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but that would require adding back in dependencies on boost_headers to many libraries where we carefully removed any remaining Boost dependencies only recently. (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its future evolution will not have any impact on the stable URE interface.) C++17 will have a proper [[fallthroug]], eventually removing the need for a macro altogether. Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
2016-04-30Fix typosAndrea Gelmini1-1/+1
Change-Id: Id81b16ff26283611f0b84929d831c827f847ab73 Reviewed-on: https://gerrit.libreoffice.org/24317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann8-59/+59
Change-Id: I8542bfaf9e27792369617c44258ddcc393e490a2
2016-04-14clang-tidy performance-unnecessary-value-param in variousNoel Grandin3-5/+5
Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14loplugin:passstuffbyref in variousNoel Grandin2-3/+3
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke2-2/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17use consistent #define checks for the Windows platformNoel Grandin8-46/+46
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09Remove excess newlinesChris Sherlock8-11/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-05Fix typosAndrea Gelmini2-2/+2
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-25more Windows build fixesNoel Grandin2-3/+3
after my OInterfaceContainer2 change Change-Id: I4adb4a1937c12c1f6cb9183d567afb729d4e78ea
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 21:24:00 +0000