summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2014-07-01clang scan-build: various warningsCaolán McNamara1-1/+1
Change-Id: I4bdfb074b3cf6fcb49765322308dfa4b9ed67713
2014-07-01error: 'SvxColorBackgroundItem' was not declared in this scopeMiklos Vajna1-1/+1
Change-Id: I296a1ba4128d5e1c9178a20df25875fd8baaefe5
2014-06-30Cleanup: removed comments and debugging outputmatteocam4-20/+1
Change-Id: I41f13d33da641153784725344f5bd526ca69542b
2014-06-30Removed assertion in EditCharAttribBackgroundColormatteocam1-6/+5
Change-Id: Ic9b41eed686ca8bf07c8e3e1555fc6953093a2d4 (cherry picked from commit e68c18f1afe93eba5e79829510df16a78d66c95e)
2014-06-30VclProcessor's text rendering looks at fill colormatteocam1-0/+2
Change-Id: I96dcafd01fb6d8a5e873719ee617008b5f2cbc13 (cherry picked from commit 74fa26c85ef79020a889d14db04130e52635b81e)
2014-06-30Set transparency besides color for text with fill (i.e. underlined text)matteocam1-0/+1
Change-Id: I88a90facac656f846a88315951b4769f502662a0 (cherry picked from commit d4c1c038dbc554dcce9c081e736a72359e80d33f)
2014-06-30DbgOutItem supports Font Background Colormatteocam1-0/+11
Change-Id: I1067e73593fdd116c3fc264b07f8bfd77057af0f (cherry picked from commit 2bcaa1ca791ff64a1629d2451bd52323e7e814e3)
2014-06-30CreateFont supports Background Colormatteocam1-0/+2
Change-Id: I3413c77db8e822aeb957909a661d175320555f6d (cherry picked from commit a7f27d468dd92a2ffbe114a5bdedf423f657f1ad)
2014-06-30ItemSet includes Background Color in SetFontInfoInItemSetmatteocam1-0/+1
Change-Id: I0a5f5cebccc73eb3c0877fae0086861ac5b93d3d (cherry picked from commit c52d374be19130c123d8316be6dac51219296abd)
2014-06-30Minor changes.matteocam1-0/+2
Change-Id: I3b8c51690eb14601435653e9a2255a5c6ed4fd7e (cherry picked from commit 0b8fe9834b398db7550f30718b3cb63860c6165d)
2014-06-30Debugging outputmatteocam1-1/+1
Change-Id: I4e9418746ad50e1bdb1336459c00a4cf614e2350 (cherry picked from commit 4b2d62f02a386013d0004058a02fed80eb8df675)
2014-06-30Added case in editdoc.cxxmatteocam2-5/+11
Change-Id: I572d79dfd770eaa13d24b27f1c689a059cb79153 (cherry picked from commit 073be3ab511a33e639135703caa2229c1f105b54)
2014-06-30Added body of EditCharAttribBackgroundColormatteocam1-5/+1
Change-Id: Ieac410809b33b1b489cb7563f3fed133d32832d0 (cherry picked from commit 8fd668c43982f683dca945277a6c9d4bc8ea720a)
2014-06-30Added EE_CHAR_BKGCOLORmatteocam1-5/+6
Change-Id: If11271f4b3b8f9ab67961206856938046ea2a416 (cherry picked from commit c2580813426a58cd2ab22efacec9d28423201562)
2014-06-30Added class SvxBackgroundColorItemmatteocam3-1/+74
Change-Id: If10795bbbd9fc911896b57bbab5410bc1e62f71f (cherry picked from commit ad6a2607f09d2f770e683a21ad7243a077d65a7a)
2014-06-30Setting SetTextFillColor from Attrs. Experiment with line colormatteocam1-3/+6
Change-Id: If34f000d6c5ef6ec38f7f735ada194b8fff4f56d (cherry picked from commit 7fb0e8c9a659417607c85f9b0e8245e4af4552dc)
2014-06-30Cleaned up code from tranparency in vcl. Trying setfillcolor from edit attrsmatteocam1-0/+5
Change-Id: I263012332e43573f260ac8c54612576eb21a11a1 (cherry picked from commit 02385eb4d8de3c5a57511d8bae3c42a523470838)
2014-06-30Cleaned up code from operations in vclmatteocam1-0/+17
Change-Id: Ica5194f0cf6e30ec099974ae8b794fb2bc5e654a (cherry picked from commit 4445f361aa2730b61fdd339dcdd7014b266e5c42)
2014-06-30Moved Text Filling Color in OutDev. Text Filling occurs in ImplDrawTextmatteocam1-5/+2
Change-Id: I9c75066a8dea32721757d0511a2af58c68408438 (cherry picked from commit b09cf493611f2521e66159287b88acc3c05d6d33)
2014-06-30Put text filling in SvxFontmatteocam1-0/+7
Change-Id: I290fff0cb66fc07122b976d977dff24ac491e108 (cherry picked from commit ea56441757a34082b9ffc5f28936413fcb55e31a)
2014-06-30HasBkg method to Font.HasBkg iff HasSingleUnderline.SetBkgColor in OutputDevmatteocam2-4/+6
Change-Id: I10e6e1b916df0c78d26596a37944e8b57b2897e7 (cherry picked from commit 181266201b5e6aaad1dcd9cbc2dd4db44ecf3dc5)
2014-06-30Test on changing backgroundmatteocam2-1/+6
Change-Id: Id1ad39eee375de229d63e749673021848690e363 (cherry picked from commit 422321340246104c0d8b11a2cf170606d8f476c3)
2014-06-30Debugging options in EditCharAttribColor::SetFontmatteocam1-1/+3
Change-Id: I44790059cffed0c124c4f30db7ea5028f0a0148d (cherry picked from commit 1091871d3e0c9ba556f223b210584aa0425ce642)
2014-06-30Called C++ object pointer is nullCaolán McNamara3-4/+4
Change-Id: I88efc4be6ff869ef97a2b398d43f7b7914debfc6
2014-06-30Drop unecessary continuePeter Senna Tschudin1-1/+0
Change-Id: Ibd16b4328da70d6ae48669a9becdb4690c6ef4df Reviewed-on: https://gerrit.libreoffice.org/9969 Tested-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-06-29Typo: beeing->beingJulien Nabet2-2/+2
Change-Id: I34937e400ac8576154d33e1e11b80690222f532c
2014-06-27OSL_ENSURE->assert where guaranteed deref followsCaolán McNamara1-7/+5
Change-Id: I6e007cc3a9fd222c1c1381c8b4f890966c05cbab
2014-06-24bnc#882631: Do not hide top of the first row when editing text in table cells.Matúš Kukan1-2/+2
This can happen when proportional line spacing is less than 100% and "FontIndependentLineSpacing" is set, so just keep the height of the very first line in case of IsFixedCellHeight() too. Change-Id: Id231fc1f2373645e5420f877e8c2568ce8a1f099
2014-06-24coverity#1103694 Missing break in switch, assuming this is wrongCaolán McNamara1-0/+1
Change-Id: I9a631eb28647ecf2633d6443d7af95cb37b860a3
2014-06-24new compilerplugin returnbyrefNoel Grandin1-1/+1
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
2014-06-21Revert "bnc#882631: keep line visible if proportional line spacing is < 100%."Matúš Kukan2-11/+2
This reverts commit 339e5d44a2afa0f5309a970f1ff11968103e336a and commit d1987a3eaccfc3add35e6b9f8307ede857c5468e "fix sd_import_tests after e42c05c1f96832572e525d85d89590f56f5a29dd". It would need more work and understanding, so just revert. Also, the problem with bnc#882631 is somewhere else, though this helped too.
2014-06-18Related: fdo#80140 a11y crash on changing text via spellchecker in impressCaolán McNamara1-4/+0
i.e. with French dictionary available, open test case of fdo#80140, open spell checking dialog and choose "correct" on the first example. Every version of LibreOffice crashes on this, so its an old bug. As can be seen from the following bt, if a11y is enabled then on calling ImpEditEngine::ImpInsertText from ImpEditEngine::ImpDeleteSelection then FormatDoc may be called and throw away all the old portions so the following ParaPortion* pPortion = FindParaPortion(aStartPaM.GetNode()) will get the new ParaPortion, not the old one, and so the MarkInvalid that uses the old ParaPortion invalid range is not correct anymore. Seeing as the only caller of ImpRemoveChars is ImpDeleteSelection and ImpDeleteSelection calls TextModified after ImpRemoveChars and after the use of MarkInvalid, it seems safe and logical to remove the TextModified from ImpRemoveChars and rely on the ImpDeleteSelection TextModified. #0 TextPortion::TextPortion (this=0x30bd020, nL=5) at /home/caolan/LibreOffice/core/editeng/source/editeng/editdoc.hxx:401 #1 0x00007fffd93f4d5a in ImpEditEngine::CreateTextPortions (this=0x3f42700, pParaPortion=0x3584930, rStart=@0x7fffffffa234: 0) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:2372 #2 0x00007fffd93ed087 in ImpEditEngine::CreateLines (this=0x3f42700, nPara=0, nStartPosY=0) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:687 #3 0x00007fffd93ebb3b in ImpEditEngine::FormatDoc (this=0x3f42700) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:394 #4 0x00007fffd93fd239 in ImpEditEngine::FormatAndUpdate (this=0x3f42700, pCurView=0x0) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit3.cxx:4156 #5 0x00007fffd937c3f4 in EditEngine::GetDocPosTopLeft (this=0x3f42690, nParagraph=0) at /home/caolan/LibreOffice/core/editeng/source/editeng/editeng.cxx:1920 #6 0x00007fffd94d298a in Outliner::GetDocPosTopLeft (this=0x3f42390, nParagraph=0) at /home/caolan/LibreOffice/core/editeng/source/outliner/outlin2.cxx:429 #7 0x00007fffd951c2d3 in SvxOutlinerForwarder::GetParaBounds (this=0x36015a0, nPara=0) at /home/caolan/LibreOffice/core/editeng/source/uno/unoforou.cxx:344 #8 0x00007fffd950efe5 in SvxAccessibleTextAdapter::GetParaBounds (this=0x3394e88, nPara=0) at /home/caolan/LibreOffice/core/editeng/source/uno/unoedprx.cxx:798 #9 0x00007fffd9aa25b5 in accessibility::AccessibleTextHelper_Impl::UpdateVisibleChildren (this=0x3394e00, bBroadcastEvents=true) at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:851 #10 0x00007fffd9aa38b3 in accessibility::AccessibleTextHelper_Impl::ProcessQueue (this=0x3394e00) at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:1332 #11 0x00007fffd9aa400c in accessibility::AccessibleTextHelper_Impl::Notify (this=0x3394e00, rHint=...) at /home/caolan/LibreOffice/core/svx/source/accessibility/AccessibleTextHelper.cxx:1482 #12 0x00007ffff548c6ba in SfxBroadcaster::Broadcast (this=0x3394ac0, rHint=...) at /home/caolan/LibreOffice/core/svl/source/notify/brdcst.cxx:43 #13 0x00007fffd895ce27 in SvxTextEditSourceImpl::NotifyHdl (this=0x3394a50, aNotify=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/svx/source/unodraw/unoshtxt.cxx:1030 #14 0x00007fffd895cd61 in SvxTextEditSourceImpl::LinkStubNotifyHdl (pThis=0x3394a50, pCaller=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/svx/source/unodraw/unoshtxt.cxx:1023 #15 0x00007fffd936252a in Link::Call (this=0x3f426a8, pCaller=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/include/tools/link.hxx:123 #16 0x00007fffd94db186 in Outliner::EditEngineNotifyHdl (this=0x3f42390, pNotify=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/editeng/source/outliner/outliner.cxx:2041 #17 0x00007fffd94db149 in Outliner::LinkStubEditEngineNotifyHdl (pThis=0x3f42390, pCaller=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/editeng/source/outliner/outliner.cxx:2038 #18 0x00007fffd936252a in Link::Call (this=0x7fffffffb490, pCaller=0x7fffffffb4c0) at /home/caolan/LibreOffice/core/include/tools/link.hxx:123 #19 0x00007fffd93e0155 in ImpEditEngine::CallNotify (this=0x3f42700, rNotify=...) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:4339 #20 0x00007fffd93cf462 in ImpEditEngine::TextModified (this=0x3f42700) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:707 #21 0x00007fffd93d5a73 in ImpEditEngine::ImpRemoveChars (this=0x3f42700, rPaM=..., nChars=8, pCurUndo=0x0) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2064 #22 0x00007fffd93d77bd in ImpEditEngine::ImpDeleteSelection (this=0x3f42700, rCurSel=...) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2424 #23 0x00007fffd93d89f6 in ImpEditEngine::ImpInsertText (this=0x3f42700, aCurSel=..., rStr="Smoothie") at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit2.cxx:2645 #24 0x00007fffd94139f7 in ImpEditEngine::ApplyChangedSentence (this=0x3f42700, rEditView=..., rNewPortions=std::__debug::vector of length 2, capacity 2 = {...}, bRecheck=false) at /home/caolan/LibreOffice/core/editeng/source/editeng/impedit4.cxx:2172 #25 0x00007fffd937d0f1 in EditEngine::ApplyChangedSentence (this=0x3f42690, rEditView=..., rNewPortions=std::__debug::vector of length 2, capacity 2 = {...}, bRecheck=false) Change-Id: I6d0a96c8875858d8a25455f0dd1408f07e1f6e14
2014-06-18coverity#1210038 Uncaught exceptionCaolán McNamara1-4/+11
and hopefully a bunch more Change-Id: I2acdf069555873303835324a877cd7c38d617ca7
2014-06-17bnc#882631: keep line visible if proportional line spacing is < 100%.Matúš Kukan2-2/+11
If line height is smaller than text height, we still want to see whole first line, so add the difference where necessary. This also helps to see paragraphs as separate to each other. Change-Id: I51a87edf0cc03d5b5e130290c90347099a581d4e
2014-06-17improve the inlinesimplememberfunctions clang pluginNoel Grandin10-69/+13
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-13Paragraph argument never used in InvalidateBulletCaolán McNamara2-7/+4
Change-Id: I07ba855e473fb137551e70de9cfa858c5e079324
2014-06-13loplugin:staticcallStephan Bergmann5-14/+14
Change-Id: If6fca7f7761877b5642eddb800de46efb59aa6dc
2014-06-12Clean upStephan Bergmann1-5/+1
Change-Id: I14ababd3adb39cbde0ae3b5622b21fe72eb06ad9
2014-06-12Clean upStephan Bergmann1-16/+9
Change-Id: I3fc017fb5ef1fe704d273d667405eee588fa35cb
2014-06-12Missing SolarMutexGuardStephan Bergmann1-0/+3
...the non-mutex'ed access to the static LinguMgr members from other functions makes it look like those are all assumed to be called with SolarMutex locked; but that does not hold for calls to LinguMgrAppExitLstnr::disposing. Change-Id: I225a9f7ace65774460502a4aa510abddd48d12ca
2014-06-10coverity#735422 Logically dead codeCaolán McNamara1-2/+1
Change-Id: I5639746f25024b0808e9c4e620bb0fa9f1a2c0b6
2014-06-09some remaining sal_uInt16 to sal_Int32 editeng ESelection boundsCaolán McNamara2-100/+51
Change-Id: Ib47dea5c2d965cf613c465e624a1bdd81becb1c2
2014-06-09loplugin: inlinesimplememberfunctionsNoel Grandin11-82/+4
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-05coverity#705153 Missing break in switch, surely this is not intentionalCaolán McNamara1-1/+1
since the initial commit of c04e60275f273dacf8796e957e1ebadc08b497a1 Change-Id: I9d3c3c2870c145b2fdb5c4f6c6ed17a14d1162c2
2014-06-05editeng: remove SAL_THROW macroNoel Grandin4-23/+21
Change-Id: I8e36112a10cdef6250dba4b4cf75e5eba443e0b9
2014-06-04coverity#736033 Missing break in switchCaolán McNamara1-4/+3
Change-Id: Iabfc6fc76a80ad30bd412826f60edbf8b3facdd2
2014-06-04coverity#705374 Mixing enum typesCaolán McNamara1-1/+1
Change-Id: Ie18131e7207d8f93a775c21abfc77d768352a5d3
2014-06-04DeInitVCL at end of testsStephan Bergmann1-0/+1
This required some changes to the framework: * Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but once per CppunitTest invocation in a new vclbootstrapprotector (similarly to the exisiting unobootstrapprotector). CppunitTests that need VCL now need to declare gb_CppunitTest_use_vcl. * For things to work properly, the UNO component context needs to be disposed from within DeInitVCL (cf. Desktop's Application::DeInit called from DeInitVCL). The easiest solution was to introduce an Application::setDeInitHook (where the hook is called from DeInitVCL) specifically for vclbootstrapprotector to call. * PythonTests don't (yet) call DeInitVCL; they still hook into BootstrapFixture's original test_init functionality (to call InitVCL), and do not make use of the vclbootstrapprotector. Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04avoid problems with poppler's and vcl's FontInfo during runtimeMarkus Mohrhard1-1/+1
Change-Id: I1dbd256812cccae1e6ed0ad8bb34ce427e5e5be8
2014-05-31fdo#64956: editeng: fix RTF color table exportMichael Stahl4-70/+29
The editengine RTF export produces this: {\colortbl\red255\green255\blue255;;} ... and then it proceeds to map COL_AUTO to \cf0 i.e. the "white" entry that is the result of erroneously writing out the 0th entry regardless of whether it is COL_AUTO or not. Fix the color table export to always put COL_AUTO first (as the Writer RTF export already does), and simplify the code a bit. Change-Id: Ia8ce19f387e3627a1b4a26bcc723edcf5b1ffdf8
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 16:27:38 +0000