summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2015-11-09EditUndoRemoveChars::GetStr must return a referenceStephan Bergmann1-1/+1
...as ImpEditEngine::ImpRemoveChars (editeng/source/editeng/impedit2.cxx) calls pCurUndo->GetStr() += aStr; Regression introduced with d5e11f5ffb741aabe7e43be78ef764a1f3cafd8e "convert editeng/source/editeng/editundo.hxx from String to OUString." Change-Id: Iab3dd3b861bca715a90e89e3a63a6f298657367d (cherry picked from commit e31205f3ec1f941ab5a188bfde6329edf2acc55b) Reviewed-on: https://gerrit.libreoffice.org/19857 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-06Resolves: tdf#76964 fall back to primary language via getLanguageCaolán McNamara1-13/+21
instead of bittwiddling which ends up trying to resolve the system language (cherry picked from commit a1ff0745cc4f78777e8dba1e7bb52d18386d7394) more tdf#76964 fall back to primary language via getLanguage (cherry picked from commit 97893e56e61a466e56d12ee46d11f6e4c32a737b) sw: fix SwUiWriterTest pointlessly loading an "empty.odt" ... ... instead of just creating a new document. (cherry picked from commit 98ddd7a32fd0d5fa080fac368b9dc53a06659285) Change-Id: I545bd5e39f99003ddedf3c90031e8b818edc1de2 Reviewed-on: https://gerrit.libreoffice.org/19545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-02Fix tdf#93438 Impress generate abnormal style when copy-pastingMark Hung1-1/+7
from Writer with Chinese UI. When user configure UI language as Chinese, style names are also translated. However when Copy-pasting from Writer to Impress ( select RTF fromat with paste-special), Chinese (unicode) style names are borken into multiparts, where some of them are empty string. Neither deleting the abnormal style nor saving the file can be achieved. The only remedy is to remove style with emtpy name with macro. With this patch: 1) Catch NoSuchElementException and ignores it, so user still has chance saving file. 2) Make sure style has valid number before inserting it. 3) Prevent text breaking into multiple tokens by handling ucN in ScanText(). Change-Id: I417f70b81c23ac63c175cc13c548068873d13a38 Reviewed-on: https://gerrit.libreoffice.org/18148 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/19685
2015-09-26tdf#93141 Calc/Impress: remove last colon of emoji short namesLászló Németh1-1/+5
AutoCorrect Emoji replacements were incomplete in Calc cells and Impress text boxes, keeping the terminating colon: :omega: -> Ω: Corrected by this patch: :omega: -> Ω Change-Id: I0d1f6f9ec9c31a7b37e0c9afaaad17dcee568dd5 Reviewed-on: https://gerrit.libreoffice.org/18849 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-09-07tdf#93052 - When save, generate unused list-styles in context.xmlJuergen Funk1-2/+3
Evaluation of the 0 is here http://opengrok.libreoffice.org/xref/core/xmloff/source/text/txtparae.cxx#615 the methode "xNumRule->getCount()" get back the 0. Change-Id: I15424fe7eb9d35a6a6d4f669e695efc904be320f Reviewed-on: https://gerrit.libreoffice.org/18231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-09-03Fix tdf#93781 Impress copy wrong style name to clipboard whenMark Hung1-1/+2
style name contains Chinese character. Encode style name in multibyte sring (ex,Chinese) properly with RTFOutFuncs::Out_String(). Change-Id: Ibdd1010e28c711d7829643b60b32637ebce58bdb Reviewed-on: https://gerrit.libreoffice.org/18247 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 85c62a36a907bc5ff31627349a80baa51efbd443) Reviewed-on: https://gerrit.libreoffice.org/18296
2015-08-28don't write SvxBackgroundColorItem via inherited SvxColorItem::StoreCaolán McNamara2-32/+12
SvxBackgroundColorItem inherits from SvxColorItem and for backwards compatibility with the StarOffice 5 binary file format (yes, really) writes/reads only rgb and not the transparency value, so copying and pasting text from a sidebar comment in writer to itself or another one results in a black character background as the default COL_AUTO turns into black Change-Id: I18b5105dd8e060b9e49dda6026e26d3a0f00d8f5 (cherry picked from commit 3bc69b1d0d8620afd89a993b5f6bc46a2ff5267f) this farcical staroffice 5.0 related junk can at least be const Change-Id: I096d98f6e0cb61cacd9cd82a623f832b88ded1e6 (cherry picked from commit 1e8b7cdbbd084a1e75f82bfff605321c8480b78d) Reviewed-on: https://gerrit.libreoffice.org/18087 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-13tdf#93384 editeng rendercontext: don't paint spellcheck result directlyMiklos Vajna1-2/+1
E.g. in Writer create a new comment, type a word that is not in the dictionary, then a space to trigger the spelling, and that painted the spelling error indicator outside Paint(). (cherry picked from commits 71aed9185fb17ee27bdc38b4ac650713c4cabb8b and 89bd30cf426ca54fc9e46295a60551b5bb2d3232) Change-Id: I8f72486189e04a5596729fb52b6af39772f8e002 Reviewed-on: https://gerrit.libreoffice.org/17690 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-11tdf#88295: Don't export transparent background colour as whiteKatarina Behrens1-0/+45
The fix is twofold: 1. retrieve transparency from colour in SvxBackgroundColorItem (add QueryValue, PutValue methods, use additional memberID to retrieve alpha channel as a bool property) 2. add CharBackTransparent bool property to Draw [text] shapes Change-Id: I6e14b81cc82f6b4d7fdd4756ff2e4f75e9270361
2015-06-08tdf#90804 remove SfxFieldUnit enumAndras Timar1-2/+2
b78d881520f2eb658180e2c90ffee3d30a80f0ae removed unused values from SfxFieldUnit enum. This broke the mapping between SfxFieldUnit and FieldUnit. In fact SfxFieldUnit was redundant. Change-Id: I13c7e7d708c6eeab0de192f4cd110b0a23989a31 Reviewed-on: https://gerrit.libreoffice.org/16150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 7f4230675c6c78ebea8b6db3f3612e3ef6fb23df)
2015-06-08AutoCorrect: fix not immediately replacement of Emoji :short_names:László Németh1-2/+7
Cherry-picked from 86782d5dfc0163159369677b0ac172ed2125b221 and cd2ba3124602ad9ee8f5927c385936cc5319808d. [86782d5dfc0163159369677b0ac172ed2125b221: AutoCorrect: direct replacement of keywords surrounded by colons Replacing immediately (without pressing space or enter) and inside words, too. For example, fixing tdf#55292 – complete input method for n-dash, m-dash – is possible now by :--: -> n-dash, :---: -> m-dash AutoCorrect replacements.] cd2ba3124602ad9ee8f5927c385936cc5319808d: unbreak calc again, a fix for the previous commit by Markus Mohrhard] Change-Id: Id7d9411599bec620fa91c246b531d26150f20c6a Reviewed-on: https://gerrit.libreoffice.org/16002 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-06-04tdf#91702 - fix stack-based MessBox allocation.Michael Meeks3-3/+3
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7 Reviewed-on: https://gerrit.libreoffice.org/15954 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-06-03tdf#88276: toolbar|sidebar button for text background colourKatarina Behrens1-1/+1
Change-Id: I547a562384d30b95b744673feb284ccbcf50a614 Reviewed-on: https://gerrit.libreoffice.org/16030 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Yousuf Philips <philipz85@hotmail.com> Reviewed-by: Philippe Jung <phil.jung@free.fr> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2015-05-29convert constants in include/vcl/settings.hxx to scoped enumsNoel Grandin1-1/+1
Change-Id: I2a110c017f13eca6ddbd70ef3ed195d24adef0a3 Reviewed-on: https://gerrit.libreoffice.org/15828 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-29convert POINTER constants to scoped enumNoel Grandin2-9/+9
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Signed-off-by: Jan Holesovsky <kendy@collabora.com>
2015-05-27tdf#91416 - fix some incorrectly allocated VirtualDevices.Michael Meeks1-1/+1
Change-Id: I9ebed313827986473c60e77b7e218b4c1b2487fe (cherry picked from commit f849d96463d967214bc063f6de912a082272c395)
2015-05-26ImpEditView::SetCursorAtPoint tiled rendering: avoid partial selectionsMiklos Vajna1-2/+2
Same problem as in the previous commit, just for mouse move. Previously when selecting "abc" with the mouse only one or zero letter got selected as the mouse moved, now it's properly the whole afffected string. Change-Id: I025dbd71fc02a0c93a532ca188836ffb957d6b35 (cherry picked from commit c6f03d6fc25a3cea22f2ce035d0948bcaa74daa9)
2015-05-26ImpEditEngine::MoveCursor tiled rendering: avoid partial selectionsMiklos Vajna1-2/+2
Tiled rendering assumes that the whole list of selection rectangles is sent, i.e. the information is not incremental. With this, if the text is "abc" and you are before "a" with the cursor, then pressing shift-rightarrow two times will result in "ab" being selected, not just "b". Change-Id: I70c043575d3c68d78342af0a6b78659d83b4f5f4 (cherry picked from commit 18e08580b660111e7e9b0bae18ac9034f57475ba)
2015-05-20bin/rename-sw-abbreviations.shlibreoffice-5-0-branch-pointChristian Lohmaier17-106/+106
renames the most annoying abbreviations in Writer (and partially in the shared code too). Change-Id: I9a62759138126c1537cc5c985ba05cf54d6132d9
2015-05-20convert DEFAULTCONSTANT constant to scoped enumNoel Grandin3-3/+3
Change-Id: I5ebd77edfa29d6c6c7acea37e826ef1d625916c3
2015-05-20convert DRAWMODE constants to scoped enumNoel Grandin1-2/+2
Change-Id: I36cbe8057d09226f8b302963bdd94dc5600b686f
2015-05-18Related tdf#88056: use better-fitting <text:page-name>Katarina Behrens2-8/+8
Implemented Regina's suggestions: * this is a text field, therefore it belongs to text namespace * page-name (evtl. slide-name) describes much better what this field really contains This (among other changes) reverts commit 6609de8856519e0e9 Change-Id: Idab3b7c291839a9137f80d325a7d3f5ef0ff2636
2015-05-15tdf#62475: partial handmade fixesAndrea Gelmini3-18/+12
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4 Reviewed-on: https://gerrit.libreoffice.org/15712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-05-15conver MENU_FLAG_ constants to scoped enumNoel Grandin1-2/+2
Change-Id: I969d99fa8881cc89601696a2d8621905a82b147b
2015-05-15convert POPUPMENU_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I4cdaf36581d1e1daa39929e621070d18a9996852
2015-05-14convert INPUTCONTEXT_ constants to scoped enumNoel Grandin1-1/+1
Change-Id: I5b99e42a3e85527b27d515c468d2ed66386fc9df
2015-05-14convert QUICKHELP constants to scoped enumNoel Grandin2-2/+2
Change-Id: Ie7302c909feb2e83b8b5e62a5e6a1f901783fb49
2015-05-14convert GRFILTER_I_FLAGS to scoped enumNoel Grandin1-1/+1
Change-Id: Ic1cb9b32fe252706cd607abb2ae1fd5a00999901
2015-05-14convert KERNING_ constants to scoped enumNoel Grandin4-5/+5
Change-Id: I58031485aaa9ebdeb986a3ee0376f36a9f667947
2015-05-12convert CURSOR_DIRECTION constants to scoped enumNoel Grandin1-3/+3
Change-Id: I444c61d0073b12740b55e316b2bb6e34f59dfe21 Reviewed-on: https://gerrit.libreoffice.org/15675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11convert COMMAND_ constants to scoped enumNoel Grandin1-10/+10
Change-Id: I88e67f89dbbab0646e8f106dfeb32c6ee1bb0b95 Reviewed-on: https://gerrit.libreoffice.org/15671 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-11loplugin:cstylecast: nop between pointer types of exactly same spellingStephan Bergmann3-3/+3
Change-Id: I94230f5d0838f26173eb17401f7bf22ab126e7ef
2015-05-11cppcheck: unreadVariableCaolán McNamara1-1/+0
Change-Id: I7af3807a4390e3b2f1bd9373feb937b6ff3dea7a
2015-05-10Replace IMPL_STATIC_LINK[_TYPED] with more useful variantsStephan Bergmann1-5/+5
Change-Id: I9aca53ea7c957524a4ade0f20ef47954ddcbf5de
2015-05-07Remove unnecessary includes of sot/storage.hxx from include/Stephan Bergmann1-0/+1
Change-Id: I242cd126814bbebdb99ea38d9e66513189c313d9
2015-05-07Unwind SotStorageStreamRef typedefStephan Bergmann1-3/+3
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07Unwind SotStorageRef typedefStephan Bergmann1-15/+15
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07Remove SvStorage aliasStephan Bergmann1-1/+1
Change-Id: Id07ace147ff4fd4a17d05ba3cce6408def05c9c7
2015-05-07Remove SvStorageStreamRef aliasStephan Bergmann1-2/+2
Change-Id: Ic25c39adf8796bb433fa7746f53a68e3e2bfd228
2015-05-07SotStorage ctor takes as 3rd param a StorageMode (aka short)Stephan Bergmann1-13/+13
The code in editeng, passing sal_True (= 1) into StorageMode, has been like that ever since cd7096b4260149eb6fdd117ea0ba26b8116a41b2 "INTEGRATION: CWS mav09: #i27773#: remove so3; new storage API" where SfxMedium ctor calls were replaced with SotStorage ctor calls, keeping the argument lists intact. And at least way-back 5a9184d9e270e0ec0fe4b378c5cfde54ede095fa "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to sfx2/inc/sfx2 and correspondent necessary changes" had a SfxMedium ctor that took as 3rd param a sal_Bool bDirect. That is, it looks like cd7096b4260149eb6fdd117ea0ba26b8116a41b2 inadvertently carried the SfxMedium bDirect arguments over as SotStorage StorageMode arguments. Given further that even way-back e1e019fed3970b916b046e2d7be48ea786026fce "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to sot/inc/sot and correspondent necessary changes" only defines STORAGE_* values with values >= 0x02 (so sal_True would never have had any effect), the best bet appears to just use the implicit default = 0 instead. Change-Id: I3c19831433173657d3a3225c28398de7481fe036
2015-05-06VclPtr: one ref too manyCaolán McNamara1-2/+2
Change-Id: I0efce31e0f7cc5aa4895b6e5e35432d3f0c6fb70
2015-05-06convert DEFAULTFONT_ constants to scoped enumNoel Grandin3-6/+6
Change-Id: Ia33e957f6cf530e2639b3c86d9482f642652cb46
2015-05-06convert FONTTOSUBSFONT constants to scoped enumNoel Grandin2-5/+5
Change-Id: I994bfc76d709d01406404991dbfbd49b15bd03f4
2015-05-05vcl::Window::Scroll takes a sal_uInt16 nFlags, not a sal_BoolStephan Bergmann1-1/+1
This passing of sal_True instead of some SCROLL_* flags has been there ever since fd069bee7e57ad529c3c0974559fd2d84ec3151a "initial import," and the signature of vcl::Window::Scroll has been like that at least since f59676fe09175725ee0a75a1678dd1581decc20b "INTEGRATION: CWS hedaburemove01: #72503# get rid of hedabu procedure: Moving headers to vcl/inc/vcl and correspondent necessary changes," so lets arbitrarily assume that this wants to pass SCROLL_CLIP (which has the same numeric value as Change-Id: I8da6536404aa220611a7df96605c7a4a9efc7f7c
2015-05-05Use typed Idle::SetIdleHdl LinkStephan Bergmann3-4/+3
Change-Id: I189937950325dc4ef663f7f49cb45f38f8537de9
2015-05-05Use typed Timer::SetTimeoutHdl LinkStephan Bergmann2-7/+4
Change-Id: Iaaf0c93e5b28c0f7dbe4f02eda8beeae30708100
2015-05-03drop useless temp debugging stringsCaolán McNamara1-12/+0
Change-Id: I9adc765654cf15633a53576e620c13eddcdc3b82
2015-05-03drop useless temp debugging stringsCaolán McNamara1-6/+0
Change-Id: I8a11a3d20fc5bde984586cb7046b174568315620
2015-04-30Gradually typed LinkStephan Bergmann11-58/+58
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30Get rid of initial :: for the svx namespaceTor Lillqvist4-13/+13
Change-Id: I03e428a749bca409ebac9c142acaddafcbfeca23
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-03 08:47:36 +0000