summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2016-05-09convert FONT_EMPHASIS_MARK to scoped enumNoel Grandin6-33/+35
Change-Id: I137c78b337e57d3442db08334128e79d186b278f Reviewed-on: https://gerrit.libreoffice.org/24753 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert SfxStyleFamily to scoped enumNoel Grandin6-12/+12
and update the RSC compiler to accept such In the process fix some confusion in SD where it was confusing SfxStyleFamily and the index of the relevant family (which other parts of the code in SVL use) Change-Id: I1efc9f85fbed8ab76eafe8f6e1ada411753ae5f9
2016-05-08Translate German commentJulien Nabet1-1/+1
Change-Id: I7a6481370cacd1c33510654d17b20d254e753476 Reviewed-on: https://gerrit.libreoffice.org/24754 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-04use Any constructor instead of temporariesNoel Grandin1-9/+3
Change-Id: Iffb82a2cee1a28d89eeea2b905aaa14086ee475a
2016-05-04While at it, delete Any functions on sal_Bool*Stephan Bergmann2-32/+15
(at least for LIBO_INTERNAL_ONLY), to help further reduce the occurrences of sal_Bool across the code base Change-Id: I70654a0cb56655984c717b7b894f26c9ab47536e
2016-05-03Prevent Any::setValue from reinterpreting bool* as sal_Bool*Stephan Bergmann1-35/+33
...which only happens ot work in environments where sizeof (bool) == 1. The simpler alternative is to use the operator <<= template without passing explicit UNO type information, anyway. The std::nullptr_t overloads are needed to disambiguate calls with a nullptr argument. (Which can at least be meaningful for VOID, but for other types what it happens to do is store a default value of the given type.) As std::nullptr_t is only C++11, this all needs to be LIBO_INTERNAL_ONLY. Change-Id: Iff06a6ba94250bd4ae4afc937c2a2bfa75f0888f
2016-05-01Replace '||' with '&&'Rosemary Sebastian1-1/+1
so that the condition doesn't always evaluate to true Change-Id: I66ba3d4c7985e1fad60f12836e44167f19216588 Reviewed-on: https://gerrit.libreoffice.org/24548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-01Fix typo in codeAndrea Gelmini2-3/+3
Change-Id: Ia1ec84da61aa353d481ada98c41cbebaca623c0e Reviewed-on: https://gerrit.libreoffice.org/24532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-28teach stylepolice plugin about ref-counted-pointer namingNoel Grandin1-5/+0
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752 Reviewed-on: https://gerrit.libreoffice.org/24459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-27todo odd warnings being printedMichael Stahl1-0/+1
Change-Id: I227ba7063827952525a4b190f864b4c7ffb3a6d8
2016-04-27-Werror,-WvarargsStephan Bergmann2-5/+5
"passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]" just replace the variadic function with one taking an initializer list Change-Id: Ied3dfe835dcebef48cf35374ec4d8835f98e6779
2016-04-26update loplugin stylepolice to check local pointers varsNoel Grandin2-6/+6
are actually pointer vars. Also convert from regex to normal code, so we can enable this plugin all the time. Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1 Reviewed-on: https://gerrit.libreoffice.org/24391 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-26clang-tidy modernize-loop-convert in e*Noel Grandin18-103/+88
Change-Id: If56abefa81b41479e3ea9890dee1c43f006086de Reviewed-on: https://gerrit.libreoffice.org/24384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-21new plugin stylepoliceNoel Grandin1-3/+3
check for local variables which follow our member field naming convention, which is highly confusing Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
2016-04-20loplugin:salbool: Automatic rewrite of sal_False/TrueStephan Bergmann13-31/+31
Change-Id: I626b79e1450d78aec96c206db82bf64a47305d08
2016-04-20Use IsRightToLeft()Stephan Bergmann2-7/+5
...instead of computing this from GetRightToLeftLevel() Change-Id: If0068c8aae581b6f097ba3897b4a3031db8d9afd
2016-04-19So this is apparently about right-to-left levels, not a boolean flagStephan Bergmann4-21/+21
Although the cases where GetRightToLeftLevel() is contextually converted to bool look fishy, and might have been intended to use IsRightToLeft() instead? Change-Id: I741b90cb6f1ccdac0886c451d05f4cfac79dbd5f
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin3-22/+16
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke1-1/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann1-1/+1
"logical ‘and’ of mutually exclusive tests is always false" <sberg> alg, in editeng/source/uno/unoipset.cxx:208 (wid < START && wid > END), is what's actually wanted to check for contained or for not contained in the START..END range? You touched the code last, in b0c2ec72ff171d8b4303d39f11f67497e88e2d8c, 15+ years ago (although the line itself was already like that in the initial import, fd069bee7e57ad529c3c0974559fd2d84ec3151a) <alg> sberg: sorry cannot remember - but looks correct. All values outside OWN_ATTR_VALUE_START/_END are answered with defaut. The renge should be the one from ditEngine <sberg> alg, the code as is is clearly incorrect, as the condition is always false <alg> sberg: Ah, yes! Should probably be an '||' <sberg> alg, OK, thanks, I'll give that a "make check" try (a bit scary to thus enable code that had effectively been disabled since at least the turn of the century) <alg> sberg: Yes - scary is the right word. Looking further, eState == SfxItemState::DEFAULT should result when outside, thus pItem->QueryValue would be taken which *should* get the default from the pool when not in the local ItemSet range. In theory, the same *should* happen Change-Id: I906361272dfe3f6af0e1ed3cb4e245ead7eabaec
2016-04-14-Werror=logical-op (GCC 6)Stephan Bergmann1-1/+1
"logical ‘or’ of collectively exhaustive tests is always true"; apparently a typo in 63114e6d863de32e2d93f0da54caca928916d9c2 "Create SvxFieldData instance directly from the UNO textfield object" Change-Id: I9e504ccb5ebad5a42a8c07d7f16d7c316dd82cf1
2016-04-13loplugin:passstuffbyref in editengNoel Grandin2-9/+9
Change-Id: I11deb7c73a1c160d587d74c9851ff10c875c972b
2016-04-12Avoid reserved identifiersStephan Bergmann2-5/+5
Change-Id: I12118ad040d1791c7afa517081040961cc7e4677
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke4-4/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-11clang-tidy performance-unnecessary-value-param in editengNoel Grandin6-19/+19
Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44
2016-04-11tdf#94306 replace boost::noncopyable ...Jochen Nitschke4-11/+17
... in modules editeng to oox. Replace with C++11 delete copy-constructur and copy-assignment. Remove boost/noncopyable.hpp includes and one unused boost/checked_delete.hpp include in linguistic. Change-Id: I5a38d8e5ac1b4286bdeb3858d56490a53d13fe80 Reviewed-on: https://gerrit.libreoffice.org/23928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-10don't pool SvxFieldItem, tdf#92773Markus Mohrhard1-1/+1
In documents with many different hyperlinks pooling them is incredibly slow. I doubt that in most cases the hyperlinks are the same so let us just not pool them. Change-Id: I2387aee57ef0ab3183d9cc3486ddbf8ca2883e0b
2016-04-06Avoid reserved identifierStephan Bergmann1-5/+5
Change-Id: Ia2af17bbf08cebc9e3c8f772583a61bde194328f
2016-04-06Avoid reserved identifiersStephan Bergmann1-6/+6
Change-Id: I0505cf418688d568c0c110bc70b2552e2fb8265c
2016-04-06Avoid reserved identifierStephan Bergmann1-1/+1
Change-Id: I87a6afeffaf7c87c6037a416783f1f22015b2fbf
2016-04-06Avoid reserved identifiersStephan Bergmann2-10/+10
Change-Id: I4c76a7d3f5a209578b5a7c230fbbcdea2ec47ae0
2016-04-06Avoid reserved identifiersStephan Bergmann1-2/+2
Change-Id: I2c83911433a8f89e7366d9f7711ca4879e44bae9
2016-04-05loplugin:constantparam in editengNoel Grandin6-17/+12
Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke2-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke1-1/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin1-1/+1
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-29Avoid reserved identifiersStephan Bergmann3-18/+18
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23loplugin:constantparam in editengNoel Grandin7-197/+47
Change-Id: I50ee4a0a3403cbed2aa8cdd6daaa951c9d0dad37
2016-03-18loplugin:constantfunction in editengNoel Grandin15-42/+33
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin2-5/+3
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-10coverity#1355507 uninitialized scalar fieldCaolán McNamara5-17/+17
I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10loplugin:constantparam in editengNoel Grandin7-29/+18
Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin1-55/+55
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:write only fieldsNoel Grandin6-24/+22
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07improve defaultparams lopluginNoel Grandin1-1/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin6-22/+20
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-06bIsExpanding is unusedCaolán McNamara1-3/+0
Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
2016-03-06coverity#1355252 Uninitialized pointer fieldCaolán McNamara1-11/+13
Change-Id: I34c5565adcfd3fd39f9b03967e5c4272767a58ea
2016-03-03editeng: fix -Werror=unused-but-set-variableMiklos Vajna1-2/+0
Change-Id: I14364bc833c97dbb5dfe323c65282f69ba7e393f
2016-03-03loplugin:unuseddefaultparams in editengNoel Grandin18-118/+72
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 20:33:38 +0000