summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2016-09-15Missing initialization of SvxBorderLine::m_pColorGapFnStephan Bergmann1-0/+1
...since 6dd4905a7ac93a48dc87358da3ba0a8078bbb6cf "loplugin:constantparam in dbaccess..editeng" Change-Id: Ib27615069ac1c7061ad691aada227ebdd70326e5
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl5-10/+11
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14Revert 8c4dbcef8f and provide a better fixAndras Timar1-0/+5
This reverts commit 8c4dbcef8f92c9bd1c2208e7de7971f184f8a3ff. bccu#1781 bug was in LibreOffice Online. After deletion of the selected editeng text, the selection did not disappear. By making the fix conditional to LibreOfficeKit::isActive(), we can avoid the weird selection problem in desktop editeng. Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106 Reviewed-on: https://gerrit.libreoffice.org/28900 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()Miklos Vajna2-4/+20
With this, in case the first view has an active text edit selection and a new view is created, then the text selection is instantly visible in the second view, even if the first view's text selection does not change later. Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
2016-09-13sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback()Miklos Vajna3-2/+26
With this, in case the first view has an active text edit and a new view is created, then the cursor position is instantly visible in the second view, even if the first view's cursor does not move later. Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
2016-09-13rename ContentInfo attribs field and methods to charAttribsNoel Grandin4-42/+41
to match naming higher up the call stack Change-Id: I8a89625de5d834b32fd6ea863ebc4152956a21fe
2016-09-13impress: extend dumpAsXml to style information in ContentInfo nodesNoel Grandin2-3/+26
Change-Id: I783f6ad9b71f18c070537e4806381a103960b6eb
2016-09-13fix out of bounds errorJochen Nitschke1-37/+25
there are 22 entries, but Sequence was allocated with 21 fields Change-Id: I6af71e2ece99b643843b4d82e0c6be332be361fa Reviewed-on: https://gerrit.libreoffice.org/28852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann20-41/+41
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13loplugin:constantparam in dbaccess..editengNoel Grandin4-8/+6
Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc Reviewed-on: https://gerrit.libreoffice.org/28833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09use std::unique_ptrDavid Tardon1-1/+2
Change-Id: I8ba37267e8a7058ade54783ea0e117a8f8816c45
2016-09-09loplugin:constantparam in sot..svlNoel Grandin1-1/+1
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08rename CollapsAttribs -> CollapseAttribsNoel Grandin2-3/+3
Change-Id: Ic70f67fb7e0e557a3a726f44aef25931def49835
2016-09-08improve comment grammarNoel Grandin1-5/+4
Change-Id: Ic7da4b4d67bb006290af6c7b9e5d084d13b6ca98
2016-09-05convert Orientation to scoped enumNoel Grandin1-1/+1
Change-Id: Ifbfcf3557ca2a16d21e7a1d613ee54c1c6625f07
2016-09-05convert RasterOp to scoped enumNoel Grandin1-1/+1
Change-Id: I136423c105316c9b5b18e64d04a248fd7ac5590b
2016-09-02editeng: don't let wild-card auto-correct leave current wordMichael Stahl1-0/+5
If a paragraph has e.g. multiple -> in it then auto-correct of the first one will create via the .*->.* rule a new auto-correct entry that has as long-word the word that contains the first -> until the last -> and everything in between. This will be somewhat irritating when it is eventually applied. Avoid it by limiting the wild-card loop to the current word, which is apparently the intent anyway. (regression from a07425892205ff8951027ea20459b97370d01de6) Change-Id: I294bae863c44eb460627b61b4383133131fe4b3a Reviewed-on: https://gerrit.libreoffice.org/28608 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-01coverity#1372384 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I4451623ba950b93e0efba5b3ec755622c2bea2bc
2016-09-01use SfxItemPool::IsWhich instead of custom implementationJochen Nitschke1-2/+2
Change-Id: I56cbdc1ede491486643f73a98117c5cd4ce77c1d Reviewed-on: https://gerrit.libreoffice.org/28564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-01use SfxItemPool::IsSlot instead of custom implementationJochen Nitschke1-1/+1
Change-Id: I435fb78f10f361120ee1865465dab93aa4661806 Reviewed-on: https://gerrit.libreoffice.org/28565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (editeng)Stephan Bergmann6-12/+12
Change-Id: If8d2eb5e02a107cc1805e349a70df54160fed02a
2016-08-30loplugin:implicitboolconversionStephan Bergmann1-1/+1
Change-Id: Ia50bd6ecc6a4b5efc2de81282a16203e89087314
2016-08-30Resolves: tdf#96369 don't superscript ordinals for mixed text and numbersCaolán McNamara1-2/+1
e.g. 5th is ok, but foo5th is not this is basically a regression from commit 17e6b8fd05af8fff86847c0ef1e8cc9ad013a1bd Date: Thu Apr 7 13:33:48 2011 +0200 where the older code would only do the conversion if the string before the number was comprised of non-letters, so go back to that logic. Change-Id: I928c365eb11891e78331bbd165dbdb9541ac0361
2016-08-30Let OUStringLiteral1 take its arg as ctor arg, not template argStephan Bergmann3-3/+3
...which makes it more flexible, can now also be used on non-const arguments. The drawback of the argument no longer being a compile-time constant is remedied by making the ctor constexpr. Change-Id: Ia4903a2cc86791fece92eac0cb8406b6659dd19d
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke2-9/+9
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26reduce defines to boolJochen Nitschke2-14/+10
nLastAction could be 0, ACTION_INSERTTEXT or ACTION_INSERTPARABRK only later was checked so make this a bool Change-Id: I49287d48ebd12f2fcb4fe71756fe39cf116f588b Reviewed-on: https://gerrit.libreoffice.org/28396 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25loplugin:staticaccess: Extend loplugin:staticcall to cover all access...Stephan Bergmann1-4/+4
to static members (data, in addition to function) via class member access syntax. Also covers the (somewhat obscure) access to enumerator members. Change-Id: Iec54b8df2fdb423c0caf21a0dd0f9fe8fdf33897
2016-08-19Resolves: coverity#705366 Mixing enum typesCaolán McNamara16-215/+215
and coverity#705367 Mixing enum types coverity#705371 Mixing enum types coverity#982694 Mixing enum types coverity#1027717 Mixing enum types coverity#1371228 Mixing enum types coverity#1371242 Mixing enum types coverity#1371280 Mixing enum types coverity#1371310 Mixing enum types MapUnit and SfxMapUnit share the same values and are freely cast from one to the other. Now that commit d30a4298bdb5ba53cd1fe659f2b742f218a2e527 Date: Thu Aug 11 15:02:19 2016 +0200 loplugin:unusedenumconstants in package..svtools removed the SfxMapUnit entries that were directly unused, they don't match anymore and casting from one to the other is dangerous. Why there was two of these anyway escapes me, get rid of SfxMapUnit and just use MapUnit universally Change-Id: I4db5dcd04b59be2f85b62b728f96c90afe00c57e Reviewed-on: https://gerrit.libreoffice.org/28234 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-18coverity#1371381 Dereference before null checkCaolán McNamara1-16/+14
this ones in 5-2 also Change-Id: Ia594fdc466d745df141b76ad7d8af3f362287766
2016-08-17convert SvxEscapement to scoped enumNoel Grandin1-5/+5
and fix a potential bug with footnotes and superscripts in writer in ndtxt.cxx, where it was passing bad args to the SvxEscapementItem constructor Change-Id: I0d2de34c056e7824f3b456a86d502e10ac93a1c1
2016-08-17convert SvxTabAdjust to scoped enumNoel Grandin5-37/+37
Change-Id: I29a33b8ea5daaa4b9059d024ffa4a99ca924f7ef
2016-08-17convert SvxLineSpace to scoped enumNoel Grandin5-27/+27
and rename to be more explicit Change-Id: Id06e6b68ef30e1d0d0daf19c37a390060e8bcb01
2016-08-17convert SvxInterLineSpaceRule to scoped enumNoel Grandin5-25/+25
and rename it to be more explicit Change-Id: I3f8bd7928495dba1e94b785cdda06d9819ee66bf
2016-08-17convert SvxSpecialLineSpace to scoped enumNoel Grandin1-16/+28
And move it inside editeng, since it's not really used anywhere else. And fix a bunch of places that were incorrectly calling the constructor with the enum. Change-Id: I74e8ab8bcf315eb5ad0720e74d04a450f0a3e5c9
2016-08-17convert SvxBreak to scoped enumNoel Grandin1-18/+18
Change-Id: If8b79ed617e5662550bd73bd1506d047217f2313
2016-08-17convert SvxCellJustifyMethod to scoped enumNoel Grandin3-8/+8
Change-Id: Ifdb9192f6556477a28af05a74042f216d4e9e8fd
2016-08-16editeng: introduce OutlinerViewShell::NotifyOtherViews()Miklos Vajna2-2/+8
This allows notifying other views about e.g. cursor position changes even if SfxLokHelper::notifyOtherViews() is not accessible from editeng. Change-Id: I921e97344ffe562109a221f241e70b3f68ee9aaf Reviewed-on: https://gerrit.libreoffice.org/28162 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-16loplugin:stringstaticStephan Bergmann1-5/+3
Change-Id: I89cbdf1b831818e7d72b5f9b6334df35a35d4f9f
2016-08-15convert SvxSpellArea to scoped enumNoel Grandin3-17/+17
Change-Id: I91d3caabb667e7d4ff23e603026e072074058712
2016-08-08loplugin:unnecessaryvirtualNoel Grandin1-17/+0
Change-Id: If25d9307efda5f57b0f80a0cf5c2c5cab6a752d6 Reviewed-on: https://gerrit.libreoffice.org/27981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05loplugin:countusersofdefaultparams in editeng..fpickerNoel Grandin4-12/+12
Change-Id: I6356c95296d81736fc6d66e510cd70606ee55f68 Reviewed-on: https://gerrit.libreoffice.org/27897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-05use std::move in a few placesNoel Grandin1-1/+1
found by git grep -n '.reset.*.release' Change-Id: I498709bd32b21d9dbbaa73603ce21d21c274f8dc Reviewed-on: https://gerrit.libreoffice.org/27863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-02editeng: track view shells in SfxListUndoActionsMiklos Vajna2-2/+16
This is needed for e.g. tracking deletions by backspace in Writer shape text. Change-Id: I6f873872566313096c2c57f4a13ac2f1db67e77d Reviewed-on: https://gerrit.libreoffice.org/27807 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02editeng: implement SfxUndoAction::GetViewShellId() interface in EditUndoMiklos Vajna3-1/+16
With this, e.g. inserting a character in a Writer shape text remembers its view shell. Change-Id: Ic82a3f45a66cf622496e3131390d365440dffb3b Reviewed-on: https://gerrit.libreoffice.org/27796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-02editeng: make SfxUndoAction::GetViewShellId() interface availableMiklos Vajna4-29/+21
Extend the existing OutlinerViewCallable interface to be able to obtain the view shell ID of a view shell, even from editeng. Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223 Reviewed-on: https://gerrit.libreoffice.org/27788 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-01svl: implement SfxUndoAction::GetViewShellId() interface in SfxListUndoActionMiklos Vajna1-2/+2
Client code in sw, sd, sc and svx is adapted, the rest is just a placeholder for now. With this, e.g. the undo item for Writer's insert comment properly tracks which window was used for the insertion. Change-Id: Idad587e6ca07ba69bf59aa7013b251af8bf95bab Reviewed-on: https://gerrit.libreoffice.org/27781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-27Resolves: tdf#101003 don't give paras in editeng accessible namesCaolán McNamara2-14/+2
change since... commit c23ab5eaed57cc3fb5860e26c591c73c5b22687b Author: Steve Yin <steve_y@apache.org> Date: Tue Nov 26 14:25:22 2013 +0000 Integrate branch of IAccessible2 keep the accessible description, but drop thea accessible name which is reportedly an undesirable change. Change-Id: I8f9c53ef967c4e566fde1829832aa035efce4f23
2016-07-27improve passstuffbyref return analysisNoel Grandin7-12/+12
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara3-3/+3
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25new loplugin overrideparamNoel Grandin1-2/+2
verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 13:24:13 +0000