summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin1-5/+0
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara2-2/+2
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-27make the AbstractDialog stuff extend from VclReferenceBaseNoel Grandin1-3/+3
Because some stuff wants to multiple-inherit from VclAbstractDialog and OutputDevice-subclasses, and we'd prefer to keep all the lifetime management through a single smart pointer class (VclPtr) The change in msgbox.cxx and window.cxx is to workaround a bug in VS2013 to do with virtual inheritance and delegating constructors. Change-Id: I178e8983b7d20a7d2790aa283be838dca5d14773 Reviewed-on: https://gerrit.libreoffice.org/29140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-26rework to avoid coverity#1371205 Missing move assignment operatorCaolán McNamara1-54/+62
Change-Id: I117fa0891e8cd1bf339bded93a7ee19d799caf9f
2016-10-26we don't need ree after the loop hereCaolán McNamara1-6/+4
Change-Id: Ib288ab3a7abf8f45c1175c36dcd4349dc4ad019f
2016-10-21loplugin:expandablemethodds in include/editengNoel Grandin5-40/+14
Change-Id: Iaf56cb9c16a4cbfb9ab1636228c77d1033a334f5 Reviewed-on: https://gerrit.libreoffice.org/30132 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20add dumpAsXmlEditDocNoel Grandin1-0/+5
to dump the current editing document to editdoc.xml on F12 Change-Id: I1b9cc2edb6429aa0bf651bdd52cac70dfd4db9d0
2016-10-19loplugin:expandablemethodds in editeng..extensionsNoel Grandin7-14/+6
Change-Id: Ibe1929d74ff460955e39f2ccce3056b2051ddf08 Reviewed-on: https://gerrit.libreoffice.org/30013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-18loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: Icf773925c37dde8b7404edac9864e7b10fe113b4 Reviewed-on: https://gerrit.libreoffice.org/29968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-17let LanguageTag::convertToLocale() decide when to create a temporaryEike Rathke1-1/+1
Change-Id: Iaefddb13192aff1aad912ac9f908c3d12236b94d
2016-10-17replace <<= with assign for <<= with rhs AnyJochen Nitschke2-7/+7
makeAny and Any ctor return an Any Change-Id: Iaa361bc315d785f80153acf1009bf47d109728ec Reviewed-on: https://gerrit.libreoffice.org/29914 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-14LOK: Calc: fixed missed tile invalidations on cell text editingMarco Cecchetti3-11/+26
What's new: 1) when an edit view is killed, the area which was used by the edit view is invalidated for both own window and other view windows after the edit view has been destroyed; 2) when an edit view is created or its out area is expanded, the windows of other views are invalidated too; 3) when a vertical scroll occurs in the edit view area the windows of other view are invalidated too; 4) same methods renaming since now we add/remove windows not edit views. Change-Id: Iac54f5b182c9562f08bb724f9ddde1c26cffa2e7 Reviewed-on: https://gerrit.libreoffice.org/29783 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-10-14LOK: Calc: missing invalidate when ending larger-than-cell edit textMarco Cecchetti4-12/+50
- reason: when text content goes further than the cell border the output area of the edit view is grown (extended to an adjacent cell), on the contrary the output area of edit views used only for invalidating windows of other view shells is never updated, so, in other views, only the tile where the edit cell is placed is invalidated; - solution: instead of adding fake edit views for invalidation porpuse (and having to updated the output area of each of them when required), the new solution provides each new edit view, created on cell editing, with a set of `foreign` windows related to other views, they are added and removed to this collection owned by an edit view still using the ScExtraEditViewManager, which has been in turn simplified; when EdiEngine::UpdateViews is invoked not only the window where the edit view lives is invalidated but also all `foreign` windows in the owned set; - note: ScTiledRenderingTest::testTextEditViewInvalidations unit test has been enhanced in order to test correct invalidation when text content goes out of the starting tile. Change-Id: Id223fb1a032d3b18d2cf70df31f704abd245b3ac Reviewed-on: https://gerrit.libreoffice.org/29625 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/29658
2016-10-13pass params to Outliner LINK callbacks on stackNoel Grandin3-42/+25
instead of yuck..cough... on itself, which is horribly vulnerable to re- entrancy Change-Id: I8f3d6d39ee50fd36b56b431978cf6c2499c375a6 Reviewed-on: https://gerrit.libreoffice.org/29756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-13loplugin:unnecessaryoverrideNoel Grandin1-6/+0
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae Reviewed-on: https://gerrit.libreoffice.org/29656 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-11loplugin:constantfunctionNoel Grandin2-11/+0
update the plugin similarly to commit 3ee3b36ae0c064fb5c81268d8d63444309d1b970 Author: Stephan Bergmann <sbergman@redhat.com> Date: Fri Oct 7 12:05:49 2016 +0200 loplugin:staticmethods: Don't be fooled by decls starting with macros Change-Id: I98ac3216d5acf89a49a26feb089ae2fd34e6e510 Reviewed-on: https://gerrit.libreoffice.org/29665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-10reduce indentationNoel Grandin2-103/+103
Change-Id: I9645e083ea61347fa323f84a271937e98d4f8eb3
2016-10-05fix debug buildDavid Tardon1-2/+2
Change-Id: Idbdb3f00faed2a0ae3f58393abf6e345e7d2363c
2016-10-05convert MapUnit to scoped enumNoel Grandin13-114/+119
I left a prefix on the names "Map" so that I would not have to re-arrange each name too much, since I can't start identifiers with digits like "100thMM" And remove RSC_EXTRAMAPUNIT, which doesn't seem to be doing anything anymore. Change-Id: I5187824aa87e30caf5357b51b5384b5ab919d224 Reviewed-on: https://gerrit.libreoffice.org/29096 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann5-30/+30
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-03add more dumpAsXml()Noel Grandin6-12/+61
and make it format the output nicely, so I don't have to use 'xmllint --format' before I can read it. Change-Id: I065ee93193f3c6c7bab87212ab96021fb0d7c5ed Reviewed-on: https://gerrit.libreoffice.org/29407 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-01Fix typosAndrea Gelmini2-2/+2
Change-Id: I8374d6d08f4eb4ae2821e213371c615b92d7e9ab Reviewed-on: https://gerrit.libreoffice.org/29432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-30tdf#101815 editeng SetMustRepaint when InsertTextJustin Luth1-0/+1
Change-Id: Ib66e7d53c231ac40f59593fd45a0706418a9398c Reviewed-on: https://gerrit.libreoffice.org/28717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org>
2016-09-28variable name and indentation improvementNoel Grandin1-21/+19
Change-Id: Ia3a97b08e1280e3665a56cdbb25ad07687dc7040
2016-09-28extend dumpAsXml to EditDocNoel Grandin5-1/+85
Change-Id: I71464b20c5897a2af3b4069f7f0963ef55dcd8c4
2016-09-25remove unused parameterJochen Nitschke1-1/+1
bTotalRanges is never used. SFX_ITEMSET_NO_DEFAULT_CTOR is no where else used. Change-Id: Ia35ea875f16a8ca04c2173b01074113f1825f565 Reviewed-on: https://gerrit.libreoffice.org/29248 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-24we shouldn't need explicit lt_rtl_OUString, etc things anymoreCaolán McNamara1-2/+2
Change-Id: Ibeec3fcc353e07e61fb2c838b318e0a04081ce2c
2016-09-23perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 relatedEike Rathke1-3/+3
There were over 150 places in *::Notify() functions that did some dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast operations come with quite some cost, so avoid if possible. Specifically for ScFormulaCell::Notify() that created a bottleneck in scenarios where cells were notified that already handled a previous notification. In mass operations doing the dynamic_cast before it could be decided whether having to act on it or not this made 2/3 of all time spent in the Notify() call. To get rid of that rename/move SfxSimpleHint to SfxHint and let classes derive from SfxHint instead of SfxSimpleHint. This comes only with a slight cost that an additional sal_uInt32 is transported in such hints, initialized to 0, but this is neglectable compared to the huge gain. For the rare cases where a Notify() actually expects both, an SfxHint (formerly SfxSimpleHint) and a derived hint, this changed order of the dynamic_cast involved so the simple SfxHint::GetId() is handled last. Modules using such combinations can further optimize by treating the simple SfxHint::GetId() first once verified that none of the other derived hints use an ID not equal to zero respectively none of the ID values the simple hint uses. Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce Reviewed-on: https://gerrit.libreoffice.org/29205 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23editeng: fix loplugin:cppunitassertequals warningsMiklos Vajna1-14/+14
Change-Id: Icccd2db45616de708d83058d76ace312db8af94e
2016-09-22convert C_ constants to typed_flagsNoel Grandin1-13/+18
Change-Id: Ia80cef26edce3e0a664044f3ca65d33998546d0f
2016-09-21Resolves: tdf#83037 <--> corrected into ← → instead of ↔Caolán McNamara1-7/+11
don't use - as a word separator except for breaking up a compound word for the purposes of tdf#55693, e.g. TEst-TEst autocorrected to Test-Test) Change-Id: Ie52a16af0b5838d1ba0de9c5f9c30dcab05c3bc7
2016-09-21convert SfxItemPresentation to scoped enumNoel Grandin3-26/+26
Change-Id: Ibf605706a9f804ab509ac4f92f5f88fcf3daebc1 Reviewed-on: https://gerrit.libreoffice.org/29131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-21loplugin:implicitboolconversionNoel Grandin1-1/+1
Change-Id: Id7dafb926a0eb7fae5e481555eae3d35fe795900
2016-09-21spelling Surregate->SurrogateNoel Grandin1-3/+3
Change-Id: Ic7d79036f4e94a487c9b12edb18d6e4098938585
2016-09-21add dumpAsXml() to more pool itemsNoel Grandin1-1/+30
Change-Id: I276109148bab8180ce2442f5ee69722357362453
2016-09-20Related cid#1371287: Improve code to not depend on missing move assignmentStephan Bergmann1-10/+6
Change-Id: I4c03ad08078e25ea7f7d754e6eaa587da7984c9d
2016-09-15Missing initialization of SvxBorderLine::m_pColorGapFnStephan Bergmann1-0/+1
...since 6dd4905a7ac93a48dc87358da3ba0a8078bbb6cf "loplugin:constantparam in dbaccess..editeng" Change-Id: Ib27615069ac1c7061ad691aada227ebdd70326e5
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl5-10/+11
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-14Revert 8c4dbcef8f and provide a better fixAndras Timar1-0/+5
This reverts commit 8c4dbcef8f92c9bd1c2208e7de7971f184f8a3ff. bccu#1781 bug was in LibreOffice Online. After deletion of the selected editeng text, the selection did not disappear. By making the fix conditional to LibreOfficeKit::isActive(), we can avoid the weird selection problem in desktop editeng. Change-Id: I78c68b5a79db816ea4d0bdf3d75dd1ba4c269106 Reviewed-on: https://gerrit.libreoffice.org/28900 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-13sw draw text: emit LOK_CALLBACK_TEXT_VIEW_SELECTION from registerCallback()Miklos Vajna2-4/+20
With this, in case the first view has an active text edit selection and a new view is created, then the text selection is instantly visible in the second view, even if the first view's text selection does not change later. Change-Id: I3255febd5d65d6576ddbc57cf96836bdf0b06a72
2016-09-13sw draw text: emit LOK_CALLBACK_INVALIDATE_VIEW_CURSOR from registerCallback()Miklos Vajna3-2/+26
With this, in case the first view has an active text edit and a new view is created, then the cursor position is instantly visible in the second view, even if the first view's cursor does not move later. Change-Id: Ia82e7dc1ce9bb58c67a280179ecadc74d3b63026
2016-09-13rename ContentInfo attribs field and methods to charAttribsNoel Grandin4-42/+41
to match naming higher up the call stack Change-Id: I8a89625de5d834b32fd6ea863ebc4152956a21fe
2016-09-13impress: extend dumpAsXml to style information in ContentInfo nodesNoel Grandin2-3/+26
Change-Id: I783f6ad9b71f18c070537e4806381a103960b6eb
2016-09-13fix out of bounds errorJochen Nitschke1-37/+25
there are 22 entries, but Sequence was allocated with 21 fields Change-Id: I6af71e2ece99b643843b4d82e0c6be332be361fa Reviewed-on: https://gerrit.libreoffice.org/28852 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann20-41/+41
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13loplugin:constantparam in dbaccess..editengNoel Grandin4-8/+6
Change-Id: I1d0dc3d89933d86cd229e503b350fccc1523dedc Reviewed-on: https://gerrit.libreoffice.org/28833 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-09use std::unique_ptrDavid Tardon1-1/+2
Change-Id: I8ba37267e8a7058ade54783ea0e117a8f8816c45
2016-09-09loplugin:constantparam in sot..svlNoel Grandin1-1/+1
Change-Id: I08db2db3b90725c556e3ba062da5d62d98f6e882 Reviewed-on: https://gerrit.libreoffice.org/28769 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-08rename CollapsAttribs -> CollapseAttribsNoel Grandin2-3/+3
Change-Id: Ic70f67fb7e0e557a3a726f44aef25931def49835
2016-09-08improve comment grammarNoel Grandin1-5/+4
Change-Id: Ic7da4b4d67bb006290af6c7b9e5d084d13b6ca98
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-26 17:05:55 +0000