summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert editeng module away from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: Iad5ad8ce11be2fbafd50f46e68947e10752bd609
2017-05-06ParaPortionList::SafeGetObject: remove SAL_WARN_IF, called on purposeEike Rathke1-4/+0
Gazillions of warnings leading nowhere.. all calling places now should handle this gracefully. Change-Id: I74b6dacb5a4a5adb9af73aa1adeee2c5b2a9323a
2017-05-05convert HTML_TOKEN_IDS to scoped enumNoel Grandin4-206/+208
Change-Id: I525506e0103e4f17e5b8b95f15c1285d65b93de9 Reviewed-on: https://gerrit.libreoffice.org/37220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04convert EVAnchorMode enum to scoped enumJochen Nitschke4-45/+45
change values to match position in definition to their meaning Change-Id: Ia96e0c7e0c70c847dea518ef871608516542d3cb Reviewed-on: https://gerrit.libreoffice.org/37186 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-5/+5
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03editeng: add pUndoManager assert in ImpEditEngine::~ImpEditEngine()Michael Stahl1-0/+4
This too can be an application UndoManager loaned only temporarily from getSdrUndoManagerForEnhancedTextEdit() and SdrObjEditView::SdrBeginTextEdit() - it must be reset again via SdrEndTextEdit(). Change-Id: I1f9d64d7af47ddc53d183bde6a6244ba5c261b0c
2017-05-02loplugin:checkunusedparams in editengNoel Grandin25-126/+115
Change-Id: I2b770d40ac2339cd2b04a765a6d970675d2ea1c1 Reviewed-on: https://gerrit.libreoffice.org/37133 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:salunicodeliteral: editengStephan Bergmann4-6/+6
Change-Id: I5db29ba3505d914ec05826128713d7e25091ed11
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock1-1/+1
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26WaE: -Wsometimes-uninitializedCaolán McNamara1-1/+1
Change-Id: Ia46d44e45a30761cc366273cda4fa62b83a79430
2017-04-26check all ParaPortionList::SafeGetObject() return values for nullptrEike Rathke4-119/+165
Change-Id: I46fdd613c9ad3762f045f984caff2a8dbef9bf16
2017-04-26ParaPortionList::SafeGetObject: SAL_WARN_IF nPos out of boundsEike Rathke1-0/+4
Change-Id: Id21e86a0db5be9f12c377d5bb48265dd2e12b9bb
2017-04-26check for nullptr, tdf#104265Eike Rathke1-10/+13
Crash not reproduced, but a nullptr is believed to be the cause as ParaPortionList::SafeGetObject() may return nullptr if a stray EditPaM was passed to ImpEditEngine::GetI18NScriptType() At least this matches http://cgit.freedesktop.org/libreoffice/core/tree/editeng/source/editeng/impedit2.cxx?h=libreoffice-5-2-4#n1756 given in http://crashreport.libreoffice.org/stats/crash_details/725e8295-6dc0-4b0c-aff3-57c6c95930f2 and http://crashreport.libreoffice.org/stats/crash_details/e2570ac8-6137-4b67-91b2-6cc871f8cb69 Change-Id: Id01983a31145442016da527a57024dc060060b1a
2017-04-26use strong_int for LanguageTypeNoel Grandin9-66/+58
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448 Reviewed-on: https://gerrit.libreoffice.org/36629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock1-1/+1
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock19-0/+19
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-23Fix mouse position conversion in case of BottomToTop textTamás Zolnai1-2/+10
Change-Id: Ib058e44a1480013ce924585d8950534d0f3fc5a4 Reviewed-on: https://gerrit.libreoffice.org/36834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-23Handle keyinput properly in case of BottomToTop vertical textTamás Zolnai1-1/+3
Change-Id: I2b0f7cee9a4a7d7ad154c705f84a8b995b4f23a1 Reviewed-on: https://gerrit.libreoffice.org/36830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky4-4/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin1-22/+15
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20SvxSpellWrapper::ReplaceAll doesn't use it's second paramNoel Grandin3-6/+4
Change-Id: I79b82d37e6cf4c1dde474f0f90b6370c2359a0b3 Reviewed-on: https://gerrit.libreoffice.org/36673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin3-13/+4
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18cppcheck: useInitializationListMuhammet Kara1-8/+8
Change-Id: Iee4db89fe3bd256da0b7ff0f40a3c4789666c525 Reviewed-on: https://gerrit.libreoffice.org/36633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-04-15Fix vertical text and bitmap bullet renderingTamás Zolnai2-6/+28
Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e
2017-04-15Introduce text rotation for Impress tablesTamás Zolnai11-72/+270
* Introduce new table property for text rotation * Support only two rotation angle (270° and 90°) * Implement editing and rendering of 270° rotated text (90° rotation was already implemented) Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e
2017-04-10loplugin:inlinefields in SvxAutoCorrectNoel Grandin1-51/+44
Change-Id: I09aa52551dd1ed96bc9a72baec6afe5a4a05c1dd Reviewed-on: https://gerrit.libreoffice.org/36346 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-07loplugin:redundantcast find cstyle arithmetic castsNoel Grandin2-3/+3
Change-Id: If7c259f0d12a41182f476ddb558f7cb5f76f9577 Reviewed-on: https://gerrit.libreoffice.org/36253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06Improved loplugin:redundantcast, static_cast on arithmetic types: editengStephan Bergmann1-8/+8
Change-Id: I64be28eb18822c29e3d540decb465c9204d16894
2017-04-06loplugin:redundantcast check for c-style float castsNoel Grandin1-1/+1
Change-Id: I86b6f58887cb398a80698f8d8564b5bc3f55eabb Reviewed-on: https://gerrit.libreoffice.org/36198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06loplugin:singlevalfieldsNoel Grandin2-5/+5
Change-Id: Ia681765aa1da5c80a3dbe91b7376af841a9c9ec1 Reviewed-on: https://gerrit.libreoffice.org/36145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06unnecessary pre-all-oustring copyCaolán McNamara1-8/+7
Change-Id: Ife45898482b74b1b911001d99d04bb8daeacfb41
2017-04-06Fix typosAndrea Gelmini1-1/+1
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4 Reviewed-on: https://gerrit.libreoffice.org/36100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-04-05loplugin:redundantcast find c-style bool castsNoel Grandin2-8/+8
Change-Id: I3237b93babc67de12c3771aa84766c2141ca93b2 Reviewed-on: https://gerrit.libreoffice.org/36137 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-05loplugin:constantparam part2Noel Grandin1-3/+2
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746 Reviewed-on: https://gerrit.libreoffice.org/36072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-03tdf#39468 Translate German commentsJens Carl2-3/+3
Translate German comments and terms in UnoControls/, editeng/, filter/, odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/, tools/, writerfilter/, and xmloff/. Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1 Reviewed-on: https://gerrit.libreoffice.org/35992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03Remove DBG_ASSERT since it's always wrongJulien Nabet1-1/+0
Indeed EditHTMLParser constructor calls HTMLParser constructor, the last one calls "SetSrcEncoding(RTL_TEXTENCODING_UTF8);" Change-Id: If749674c3d4f2b9f9fccbf0b99f1e7d62fd0450d Reviewed-on: https://gerrit.libreoffice.org/36011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-02Add SvxTextRotateItem inherited from SvxCharRotatItemTamás Zolnai2-12/+115
I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-04-02coverity#1403662 Mixing enum typesCaolán McNamara2-9/+9
Change-Id: Ic5e797c65dfc736a9ef0ab14f3ae563216143947 Reviewed-on: https://gerrit.libreoffice.org/36020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-31use actual UNO enums in editengNoel Grandin6-9/+11
Change-Id: I58e794f161f3c4dd103985f575bc25202d4989b3 Reviewed-on: https://gerrit.libreoffice.org/35907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-31tdf#82580 tools: rename Rectangle to tools::RectangleMiklos Vajna25-197/+197
Mostly generated using make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle" Except some modules have their own foo::tools namespace, so there have to use ::tools::Rectangle. This commit just moves the class from the global namespace, it does not update pre/postwin.h yet. Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2 Reviewed-on: https://gerrit.libreoffice.org/35923 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-03-30editeng: tweak commentMichael Stahl1-1/+1
Change-Id: I587fafea157a02d2c903dda4b85448b1fe349c3e
2017-03-30tdf#39468 Translate German commentsJens Carl7-13/+9
Translate German comments and terms in editeng/ Change-Id: I9bd15ca0914b34839d83751f530dd212d91e029e Reviewed-on: https://gerrit.libreoffice.org/35884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-30convert SvxDateType to scoped enumNoel Grandin3-8/+8
Change-Id: I5ce04f252642cb3a6c1b08ee22255f6c7b97f0f8 Reviewed-on: https://gerrit.libreoffice.org/35842 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Resolves: tdf#106079 automatic color described as 'white'Caolán McNamara2-0/+8
move RID_SVXSTR_AUTOMATIC from svx to editeng for this Change-Id: Icc3fbb15e627ed54770d11bce7aadf30a0d12aa7
2017-03-29split ImportState enum into RtfImportState and HtmlImportStateNoel Grandin4-55/+90
and convert to scoped enum Change-Id: I23e44e78ce96ed5fc19374e3e069e1cdc2166a35 Reviewed-on: https://gerrit.libreoffice.org/35840 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Fix integer type of EditCharAttrib nStart/nEnd membersStephan Bergmann4-75/+77
Looks reasonable to replace assignment to nEndField from USHRT_MAX with -1 in ImpEditEngine::AddPortionIterated (editeng/source/editeng/impedit4.cxx). This apparently needs to just be an arbitrary value that EditPaM::GetIndex() will never have. Looks like 3cbfcee36dd16e451d76c561eaaaee0ff29b01a5 "xub_StrLen and tools/string.hxx final straw" missed that (as that commit's message acknowledges). Change-Id: I5840d52d12a71937a5ed2779bfd5de071f702300
2017-03-29loplugin:unusedmethodsNoel Grandin2-35/+0
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0 Reviewed-on: https://gerrit.libreoffice.org/35834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-27Make loplugin:loopvartoosmall look past top-level ExprWithCleanupsStephan Bergmann3-20/+30
Note the two "//TODO!" in the fix of the one newly found issue. Change-Id: I181691da4b74cd55611452e002b37bd6798ff1e6
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-23 04:25:20 +0000