summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2015-08-17Put Polygon from tools under tools:: namespaceNorbert Thiebaud3-5/+5
Polygon is one of these names that Clash with some system objects A similar work has been done earlier with PolyPolygon. Change-Id: Icf2217cb2906292b7275760f1a16be0e150312f5 Reviewed-on: https://gerrit.libreoffice.org/17789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-15tdf#93052 Fix abundance of calc annotation stylesJan-Marek Glogowski1-2/+1
This is a regression introduced by fixing tdf#47018, which changed the default NumRule and pushed a lot of SVX_MAX_NUM to the SvxNumRule constructors. The changed NumRule default seems not needed to fix the crash; at least it still doesn't crash as described in the old bug report after reverting this part of the change. Change-Id: I908eeb4a827799419d3f28584fdcbc9272cbc76d Reviewed-on: https://gerrit.libreoffice.org/17527 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-14remove default value from SfxPoolItem::PutValueNoel Grandin2-3/+3
more useful to make it explicit. Specifically, otherwise my defaultvalue clang plugin would want to remove lots of places that contains #define constants which, while technically the same as the default value, convey semantic information which is quite useful. Change-Id: I918ad5b0e73ba279fa1b1489b62d900339ff71eb
2015-08-12tdf#93384 editeng rendercontext: don't paint spellcheck result directlyMiklos Vajna1-2/+1
E.g. in Writer create a new comment, type a word that is not in the dictionary, then a space to trigger the spelling, and that painted the spelling error indicator outside Paint(). Change-Id: I8f72486189e04a5596729fb52b6af39772f8e002 Reviewed-on: https://gerrit.libreoffice.org/17671 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2015-08-11loplugin: defaultparamsNoel Grandin17-90/+90
Change-Id: I2a1255c00a051b29381ec57c380eafb08c4900d9
2015-08-05loplugin:unusedmethodsNoel Grandin2-9/+0
Change-Id: I6801618efb5a66d24156fa429e026acb6ca03aba Reviewed-on: https://gerrit.libreoffice.org/17506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03new loplugin: refcountingNoel Grandin4-58/+58
This was a feature requested by mmeeks, as a result of tdf#92611. It validates that things that extend XInterface are not directly heap/stack-allocated, but have their lifecycle managed via css::uno::Reference or rtl::Reference. Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692 Reviewed-on: https://gerrit.libreoffice.org/16924 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe4-11/+11
with the variadic variants for editeng. Change-Id: I28373dd31b8b922f59b99bf1c12faa31c72b9906 Reviewed-on: https://gerrit.libreoffice.org/17416 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30loplugin:unusedmethodsNoel Grandin1-5/+0
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971 Reviewed-on: https://gerrit.libreoffice.org/17378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-28convert RGCHK constants to scoped enumNoel Grandin3-8/+9
Change-Id: Iafeae0f85f751469900471cf8fccd5f763407890
2015-07-28remove some unused EDITUNDO_ constantsNoel Grandin1-3/+0
Change-Id: Ia2c2f5f42a9d8e2d6041aac415d253f096d47f43
2015-07-28convert EE_ACTION constants to scoped enumNoel Grandin1-4/+2
Change-Id: Iaa51c235a2118e0d808400eba622fbe021571b38
2015-07-24loplugin:unusedmethodsNoel Grandin4-22/+2
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-24convert WALLPAPER constants to scoped enumNoel Grandin1-25/+25
Change-Id: I3b4b4e8a94904e22823a263bd5446a2e1aa47661
2015-07-21loplugin:unusedmethods sdNoel Grandin1-13/+0
Change-Id: I9b5399ace50db3259df2e619f28ae547a38e6c6d Reviewed-on: https://gerrit.libreoffice.org/17254 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-20Removed commentAndrea Gelmini1-1/+0
No evindence of intn.hxx in all git history Change-Id: I435f3082e0bb13b1e3129b49c7eaea80d75ea452 Reviewed-on: https://gerrit.libreoffice.org/17186 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-07-20editeng: replace boost::ptr_vector with std::vector<std::unique_ptr>>Michael Stahl2-54/+58
Change-Id: I29923bc78100d4b196d285dd78f664f7bcf3df19
2015-07-20editeng: replace boost::ptr_map with std::map<std::unique_ptr>>Michael Stahl1-18/+15
Change-Id: Ia6fce8eceb364d83cbbf5abcf734be262614e792
2015-07-20editeng: replace boost::ptr_map with std::map<std::unique_ptr>>Michael Stahl2-17/+17
Change-Id: Id59fb4ee59872e60094bde85746416c83f058b00
2015-07-20loplugin:unusedmethods svlNoel Grandin1-7/+0
Change-Id: If86cc43fda4d138cf7f678d81fa2b35f68f3c03b Reviewed-on: https://gerrit.libreoffice.org/17162 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-19sal_uInt16 to sal_Int32/size_tMatteo Casalin2-6/+6
Change-Id: Icb8765339412bedf1e424a766bc99274ab96ceab
2015-07-17editeng: pointless codeMichael Stahl1-6/+0
Change-Id: Ice4f34ce60b0f4af97a985f4203a705523c0626b
2015-07-17editeng: replace boost::ptr_map with std::map<std::unique_ptr>Michael Stahl1-66/+66
Change-Id: I343071cc29c2041bc98456954b0aa32fff324d82
2015-07-16loplugin:unusedmethods editengNoel Grandin15-204/+27
Change-Id: I15b2be5a9cd6e72447b674a65eabe9f89cb6ff12 Reviewed-on: https://gerrit.libreoffice.org/17115 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug buildsStephan Bergmann2-4/+3
...to avoid lots of loplugin:staticmethods warnings. Also enables DBG_ASSERT etc. also for --enable-debug builds in addition to --enable-dbgutil builds. Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
2015-07-13Fix IndentingPagesHdl type (and GetIndentingPagesHdl is unused)Stephan Bergmann1-2/+2
Change-Id: Ide5398040678a81e032e91e582b39d516e8c08a8
2015-07-13editeng: make Link<> usage typedNoel Grandin1-10/+3
Change-Id: Iec36c7e4f4fbc2ee2ee25d4d0c8488340ba7d8c4 Reviewed-on: https://gerrit.libreoffice.org/16968 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-13editeng, convert to typed Link<>Noel Grandin2-11/+0
and remove SvxBrushItem::SetDoneLink since the field it sets is unused.wq Change-Id: Ide95a295fa8004f1ddab5e560f01d36d36658a72 Reviewed-on: https://gerrit.libreoffice.org/16943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-08Fix typosAndrea Gelmini2-2/+2
Change-Id: I70b03c152f63e48341dc5629a99b0eeab7b497c0 Reviewed-on: https://gerrit.libreoffice.org/16834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-07-06improve the returnbyref lopluginNoel Grandin8-346/+326
Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-03Fix typosAndrea Gelmini8-8/+8
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-30Fix typosAndrea Gelmini2-2/+2
Change-Id: I1c5e4970d4e90bdea68a901294594104de5e189e Reviewed-on: https://gerrit.libreoffice.org/16582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-06-30remove some unnecessary typedefs to pointerNoel Grandin2-5/+3
that were really not helping make the code any clearer. Found with a search git grep -P 'typedef\s+\w+\s*\*\s*\w+\;' and manual inspection Change-Id: I6a5c031e9e060ad3623a7586ec8a8cc4fe6252e9
2015-06-29remove custom RTTI from SvxAutoCorrectNoel Grandin1-2/+0
unused Change-Id: I2f4504fdbe88fa83abe6da8a1f733f9ae1c2742d
2015-06-28coverity#1308551 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I61fb5e047b64873b3f5e07582dd1155340d7a1b5
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9 Reviewed-on: https://gerrit.libreoffice.org/16523 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff Reviewed-on: https://gerrit.libreoffice.org/16522 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-28coverity#1308483 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: I7d778173ecff7c343b289eb371b53b825f6cc301
2015-06-26loplugin:stringconstant: handle OUString+=OUString(literal)Stephan Bergmann2-2/+2
Change-Id: I19f7a0a3cc6641a21ed6004adecdac7956e5132f
2015-06-25loplugin:stringconstant: Flag more inefficienciesStephan Bergmann1-1/+1
Change-Id: Ie217f99961c6f2c224d1c01beaf0146a4ea3e0c2
2015-06-24Simplify uses of comphelper::string::equals with constant argumentStephan Bergmann1-5/+2
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-22Fix typosAndrea Gelmini2-4/+4
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b Reviewed-on: https://gerrit.libreoffice.org/16408 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-21Fix typosAndrea Gelmini1-1/+1
Change-Id: I2297bf392a405f02be2450f4624f1c9fc0b512ce Reviewed-on: https://gerrit.libreoffice.org/16373 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-19Simplify uses of OUString::replaceAll with literal argumentsStephan Bergmann1-1/+1
Change-Id: I769cc6e11909c7f4c6394fdc4dec8a12b9a67af8
2015-06-19All uses of LINE_SEP are fine with a char literalStephan Bergmann1-1/+1
Change-Id: I057c2d346be6a6775f01a3a32edd4fc8224271a5
2015-06-18drop unused sequenceasvector.hxx (see sequence.hxx)Caolán McNamara1-1/+0
Change-Id: Ib6d91f1ee427d5f94eed75e478f0809346f38e05
2015-06-18Fix typosAndrea Gelmini1-1/+1
Change-Id: Ibfa971952cd330ddf430e7e951c5c235d2ae6bd8 Reviewed-on: https://gerrit.libreoffice.org/16314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-06-18seems to be what was meantLionel Elie Mamane1-1/+1
Change-Id: Ia7b784d820249c3d75915761dac34a2aaa190c0b Reviewed-on: https://gerrit.libreoffice.org/16358 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-17Replace boost::scoped_array<T> with std::unique_ptr<T[]>Takeshi Abe6-12/+12
This may reduce some degree of dependency on boost. Done by running a script like: git grep -l '#include *.boost/scoped_array.hpp.' \ | xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@' git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \ | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/' ... and then killing duplicate or unnecessary includes, while changing manually m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx, extensions/source/ole/unoconversionutilities.hxx, and extensions/source/ole/oleobjw.cxx. Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd Reviewed-on: https://gerrit.libreoffice.org/16289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Fix typosAndrea Gelmini1-1/+1
Change-Id: Id8c7cf460cba5af89891c470e1aaa61b227d356e Reviewed-on: https://gerrit.libreoffice.org/16310 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>