summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2018-02-26sd lok: Delete selection highlight after cutting text.Tamás Zolnai1-0/+3
Call drawing also after the new selection is set, similar to other cases where DrawSelectionXOR() is called before and after selection change. In desktop LO drawing is always called again and again by timeout, so there the selection is updated anyway, while in LO online painting does not emit a notification. Reviewed-on: https://gerrit.libreoffice.org/50268 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 56629f9797fa1cf8b7c86b93ee2ea62673444c94) Remove accidently committed debug lines (cherry picked from commit c64f2d34c0e62ec288b2e1453bf91f9f650db845) Change-Id: Id083a3bb38ba89e00239e71387377691afd4f31c Reviewed-on: https://gerrit.libreoffice.org/50335 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-21tdf#115639: Handle alignment correctly for multiple paragraph caseTamás Zolnai5-7/+40
I used the wrong calculator method to get the line width. This commit also fixes the crashes found by crashtest. Reviewed-on: https://gerrit.libreoffice.org/49994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f0485ba2d90aae0312f5775588f22789016165d2) Change-Id: I25392f86af912ee54c07b14480d82282210ac346 Reviewed-on: https://gerrit.libreoffice.org/50018 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-19tdf#115639: Align right/center with trailing spaces the same as MS PowerPointTamás Zolnai6-12/+160
* Add HoriAlignIgnoreTrailingWhitespace compatibility option. ** For MSO file formats it is set to true ** For ODP format it's set to false by default ** The flag is saved to ODP format as user data if the document comes from an MSO format. Reviewed-on: https://gerrit.libreoffice.org/49889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1da3a3cb74a415a76fa547ef0c8f61780e260e7f) Change-Id: Ie22233d33a25e605de46120bfc2195038dffd63c Reviewed-on: https://gerrit.libreoffice.org/49909 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-01-17tdf#114628 correct line spacing for impressSzymon Kłos2-17/+28
* use line spacing also for the first line * correct spacing in case of > 100% proportional spacing * impedit2.cxx only code readability change Change-Id: I24832e7dc2fa8cfbb2f9cdfe7062eaaaa63f1729 Reviewed-on: https://gerrit.libreoffice.org/46925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/47571 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-12-18replace CHAR flags with o3tl::typed_flagsNoel Grandin5-21/+28
the usage of which looks a little dodgy, because this is a bitmask, but it's using == everywhere to check them Change-Id: I8e57d4f943a9048cc457a376ffbdfde0cffe22dd (cherry picked from commit 76ab8c76daa57d21288c3a90f017ea5ae51db564) (cherry picked from commit f54b392274cfe2f4b9fbfd5c9677c40ab1dc1322)
2017-12-18convert DELMODE to scoped enumNoel Grandin4-20/+21
Change-Id: Idd3f45adb43930358420dba464dbdb88fe27b91d (cherry picked from commit 84e3e6ee04c2be0f8fa3a43c8c55bad6b6504f65) (cherry picked from commit 6841451d6d80fdd3bfe9f8cb430bca6b671c6cbf)
2017-12-18convert GETCRSR constants to o3tl::typed_flagsNoel Grandin5-43/+53
Change-Id: Ia367d9a1b73d6c5b7a7989da45af0f002c43413c (cherry picked from commit 1a4cb47b27c059d92b4e94b249ca3974b72b35da) (cherry picked from commit a8f5b38aae184341d8ce217188cd85d282feea29)
2017-12-18convert ATTRSPECIAL to scoped enumNoel Grandin7-16/+13
Change-Id: I8abf09dc5f17343945b909887c580e9016a79ac5 (cherry picked from commit aebf05f324661a07f4124a4c48b6fc889d4bfbf6) (cherry picked from commit 50d0a2a6bad92124af5f2b8ea057767b4421c71b)
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin4-10/+10
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-05remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2e8acde112e1c6754df26902e79a78346ba45a2d) Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/45452 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2887aefa4d4f60ba8b0cd7efd5d3a73ffb209781)
2017-12-05tdf#97087 GDB pretty print the Scheduler task listJan-Marek Glogowski1-0/+3
In addition to the GDB pretty printer, this annotates a lot more Timers and Idles. Change-Id: I5b93fab02161b23bb753e65ef92643a04fb0789c (cherry picked from commit 9e51007039770370182839846676b205f5c34c57) (cherry picked from commit a090e1e17962c5ca95f66c9d18fca6ac5dd4bca0)
2017-12-05loplugin:useuniqueptr extend to check local varsNoel Grandin1-3/+2
just the simple and obvious case for now, of a local var being allocated and deleted inside a single local block, and the delete happening at the end of the block Reviewed-on: https://gerrit.libreoffice.org/33749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2489000d3fd66319a8355fd4e37cfdfda47296d0) Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625 (cherry picked from commit e540ccfb5eb43bd4a3d6920074dce8436720ba8e)
2017-10-26sd lok: fix spell checking languages in ImpressHenry Castro1-0/+10
Change-Id: I133c9b91521fa7f2b5f7e3a47396f7efa31e1a86 Reviewed-on: https://gerrit.libreoffice.org/43382 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/43388 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-21lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.cp-5.3-26Jan Holesovsky1-1/+5
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-08-03lok - add support for in place chart editingMarco Cecchetti1-2/+24
This commit add a minimal support for editing chart embedded in a spreadsheet or a text document or a presentation. Graphic object can be moved and resized, text object can be edited. Change-Id: I8e637dabf328a94bd6bb0e309a245302cff421d8 Reviewed-on: https://gerrit.libreoffice.org/40681 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-03tdf#108622: use correct type for last check timestamp during autocorrectAron Budea1-1/+1
It's only supposed to check the files once every 2-mins, with mismatching type that happens each time. Reviewed-on: https://gerrit.libreoffice.org/39428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 51f616ddd7a2e3310e1b30dbd73d90e5138980ea) Change-Id: Ie9243cf928d952e28989dd981508de86cb7dbddb
2017-05-30tdf#107176: just return initial selection when there's no rangeJulien Nabet1-0/+4
See https://bugs.documentfoundation.org/show_bug.cgi?id=107176#c2 Change-Id: I606b7f248821bb24b3a9026ecd26a9bc93971748 Reviewed-on: https://gerrit.libreoffice.org/36582 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 6bde2e93a2e0f94bc2263928cb27c4b85827822d) Reviewed-on: https://gerrit.libreoffice.org/37788 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 83e87f7579ecf63e810c7556661e4f95a8309aff)
2017-05-30fix gdi resource leak (editeng/impedit)Julien Nabet2-0/+5
Change-Id: Ia2d9ad88b5bcc2adf7f28ac7833132c04045d55b Reviewed-on: https://gerrit.libreoffice.org/37802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4b6bc4e012bde5737f279377c8186faf38a888ad)
2017-05-04check for nullptr, tdf#104265Eike Rathke1-10/+13
Crash not reproduced, but a nullptr is believed to be the cause as ParaPortionList::SafeGetObject() may return nullptr if a stray EditPaM was passed to ImpEditEngine::GetI18NScriptType() At least this matches http://cgit.freedesktop.org/libreoffice/core/tree/editeng/source/editeng/impedit2.cxx?h=libreoffice-5-2-4#n1756 given in http://crashreport.libreoffice.org/stats/crash_details/725e8295-6dc0-4b0c-aff3-57c6c95930f2 and http://crashreport.libreoffice.org/stats/crash_details/e2570ac8-6137-4b67-91b2-6cc871f8cb69 Change-Id: Id01983a31145442016da527a57024dc060060b1a (cherry picked from commit 17236fe21f9b0c734c0e8d5c371b8112dcab8ac0) Reviewed-on: https://gerrit.libreoffice.org/36989 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9982510049417ce4e3969a492cfdecd3e5ed0760)
2017-04-24Fix mouse position conversion in case of BottomToTop textTamás Zolnai1-2/+10
Change-Id: Ib058e44a1480013ce924585d8950534d0f3fc5a4 Reviewed-on: https://gerrit.libreoffice.org/36834 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit c0d09cc0e7ee12ac6dcc144e06855ba4621e4144) Reviewed-on: https://gerrit.libreoffice.org/36888 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-04-24Handle keyinput properly in case of BottomToTop vertical textTamás Zolnai1-1/+3
Change-Id: I2b0f7cee9a4a7d7ad154c705f84a8b995b4f23a1 Reviewed-on: https://gerrit.libreoffice.org/36830 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 8c46185bf28f61e674186694e4944c1f8b3a9c00) Reviewed-on: https://gerrit.libreoffice.org/36887 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-04-18tdf#105286: Implement text rotation for Impress tablesTamás Zolnai14-90/+413
Typo: TopToBotton -> TopToBottom Change-Id: I1b4d3ab9ec1d1383d76a56c9662ffeeb9fe69655 Reviewed-on: https://gerrit.libreoffice.org/36014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 334e6e2f1ad3da319be0849ec426aa64b18cb599) Add SvxTextRotateItem inherited from SvxCharRotatItem I will be use it later for text rotation inside a table. Change-Id: I4cbaf05953b0e71331d2f3fdb45b7c4254a2b8cc Reviewed-on: https://gerrit.libreoffice.org/36021 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1e30d2aface12a31687e5a27126e2061efd4b0cd) Introduce text rotation for Impress tables * Introduce new table property for text rotation * Support only two rotation angle (270° and 90°) * Implement editing and rendering of 270° rotated text (90° rotation was already implemented) (cherry picked from commit c671094154ecec6f3ba5beea9d26ff0d2d4d86ad) Change-Id: Ifc2e0f171e9c840e86b365e9af2c30aa97ecd92e Implement RotateAngle API property for Impress table cells (cherry picked from commit a0755ab8772d01797f4945016a978a2bbd8fdf20) Change-Id: I01379c0fc21e8fe294bc882bf824f64502863ff4 tdf#100926: PPTX import of table with rotated text (cherry picked from commit 2436cf17304f25c7d34da52a321d6da0e9011d19) Change-Id: I05a8e979ac11b179e15784023032a56edc5b569b ODF import / export of rotated text in Impress table (cherry picked from commit bcb371b1a830442610ad7fda476eda5271427a50) Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8 Fix vertical text and bitmap bullet rendering Change-Id: I881fce0511c81b164516d68f72c7e750687d4e0e (cherry picked from commit 15ac3f9f4dc65fc0c6020284064e3725956f5d0a)
2017-03-10ofz: leak in loading pptsCaolán McNamara1-7/+5
regression from commit 5e10e6937a8d5117555a4dcc9520aca173d75c95 Date: Sat Jan 18 10:15:10 2014 +0100 EDITENG : Remove usage of DBG_CTOR and DBG_DTOR. Change-Id: Id109f5bb23b1e4a93195548f880973ebc778515f (cherry picked from commit 0cbc0181d52433790bb607176ff01dcffc89ce99) Reviewed-on: https://gerrit.libreoffice.org/34952 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 098a25fc9b03fd4c65470d947b1e62ba922d2b23)
2017-03-01Resolves: tdf#106123 store and restore the PaM around the menu ExecuteCaolán McNamara1-0/+11
because the loss of focus in the current editeng causes writer annotations to save their contents, making the pContent of the current EditMaps invalid (cherry picked from commit 71a84b69ae30458a941f38869aa994118051a063) Change-Id: Ic01379291fa66dd58246d33287b18801f5da49c0 Reviewed-on: https://gerrit.libreoffice.org/34613 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 48ad98b36403a04d05f6ed08e541ffbd65995af9)
2017-02-24LOK - Calc: Text is not visible in cell when entering numerical inputMarco Cecchetti2-13/+13
Problem The issue occurs when you double click and enter a numerical input in a cell which belongs to one of the front colums. Findings After a bit of investigation I detected that the problem shows up when the spreedsheet width is increased by invoking ScViewData::SetMaxTiledCol. Indeed the problem occurs whenever the spreadsheet width is larger than 2^16 twips. Solution By changing the type of some variables from sal_uInt16 to long in all involved contexts, the problem disappeared. Change-Id: Ia6c6c258b0644f03c897e7b4bcaded967f21537c Reviewed-on: https://gerrit.libreoffice.org/34597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 288d694ff695ef83cbe4224db87dd65281c75a8f) Reviewed-on: https://gerrit.libreoffice.org/34605 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2017-02-20revert tdf#101815 editeng SetMustRepaint when InsertTextJustin Luth1-1/+0
It wasn't targetted enough at the specific problem, and caused paint problems. This fixes tdf#106056. Change-Id: I2d87bc78627a558c62cb0efc24e49c7656662976 Reviewed-on: https://gerrit.libreoffice.org/34403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a189b27ebeac8f179b9cce959e66862a16c4dd52) Reviewed-on: https://gerrit.libreoffice.org/34405 (cherry picked from commit 9431ab38da9e8e1c438a88a97b9fc4172a3f7213)
2017-02-14editeng: presumed copypasta in 048e30c1f8231e6cd144a9251061f6fa127b353eMichael Stahl1-1/+1
Doesn't make sense to check for RTF twice in a row. Change-Id: I15a384adb4d9e65770d81c414b6f24cc0a2b75e8 (cherry picked from commit 6ed7a9759fdf6affdb6ec81a9aae7a3398de8d9b) Reviewed-on: https://gerrit.libreoffice.org/34244 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-02-01tdf#103927: Share single standard VirtualDevice instance.Kohei Yoshida4-25/+25
To avoid creating excessive amounts of VirtualDevice instances. Also, since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag. This fixes tdf#102688 as well as other GDI-Limit related issues. See tdf#105469 for other bugs this may fix. (cherry picked from commit b41186a2fc49e440890b8c86e5367352ffaf9cd6) (cherry picked from commit fab2f546d1fb3ceaf5ee5d4d728f1728a8f1e7f3) (cherry picked from commit bac2baa785ffc75160de2d15da60901152da33de) Change-Id: Ieda242786c6376c7ac249a9f6d469b670f1ac177 Reviewed-on: https://gerrit.libreoffice.org/33640 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-26tdf#101828 handle rtf/richtext correctlyOliver Specht2-4/+15
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 048e30c1f8231e6cd144a9251061f6fa127b353e) Reviewed-on: https://gerrit.libreoffice.org/33567 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-19tdf#96354 correct broken autocorrect INitial CApitalsYossi Zahn1-3/+3
Change-Id: If65ec7814c3aed5e4c17294ae57c34550373469d Reviewed-on: https://gerrit.libreoffice.org/31317 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org> (cherry picked from commit c6db0e064959ec154db9471a8e1f1e2716bb3523) Reviewed-on: https://gerrit.libreoffice.org/33265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-19tdf#104488 editeng,svx: throw less Accessible exceptionsMichael Stahl1-15/+0
For some of these functions it doesn't make sense to throw DisposedException as they can return a sensible default value. Particularly AccessibleShape::getAccessibleChildCount() was throwing an exception that was never caught. (cherry picked from commit 5a3b2111172f106378cbf78aba0fde1db3642275) loplugin:unnecessaryoverride (cherry picked from commit 10bf49c18d56f198e63514953a1c6e2ea17fcc9c) Change-Id: I000149cf9bb0fd13f69650ad8224a8daf26f7bee Reviewed-on: https://gerrit.libreoffice.org/32187 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-11-30Resolves: tdf#104152 suppress notifications from EditEngine during PasteEike Rathke1-0/+5
Broadcast once at the end instead to notify a11y. Change-Id: I12383b6efbbb2b149f0d73c67d8576fcc050b253 (cherry picked from commit 7c20d0174c59d46b11fc5029fe3fc0c00f5dc6d0) Reviewed-on: https://gerrit.libreoffice.org/31424 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30prevent endlessly creating new lines until out of memory, tdf#104152Eike Rathke1-17/+61
Though this just prevents mishappens during reformatting a broken portion that is in a half-ready state because a11y was notified and attempts to obtain a paragraph. Solving the real cause means not being called in such state.. However, not going out of memory and also having matching X-values for the node's text positions that don't make the EditEngine crash later is better than nothing. Change-Id: Ifa8d2c5d1766b0f145b8e89ad26a78528db42056 (cherry picked from commit fff0cf20e4020af9e2c134549a5164417fde30b7) Reviewed-on: https://gerrit.libreoffice.org/31423 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-22trivial makefile cleanupsMichael Stahl1-1/+1
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21convert inventorId to scoped enumNoel Grandin1-1/+1
SW_DRAWLAYER had the same value as SC_DRAWLAYER, so I merged it into the ScOrSwDraw enum constant Change-Id: I5c45d378c00364d11cc960c9e48a6e3f10928724 Reviewed-on: https://gerrit.libreoffice.org/31037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-21make this just every so slightly less awfulCaolán McNamara3-12/+13
Change-Id: Iddc39359d426f345eff0abf9fc9616e19597a0a4
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl6-31/+31
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-16make the element names in dumpAsXml match the class namesNoel Grandin9-24/+24
Change-Id: I955facfe3e901fcb76798dab342f96a67d5ac63f Reviewed-on: https://gerrit.libreoffice.org/30894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-13drop useless semicolonsDavid Tardon1-1/+1
Change-Id: I039f8ff491b42ea9c3936bf13922df8095434228
2016-11-11coverity#1371263 Missing move assignment operatorCaolán McNamara1-0/+26
Change-Id: Ifb4117afac4aa86893e674a581e1a7bb80925ee3
2016-11-11check for self-assignmentCaolán McNamara1-8/+11
Change-Id: I74eb934d19c0b511870e5a675917ca4baaf768cc
2016-11-11make it more typical copy ctorCaolán McNamara1-2/+9
Change-Id: I0367e24b966a5bcc0d4838022ae12054e097270e
2016-11-11seems dubious to copy the state, but drop the load again bitCaolán McNamara1-1/+1
if the assigned-to item had loaded its original content, but the assigned-from item hadn't, then surely the assigned-to item will never load the new content. if the assigned-to item hadn't loaded its original content, but the assigned-from had, then why load it again Change-Id: I68c2cf2682a517e7e630ab6cbc637b35a2b9c7aa Reviewed-on: https://gerrit.libreoffice.org/30781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11these are going to get overwritten immediatelyCaolán McNamara1-3/+0
Change-Id: I065ae2aa2dead0679d05f080124ed54c27f0d68f
2016-11-11make this operator= a little less crazyCaolán McNamara1-18/+4
if SetGraphicPos was called with GPOS_NONE then xGraphicObject, maStrLink and maStrFilter are in a suitable state to copy to get the same results as explicitly forced here Change-Id: Id072590e92e0c083a3cbc443db0e85d9dbfa73f0 Reviewed-on: https://gerrit.libreoffice.org/30780 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-11why have a pimpl with somethings in it and somethings notCaolán McNamara1-167/+99
Change-Id: I6151defcd9dddf4582ecf8d5952f6f8a825c545a
2016-11-11the pStream member makes no sense at allCaolán McNamara1-14/+6
maybe the PurgeMedia call in sw was meant to be a PurgeGraphic call originally (PurgeGraphic since removed by... commit a22ac2c218870033822120bf0b0d6cfde6ce799f Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jul 14 22:06:29 2011 +0100 callcatcher: remove unused methods) PurgeMedia releasing the stream makes no difference to the only place its used which is SvxBrushItem::GetGraphicObject which makes a new one every time anyway. the SvxBrushItem assignment operator doesn't change the stream member of the pImpl which looks utterly nuts, so its a good thing the stream is not reused Change-Id: Ie0dee22a6640a6916908fcddbc3541ba85034217
2016-11-11this looks like a leak to meCaolán McNamara1-10/+9
Change-Id: Id72d770ec55d6e627a81cc9590cb59f6c84f27b9
2016-11-11use std::unique_ptrCaolán McNamara1-51/+44
Change-Id: I03e2fb2d3ad1b0b7e64f93dbee172b119ef7bf40
2016-11-11loplugin:countusersofdefaultparams in editeng..rscNoel Grandin1-1/+1
Change-Id: I8a8d13faf228cbc934ae21d6763d92d370eb42ec
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 07:19:50 +0000