summaryrefslogtreecommitdiff
path: root/editeng/source/outliner/outlvw.cxx
AgeCommit message (Collapse)AuthorFilesLines
2016-08-02editeng: make SfxUndoAction::GetViewShellId() interface availableMiklos Vajna1-2/+2
Extend the existing OutlinerViewCallable interface to be able to obtain the view shell ID of a view shell, even from editeng. Change-Id: I13708b0e4f58ee86643b913c7d21de022a685223 Reviewed-on: https://gerrit.libreoffice.org/27788 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-20sd lok: decouple vcl window focus from cursor visibilityMiklos Vajna1-4/+4
The problem was the the blinking cursor was hidden when another vcl window got its focus, so it wasn't possible to edit two shape text in parallel in two windows. The code path is like this: - show cursor, cursor is created: SdrObjEditView::SdrBeginTextEdit() -> OutlinerView::ShowCursor() - show cursor, focus case: sd::FuText::Activate() -> OutlinerView::ShowCursor() - hide cursor, cursor is deleted: SdrObjEditView::SdrEndTextEdit() -> OutlinerView::HideCursor() - hide cursor, focus case: sd::FuText::Deactivate() -> OutlinerView::HideCursor() So add a new optional bool parameter that allows not emitting the LOK_CALLBACK_CURSOR_VISIBLE callback in the focus change case. Also, if we're at it, make sure that painting emits no show/cursor LOK callbacks. Change-Id: I1068a1b1f5cd76fd09b5a79066834bfb0daebc77 Reviewed-on: https://gerrit.libreoffice.org/27335 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-22Remove no longer needed ImpEditView::mpLibreOfficeKitSearchableMiklos Vajna1-9/+0
All clients has been ported to use ImpEditView::mpLibreOfficeKitViewCallable instead. Change-Id: I3a2513ac5900f801a2e7aec79807f4e333dfba3d Reviewed-on: https://gerrit.libreoffice.org/26561 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-10editeng: implement per-view LOK_CALLBACK_INVALIDATE_VISIBLE_CURSORMiklos Vajna1-0/+5
Given that the per-view callback is in SfxViewShell, and editeng doesn't depend on sfx2, add an interface class in editeng to invert the dependency. With this, gtktiledviewer no longer crashes when starting editeng text edit with per-view callbacks. Change-Id: I783cdc646b890a6b597000f1d88428c8042417cf Reviewed-on: https://gerrit.libreoffice.org/26169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-27tdf#34465 remove calls to SfxItemSet::Put(const SfxPoolItem&, sal_uInt16)Noel Grandin1-2/+2
and put an assert in SfxPoolItem::SetWhich() so nothing new creeps in. Change-Id: I6497650fa61ffb2b6941ffff2d471c8f117be1df Reviewed-on: https://gerrit.libreoffice.org/24324 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-09convert OUTLINER_MODE to scoped enumNoel Grandin1-12/+12
Change-Id: I7ac45d7fbd5e77a105cbe942c6d4fd6cfc8ff909 Reviewed-on: https://gerrit.libreoffice.org/24789 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05loplugin:constantparam in editengNoel Grandin1-4/+4
Change-Id: If8342112e0657014266133954269b9396085a27d Reviewed-on: https://gerrit.libreoffice.org/23807 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-18loplugin:constantfunction in editengNoel Grandin1-10/+5
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-03loplugin:unuseddefaultparams in editengNoel Grandin1-4/+4
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna1-2/+2
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-02-09Remove excess newlinesChris Sherlock1-5/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna1-5/+0
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-14editeng: handle SdrModel::isTiledSearching()Miklos Vajna1-3/+5
Given that the edit/outliner views can come and go, avoid the lifecycle problems with just passing a pointer to the sdr model to editeng, and then it'll always have the up to date "are we searching" information. editeng can't depend on svx, so provide an interface class SdrModel can implement. Change-Id: I3b98011593b00ac0fab05b6b9c591dd20d94c579
2016-01-12loplugin:unusedmethods unused return value in include/editengNoel Grandin1-4/+3
Change-Id: I1314480950b0d3a3e5ed066d71c175604dd41970 Reviewed-on: https://gerrit.libreoffice.org/21361 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann1-6/+6
Change-Id: I9fe00eef7ddcd4a3c87e497a8d62f98e71a0d6d8
2015-10-19loplugin:defaultparamsStephan Bergmann1-4/+4
Change-Id: I62e0ec63ff09c200e0b621c8b042a976e8ce630e
2015-10-15calling IsSet() before Call() on Link<> is unnecessaryNoel Grandin1-4/+2
the Call() already does a check Found with: git grep -A 1 -w 'IsSet()' | grep -B 1 '.Call(' | grep ':' | cut -d ':' -f 1 Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
2015-10-13editeng: add EditView::GetSelectionRectangles()Miklos Vajna1-0/+5
This gives sd access to the selection rectangles as well (as opposed only to the document model positions of selections). Change-Id: Icb903e91f9e868573403b360bbe839705ddf2916
2015-09-30 tdf#94559: second step to remove rtti.hxxOliver Specht1-1/+1
replaced use of PTR_CAST, IS_TYPE, ISA in chart2, connectivity, editeng, extensions, filter, forms, framework, idl Change-Id: I6a2f9d8bbccb07088413f7552af4b5af8f0cad99 Reviewed-on: https://gerrit.libreoffice.org/18920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-22convert Link<> to typedNoel Grandin1-1/+1
Change-Id: I684a72cc3eeff0caf27132ff641f0d3b20ff7c08 Reviewed-on: https://gerrit.libreoffice.org/18770 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-20chained editeng: Handle chaining for cutting and pastingmatteocam1-1/+10
Change-Id: Iec08e339a7f06c5fa56e67b42206b31c766f845b
2015-08-11loplugin: defaultparamsNoel Grandin1-6/+6
Change-Id: I2a1255c00a051b29381ec57c380eafb08c4900d9
2015-07-03Fix typosAndrea Gelmini1-1/+1
Change-Id: Ideb5688a8c9e7cf10038f2e9d00991e8653b1875 Reviewed-on: https://gerrit.libreoffice.org/16706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-06-06Typo: emty->emptyJulien Nabet1-2/+2
Change-Id: I495ae28194da449ab1b31b2b5ec0d9e08fbcc291
2015-05-22convert POINTER constants to scoped enumNoel Grandin1-4/+4
Change-Id: Iea29ce5fd6c620535197d3ca8538335078430e19 Reviewed-on: https://gerrit.libreoffice.org/15825 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-30Gradually typed LinkStephan Bergmann1-1/+1
Turn the Link class into a template abstracting over the link's argument and return types, but provide default template arguments that keep the generic, unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the Link class can be updated over time. All the related macros are duplicated with ..._TYPED counterparts, that additionally take the RetType (except for LINK_TYPED, which manages to infer the relevant types from the supplied Member). (It would have been attractive to change the "untyped" LinkStubs from taking a void* to a properly typed ArgType parameter, too, but that would cause -fsanitize=function to flag uses of "untyped" Link::Call.) Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-17convert SCRIPTTYPE_ constants to scoped enumNoel Grandin1-5/+5
Change-Id: I5be3980ac865162d8d7626556ca47eca4b0ee433 Reviewed-on: https://gerrit.libreoffice.org/15344 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-25convert EV_CNTRL constants to enum classNoel Grandin1-2/+2
Change-Id: I0ffc0e222c978ce7c734228f712e88422d3a615f
2015-03-25convert EE_CNTRL constants to enum classNoel Grandin1-1/+1
there were a couple of lines in SC and SW where the code was using a EV_CNTRL constant. I switched it to used the same-valued constant from EE_CNTRL Change-Id: I027183cc3b6e700bf365d48833e37eddc9b50f04
2015-03-25convert MouseTarget to enum classNoel Grandin1-9/+9
Change-Id: I223c032e1637fecb8b7b0578a81762572973084b
2015-03-16Add ImpEditView::libreOfficeKitCallback()Miklos Vajna1-0/+5
And various other methods, so that it's possible to invoke the callback in ImpEditView. This will be needed by the blinking editeng cursor. Change-Id: Ie1b6957e5c48f606e71d5808df3f632924d3a2ec
2015-03-02convert PARAFLAG_ constants to enum classNoel Grandin1-6/+6
Change-Id: I71f5ea8e91fe0f50a471e33e4e2c02840a76b707
2015-02-23ImpEditEngine::UpdateViews: need to go via Invalidate() for tiled renderingMiklos Vajna1-0/+4
This makes typed characters appear as you type it (and not only after the editing of the shape text is finished) in Impress. Change-Id: Id47efe8223ddfdbad36f436366c9c8c8e0cb45f4
2015-01-05Some loplugin:revisibility clean-upStephan Bergmann1-2/+2
Stumbled across such redundant visibility re-specifications when looking at the odd case of cppu_unsatisfied_iquery_msg declared CPPU_DLLPUBLIC in cppu/source/cppu/cppu_opt.cxx and used in inline code in include/com/sun/star/uno/Reference.hxx with only a declaration lacking CPPU_DLLPUBLIC visible, and wondering how that actually works on Windows. However, this plugin is probably not worth it being run all the time, so committing it to compilerplugins/clang/store/. Change-Id: Ibc3c4e7499213de1b419ce7eb85455cb832e1510
2014-10-27fdo#84938: replace KEYTYPE_ constants with enumNoel Grandin1-7/+7
Change-Id: I563cf96f8ca815d6c8ad9f5fe365fc7ce7a2a328 Reviewed-on: https://gerrit.libreoffice.org/12104 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07Resolves: fdo#44998 crash when opening context menu of a fieldCaolán McNamara1-1/+5
If you right click on a field in an inactive text box, then a mouse down, context command, mouse up sequence is sent. The mouse up is supposed to be captured by the context menu here. But it doesn't because the mouse down in draw sends an artificial mouse down to the editengine which eventually sets up a MouseCapture window so the context menu doesn't get considered (because it occurs before the capture window is released) so the mouse up gets send to sd while the context menu is up and that causes all sorts of havoc. Change-Id: If3b7c501586f8561be484d0828c630d84644f770
2014-10-01loplugin: cstylecastNoel Grandin1-1/+1
Change-Id: I58582059495f7c50880038e2174ea2de026aa1c9
2014-09-23fdo#82577: Handle WindowNoel Grandin1-4/+4
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-18fdo#82577: Handle FontNoel Grandin1-1/+1
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann1-3/+3
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist1-1/+1
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-06-13Paragraph argument never used in InvalidateBulletCaolán McNamara1-1/+1
Change-Id: I07ba855e473fb137551e70de9cfa858c5e079324
2014-05-06simplify ternary conditions "xxx ? true : yyy"Noel Grandin1-1/+1
Look for code like: xxx ? true : yyy; Which can be simplified to: xxx || yyy Change-Id: Ib7ca86580bfd0cf04674328a3c0cf3747de4758d
2014-02-27Remove visual noise from editengAlexander Wilms1-4/+4
Change-Id: Id7582119a5628cb7f54347678580ce7e47f6d703 Reviewed-on: https://gerrit.libreoffice.org/8255 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27editeng: sal_Bool->boolNoel Grandin1-79/+79
Change-Id: Id4174904487fc153d8e80471da7c829c52092f78
2014-02-21editeng: sal_Bool->boolNoel Grandin1-8/+8
Change-Id: Ia9b76985ea0b9c511208b8283c8487c89aa67b88
2014-02-21editeng: sal_Bool->boolNoel Grandin1-8/+8
Change-Id: I36cb765d87ddef1fba3447a3ea90e5285cbcd678
2014-02-20svl: sal_Bool -> boolStephan Bergmann1-1/+1
Change-Id: Ic31455a1f5ffffa35d4fdde901dd70734207b6f4
2014-02-10A little simpler.Kohei Yoshida1-4/+1
Change-Id: I684317003a7afee4154fe39098ced7ba27bdff2f
2014-02-10fdo#46707: Don't bother with synonyms for text with mixed script types.Kohei Yoshida1-0/+26
Change-Id: I7922905523406d05f864b10e1ecfd27f3fb5f9d6
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-26 11:30:50 +0000