summaryrefslogtreecommitdiff
path: root/editeng/source/items/frmitems.cxx
AgeCommit message (Collapse)AuthorFilesLines
2013-09-29fix make check breakers due to GraphicObject refactorsfeature/graphicobjectNorbert Thiebaud1-8/+6
Change-Id: I26194e4ea3a6557c160c0516c58a5d3cd136867c
2013-09-27Save Commit: must be squashed!!! ObjectGraphic refactorNorbert Thiebaud1-17/+26
Change-Id: I69f0b8bef3a08d1a325ccbe2b5f128df9cc14880
2013-09-24Construct graphic objects from streams and misc. other fixes.Michael Meeks1-6/+2
Change-Id: I3b8c65adf7621e855b36d777e358d2465d7d0a14
2013-08-06initial cut at ref-counting GraphicObjectsMichael Meeks1-50/+41
Change-Id: Ia87c429fc9e8b470fe066ee2179928de01c1fa1b
2013-07-10SvxBrushItem::TransparencyToPercent: add this to avoid copypasteMiklos Vajna1-2/+2
Change-Id: I9b77c0a48b7de39eadae118c24c70ac415898293
2013-06-25fdo65400: fix for Character Shading being lostAdam Co1-47/+86
This bug fixes the DOCX import and export filters, adds a new property to the document model and updates the UNO API. There is no need to add layout \ UI updates, because in Word the only way to turn this on\off is using a simple button, and there is no way to control the shading color itself. However, ODF import \ export filters should be updated in a future commit. Conflicts: sw/qa/extras/ooxmlexport/ooxmlexport.cxx Change-Id: I1d34cec79289e38c08e42a4c6265d998e1edfdef Reviewed-on: https://gerrit.libreoffice.org/4452 Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
2013-05-03fdo#64150 don't segfault when there is no lineLionel Elie Mamane1-1/+2
Change-Id: Iab36de3d407925cdb0e092afae457907f0261b3e
2013-04-19Revert "fix fdo#47018 Impress paste destroy bullet"Stephan Bergmann1-3/+2
This reverts commit a95cce27295f9cd255fa72eaded00972e3efb69b, it lead to live- lock in JunitTest_sc_unoapi, where SvxBoxItem::Create (editeng/source/items/frmitems.cxx) failed to break out of the while(true) loop, apparently because it kept reading past the end of rStrm, so cLine wouldn't be updated. (That code would need to be made more robust, but I do not know how best to flag errors from SvxBoxItem::Create?) What looks suspicious about the changes of a95cce27295f9cd255fa72eaded00972e3efb69b at least to editeng/source/items/frmitems.cxx is that it changes the stream's format, now reading/writing a 16 bit value where it previously read/wrote an 8 bit value (SvStream /does/ support sal_Int8, btw). Change-Id: I1a46746559dcf8e1ea8be63a9a0cf2d32ccc69a1
2013-04-18fix fdo#47018 Impress paste destroy bulletCao Cuong Ngo1-2/+3
Currently the copy function stores the paragraph attributes to SvStream but the restoration in paste isn't implemented yet! This patch implements the attributes loading from SvStream. Change-Id: I58928ca66a83b3fe3c3894a28ccf1e7fe5f661b3 Reviewed-on: https://gerrit.libreoffice.org/3369 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák1-4/+4
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk have kept them, in order not to break external API (the automatic using declaration is LO-internal). Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-03-27kill some unused inlinesThomas Arnhold1-22/+0
Change-Id: I17160b264b547067c694dd268eb0d3bd1086565d
2013-03-20Remove uses of rtl::OUString::compareToAscii(asciiStr, maxLength)Stephan Bergmann1-4/+2
...which is a confusing overload with unexpectedly different semantics from the one-parameter form. In preparation of marking it as deprecated. Change-Id: I4f176995546ae583fc570d770647ffc315eecc75
2013-03-18coverity#735373 Copy-paste errorJulien Nabet1-1/+1
Change-Id: I0273a08a7aa23aa9bb7aa2139a0cea02611e8feb Reviewed-on: https://gerrit.libreoffice.org/2797 Reviewed-by: Joren De Cuyper <joren.libreoffice@telenet.be> Reviewed-by: Tomáš Chvátal <tchvatal@suse.cz> Tested-by: Tomáš Chvátal <tchvatal@suse.cz>
2013-03-04sal_Bool to boolTakeshi Abe1-2/+2
Change-Id: I8c554fb3faead41c974af9c2a89728bd0bdf5eb6
2013-03-04remove unused and commented out codeThomas Arnhold1-1/+0
This code gets never called. Change-Id: I59228cba1444b7b09f74eb5cf8da9b755c7c32f7
2013-02-26fdo#38838 Replaced some use of (Xub)String with OUString.Jean-Noël Rouvignac1-2/+2
Change-Id: I5a8f2d1a5762c20d21d31b04778a9e2cac8df9cb Reviewed-on: https://gerrit.libreoffice.org/2364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-24fdo#38838 searched, replaced and removed String::CreateFromInt32().Jean-Noël Rouvignac1-4/+4
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ And finally removed String::CreateFromInt32(). Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5 Reviewed-on: https://gerrit.libreoffice.org/2279 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-12Renamed hard-to-remember 8-char headers in editeng.Kohei Yoshida1-3/+3
Change-Id: If255802082890e1b1b4c5197a791fa79a011773e
2013-01-28fdo#38838 Some removal/replacement of the String/UniString with OUStringJean-Noël Rouvignac1-151/+152
Changed SfxItemPool::GetPresentation( SfxItemPresentation ePres, SfxMapUnit eCoreMetric, SfxMapUnit ePresMetric, String &rText ) const; to use OUString. Change-Id: I656c1d321ff96f1f2e5b77f6adc103ef0a6fdf66
2013-01-28SwXTextFrame: use XFillGradientItem instead of extending SvxBrushItemMiklos Vajna1-49/+1
Change-Id: I8863cbe1d01fceac0f4b4152264c1464c90e02b8
2013-01-28SwXTextFrame: use XFillStyleItem instead of extending SvxBrushItemMiklos Vajna1-20/+1
Change-Id: I03b841ed703503425c9f1a2045d6399c8899815f
2013-01-25SvxBrushItem: extend this with a vcl Gradient and drawing::FillStyleMiklos Vajna1-2/+70
So Writer fly frames can have gradient info as well. Change-Id: If59ae9092fedabbe112f034e13fbe801815ebaaf
2013-01-04Make LO buildable again after the GraphicFilter move.Jan Holesovsky1-1/+1
Change-Id: I3455a7294b136400f32163626d5a7a7f2bfa898c
2013-01-01remove use of #pragma optimizeLuboš Luňák1-8/+0
All these are years old, guessing from some comments as old as Windows 9x support. These workarounds do not seem to be needed now. Change-Id: If67baa5cdefcec33b28696c764b1ed96143b7ccd
2012-12-22Some cppcheck cleaning in editengJulien Nabet1-1/+0
Change-Id: I94bf89867cec9cc24f8b96635c515d9477b561a9
2012-12-04Support added for fine dashing on table borders.Eilidh McAdam1-1/+1
When reading in docx documents, fine dashing provides a better visual match for some border types. Added in this patch: - FINE_DASHED in BorderLineStyle UNO enum and in internals - Import of docx table borders using this border style Change-Id: I39cfa18c915ec94d8e4ecfc6a2ca637076d1e468 Reviewed-on: https://gerrit.libreoffice.org/1123 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2012-11-06re-base on ALv2 code. Includes (at least) relevant parts of:Michael Meeks1-23/+14
linecap: Reintegrating finished LineCap feature Patch contributed by Regina Henschel http://svn.apache.org/viewvc?view=revision&revision=1232507 Patches contributed by Sven Jacobi impress212: #i81610# fixed animation export http://svn.apache.org/viewvc?view=revision&revision=1167620 impress212: drawinglayer gbuild environment changes http://svn.apache.org/viewvc?view=revision&revision=1167627 http://svn.apache.org/viewvc?view=revision&revision=1167628 impress212: DffPropSet -> minor code improvements, removing table http://svn.apache.org/viewvc?view=revision&revision=1167634 impress212: #158494# fixed excel import (text rotation) http://svn.apache.org/viewvc?view=revision&revision=1167638 Patches contributed by Armin Le Grand Svg: Reintegrated Svg replacement from /branches/alg/svgreplavement http://svn.apache.org/viewvc?view=revision&revision=1220836 #118728# changed indentifying definitions for Svg file detection http://svn.apache.org/viewvc?view=revision&revision=1229961 #118838# LineGeometry creation for complicated cases optimized to create single Polygons http://svn.apache.org/viewvc?view=revision&revision=1236232 #119176# corrected file type detection for SVG for svg files without xml header http://svn.apache.org/viewvc?view=revision&revision=1309445 #118728# Extended Svg file detection http://svn.apache.org/viewvc?view=revision&revision=1230531 #118529# solve break converters and convert commands for OLEs and images http://svn.apache.org/viewvc?view=revision&revision=1186168 svg: added WaE changes from branch svgreplacement to trunc http://svn.apache.org/viewvc?view=revision&revision=1222974 svg: corrected missing member initialization http://svn.apache.org/viewvc?view=revision&revision=1226134 fix for #118525#: Using primitives for chart sub-geometry visualisation http://svn.apache.org/viewvc?view=revision&revision=1226879 #118898# Adapted ImpGraphic::ImplGetBitmap to correctly convert metafiles to bitmapEx ... http://svn.apache.org/viewvc?view=revision&revision=1293316 fix for #118525#: removed no longer used variable maOriginalMapMode, one more exception eliminated http://svn.apache.org/viewvc?view=revision&revision=1227097 #16758# Added buffering to the VDev usages of the VclProcessor2D derivates... http://svn.apache.org/viewvc?view=revision&revision=1229521 #116758# Secured VDev buffer device to Vcl deinit http://svn.apache.org/viewvc?view=revision&revision=1230574 #116758# added remembering allocated VDevs for VDevBuffer to be able to also delete these when vcl goes down; it should never happen, but You never know http://svn.apache.org/viewvc?view=revision&revision=1230927 #118730# Changed SvgClipPathNode to use MaskPrimitive2D for primitive representation instead of TransparencePrimitive2D http://svn.apache.org/viewvc?view=revision&revision=1231198 #118822# secured 3D geometry creation (slices) by subdividing the 2D source polyPolygon early http://svn.apache.org/viewvc?view=revision&revision=1234749 #118829# enhanced Svg gradient quality, obstacles avoided http://svn.apache.org/viewvc?view=revision&revision=1235361 #118834# Unified usage of TextBreakupHelper as single tooling class for i18n text primitive breakup http://svn.apache.org/viewvc?view=revision&revision=1236110 #118853# added square pixel size limit to conversion of TransparencePrimitive2D to Metafile action http://svn.apache.org/viewvc?view=revision&revision=1237656 #118824# coreccted mirroring and boundrect when the graphicmanager is used for bitmap output http://svn.apache.org/viewvc?view=revision&revision=1240097 #115092# Corrected VclProcessor2D::RenderPolygonStrokePrimitive2D for various optimization scenarios http://svn.apache.org/viewvc?view=revision&revision=1241434 #118783# Corrected errors in ID strings, corrected Svg line/fill export, corrected polygon close state http://svn.apache.org/viewvc?view=revision&revision=1232006 #118796# corrected null-pointer usage in SVG text exporter http://svn.apache.org/viewvc?view=revision&revision=1240262 #118729# Use GraphicStreamUrl and GraphicUrl to allow multi image import with linked graphics, too http://svn.apache.org/viewvc?view=revision&revision=1229962 #118898# corrected error in GDIMetaFile::GetBoundRect in handling MetaFloatTransparentAction http://svn.apache.org/viewvc?view=revision&revision=1293349 #118855# Corrected handling of possibly created empty clipRegions after PolyPolygon clipping http://svn.apache.org/viewvc?view=revision&revision=1237725 #115962# Better (but not yet optimal, see comments in task) handling of MetaFloatTransparentAction in PDF export http://svn.apache.org/viewvc?view=revision&revision=1241078 IP clearance: #118466# This patch removes librsvg, libcroco, libgsf, ... http://svn.apache.org/viewvc?view=revision&revision=1200879 118779# Added svg content streaming in/out to ImpGraphic stream operators http://svn.apache.org/viewvc?view=revision&revision=1231908 linecap: correctons for WaE and mac drawing http://svn.apache.org/viewvc?view=revision&revision=1232793 svg: uses current system Dpi for Svg replacement image creation http://svn.apache.org/viewvc?view=revision&revision=1233948 Patches contributed by Mathias Bauer (and others) gnumake4 work variously http://svn.apache.org/viewvc?view=revision&revision=1394326 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1397315 http://svn.apache.org/viewvc?view=revision&revision=1394326 Remove duplicate header includes. cws mba34issues01: #i117720#: convert assertion into warning http://svn.apache.org/viewvc?view=revision&revision=1172352 118485 - Styles for OLEs are not saved. Submitted by Armin Le Grand. http://svn.apache.org/viewvc?view=revision&revision=1182166 cws mba34issues01: #i117714#: remove assertion http://svn.apache.org/viewvc?view=revision&revision=1172357 Patch contributed by Jurgen Schmidt add some additional checks to ensure proper reading operations http://svn.apache.org/viewvc?view=revision&revision=1209022 mostly prefer our stream / bounds checking work. Patches contributed by Herbert Duerr #i118816# add clarifying comment regarding Font::*Color*() methods http://svn.apache.org/viewvc?view=revision&revision=1233833 extend macro->string handling for empty strings http://svn.apache.org/viewvc?view=revision&revision=1175801 avoid magic constants for SALCOLOR_NONE http://svn.apache.org/viewvc?view=revision&revision=1177543 initialize slant properly in ImplFontMetricData constructor (author=iorsh) http://svn.apache.org/viewvc?view=revision&revision=1177551 #i118675# make check for extension updates more stable http://svn.apache.org/viewvc?view=revision&revision=1214797 #a118617# remove VBasicEventListener.dll binary There are no known users depending on its CLSID http://svn.apache.org/viewvc?view=revision&revision=1203697 Patches contributed by Ariel Constenla-Haile Fix build breaker on Linux/gcc http://svn.apache.org/viewvc?view=revision&revision=1221104 Fix crash when trying to instantiate css.graphic.GraphicRasterizer_RSVG http://svn.apache.org/viewvc?view=revision&revision=1215559 Patches contributed by Oliver-Rainer Wittmann sw34bf06: #i117962# - method <SwFlyFrm::IsPaint(..)> - consider instances of <SwFlyDrawObj> http://svn.apache.org/viewvc?view=revision&revision=1172120 sw34bf06: #i117783# - Writer's implementation of XPagePrintable - apply print settings to new printing routines http://svn.apache.org/viewvc?view=revision&revision=1172115 gnumake4 work variously from Hans-Joachim Lankenau http://svn.apache.org/viewvc?view=revision&revision=1397315 http://svn.apache.org/viewvc?view=revision&revision=1396797 http://svn.apache.org/viewvc?view=revision&revision=1396782 http://svn.apache.org/viewvc?view=revision&revision=1394707 plus some amount of re-splitting of legacy headers. Patch contributed by Pavel Janik WaE: Remove unused variables. http://svn.apache.org/viewvc?view=revision&revision=1230697 Patches contributed by Takashi Ono mingwport35: i#117795: MinGW port fix for vcl2gnumake http://svn.apache.org/viewvc?view=revision&revision=1172091 mingwport35: i#117795: MinGW port fix for vcl2gnumake http://svn.apache.org/viewvc?view=revision&revision=1172091 Patch contributed by Christian Lippka impress212: #i98044# re enable Text menu for outline and title shapes http://svn.apache.org/viewvc?view=revision&revision=1167639 Patch contributed by Andre Fischer 118674: Made category B code optional and disabled by default. http://svn.apache.org/viewvc?view=revision&revision=1215131 118881: Ignore empty paragraphs after bullets. http://svn.apache.org/viewvc?view=revision&revision=1296205 Patches contributed by Philipp Lohmann ooo340fixes: #i117780# use rtl allocator http://svn.apache.org/viewvc?view=revision&revision=1172087 ooo34gsl02: #i117807# fix an off by one error (index actually inside the pfb section header) http://svn.apache.org/viewvc?view=revision&revision=1167576 various cleanups, related compilation fixes, warning cleanups, re-working of obsolete stl template pieces to use boost instead, changed string classes, re-adapt KDE about data, about dialog, fixing warnings, and other fixes & improvements. Disable svg import / render for about/ branding code-paths for now. Restore full icon theme set. Remove OS/2 conditionals and sources. Remove conflicting gtk/full-screen monitors support. Retain existing svg rasterizer files - temporarily disabled. Standardize stringificaiton and fixup dllpostfix issues. Rename SvgGradientHelper::== to equalTo to avoid overloading issues. Use the flat GdiPlus API for LineCaps calls.
2012-10-12mark lcl_ functions static or rename them if they are not local at allLuboš Luňák1-2/+2
http://lists.freedesktop.org/archives/libreoffice/2012-October/039639.html Change-Id: I231f0b367bf0b513c6c1ce4c4cfdb7c3dc8660d5
2012-08-27fdo#46808, Adapt script::Converter service code to new styleNoel Grandin1-6/+3
Change-Id: I19b3ba7c978e02ce865360f0411007525012149c
2012-07-04refactor handling of double border widths:Michael Stahl1-7/+0
Word uses a completely different definition of "width" of a double border than OOo and ODF: for Word the width is apparently the largest of the 3 component widths, while OOo and ODF define the width as the total with of all 3 components. The new border implementation in LO 3.4 was apparently inspired by Word's double border definition, which resulted in various import filter regressions, see the previous fixes: 36e43b52992735c622833e923faa63774b9e2f76 e2ffb71305c5f085eec6d396651c76d6daee3406 70a6a4d425558340bb49507975343a3e0a1bdde8 These fixes set the ScaleMetrics, which actually seems sub-optimal as there is a ScaleItemSet function somewhere that apparently re-scales all items in an itemset, which could undo the fixes. Also, one of the fixes actually managed to break RTF/DOCX import of double borders, as that ended up in the same code via the API. This commit now reverses the change, so that the width of a border is now always the total with of all components, which is (imho) much more intutitive, and also leads to a consistent UI where selecting say 3pt width has predictable results, no matter what the border style. The border widths are now converted in the Word format import/export filters (writerfilter and sw/source/filter/ww8), and various tests were adapted to the new handling. Change-Id: I50456c49b1a298569607e6c88f19f18441348ac3
2012-07-04replace enum SvxBorderStyle with css::table::BorderLineSyleMichael Stahl1-62/+21
Change-Id: I1dadb53f46b23f92d34061ef78dda872bdbcda67
2012-06-29Remove some unused defines and controlsThomas Arnhold1-3/+0
Change-Id: I96f76ed6b33f5c786d1e3ab3981a535037a9c1b5
2012-06-25rename SvxBorderLine::SetStyle to something unambiguousMichael Stahl1-7/+9
Change-Id: Iec70985319a64cdc3630e15499ac304a7f1aabae
2012-06-09Remove superfluous include commentsThomas Arnhold1-2/+0
Change-Id: Icd57ca7fd89e30c190c1b06dbe67c30bea8d1b59
2012-06-04fdo#46112: tweak condition to prevent guessing only...Michael Stahl1-1/+2
...if there are actually individual line widths given; fixes the sw_rtftok test. Change-Id: If5f6ef54b93c5bfccfd011f25d9d9301637d388e
2012-06-04fdo#46112: fix Calc ODF border line import:Michael Stahl1-1/+10
There are 2 problems here: - the border widths are tripled on import, because that is effectively what SetWidth does for DOUBLE borders; set a divisor of 3 similar to e2ffb71305c5f085eec6d396651c76d6daee3406 - the 3 individual line widths are ignored and the 3 lines end up with the same width, while older versions had numerous pre-defined border styles with asymmetric line widths; fix this by always guessing the width from the 3 parts for DOUBLE lines Change-Id: Ibdde7e034e25433835765330e81db0825efd9eb8
2012-05-29targeted string re-workNorbert Thiebaud1-4/+4
Change-Id: I477fc34c21530b51d975216156e66abf21a7149c
2012-05-21fdo#40874: make recorded border macros run:Michael Stahl1-3/+40
When the new BorderLine2 struct with its added members was introduced, the PutValues methods that are called by the macro recorder with seqeunces of Anys were not adapted, so running recorded macro for ".uno:BorderInner" ".uno:BorderOuter" ".uno:SetBorderStyle" fails. (regression from b624e6e6cf2ecfc6e6e983af45212fce5e731006, 7db30f7aa037f52eb07cbb4fd2796bd869204af8) Change-Id: Icd8a11d7f5c8d79c57020f213a1554540b6c666d
2012-05-03fdo#31005 Table Autoformats do not save/apply all propertiesMuhammad Haggag1-11/+52
This change expands the number of properties supported by autoformats, mainly for Writer. Some improvements affect Calc as well (e.g. border styles are now preserved for Calc). Common: boxitem.hxx, frmitems.cxx * Added a new version for SvxBoxItem serialization that includes border styles. * Updated SvxBoxItem and SvxBorderLine serialization logic accordingly. Writer: fmtornt.hxx, attrfrm.cxx * Added serialization/deserialization logic for SwFmtVertOrient. Writer: tblafmt.hxx, tblafmt.cxx, ndtbl.cxx * Updated file version for autotbl.fmt to be SOFFICE_FILEFORMAT_50. * Autoformats now record the text orientation and vertical alignment of table cells. * Autoformats now record the following table-level properties: - Break - Keep with next paragraph - Repeat heading - Allow table split across pages - Allow rows to break across pages - Merge adjacent line styles - Table shadow Calc: autoform.hxx, autoform.cxx * Added support for reading/writing writer-specific data as binary blobs. * Updated file version for autotbl.fmt to be SOFFICE_FILEFORMAT_50.
2012-04-20fdo#47436: Fixed crash while opening odt file.Dezsi Szabolcs1-1/+2
2012-04-16upgrade GetValueTextByPos family to rtl::OUStringCaolán McNamara1-5/+4
2012-03-26readUnicodeString can just return the stringCaolán McNamara1-1/+1
seeing as no-one checks the return value, we don't need the intermediate temporary string
2012-03-13Conditional jump or move depends on uninitialised valueCaolán McNamara1-16/+14
2012-03-12SvxULSpaceItem: implement contextual spacingMiklos Vajna1-0/+8
2012-02-28we don't want any of these to be streamed out/in as 64bit valuesCaolán McNamara1-2/+2
2012-02-27Removed unused codeSzabolcs Dezsi1-5/+0
2012-02-23WaE: nWidth might be unused uninitializedCaolán McNamara1-1/+1
2012-02-23fdo#45560: Fixed docx textbox borders style and width importCédric Bosdonnat1-0/+48
2012-01-18fdo#39428 Remove/audit SvStream operator>>/<<(long)Keith McRae1-3/+5
Replaced calls to operator<<(long) with sal::static_int_cast<sal_Int32> Replaced calls to operator>>(long) with operator>>(sal_Int32)
2012-01-17Replaced SAL_INFO with SAL_WARN were applicable.Marcel Metz1-2/+2