summaryrefslogtreecommitdiff
path: root/editeng/qa
AgeCommit message (Collapse)AuthorFilesLines
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): editengStephan Bergmann1-1/+1
Change-Id: Id1ed8953803dde7ed0709d999ef8efe4eb055176 Reviewed-on: https://gerrit.libreoffice.org/76682 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-22Spell out element access explicitly in test codeStephan Bergmann1-410/+346
...to avoid the upcoming loplugin:data asking to replace just each initial &aAttrs[0] with aAttrs.begin() and leave the remaining &aAttrs[N] alone, which would make the results look odd. Change-Id: I7d5c76e9d4fc6c7fa13cb28fca5ea65ea2d0f77e Reviewed-on: https://gerrit.libreoffice.org/72764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-01tdf#120703 PVS: Silence V522 warningsMike Kaganski1-0/+5
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie617b41a8f8d334022cf5313b242a236baedba48 Reviewed-on: https://gerrit.libreoffice.org/70017 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-20Simplify containers iterations in desktop, dtrans, editeng, extensionsArkadiy Illarionov1-39/+15
Use range-based loop or replace with STL functions Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292 Reviewed-on: https://gerrit.libreoffice.org/68036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-08loplugin:indentation in editeng..extensionsNoel Grandin1-1/+1
Change-Id: If7d7c400fb5d24e48b6cd02b364a8ac7fa23505d Reviewed-on: https://gerrit.libreoffice.org/67538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16Revert "tdf#115639: Align right/center with trailing spaces the same"Tamás Zolnai1-144/+0
.. as MS PowerPoint" This reverts commit 1da3a3cb74a415a76fa547ef0c8f61780e260e7f. It was a bad solution for the problem. Change-Id: I6f6fecb7c74a884fbfb04c6e7204eb8bf347a272 Reviewed-on: https://gerrit.libreoffice.org/63473 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-29loplugin:oncevarNoel Grandin1-2/+1
Change-Id: Iba892694acb378887a1d15ab59104c55f591f0bd Reviewed-on: https://gerrit.libreoffice.org/62498 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin1-3/+3
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-11Make editeng_core test depend on more_fontsJan-Marek Glogowski1-0/+8
CppunitTest_editeng_core explicitly request the "Liberation Sans" font. Change-Id: I810bddda26498252985f1869df58610e79ebc5ef Reviewed-on: https://gerrit.libreoffice.org/61658 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-26tdf#106260 Fix invisible pasted urlsPaul Trojahn1-5/+4
UpdateFields() was never called after pasting a field. Change-Id: I91f3eb183a0545d8735c0844f1e864a287101d22 Reviewed-on: https://gerrit.libreoffice.org/59339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-10store Color using boost::optional in EditCharAttribFieldNoel Grandin1-1/+1
Change-Id: If4af5991be51cdb035c0bc0fb7668844df703073 Reviewed-on: https://gerrit.libreoffice.org/54022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-27convert auto correct flags to scoped enumNoel Grandin1-1/+1
Change-Id: I73356493d97bb4f0d5b7db8b5c742837d7a4c78b Reviewed-on: https://gerrit.libreoffice.org/53505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-18tdf#42949 Remove unnecessary localization headers of editengGabor Kelemen1-2/+0
Found by searching for the header names and the localization function: git grep -l -e \<editeng/eerdll.hxx\> -e \<editeng/editrids.hrc\> | xargs grep -c EditResId | grep :0$ | grep -v /pch Change-Id: Ic542ceee09352cb52dcdc9780d4cb1890e02f383 Reviewed-on: https://gerrit.libreoffice.org/53062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-03tdf#93173: Remove arbitrary line spacing limitMike Kaganski1-50/+42
OASIS Open Document Format for Office Applications (OpenDocument) v.1.2 doesn't limit the value of fo:line-height. But we have arbitrary limits in proportional mode for both minimal (50%) and maximal (200%) values. The implementation uses sal_uInt16 to store the value, so fix places where sal_uInt8 was unreasonably used to set it, change the upper limit to max sal_uInt16 value, and set lower limit to 6% (to match Word's minimal factor of 0.06). Change-Id: I4c2ac5f0acf65d7573328e71bcf36ac9abb5ffd5 Reviewed-on: https://gerrit.libreoffice.org/52252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-29tdf#116536 Fix bullet position with linespacing > 100Szymon Kłos1-1/+1
Change-Id: I862246d9c69e754bdd883787fe42c7d61a1a53d3 Reviewed-on: https://gerrit.libreoffice.org/51790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-09tdf#116101 Correct bullet position for linespacing > 100%Szymon Kłos1-1/+1
Change-Id: Ia900636d4013ab2a9c893c8246391db867fe1543 Reviewed-on: https://gerrit.libreoffice.org/51017 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-09tdf#116101 Correct position for linespacing > 100%Szymon Kłos1-1/+1
Change-Id: Ia3d90d521e03ed59312d1603b2cf5e5680b00781 Reviewed-on: https://gerrit.libreoffice.org/51005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-02-21New loplugin:nestedunnamedStephan Bergmann1-15/+9
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21Increase delta value for these checksTamás Zolnai1-11/+6
Change-Id: I14582541bf076340cfc95a17e1a9070a596c67db Reviewed-on: https://gerrit.libreoffice.org/50073 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-20Blind fix for -Werror,-Wunused-variable on macOSStephan Bergmann1-0/+2
...after c40ef4d19bfecd91e16a104a657d01196d855630 "workaround jenkins failure on OSX". Probably better to keep executing the code under test than to #if-out the whole block. Change-Id: I83c21c532cd69f72834e4a242f767cca419b04ea
2018-02-20workaround jenkins failure on OSXNoel Grandin1-0/+3
Change-Id: I82fd0bba275c4c58f1a39b823c75fd18889987ed Reviewed-on: https://gerrit.libreoffice.org/50024 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19tdf#115639: Handle alignment correctly for multiple paragraph caseTamás Zolnai1-0/+33
I used the wrong calculator method to get the line width. This commit also fixes the crashes found by crashtest. Change-Id: I25392f86af912ee54c07b14480d82282210ac346 Reviewed-on: https://gerrit.libreoffice.org/49994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-17tdf#115639: Align right/center with trailing spaces the same as MS PowerPointTamás Zolnai1-0/+111
* Add HoriAlignIgnoreTrailingWhitespace compatibility option. ** For MSO file formats it is set to true ** For ODP format it's set to false by default ** The flag is saved to ODP format as user data if the document comes from an MSO format. Change-Id: Ie22233d33a25e605de46120bfc2195038dffd63c Reviewed-on: https://gerrit.libreoffice.org/49889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-12More loplugin:cstylecast: editengStephan Bergmann2-280/+280
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable loplugin:cstylecast for some more cases" plus solenv/clang-format/reformat-formatted-files Change-Id: I09a4d688e6f3c1ecbe05a7d27ebd955e8ba1eb65
2018-01-07tdf#114628 unit test for line spacingSzymon Kłos1-0/+92
* two cases 60% and 150% line spacing Change-Id: I2ce66cd19f459b738243052b5c12da0bbb883ebe Reviewed-on: https://gerrit.libreoffice.org/47303 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-27rhbz#1517407 Capitalize every word doesn't work after bracketsCaolán McNamara1-0/+15
Change-Id: Iab2da3f74f6116bb1b9855044df2a2ece977bb95 Reviewed-on: https://gerrit.libreoffice.org/45335 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-23loplugin:includeform: editengStephan Bergmann1-19/+19
Change-Id: If2aa2cbbfabe164ccf0f68522fa18fa3bae2225d
2017-10-16Move editeng/source/editeng include files to common include directoryStephan Bergmann1-2/+3
...that are included from various source directories. Change done in preparation of loplugin:includeform. Change-Id: I4c2160d1c682b37e93e1161796c67097866bf659
2017-09-16convert SvxURLFormat to scoped enumNoel Grandin1-6/+6
Change-Id: Ie2199cf0bcfb6d649f8aa33325ab645b18e7c000 Reviewed-on: https://gerrit.libreoffice.org/42343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24Related: tdf#108795 a shared SvxAutoCorrect instance can not be statefulEike Rathke1-6/+12
An SvxAutoCorrect instance is shared via SvxAutoCorrCfg::Get().GetAutoCorrect(). Since commit 284eb106767d094fc5c547efd6c11cc390e3538a and following the SvxAutoCorrect::bRunNext/HasRunNext() introduced a state whether a previously inserted NO-BREAK SPACE should be removed again, depending on the next character input. That does not work, for example, if SvxAutoCorrect::DoAutoCorrect() is called from two different EditEngine instances, like it is the case in the Calc input line and cell which are synchronized; or any other two or more instances for that matter. The caller has to pass and remember a flag that is maintained by SvxAutoCorrect. Change-Id: I79a26d2ba44cc40771979a78b686c89f0c80b412 Reviewed-on: https://gerrit.libreoffice.org/41475 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-17Removing unused serialisation codeVarun Dhall1-1/+1
Change-Id: I86911c77f0831d448ff803afae2a74ec55ad4dd8 Reviewed-on: https://gerrit.libreoffice.org/41233 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-13loplugin:oncevar: empty strings: editengStephan Bergmann1-3/+1
Change-Id: I3b60b918277b408038a99f2c4801a454e6aa7b4a
2017-07-12EditEngine: Making ODF Format Default for Copy/PasteVarun Dhall1-25/+54
Change-Id: Idfb4dacf4a1595ff974bbca195e419ff6a98418b Reviewed-on: https://gerrit.libreoffice.org/39876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-06EditEngine: Added test for large para copy/pasteVarun Dhall1-0/+76
Change-Id: Ica1e5ae18f71470a3124fd0389213d2fbfc7e521 Reviewed-on: https://gerrit.libreoffice.org/39615 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-03EditEngine: Added test to check multi para start copy/pasteVarun Dhall1-0/+49
Change-Id: Ic253af5ab75783280926f2ed8387f69015014227 Reviewed-on: https://gerrit.libreoffice.org/39488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-29loplugin:oncevar variousNoel Grandin1-1/+1
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6 Reviewed-on: https://gerrit.libreoffice.org/38766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-26EditEngine: Added test to check MultiPara Copy/Paste with Bold/Italic textVarun Dhall1-0/+301
Change-Id: Ic94338662009a4e0ddbc28e21ac1f5028ddd9126 Reviewed-on: https://gerrit.libreoffice.org/39219 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-26Fix typosAndrea Gelmini1-1/+1
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23EditEngine: Added test to check MultiPara SelectiveSelection Copy/PasteVarun Dhall1-0/+50
Change-Id: Iffb55599c90483b231820f60536c93ec3bfec2c9 Reviewed-on: https://gerrit.libreoffice.org/39140 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-23EditEngine: Added test to check Multi Para Copy/PasteVarun Dhall1-0/+46
Change-Id: Ida45d5861068c71e5c8d75eb711aaacbf543be79 Reviewed-on: https://gerrit.libreoffice.org/39119 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-23loplugin:oncevar editeng..extensionsNoel Grandin1-24/+17
Change-Id: I3a63e3e3b873ef8a2d708d39be084124a6ad1346 Reviewed-on: https://gerrit.libreoffice.org/39153 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-19consider field marks as text for auto quotesCaolán McNamara1-0/+17
Change-Id: I511a13f7785a0de6efaa8439d3f0bff20a1644ed
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-5/+5
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-24Added Test for EditEngine - Copy/Paste with Hyperlinks in TextVarun Dhall1-0/+131
Change-Id: Iabe11ddac346f1c48b355c21797c11de8db54b1f Reviewed-on: https://gerrit.libreoffice.org/35593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24Added Test for EditEngine - Copy/Paste with Tabs in TextVarun Dhall1-0/+57
Change-Id: If40dabc53d35c01e61f8a17799f26e6ef9fd6b08 Reviewed-on: https://gerrit.libreoffice.org/35579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24Added Test for EditEngine - Copy/Paste using Underline TextVarun Dhall1-0/+125
Just because Underline is as important as Bold/Italic we cannot skip a test for it :) Change-Id: I6c240a3232cf97794c8265afe66f58ce6f68fa43 Reviewed-on: https://gerrit.libreoffice.org/35217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-17convert SvxBorderStyle to scoped enumNoel Grandin1-15/+15
and rename to SvxBorderLineStyle Change-Id: I19e530f162e4ca6290a0ad076e7fe3d5775ae6bc Reviewed-on: https://gerrit.libreoffice.org/35265 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13Added Test for EditEngine - Copy/Paste using Bold/Italic TextVarun Dhall1-0/+192
Change-Id: Ifd2fd8088590493377749866f37b1e663f97fa76 Reviewed-on: https://gerrit.libreoffice.org/34983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-10ensure SfxApplication exists for editeng testCaolán McNamara1-0/+3
Change-Id: I73814e38437f83f8aa7b87addc285e82f7357bea
2017-02-24Added Test for EditEngine - Copy/Paste using Legacy FormatVarun Dhall1-0/+36
Change-Id: I3153010f4e327abd2ef48bdefa50ade1c0ba2f81 Reviewed-on: https://gerrit.libreoffice.org/34552 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-19 22:53:08 +0000