summaryrefslogtreecommitdiff
path: root/dtrans
AgeCommit message (Collapse)AuthorFilesLines
2019-02-08tdf#122435: reimplement fix for tdf#109085Mike Kaganski2-13/+90
This reverts commit 3d8c159841bcab7365b2bed3df71ed3c15188312, and instead, checks if the MtaOleReq window is not destroyed yet, in addition to the wait for the condition. This allows to avoid wait forever for condition which never gets signalled, and process the sent messages when waiting. The window's WM_DESTROY handler sets the event signalling that. The Win32Condition's wait() is changed to take the abort event, and return true if its own event fired, and false if abort event fired. Change-Id: I1861dd3dabb39329976a3ccf2a5392c9ddbf9613 Reviewed-on: https://gerrit.libreoffice.org/67383 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 11a2809e369b2a6fcbb2d7f0db131a945557c6e2) Reviewed-on: https://gerrit.libreoffice.org/67389 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-16Fix typosAndrea Gelmini2-2/+2
Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-05Win: implement Clipboard Format Listener instead of obsolete ViewerMike Kaganski2-61/+10
https://docs.microsoft.com/en-us/windows/desktop/dataxchg/using-the-clipboard discusses the techniques to monitor clipboard contents on Windows, and recommends Clipboard Format Listener for Vista+. https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-setclipboardviewer further mentions that using the current "Clipboard Viewer Window" approach, "The clipboard viewer chain can be broken by an application that fails to handle the clipboard chain messages properly". This change reimplements our listener to use recommended way; this should make our clipboard handling more robust, avoiding the need to handle the chain with other applications' windows. Change-Id: Ib33b27a57d7a6af2ab7e3e59d030aa55329694f9 Reviewed-on: https://gerrit.libreoffice.org/62909 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#109085: don't assume MtaOleReq window is still valid at shutdownMike Kaganski1-95/+5
The window can be destroyed by e.g. WM_QUERYENDSESSION/WM_ENDSESSION sequence, and then the message MSG_REGCLIPVIEWER handler would not run and the condition would never be set. Since we need to wait for the message processed, let's just use sendMessage which would return only after the message has been processed anyway, and also will return immediately on failure (e.g., window handle invalid). Also this changes other cases where postMessage + wait pattern was used, and removes the condition from MsgContext. Change-Id: Ic12deafbaedd1cc99b9d6145650d99069c618f0e Reviewed-on: https://gerrit.libreoffice.org/62881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin1-2/+2
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-28tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl1-1/+1
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Remove unnecessary mutexStephan Bergmann2-7/+0
CMimeContentType::m_ParameterMap isn't modified after construction Change-Id: Ib3dbfbd4212ed0d7e8a9f29c655f935d3fc4f1bf Reviewed-on: https://gerrit.libreoffice.org/61698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-12Remove undefined member function declarationsStephan Bergmann1-12/+0
...that had accidentally not been removed along with the definitions in b75e3ded1f73c943fb09f117e476e367ac0c3413 "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" Change-Id: If94c0c413b891480c12a098c7b15caa1422213b0 Reviewed-on: https://gerrit.libreoffice.org/61697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11tdf#120158: Base CMimeContentType on INetMIME::scanContentTypeStephan Bergmann3-255/+19
...instead of using yet another local implementation of parsing media types. CMimeContentType is the implementation of the UNO css.datatransfer.XMimeContentType interface. One observable change in behavior is that type, subtype, and parameter names will now always be reported in lower case instead of with the casing from the input preserved (but those differences in casing are functionally equivalent per the media type specification). Also, parameter names supplied to the hasParameter and getParameterValue functions are now also treated case-insensitive. The upside of this change is that INetMIME::scanContentType (via "The encoding of rMediaType should be US-ASCII, but any Unicode values in the range U+0080.. U+FFFF are interpreted 'as appropriate.'") already implicitly supports RFC 6532 "Internationalized Email Headers" extensions for media types, allowing quoted- string parameter values to contain non-ASCII Unicode characters. That means that tfd#120158 "Impossible to paste special in Writer from Calc in Libreoffice 6.1.x in some UI languages - the dialogue caption says 'unknown source'" can be fixed by just allowing non-ASCII typename parameters being generated in ImplGetParameterString in svtools/source/misc/transfer.cxx, and reverting the problematic (see the comments there) previous fix <https://gerrit.libreoffice.org/61601> "tdf#120158: fix ImplGetParameterString for typename". (Which will be done in a follow-up commit, to ease potential backporting, as that previous fix has already been backported to some versions but not to others.) Change-Id: I5d4d3586e8046f288a97605b000e262a8db5a4e9 Reviewed-on: https://gerrit.libreoffice.org/61684 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski1-4/+0
Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-10Properly check HRESULTMike Kaganski1-1/+1
Although the IEnumFORMATETC::Next documentation only mentions S_OK and S_FALSE, there are error codes that also may be returned: e.g., 0x800706BA RPC server unavailable (encountered locally in a unit test). In that case, this used to loop infinitely. We are only interested in S_OK result, so check for it. Change-Id: I062e409e84efb68353321f7c48d922ec83191f73 Reviewed-on: https://gerrit.libreoffice.org/61621 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann5-13/+13
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-10tdf#42949 Fix IWYU warnings in include/cppuhelper/*Gabor Kelemen5-0/+5
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45 Reviewed-on: https://gerrit.libreoffice.org/59297 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-09-07Fix some std::unique_ptr array allocsJan-Marek Glogowski1-1/+1
Found by reviewing the output of and the code around git grep -n "unique_ptr.*new.*\[.*\]" | grep -v "\[\]" The onlineupdater code needs a little bit more attention. Change-Id: I8b70c7da7db60af52bfac12314a21602ede8bfc0 Reviewed-on: https://gerrit.libreoffice.org/60162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-07Cppcheck: release the handle that CreateThread returnsMike Kaganski1-1/+1
Change-Id: I4d6d04873d69d2ff1e5409372b353e0bb9a5d68d Reviewed-on: https://gerrit.libreoffice.org/60120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-29loplugin:stringloop in variousNoel Grandin1-9/+10
Change-Id: Ic2436c6d94729211cd5bc72fee18af228381e4a3 Reviewed-on: https://gerrit.libreoffice.org/58250 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-05tdf#42949 remove unused compheler includes ..Jochen Nitschke1-1/+0
and fix the fallout Change-Id: I15bc5d626f4d157cbc69a87392078b41e621d14e Reviewed-on: https://gerrit.libreoffice.org/54882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-03tdf#96099 Remove some trivial std::vector typedefsArkadiy Illarionov1-5/+4
Change-Id: I21171bd90b5e19fe8e5b8f2d125b6dfcb9a8b766 Reviewed-on: https://gerrit.libreoffice.org/55198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-04-27Fix typosAndrea Gelmini2-2/+2
Change-Id: I32c0966f8489d58f02b32bf205aedbb8303a217d Reviewed-on: https://gerrit.libreoffice.org/53432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke2-2/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-11Use for-range loops in drawinglayer and dtransJulien Nabet2-13/+7
Change-Id: I4d3368e2ffa4d98c04d69b8f5ef485558d812fda Reviewed-on: https://gerrit.libreoffice.org/51047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-01dtrans: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski20-123/+1
Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958 Reviewed-on: https://gerrit.libreoffice.org/48974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann2-2/+2
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19inline some definesNoel Grandin1-2/+1
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2017-12-19Fix typosAndrea Gelmini3-3/+3
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15loplugin:salcall (clang-cl)Stephan Bergmann16-68/+68
Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin2-3/+3
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall (clang-cl)Stephan Bergmann19-131/+131
Change-Id: I31018af8d992c9496f01a72925e24d9b362e340d Reviewed-on: https://gerrit.libreoffice.org/46204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:redundantcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I6d45c262bfa79f00f21e71df25a324263bef0971 Reviewed-on: https://gerrit.libreoffice.org/46198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-07loplugin:salcall handle static methodsNoel Grandin2-2/+2
Change-Id: Id6820abec4b8ca8bee26d62b333fd30b42a14aec Reviewed-on: https://gerrit.libreoffice.org/46007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin2-24/+24
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27loplugin:simplifybool (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Id86ddcbed61df87f8da7a58972387d950d14634d Reviewed-on: https://gerrit.libreoffice.org/45339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-27loplugin:includeform: dtrans (Windows)Stephan Bergmann8-9/+9
Change-Id: I8da9250a64d1be4fe410028676320f5bb38d0176
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski3-7/+10
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski1-1/+1
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01throw more useful uno::Exception'sNoel Grandin1-1/+1
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01loplugin:flatten (clang-cl, dtrans)Stephan Bergmann1-11/+8
Change-Id: I773640d233d5a80cb31dad5a8acff4e04afeedbd Reviewed-on: https://gerrit.libreoffice.org/42976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski5-25/+21
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-27loplugin:unnecessarycatchthrow (clang-cl)Stephan Bergmann1-8/+2
Change-Id: Ie564d16cbd23929cea0e54d38a451b4bfa4fbe84
2017-09-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara991-2/+2
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski3-38/+39
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski14-9/+45
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-16Use more WIN32_LEAN_AND_MEANMike Kaganski1-0/+1
https://msdn.microsoft.com/en-us/aa383745 Change-Id: I83528dc8e6a5e119e7aa816219d35f1ea3723b96 Reviewed-on: https://gerrit.libreoffice.org/42338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-14loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Icd5e625f7c67c45ea3038455514e44c1c9449661
2017-08-31loplugin:constparams: dtrans (clang-cl)Stephan Bergmann6-14/+14
Change-Id: I0a965f6957b74ff5db3aab54bef1fa05f3b594c7
2017-08-29remove some unused macro definitionsNoel Grandin1-2/+0
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0 Reviewed-on: https://gerrit.libreoffice.org/41672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I61b006051e708636f0bba83b16de36f4571b8da7
2017-08-07EditEngine: Removing BIN format for WindowsVarun Dhall1-2/+0
Change-Id: I2caf2323220c076374e89294c26e4976bf1ddbea Reviewed-on: https://gerrit.libreoffice.org/40332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17loplugin:unnecessaryparen: dtrans (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie366a48242d04a888e34ae2c95230ef4de05fbbb
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-28 03:48:51 +0000