summaryrefslogtreecommitdiff
path: root/dtrans
AgeCommit message (Collapse)AuthorFilesLines
2018-04-27Fix typosAndrea Gelmini2-2/+2
Change-Id: I32c0966f8489d58f02b32bf205aedbb8303a217d Reviewed-on: https://gerrit.libreoffice.org/53432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke2-2/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-11Use for-range loops in drawinglayer and dtransJulien Nabet2-13/+7
Change-Id: I4d3368e2ffa4d98c04d69b8f5ef485558d812fda Reviewed-on: https://gerrit.libreoffice.org/51047 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-01dtrans: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski20-123/+1
Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958 Reviewed-on: https://gerrit.libreoffice.org/48974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-23More loplugin:cstylecast on WindowsStephan Bergmann2-2/+2
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after cab0427cadddb3aaf1349c66f2fa13a4234ba4b2 "Enable loplugin:cstylecast for some more cases" and a409d32e7f6fc09e041079d6dbc3c927497adfed "More loplugin:cstylecast" Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862 Reviewed-on: https://gerrit.libreoffice.org/48317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19inline some definesNoel Grandin1-2/+1
which don't add any value anymore Change-Id: I45977d972d4d02926630b749d3ec736416138cf5
2017-12-19Fix typosAndrea Gelmini3-3/+3
Change-Id: Ibffe19c1dfda9d0f4ba8d2a0761ad1222491007f Reviewed-on: https://gerrit.libreoffice.org/46599 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-15loplugin:salcall (clang-cl)Stephan Bergmann16-68/+68
Change-Id: Idda630320bb5e02e1ea675b3b3786c9ec6ac166b Reviewed-on: https://gerrit.libreoffice.org/46504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:salcall fix functionsNoel Grandin2-3/+3
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11loplugin:salcall (clang-cl)Stephan Bergmann19-131/+131
Change-Id: I31018af8d992c9496f01a72925e24d9b362e340d Reviewed-on: https://gerrit.libreoffice.org/46204 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-11loplugin:redundantcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I6d45c262bfa79f00f21e71df25a324263bef0971 Reviewed-on: https://gerrit.libreoffice.org/46198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-07loplugin:salcall handle static methodsNoel Grandin2-2/+2
Change-Id: Id6820abec4b8ca8bee26d62b333fd30b42a14aec Reviewed-on: https://gerrit.libreoffice.org/46007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin2-24/+24
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-27loplugin:simplifybool (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Id86ddcbed61df87f8da7a58972387d950d14634d Reviewed-on: https://gerrit.libreoffice.org/45339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-27loplugin:includeform: dtrans (Windows)Stephan Bergmann8-9/+9
Change-Id: I8da9250a64d1be4fe410028676320f5bb38d0176
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski3-7/+10
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski1-1/+1
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01throw more useful uno::Exception'sNoel Grandin1-1/+1
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01loplugin:flatten (clang-cl, dtrans)Stephan Bergmann1-11/+8
Change-Id: I773640d233d5a80cb31dad5a8acff4e04afeedbd Reviewed-on: https://gerrit.libreoffice.org/42976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski5-25/+21
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-27loplugin:unnecessarycatchthrow (clang-cl)Stephan Bergmann1-8/+2
Change-Id: Ie564d16cbd23929cea0e54d38a451b4bfa4fbe84
2017-09-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara991-2/+2
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski3-38/+39
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski14-9/+45
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-16Use more WIN32_LEAN_AND_MEANMike Kaganski1-0/+1
https://msdn.microsoft.com/en-us/aa383745 Change-Id: I83528dc8e6a5e119e7aa816219d35f1ea3723b96 Reviewed-on: https://gerrit.libreoffice.org/42338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-14loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Icd5e625f7c67c45ea3038455514e44c1c9449661
2017-08-31loplugin:constparams: dtrans (clang-cl)Stephan Bergmann6-14/+14
Change-Id: I0a965f6957b74ff5db3aab54bef1fa05f3b594c7
2017-08-29remove some unused macro definitionsNoel Grandin1-2/+0
Change-Id: I253e5108161b932e3dc588b656e550bb9dc022b0 Reviewed-on: https://gerrit.libreoffice.org/41672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I61b006051e708636f0bba83b16de36f4571b8da7
2017-08-07EditEngine: Removing BIN format for WindowsVarun Dhall1-2/+0
Change-Id: I2caf2323220c076374e89294c26e4976bf1ddbea Reviewed-on: https://gerrit.libreoffice.org/40332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17loplugin:unnecessaryparen: dtrans (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie366a48242d04a888e34ae2c95230ef4de05fbbb
2017-07-05loplugin:casttovoid (clang-cl): dtransStephan Bergmann2-2/+0
Change-Id: Ie58ab849def17157472e6827c84ee51e14c24b7d
2017-07-03loplugin:oncevar (clang-cl): dtransStephan Bergmann2-5/+2
Change-Id: I2ec41f641f3784ef86322c25481e6794e29eb889
2017-06-26Fix typosAndrea Gelmini1-1/+1
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-15EditEngine: Added EditEngine ODF format for WindowsVarun Dhall1-0/+2
Change-Id: I6750295708f2e7a9d73f85df4abbeeb8e5e60a07 Reviewed-on: https://gerrit.libreoffice.org/38716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-29Revert "[API-CHANGE] Add persistent (in addition to persistant)"Stephan Bergmann1-3/+1
This reverts commit 795d56dfd55a78a240cef79c822ba958c4f18006. The Gerrit UI had fooled me into pushing the "Submit" button in error.
2017-05-29[API-CHANGE] Add persistent (in addition to persistant)Julien Nabet1-1/+3
+ keep "persistant" for compatibility reasons but put it as deprecated Change-Id: I7ef8efb9f376eadfdac876d142840aab5a0b4416 Reviewed-on: https://gerrit.libreoffice.org/37042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-05-22Translate German comments and debug strings (leftovers in dirs d...)Johnny_M1-1/+1
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "d". Additionally, one FormatEntry in dtrans/source/win32/ftransl/ftransl.cxx is translated as well. Change-Id: Ia9b3df0210830bd65443883b5f27d56aef811437 Reviewed-on: https://gerrit.libreoffice.org/37600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke7-7/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky6-6/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin1-4/+1
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Revert "tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()"Tor Lillqvist2-10/+0
It worked (for the specific case in the bug report), but for a more generic fix that covers also other similar cases (where VCL code gets called in threads that epoxy doesn't know about, or something), it's better to call epoxy_handle_external_wglMakeCurrent() in vcl, instead of all over the place in thread callbacks. This reverts commit 78c67c6bbba0eaa418c573637858828b274b3c72. Change-Id: Iaad7b3d1191847b9d3f1e74c3339de9f16194aed
2017-04-04tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()Tor Lillqvist2-0/+10
... in SourceContext::fire_dragDropEnd, it seems, because it runs in a thread in its own. Educated guess based on debugging, turned out to work. Change-Id: I084a1af30b1f7e157aafdb2d95866d767fc0f8d6
2017-03-30tdf#39468 Translate German commentsJens Carl3-3/+3
Translate German comments in dtrans/ Change-Id: I8cdae7234e6ffd60e61c3b6b35ae5eee55924ac6 Reviewed-on: https://gerrit.libreoffice.org/35883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-25Fix typosAndrea Gelmini4-5/+5
Change-Id: I85214642167d9c7876fd0fdc2cb7cf8e85765614 Reviewed-on: https://gerrit.libreoffice.org/35627 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-14loplugin:unoany (clang-cl)Stephan Bergmann1-2/+2
Change-Id: Ia5211e7ad27332d4d4cab546d6968e32dfb71523
2017-03-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I6b547a864e7a8c8eeedcd7f7c56796e2b3a606d1 Reviewed-on: https://gerrit.libreoffice.org/34807 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist2-2/+2
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>