summaryrefslogtreecommitdiff
path: root/dtrans
AgeCommit message (Collapse)AuthorFilesLines
2020-06-11cache foreign content in win32 clipboard code (tdf#133267)Luboš Luňák2-0/+13
The slowness in tdf#133267 on Windows is because the Calc operation repeatedly calls ScDocument::IsClipboardSource(), which calls ScModule::GetClipDoc(), which proceeds to fetch the clipboard content, which means fetching it from the system clipboard if it's not owned by LO. Other LO clipboard implementations such as gtk3 or qt5 already do caching, and it seems that it's easy to do for the win32 code. Change-Id: I4696cc7488d66803fd5dd2963d27900957decdec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit fda6ad1458fcd5087c3dde56300b9d0367af6db5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95246 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 9b311cabd908c6bc9e7f7d461ee11eaf0ea6b18c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95749 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11Fix typoAndrea Gelmini1-1/+1
To complete https://gerrit.libreoffice.org/82392 Change-Id: Ieff164b11c66b55280b12940a080a186ce0fba8b Reviewed-on: https://gerrit.libreoffice.org/82408 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-01loplugin:stringconstant (clang-cl)Stephan Bergmann6-6/+6
Change-Id: Id1a82cea4444255fdb693e126b7571a406094624 Reviewed-on: https://gerrit.libreoffice.org/79916 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01loplugin:simplifyconstruct (clang-cl)Stephan Bergmann1-4/+4
Change-Id: I08da288a88c2bce1d4250ec77f17bd483e6bc09c Reviewed-on: https://gerrit.libreoffice.org/79911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-20Fix typosAndrea Gelmini4-4/+4
Change-Id: Iac38284daf0196d6a7f29aaa6e2103c1d76d7cc4 Reviewed-on: https://gerrit.libreoffice.org/77755 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini2-3/+3
Change-Id: I488908096aac319daf30875aee1e46b914cc4759 Reviewed-on: https://gerrit.libreoffice.org/77608 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I207333e9bafc5d6c38ffa53a303046e437b7a815 Reviewed-on: https://gerrit.libreoffice.org/77607 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12Fix typoAndrea Gelmini1-1/+1
"an one" Change-Id: Ic12d139acfdb32aaf0089c60609feaa653fd686b Reviewed-on: https://gerrit.libreoffice.org/77259 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): dtransStephan Bergmann1-1/+1
Change-Id: I8894c9311e2a1dfe5c18a8ec1f0f7fe36ecc79bb Reviewed-on: https://gerrit.libreoffice.org/76683 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-30Fix typoAndrea Gelmini1-3/+3
Change-Id: Ie1d5b87b4d02faac560bf64cb11a31082189e7a5 Reviewed-on: https://gerrit.libreoffice.org/72575 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-07-29Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia12484339eff532112e5de4b9c95d41a61d25574 Reviewed-on: https://gerrit.libreoffice.org/72572 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-24Fix typoAndrea Gelmini1-1/+1
Change-Id: I6632893980c8f71addda60c9bf447ceca962804d Reviewed-on: https://gerrit.libreoffice.org/72691 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-19Fix typoAndrea Gelmini1-7/+7
Change-Id: Ifdb5ca9a9f7b6ee2c1549675da28af35c695e354 Reviewed-on: https://gerrit.libreoffice.org/72574 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-21simplify some getSupportedServiceNamesNoel Grandin2-5/+2
Change-Id: I81195505d6006b6587f7b98c1545919083f0e588 Reviewed-on: https://gerrit.libreoffice.org/74497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-15Fix typoAndrea Gelmini1-1/+1
Change-Id: I0ce4ed9eec22de1f96a42b4b907a753478ca9805 Reviewed-on: https://gerrit.libreoffice.org/74079 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21Fix typoAndrea Gelmini1-1/+1
Change-Id: I282902c410ab93017b3aea46f88f60c246ca9894 Reviewed-on: https://gerrit.libreoffice.org/72629 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21Fix typoAndrea Gelmini1-2/+2
Change-Id: I828c0529ae935ed6076f8c5f2dc93df04c38d81f Reviewed-on: https://gerrit.libreoffice.org/72630 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21Fix typoAndrea Gelmini1-1/+1
Change-Id: If3601066764ca33fd5321e318af6fee0501199e5 Reviewed-on: https://gerrit.libreoffice.org/72631 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-21Fix typoAndrea Gelmini1-1/+1
Change-Id: If25ae724fcac4bf9475eca506194593a7a5fdeab Reviewed-on: https://gerrit.libreoffice.org/72628 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-3/+3
Change-Id: I6addc8273cbf46d047e2df4aa27dff11a8666bce Reviewed-on: https://gerrit.libreoffice.org/72569 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-2/+2
Change-Id: I5fce4297a8172889e4a609da1f99e5e9cba371bb Reviewed-on: https://gerrit.libreoffice.org/72573 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-2/+2
Change-Id: Ifd8b571d2331e3b11b38ee40fd2bc39de5e8d64c Reviewed-on: https://gerrit.libreoffice.org/72576 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-7/+7
Change-Id: Ie0d2c0cde9c1fb58a63e8ef5331bdcb5126aaf28 Reviewed-on: https://gerrit.libreoffice.org/72577 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-1/+1
Change-Id: Idc7a1e11b2d2e0e2383d742bf144e29ad0332269 Reviewed-on: https://gerrit.libreoffice.org/72540 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I23bd7912a38845a050ef34cbd0efd17a028ef109 Reviewed-on: https://gerrit.libreoffice.org/72538 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-1/+1
Change-Id: I931e9aaf623a1b405054df4aebe1d2e1b591f212 Reviewed-on: https://gerrit.libreoffice.org/72537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-19Fix typoAndrea Gelmini1-2/+2
Change-Id: I57ddee21cb31c06b47eaf30010fa7378401a2f17 Reviewed-on: https://gerrit.libreoffice.org/72541 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski2-23/+22
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-04Drop UNICODE/_UNICODE definesMike Kaganski1-5/+0
The code is using expicit (mostly W) Windows API, and is independent from the macro. Removing it here allows to catch places where some UNICODE-dependent macro is used unintentionally. Change-Id: I5dff40aecfc3c3dc7fc4cf7271a995a675943a45 Reviewed-on: https://gerrit.libreoffice.org/70237 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-01IShellLinkA -> IShellLinkWMike Kaganski1-7/+5
Change-Id: If07d7e0d2a3a33f0bcc96352ea40ff83a2f483ed Reviewed-on: https://gerrit.libreoffice.org/70062 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#120703 PVS: remove redundant static castsMike Kaganski3-6/+5
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c Reviewed-on: https://gerrit.libreoffice.org/69989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-27loplugin:typedefparam (clang-cl)Stephan Bergmann7-53/+53
Change-Id: I07604028845c49cc084927e21db7f21c5d053bab Reviewed-on: https://gerrit.libreoffice.org/69796 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-20Simplify containers iterations in desktop, dtrans, editeng, extensionsArkadiy Illarionov3-65/+38
Use range-based loop or replace with STL functions Change-Id: Ic5389d123d0a6a32a8bb46b081165e94a7c55292 Reviewed-on: https://gerrit.libreoffice.org/68036 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10Win64 fixes for dtrans.Damjan Jovanovic2-9/+9
Patch by: me (cherry picked from commit 7595a809d2a4aea9299633546ca95f709133dee8) Change-Id: I59a561aad16073fec1567e1873842a2b11dff4df Reviewed-on: https://gerrit.libreoffice.org/67594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05Cleanup event properly; handle error from MsgWaitForMultipleObjectsMike Kaganski1-0/+10
Commit 11a2809e369b2a6fcbb2d7f0db131a945557c6e2 follow-up Change-Id: Id70a95f46655ade3b867e0377ddd5bee13993187 Reviewed-on: https://gerrit.libreoffice.org/67402 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-05tdf#122435: reimplement fix for tdf#109085Mike Kaganski2-13/+90
This reverts commit 3d8c159841bcab7365b2bed3df71ed3c15188312, and instead, checks if the MtaOleReq window is not destroyed yet, in addition to the wait for the condition. This allows to avoid wait forever for condition which never gets signalled, and process the sent messages when waiting. The window's WM_DESTROY handler sets the event signalling that. The Win32Condition's wait() is changed to take the abort event, and return true if its own event fired, and false if abort event fired. Change-Id: I1861dd3dabb39329976a3ccf2a5392c9ddbf9613 Reviewed-on: https://gerrit.libreoffice.org/67383 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-01-30loplugin:redundantfcast (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I814e7b61ebbef1a0bbd38a5e70beeb7f99a0cfa1 Reviewed-on: https://gerrit.libreoffice.org/67146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-30-Werror,-Wunused-const-variable (clang-cl)Stephan Bergmann1-1/+0
Change-Id: I3a1ebc4cc4cadd3b4a69b772addbb51eace84e27 Reviewed-on: https://gerrit.libreoffice.org/67142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-30loplugin:redundantinline (clang-cl)Stephan Bergmann3-7/+1
Change-Id: Ib6320ddc049e93cca4c5931ad28d1873d34bd8b4 Reviewed-on: https://gerrit.libreoffice.org/67137 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16Fix typosAndrea Gelmini2-2/+2
Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-05Win: implement Clipboard Format Listener instead of obsolete ViewerMike Kaganski2-61/+10
https://docs.microsoft.com/en-us/windows/desktop/dataxchg/using-the-clipboard discusses the techniques to monitor clipboard contents on Windows, and recommends Clipboard Format Listener for Vista+. https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-setclipboardviewer further mentions that using the current "Clipboard Viewer Window" approach, "The clipboard viewer chain can be broken by an application that fails to handle the clipboard chain messages properly". This change reimplements our listener to use recommended way; this should make our clipboard handling more robust, avoiding the need to handle the chain with other applications' windows. Change-Id: Ib33b27a57d7a6af2ab7e3e59d030aa55329694f9 Reviewed-on: https://gerrit.libreoffice.org/62909 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#109085: don't assume MtaOleReq window is still valid at shutdownMike Kaganski1-95/+5
The window can be destroyed by e.g. WM_QUERYENDSESSION/WM_ENDSESSION sequence, and then the message MSG_REGCLIPVIEWER handler would not run and the condition would never be set. Since we need to wait for the message processed, let's just use sendMessage which would return only after the message has been processed anyway, and also will return immediately on failure (e.g., window handle invalid). Also this changes other cases where postMessage + wait pattern was used, and removes the condition from MsgContext. Change-Id: Ic12deafbaedd1cc99b9d6145650d99069c618f0e Reviewed-on: https://gerrit.libreoffice.org/62881 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin1-2/+2
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-28tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl1-1/+1
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Remove unnecessary mutexStephan Bergmann2-7/+0
CMimeContentType::m_ParameterMap isn't modified after construction Change-Id: Ib3dbfbd4212ed0d7e8a9f29c655f935d3fc4f1bf Reviewed-on: https://gerrit.libreoffice.org/61698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-12Remove undefined member function declarationsStephan Bergmann1-12/+0
...that had accidentally not been removed along with the definitions in b75e3ded1f73c943fb09f117e476e367ac0c3413 "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" Change-Id: If94c0c413b891480c12a098c7b15caa1422213b0 Reviewed-on: https://gerrit.libreoffice.org/61697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11tdf#120158: Base CMimeContentType on INetMIME::scanContentTypeStephan Bergmann3-255/+19
...instead of using yet another local implementation of parsing media types. CMimeContentType is the implementation of the UNO css.datatransfer.XMimeContentType interface. One observable change in behavior is that type, subtype, and parameter names will now always be reported in lower case instead of with the casing from the input preserved (but those differences in casing are functionally equivalent per the media type specification). Also, parameter names supplied to the hasParameter and getParameterValue functions are now also treated case-insensitive. The upside of this change is that INetMIME::scanContentType (via "The encoding of rMediaType should be US-ASCII, but any Unicode values in the range U+0080.. U+FFFF are interpreted 'as appropriate.'") already implicitly supports RFC 6532 "Internationalized Email Headers" extensions for media types, allowing quoted- string parameter values to contain non-ASCII Unicode characters. That means that tfd#120158 "Impossible to paste special in Writer from Calc in Libreoffice 6.1.x in some UI languages - the dialogue caption says 'unknown source'" can be fixed by just allowing non-ASCII typename parameters being generated in ImplGetParameterString in svtools/source/misc/transfer.cxx, and reverting the problematic (see the comments there) previous fix <https://gerrit.libreoffice.org/61601> "tdf#120158: fix ImplGetParameterString for typename". (Which will be done in a follow-up commit, to ease potential backporting, as that previous fix has already been backported to some versions but not to others.) Change-Id: I5d4d3586e8046f288a97605b000e262a8db5a4e9 Reviewed-on: https://gerrit.libreoffice.org/61684 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11Drop duplicate WINVER and _WIN32_WINNT definesJan-Marek Glogowski1-4/+0
Just keep the definition of _WIN32_WINNT in windows.mk, which claims it automatically derivates WINVER in some sdk header. Change-Id: I0a83e91ffdc9e0fc847433a92a45424fbfcb189c Reviewed-on: https://gerrit.libreoffice.org/61631 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-10Properly check HRESULTMike Kaganski1-1/+1
Although the IEnumFORMATETC::Next documentation only mentions S_OK and S_FALSE, there are error codes that also may be returned: e.g., 0x800706BA RPC server unavailable (encountered locally in a unit test). In that case, this used to loop infinitely. We are only interested in S_OK result, so check for it. Change-Id: I062e409e84efb68353321f7c48d922ec83191f73 Reviewed-on: https://gerrit.libreoffice.org/61621 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-09-24loplugin:external (clang-cl)Stephan Bergmann5-13/+13
Including: * expanding STDAPI to its definition (as per <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at <https://gerrit.libreoffice.org/#/c/60691/> "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place? * follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 12:12:28 +0000