summaryrefslogtreecommitdiff
path: root/dtrans/source
AgeCommit message (Collapse)AuthorFilesLines
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski3-7/+10
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-03Replace more reinterpret_cast with SAL_W/SAL_UMike Kaganski1-1/+1
Change-Id: Ia632e4083222ad9e7f17c2ad0d0825f189c700cc Reviewed-on: https://gerrit.libreoffice.org/43071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-01throw more useful uno::Exception'sNoel Grandin1-1/+1
if we're going to throw the base class of the exception hierarchy, we can at least put a useful message in there to make the source a little bit easier to locate. Change-Id: I2f3106c99ba25125eacef8fa77e2f3a2c89f2566 Reviewed-on: https://gerrit.libreoffice.org/42968 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-01loplugin:flatten (clang-cl, dtrans)Stephan Bergmann1-11/+8
Change-Id: I773640d233d5a80cb31dad5a8acff4e04afeedbd Reviewed-on: https://gerrit.libreoffice.org/42976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-30Use explicit function names for fooA/fooW WinAPI; prefer fooWMike Kaganski5-25/+21
We should only use generic foo function name when it takes params that are also dependent on UNICODE define, like LoadCursor( nullptr, IDC_ARROW ) where IDC_ARROW is defined in MSVC headers synchronised with LoadCursor definition. We should always use Unicode API for any file paths operations, because otherwise we will get "?" for any character in path that is not in current non-unicode codepage, which will result in failed file operations. Change-Id: I3a7f453ca0f893002d8a9764318919709fd8b633 Reviewed-on: https://gerrit.libreoffice.org/42935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-27loplugin:unnecessarycatchthrow (clang-cl)Stephan Bergmann1-8/+2
Change-Id: Ie564d16cbd23929cea0e54d38a451b4bfa4fbe84
2017-09-25Fix typosAndrea Gelmini1-1/+1
Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-24tdf#96505 Get rid of cargo cult "long" integer literals66kesara991-2/+2
Remove unnecessary "Long" literals in multiple locations Change-Id: Icc44546f10fed841683053eee01b788274e0add1 Reviewed-on: https://gerrit.libreoffice.org/42683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22Windows: avoid dependence on UNICODE define; prefer W functionsMike Kaganski2-23/+25
Change-Id: I95b90128e93f0d88ed73601bcc5a7ca9279d4cf1 Reviewed-on: https://gerrit.libreoffice.org/42560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18Some more WIN32_LEAN_AND_MEANMike Kaganski14-9/+45
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874 Reviewed-on: https://gerrit.libreoffice.org/42419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-16Use more WIN32_LEAN_AND_MEANMike Kaganski1-0/+1
https://msdn.microsoft.com/en-us/aa383745 Change-Id: I83528dc8e6a5e119e7aa816219d35f1ea3723b96 Reviewed-on: https://gerrit.libreoffice.org/42338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-14loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Icd5e625f7c67c45ea3038455514e44c1c9449661
2017-08-31loplugin:constparams: dtrans (clang-cl)Stephan Bergmann6-14/+14
Change-Id: I0a965f6957b74ff5db3aab54bef1fa05f3b594c7
2017-08-22loplugin:unnecessaryparen (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I61b006051e708636f0bba83b16de36f4571b8da7
2017-08-07EditEngine: Removing BIN format for WindowsVarun Dhall1-2/+0
Change-Id: I2caf2323220c076374e89294c26e4976bf1ddbea Reviewed-on: https://gerrit.libreoffice.org/40332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-07-17loplugin:unnecessaryparen: dtrans (clang-cl)Stephan Bergmann1-1/+1
Change-Id: Ie366a48242d04a888e34ae2c95230ef4de05fbbb
2017-07-05loplugin:casttovoid (clang-cl): dtransStephan Bergmann2-2/+0
Change-Id: Ie58ab849def17157472e6827c84ee51e14c24b7d
2017-07-03loplugin:oncevar (clang-cl): dtransStephan Bergmann2-5/+2
Change-Id: I2ec41f641f3784ef86322c25481e6794e29eb889
2017-06-26Fix typosAndrea Gelmini1-1/+1
Change-Id: I2ce725f87ee6f8ebcffbac268cc7e7f8850023e5 Reviewed-on: https://gerrit.libreoffice.org/39232 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-15EditEngine: Added EditEngine ODF format for WindowsVarun Dhall1-0/+2
Change-Id: I6750295708f2e7a9d73f85df4abbeeb8e5e60a07 Reviewed-on: https://gerrit.libreoffice.org/38716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-29Revert "[API-CHANGE] Add persistent (in addition to persistant)"Stephan Bergmann1-3/+1
This reverts commit 795d56dfd55a78a240cef79c822ba958c4f18006. The Gerrit UI had fooled me into pushing the "Submit" button in error.
2017-05-29[API-CHANGE] Add persistent (in addition to persistant)Julien Nabet1-1/+3
+ keep "persistant" for compatibility reasons but put it as deprecated Change-Id: I7ef8efb9f376eadfdac876d142840aab5a0b4416 Reviewed-on: https://gerrit.libreoffice.org/37042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-05-22Translate German comments and debug strings (leftovers in dirs d...)Johnny_M1-1/+1
Translates all (leftovers) found using a custom regex, in directories not shown by /bin/find-german-comments and beginning with "d". Additionally, one FormatEntry in dtrans/source/win32/ftransl/ftransl.cxx is translated as well. Change-Id: Ia9b3df0210830bd65443883b5f27d56aef811437 Reviewed-on: https://gerrit.libreoffice.org/37600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke7-7/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini1-1/+1
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky1-1/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin1-4/+1
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-04Revert "tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()"Tor Lillqvist1-5/+0
It worked (for the specific case in the bug report), but for a more generic fix that covers also other similar cases (where VCL code gets called in threads that epoxy doesn't know about, or something), it's better to call epoxy_handle_external_wglMakeCurrent() in vcl, instead of all over the place in thread callbacks. This reverts commit 78c67c6bbba0eaa418c573637858828b274b3c72. Change-Id: Iaad7b3d1191847b9d3f1e74c3339de9f16194aed
2017-04-04tdf#105162: Need to call epoxy_handle_external_wglMakeCurrent()Tor Lillqvist1-0/+5
... in SourceContext::fire_dragDropEnd, it seems, because it runs in a thread in its own. Educated guess based on debugging, turned out to work. Change-Id: I084a1af30b1f7e157aafdb2d95866d767fc0f8d6
2017-03-30tdf#39468 Translate German commentsJens Carl3-3/+3
Translate German comments in dtrans/ Change-Id: I8cdae7234e6ffd60e61c3b6b35ae5eee55924ac6 Reviewed-on: https://gerrit.libreoffice.org/35883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-25Fix typosAndrea Gelmini4-5/+5
Change-Id: I85214642167d9c7876fd0fdc2cb7cf8e85765614 Reviewed-on: https://gerrit.libreoffice.org/35627 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-14loplugin:unoany (clang-cl)Stephan Bergmann1-2/+2
Change-Id: Ia5211e7ad27332d4d4cab546d6968e32dfb71523
2017-03-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I6b547a864e7a8c8eeedcd7f7c56796e2b3a606d1 Reviewed-on: https://gerrit.libreoffice.org/34807 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-17Drop :: prefix from std in [de]*/Tor Lillqvist2-2/+2
Change-Id: I3247894fe022dce7f0aa351bd85fefcd7c545dd4 Reviewed-on: https://gerrit.libreoffice.org/34377 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-02-10Remove MinGW supportStephan Bergmann7-116/+0
In OOo times, there'd originally been efforts to allow building on Windows with MinGW. Later, in LO times, this has been shifted to an attempt of cross- compiling for Windows on Linux. That attempt can be considered abandoned, and the relevant code rotting. Due to this heritage, there are now three kinds of MinGW-specific code in LO: * Code from the original OOo native Windows effort that is no longer relevant for the LO cross-compilation effort, but has never been removed properly. * Code from the original OOo native Windows effort that is re-purposed for the LO cross-compilation effort. * Code that has been added specifially for the LO cross-compilation effort. All three kinds of code are removed. (An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing --with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.) Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568 Reviewed-on: https://gerrit.libreoffice.org/34127 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08Add missing #includesStephan Bergmann5-0/+11
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-06Add missing #includesStephan Bergmann1-0/+4
...and remove some unncessary using directives/declarations, in preparation of removing now-unnecessary #includes from cppumaker-generated files, post e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications". Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
2017-02-01loplugin:stringconstantStephan Bergmann1-1/+1
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
2017-01-26Remove dynamic exception specificationsStephan Bergmann27-233/+119
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-19New loplugin:dynexcspec: Add @throws documentation, dtransStephan Bergmann1-0/+1
Change-Id: Id1249957a544e7ab43d0f331190db72871723f40
2017-01-11loplugin:externvar (clang-cl)Stephan Bergmann3-3/+9
Change-Id: I7219f2e720b7c1581c59cefe39e152c5aa20a8fe
2017-01-09tdf#101828 handle rtf/richtext correctlyOliver Specht1-1/+3
Change-Id: Id894f62a918bd6e6fa59f8d546307343bf2bd4b0 Reviewed-on: https://gerrit.libreoffice.org/32682 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-12-30cleanup tailing backslashesJochen Nitschke2-5/+5
Change-Id: Idb4bfc97e7d758c58118742affd9a9345c7a99f2 Reviewed-on: https://gerrit.libreoffice.org/32491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07Fix typo in comments: et -> edTakeshi Abe1-1/+1
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
2016-11-24tdf#103852 avoid clipboard deadlockTomaž Vajngerl2-1/+35
Deallocate the XTransferable object async using AsyncCallback (that uses Application::PostUserEvent) which executes the callback in a thread-safe way on the main thread. This avoids a deadlock at deallocation so that the XTransferable. Modify AsyncCallback to not hold the SolarMutexGuard because Application::PostUserEvent is considered thread-safe. Document Application::PostUserEvent thread-safety Change-Id: I4237a1cf380e8be66b3eefc393a58bb4853bf4e1 Reviewed-on: https://gerrit.libreoffice.org/31126 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke1-1/+1
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-23Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-16clang-cl loplugin: dtransStephan Bergmann46-1002/+962
Change-Id: I1d55f3e7ecbde486f318d5175b1570f0caa33255 Reviewed-on: https://gerrit.libreoffice.org/29870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist15-124/+9
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-07-14dtrans: remove commented-out codeThorsten Behrens1-108/+0
This was disabled since f87fd75f68148b9b5ddff7f62ce12c5ec1d7757a INTEGRATION: CWS dtransfix (1.11.136) Change-Id: Ica132a8b5ed13f5b70944c48e2ec5f6fdd88159e
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-17 09:23:35 +0000