summaryrefslogtreecommitdiff
path: root/drawinglayer
AgeCommit message (Collapse)AuthorFilesLines
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock1-2/+2
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-09Remove excess newlinesChris Sherlock106-230/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08Fix typosAndrea Gelmini1-1/+1
Change-Id: I4586168d3af81f047a4ded59fc6d257f17554885 Reviewed-on: https://gerrit.libreoffice.org/22194 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-02-08loplugin:unusedmethodsNoel Grandin2-42/+0
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-06vcl: bmpacc.hxx -> bitmapaccess.hxxChris Sherlock3-3/+3
Change-Id: I4bb19d6103c4a6a902d86b62a857e3478493924c
2016-02-06vcl: split exception types from input typesChris Sherlock1-6/+4
Having them in the file apptypes.hxx isn't necessary helpful, IMO so I've split the types into inputtypes.hxx and exceptiontypes.hxx Change-Id: I89a1ff168c3ae276b2f5486669d4ec2dda062d57
2016-02-05Fix typosAndrea Gelmini1-1/+1
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3 Reviewed-on: https://gerrit.libreoffice.org/21797 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock4-15/+15
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-02remove B2DLineJoin::MiddleCaolán McNamara2-5/+3
and consistently map css::drawing::LineJoint_MIDDLE to the same thing that css::drawing::LineJoint_MITRE points to everywhere else Change-Id: I77b7586ea13f3fe84c0529172758256666488d36
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock3-51/+51
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29tdf#91017 Enhance WMF import of EMR_ALPHABLEND actionArmin Le Grand1-3/+37
The EMR_ALPHABLEND action was added 2012/2013, but missed support for Bitmaps with Mask/Alpha. Due to that files with WMF containing these actions may look different from before. Added suport to load contained Mask/Alpha information in DIBs and the needed additional processing through the display chain. WMF import is still based on Metafile creation, when it would be using Primitives more original data could be preserved. Change-Id: I577569848cee2528328181fa0c7eb7f87857d094 Reviewed-on: https://gerrit.libreoffice.org/21709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock2-7/+7
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-26Bin some unneeded 'using' and includesTor Lillqvist1-16/+0
Change-Id: Ia91b3837ce39ae48e8c660274a08415ee4f9e5c7
2016-01-17vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock1-1/+1
Change-Id: Ie20871a3078bf875c1782b7761d60591a9c9704f Reviewed-on: https://gerrit.libreoffice.org/21529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-16revert vcl patch series that brok Mac and WindowsNorbert Thiebaud1-1/+1
revert: 9bc2f3de8672e812f3a67541c6d7069b434a7e42 vcl: add comment about ImplFontMetric::{Get|Set}LineHeight() 26371f105bc44e04469ec03fc5bb12505e651c6b vcl: FontAttributes::GetSlantType() -> FontAttributes::GetItalic() 2dd0b4317372b8022efe3911b38b4fa02956d8b9 vcl: font.hxx and metric.hxx cleanup, make ctors explicit and the dtor virtual 5ab13bf3ead3539e4ad847656da81e7eb6029652 vcl: tabify font.hxx f99550dae55e40e49bf9c9875053fe2abb4c71ca vcl: change Font::SetName() to Font::SetFamilyName() 2b297116cb6bb1061c43e5714e2609c8ee9f57d2 vcl: rename Font::GetName to Font::GetFamilyName Change-Id: I23f38921187d66b970ca815eb30dda4222a2da62
2016-01-16vcl: rename Font::GetName to Font::GetFamilyNameChris Sherlock1-1/+1
Change-Id: I83927e0992dfe0a2a79d139818a9f45d3761aae5 Reviewed-on: https://gerrit.libreoffice.org/21509 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-15svx: remove now unused SdrModel::isTiledRendering()Miklos Vajna1-7/+4
Change-Id: I8d3c6b1de2db57e39678a7e57de6e015c72719ec
2016-01-13vcl: Create accessor and mutator for int and ext leading in FontMetricChris Sherlock1-3/+3
Accessor and mutator created for external and internal leading space in FontMetric. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit tests - check to ensure that can set external and leading space - check equality operator on FontMetric after setting both external and internal leading space - enhanced tests to also check the inequality operator Change-Id: I973970dd0b0631c5eca3e89039dce57ac3a3eb63 Reviewed-on: https://gerrit.libreoffice.org/21454 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-11loplugin:privatebase: Make derivation from noncopyable explicitly privateStephan Bergmann1-3/+3
Change-Id: Ia410950353aec0106ea82d025ed3ee89c79ca127
2016-01-10Fix typosAndrea Gelmini9-13/+13
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-23tdf#96541 - dialog "About LibreOfficeDev" has lost its logoNoel Grandin1-3/+4
regression from 58d8d8a "tdf#69977: uno::Sequence is expensive" Change-Id: I792b5971a7a3a9532cccb36add5b558c68e397ef
2015-12-21loplugin:unusedmethodsNoel Grandin2-93/+0
Change-Id: Ifafdaf6da0225f244853a0042a6458643b570623
2015-12-15Missing includeStephan Bergmann1-0/+4
Change-Id: Iac9006292bfdb1b56e213346188245a205146803
2015-12-15loplugin:unreffunStephan Bergmann1-34/+0
Change-Id: Ic741021b18b4064cb74786fc3d40fadf8eb85ab7
2015-12-15Correct claim made in commentTor Lillqvist1-0/+1
Change-Id: I7adccb1833ad2823ec7fa85f06752614d38639f9
2015-12-15use vector as container for Primitive3DReferenceNoel Grandin23-178/+226
rather than uno::Sequence, since we modify this container a lot and uno::Sequence is expensive to update Change-Id: Id5bc5171cbc4b90b243e6dda6d572f21b3bdf00d
2015-12-15create a move append method for Primitive2DContainerNoel Grandin1-7/+8
since it is fairly common to append temporaries. Change-Id: I920daf8539e42fc9fe313af48fdb34ee4aaf908d Reviewed-on: https://gerrit.libreoffice.org/20637 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-12-14drawinglayer: remove comment that no longer makes senseMiklos Vajna1-1/+0
It referred to the previouly removed Primitive2DContainerToPrimitive2DSequence(), not to maybeInvert(). Change-Id: I77dad2218d5b3e2e2d76673bd2e97d856d0b94f2
2015-12-11loplugin:unreffunNoel Grandin1-35/+0
fallout from 58d8d8ac67aa9b907f1304a48efa0f7a473d9de4 "tdf#69977: uno::Sequence is expensive" Change-Id: Ib55de090c72dcfd8ad049746b693b383e70e8ca9
2015-12-11tdf#69977: uno::Sequence is expensiveNoel Grandin60-436/+526
when used as a mutable data-structure. Plain std::vector halves the time taken to display the chart dialog Create a class to represent the std::vector we are going to be passing around, and move some of the utility methods into it to make the code prettier. Also create an optimised append(&&) method for the common case of appending small temporaries. Change-Id: I7f5b43fb4a8a84e40e6a52fcb7e9f974091b4485
2015-11-27Missing includesStephan Bergmann1-0/+6
Change-Id: I4cefabc51c00b0e6ffd0613c4409cc31e1aa5673
2015-11-27Resolves: rhbz#1283426 using vdevs based on now dead physical devs is unsafeCaolán McNamara1-5/+28
This is the same problem that commit 133e04fc1a870c0aad207e82eefeeeceaba5dc6d Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 17 09:23:32 2015 +0100 Resolves: tdf#91880 Invalidate graphics when the gtk window is destroyed not just when the GtkSalFrame is dtored tried to fix, but that just made it more unlikely to fail Change-Id: Icba750c787adb6cd5c5ed0874ef07e6201c4cf25
2015-11-25vcl: improve scheduler debugging information.Michael Meeks1-1/+2
Change-Id: I6f7d7d3b5b027097417a15804a42aaaab4a03158 Reviewed-on: https://gerrit.libreoffice.org/20185 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-23VirtualDevices either match another device depth, or are 1 bitCaolán McNamara1-1/+1
cairo can therefore always render to a svp virtual device with need for a fallback Change-Id: I5d03ae541820389e26f7448444444be009fb28a4
2015-11-23establish that Virtual Devices either match Physical Device depth or ...Caolán McNamara2-11/+11
are 1 or (rarely) 8 bit and lock that down. Change-Id: I3d946ebef34ffb71c5adea7aa420af50e9584e05
2015-11-17other #includes should be AFTER the include-once #defineNoel Grandin1-3/+2
found with the following script: git ls-files *.hxx | xargs perl -0777 -ne 'if (/include.* .* .* "; close ARGV }' Change-Id: I3afb0e81eb315c34bc0eb6bb4733dd1f0537d5c0
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian1-89/+146
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-12Namespace cleanup and disambiguationAshod Nakashian2-10/+10
Change-Id: Ib6d2f8b4e71436c3a7c26bdfc9847152ebaf0739 Reviewed-on: https://gerrit.libreoffice.org/19900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann21-58/+58
Change-Id: I3aa15efd12b8c9b20319a1975dbbd541783aea2d
2015-11-09new loplugin: oncevarNoel Grandin1-3/+1
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-05Reduce scope of #include <tools/poly.hxx>Matteo Casalin1-0/+1
Change-Id: I0d64393c029d27c8e6f3b6d360d2509dad16d860
2015-10-25tdf#39440: fix several warnings reported by cppcheckSerge Krot2-4/+4
Change-Id: I560d28b7cc67740c6479494d0e5aa62d2ac6ffae Reviewed-on: https://gerrit.libreoffice.org/19587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-10-20loplugin:defaultparamsStephan Bergmann2-6/+2
Change-Id: Ice8e3800bab22c08daefe41eae1be706f15c004c
2015-10-13remove some useless commentsNoel Grandin1-41/+0
found with git grep '// /' Change-Id: I948cf9ae61bbbf2ec706ca5b0572c4f27c58c745
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann7-10/+10
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Reduce scope of fTexStart/Stop even furtherStephan Bergmann1-3/+6
...than 92c8d74c543aa94cd512369072975dca7006d5b3 "CppCheck : reduce variables scope" did, to make it clear that it is OK to move these into the for loop: the values these variables receive (when bCreateTextureCoordinates is true) are only relevant for each immediately following call to impAddInBetweenFill, and are only actually used inside impAddInBetweenFill when bCreateTextureCoordinates (which is also passed into the call) is true. Change-Id: Ib9e315d80a04736fb6b49144c8f09239ac351c7f
2015-10-12fTexHeightPos shall be incremented across loop iterationsStephan Bergmann1-1/+1
Regression introduced with 92c8d74c543aa94cd512369072975dca7006d5b3 "CppCheck : reduce variables scope," found by clang-analyzer-deadcode.DeadStores. Change-Id: I3758a9827d4d242d4fd57af7bbb77decf2d0f327
2015-10-06Fix typosAndrea Gelmini6-12/+12
Change-Id: Ia6246bb6d37a0ec1ac53a4cb095bfd6fd15f873d Reviewed-on: https://gerrit.libreoffice.org/18945 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-10-02svx, drawinglayer: handle tools Color <-> BackgroundColorPrimitive2D roundtripMiklos Vajna1-1/+3
Change-Id: Ia8c080ef50e1ddbfce17b5c5d357a240edea46f2
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 13:27:00 +0000