summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2016-09-13tdf#74377 Keyboard shortcuts for context menusMaxim Monastirsky1-0/+1
Configurable through the options dialog. The default behavior depends on the current vclplug (hide for gtk2/3 and OS X, show otherwise). Menus currently affected by this change: - SfxDispatcher based context menus - chart2 context menus - vcl's Edit control context menu - Several MenuBarManager based toolbar dropdowns. Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d Reviewed-on: https://gerrit.libreoffice.org/28849 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-13loplugin:dllprivateStephan Bergmann3-21/+21
Change-Id: I1fe70a39c50aba8b84c117653185fc37dbbfeab0
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann40-57/+57
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-11LOK: we use callbacks latch for not missing messages sent very earlyMarco Cecchetti1-1/+18
- lok::Document::setCallbackLatch: used on document load for set/unset the latch - now cell cursors of other views are correctly notified to the new view Change-Id: Ife6dca0e3e329b801d44070f55869afe95a2f313 Reviewed-on: https://gerrit.libreoffice.org/28812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-09-10LOK: new callback dropping implementationMarco Cecchetti2-34/+168
Now view callbacks have their own collection of last states where the key is made up by both the view id and the callback type. Callback dropping based on the last state is no more handled on queueing but on flushing, since what really matters is the last performed callback (for each callback type). Anyway in order to not modify the order of callbacks, that could be changed when an already queued callback is superseeded, dropping still occurs on queuing too, just by looking for the last queued callback of the same type. The result is a substantial reduction of redundant callbacks and fix the following problem in loleaflet: when there are more views for a speadsheet and cell cursors for two view are placed on the same cell, a continuos swapping between the two cell cursors can occur. That was due to a sequence of "EMPTY" and coordinates messages or cell cursor and cell view cursor messages which were sent in an alternating way. Change-Id: I79e14d11d4e8590aff715181e3410ad88c4e6175 Reviewed-on: https://gerrit.libreoffice.org/28783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-09-10LOK: tidy up `CallbackFlushHandler::queue`, improved cell view cursorMarco Cecchetti2-79/+108
Rewritten the switch statement in `CallbackFlushHandler::queue`: - Now, the new callback data is emplaced after removing all states overridden by the new one. - View callbacks are checked not only for the same type but even for the same view id: that allowed to fix the following issue: starting from the 3rd view for a spreadsheet it could occur that only the cell cursor of the previous last view was displayed in the new view. Change-Id: I2b63526deb4dca39e3a1f430443ebc5d0f61938d Reviewed-on: https://gerrit.libreoffice.org/28782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-09-09loplugin:constantparam in svtoolsNoel Grandin1-1/+1
Change-Id: I04caae0c9ae621c55e16d3bdc014a4729617feb3 Reviewed-on: https://gerrit.libreoffice.org/28757 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-05convert ScrollType to scoped enumNoel Grandin1-1/+1
Change-Id: I6dd02d4f7df028dada6cfd5d767a6ec1b1c1efe1
2016-09-01sfx2: nullptr pViewShell was seen in SfxLokHelper::getView()Miklos Vajna1-4/+15
I'm not sure how to trigger this reliably, but Pranav got this: #0 0x00007fb2f471bbf0 in SfxLokHelper::getView(SfxViewShell*) (pViewShell=0x0) at sfx2/source/view/lokhelper.cxx:82 #1 0x00007fb2f75edf4f in doc_paintPartTile(LibreOfficeKitDocument*, unsigned char*, int, int, int, int, int, int, int) (pThis=0x7fb290253c40, pBuffer=0x281fbd0 "", nPart=0, nCanvasWidth=1024, nCanvasHeight=256, nTilePosX=0, nTilePosY=11520, nTileWidth=15360, nTileHeight=3840) at desktop/source/lib/init.cxx:1338 Given that SfxViewShell::Current() may indeed return nullptr (e.g. during shutdown), change SfxLokHelper::getView() to return -1 in that case, and adapt client code to handle that. Change-Id: Ia191c843c8a993f3d7157de432af57964c0a8f63 Reviewed-on: https://gerrit.libreoffice.org/28583 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-31desktop: fix Android buildMiklos Vajna1-0/+13
to_string() is missing in the std namespace on the broken Android toolchain, work it around. Change-Id: I77fd06f869291e04c265b6b6d38b2e60b0d48caf
2016-08-31LOK: queue-up events while processing client callsAshod Nakashian2-23/+65
To prevent feedback effects and improve performance, we now queue up events fired during the processing of a client call on the LOK API. This has the advantage of giving us a chance to compress redundant events and to combine others (where possible) into fewer ones. Change-Id: I2f6ea12c5d85205e6495cb130f6a6262534b6bb2 Reviewed-on: https://gerrit.libreoffice.org/28311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-08-30sc lok: implement getCommandValues(.uno:AcceptTrackedChanges) APIMiklos Vajna2-30/+73
Unlike in Writer, there doesn't seem to be an existing UNO API that can be reused here. Change-Id: I011a2f34d4d09ad604991637322ceadf6b2eb181 Reviewed-on: https://gerrit.libreoffice.org/28498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-30loplugin:stringconstant: adapt to improved OUStringLiteral1 (desktop)Stephan Bergmann1-1/+1
Change-Id: Icdfcdb168d5570e37818bf866e2b4296c02824be
2016-08-30No reason why these functions can't be static, tooTor Lillqvist1-14/+14
Change-Id: I95b68e912c87657a6884f8c56bfcc7bc52c2f2e5
2016-08-27put StreamMode masks in scope of enum classJochen Nitschke1-1/+1
Change-Id: I77682f7e289a59b986bb84edf014029a20266470 Reviewed-on: https://gerrit.libreoffice.org/28420 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-26tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu1-6/+7
Change-Id: I3099818283a9801976288d0efa67a8711106f376 Reviewed-on: https://gerrit.libreoffice.org/28360 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-25cid#1371326 Misused comma operatorNoel Grandin1-1/+1
Change-Id: I8b27c4d20e86b6cf173374df0242f438909b4db6
2016-08-24tdf#100726 - Improve readability of OUString concatanationsGökhan Gurbetoğlu3-11/+14
Change-Id: I59c605bb31859a2a419cc9e9e60c174e842a03db Reviewed-on: https://gerrit.libreoffice.org/28349 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-22clearly we want to match "-env:" only at arg start, not as substring anywhereEike Rathke1-1/+1
Change-Id: Id7238329118ac6f9ddf58b31c6477be002895307
2016-08-19sw redlines: expose description as part of the UNO/LOK APIMiklos Vajna2-0/+8
A redline can have a manual comment and also an autogenerated description, like "Insert 'abc'". Expose this later property as well, as it provides useful additional information, especially when the comment property is empty. Change-Id: Id0f0ff62aef58d96b9b6071706c6f5b4a0d74800
2016-08-19coverity#1371375 Resource leakCaolán McNamara1-1/+2
Change-Id: I53b5ddc26e77168c29ba1bcfd199b1accbc54d3a
2016-08-19coverity#1371119 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: I6a39ee4aafe646c542f03c8548e1822837dfde5c
2016-08-19tdf#101592 sw: track changes state is doc-specific, not view-specificMiklos Vajna2-2/+35
So update the bindings of all views after changing it. Change-Id: I5355f40ba27be521dcdf343b08305f3736979bbb Reviewed-on: https://gerrit.libreoffice.org/28233 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-18experiment with renaming for bogus coverity#1371326 Misused comma operatorCaolán McNamara1-15/+15
Change-Id: Idd2cc5e888c85a33c9d26aac26c48f3c74571724
2016-08-18cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I61ab542f4cc777ecd8f8393c7bcbb681e529de5f
2016-08-18cppcheck: passedByValueCaolán McNamara1-1/+1
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
2016-08-18screenshots: add new global make targetArmin Le Grand1-1/+2
Up to now the screenshot creation was added/dependent of target slowcheck. Since quite some modules have added screenshot creations now, I added an own target 'screenshot' to allow to keep current slowcheck and screenshot creation separated Change-Id: I80a49a0db607edf8e0405672d570f624d29912e7
2016-08-18screenshots: unify dumping of dialog test batch fileArmin Le Grand1-74/+2
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18screenshots: add dialog test cases for desktopArmin Le Grand4-0/+266
Only one dialog had to be disabled, some others look not very useful Change-Id: I2f8e786c0bb94259c5d03e7a72cc1d6ed9bbc066
2016-08-17lok::Document::getCommandValues: expose redline infoMiklos Vajna2-0/+78
Index is added as a property for each item, so that later changes can be identified by the index when they are accepted/rejected. Change-Id: I9362d208fdbed1f46d64558d44498d2b19150c81
2016-08-15Resolves: tdf#44241 highlight the newly installed extensionCaolán McNamara2-12/+2
this was changed by commit a6efec83cee0ab447f9e6a5716aee5d2165f95c7 Date: Mon Nov 28 10:54:55 2011 -0200 Fix for bug fdo39748, Easy-hack Cleanup extension list. so restore addPackageToList to not remove the old one before potentially re-adding it, and instead follow the same model as TheExtensionManager::modified to refresh the list Change-Id: I8c3207760361dbd42e400fa9f323ca42971bbcc0 Reviewed-on: https://gerrit.libreoffice.org/28137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-08-14tdf#100965: Restart on initialisation-time OpenCL crashTor Lillqvist1-0/+1
Add a flag to the OpenCLZone indicating whether we are performing the first-start OpenCL functionality verification, so that if we run into a crash that is caught by the VCL VCLExceptionSignal_impl() handler, we terminate the process with the EXITHELPER_NORMAL_RESTART status after first having disabled OpenCL use. The wrapper process will then restart soffice.bin. This is for Windows only so far. This matches what we do if OpenGL fails early during start of LibreOffice. Change-Id: Ibb9bf3a86b7521bf16728de2a118ad4323be674b Reviewed-on: https://gerrit.libreoffice.org/28086 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-08-05(initial) sparc64 portJames Clarke1-0/+2
Change-Id: I8ec9bb5415a9e6b9083ba89a7790872d67625de1
2016-08-05desktop: add undo/redo support to lok::Document::getCommandValues()Miklos Vajna2-1/+66
Expose the undo/redo stack and the metadata of each item. Change-Id: I66b81e855a945c97be3d491ed709959f310d4b73 Reviewed-on: https://gerrit.libreoffice.org/27905 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-08-05loplugin:countusersofdefaultparams in chart2..desktopNoel Grandin2-2/+2
Change-Id: Iaca94acd6ef91f07ed0c0085390500c418099dee Reviewed-on: https://gerrit.libreoffice.org/27896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-08-04CppunitTest_desktop_app needs the Foundation framework when sandboxedTor Lillqvist1-0/+8
Because cmdlineargs.cxx uses NSTemporaryDirectory when HAVE_FEATURE_MACOSX_SANDBOX. Change-Id: I120a1f69bc94be161b76a9b813623103adc5fbe7
2016-08-01lok: re-load UNO bootstrap pieces and set UserInstallation on second init.Michael Meeks1-1/+3
Ideally should check whether the path is different. Changing the user-install path is useful for valgrinding online outside of a chroot jail. Change-Id: I6ad76af1245491acdcb6664896be89073406b742 Reviewed-on: https://gerrit.libreoffice.org/27782 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-07-31tdf#100837: honor LibreOffice command line arguments for Office URIsMike Kaganski2-98/+105
This patch allows modifying open mode set in Office URI by using LibreOffice usual command line arguments. For instance, if there is -p "ofe:...", then the file won't be open for editing, but instead will be printed. Change-Id: I4bde9b6e1c0e92b63ee3834ee1fd8f6e1bd321f2 Reviewed-on: https://gerrit.libreoffice.org/27629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-07-28desktop: fix Android buildMiklos Vajna1-0/+2
Change-Id: I1ea8edba2dc34386c2748c3ee2310963252082e6
2016-07-27add uui component to some other placesCaolán McNamara1-0/+1
Change-Id: If07caacf7bc18b39820db73fe64201f9cb97bc6c
2016-07-27improve passstuffbyref return analysisNoel Grandin3-6/+6
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c Reviewed-on: https://gerrit.libreoffice.org/27317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-26Restructure CommandLineArgs::ParseCommandLine_ImplMike Kaganski2-178/+88
CommandLineArgs::ParseCommandLine_Impl is restructured to remove multiple redundant booleans and make its structure more clear. Command line "events" (that specify following filenames treatment) are grouped to an enum. (NB: "events" is not invented by me, this is currently used term). Normalized treatment of --display param: now it is always ignored. Previously, if it happened to be a known switch like --writer, it handled as it's not after --display. Immediate parameters to switches --pt, --convert-to, --outdir, --printer-name are now treated likewise. They are treated as corresponding values, even if they happen to be known switches. --language (without "=") is no more a recognized switch. Before this it skipped all filenames until next file management switch. After this gets approved, TODO is to tweak Office URIs to take current event into account: e.g., to print opened file if it's after -p. Change-Id: Ic2f3980548f8906f695d297dc6677bd2cbd19c5b Reviewed-on: https://gerrit.libreoffice.org/27316 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-07-26masses of MessBoxes not being disposed promptlyCaolán McNamara1-2/+2
since... commit ba81e5c6bd420b41a84ade6ccd774011a8089f7f Date: Thu May 28 21:35:43 2015 +0100 tdf#91702 - fix stack-based MessBox allocation. There is no special ScopedVclPtr<X>::Create or ScopedVclPtrInstance<X>::Create just VclPtr<X>::Create and a raw VclPtr<X>::Create()->foo doesn't call dispose on the owned X Change-Id: Ifacc8d5e742820701307c3c37b9b86487667d84f
2016-07-25Fix some misleading commentsTor Lillqvist1-4/+2
Change-Id: I0f29133c3e9b881835b970b2226583ec348828cb
2016-07-19desktop: simplify $(ENABLE_BREAKPAD) checksMichael Stahl1-5/+2
Change-Id: Ibe2da6214b1f6555922313b22e2882a2ddb4b9e7
2016-07-19desktop: CppunitTest_desktop_app requires breakpadMichael Stahl1-0/+2
Change-Id: I314fd2ba94ec6efdfecbc9694138a6410665163c
2016-07-19clang-tidy performance-unnecessary-value-param in desktopStephan Bergmann1-1/+1
Change-Id: I1b1bf615c5afcb6e14929fde456c6b734be65414
2016-07-19tdf#100837: Support Office URI SchemesMike Kaganski4-1/+246
This patch adds support for Office URI Schemes (see https://msdn.microsoft.com/en-us/library/dn906146). This will enable browser (non-CMIS) integration of LibreOffice with MS SharePoint server (v.2013 tested). In this patch, in addition to ms-* schemes, a new scheme is introduced: vnd.libreoffice.command, which is analogous to ms-*. Its purpose is to enable flexible configuration of server and client, where some types of documents are declared as handled by LibreOffice, and other are handled by other software. E.g., ODTs may have "vnd.libreoffice.command" scheme, while DOCXs could be "ms-word". Client may register LibreOffice to handle both, or to handle only "vnd.libreoffice.command" scheme. Unit test included. TODO in a later patch: add a mechanism to register LibreOffice to the schemes with OS. Change-Id: I1c449a211102036f87163058a4c90a93eb32c948 Reviewed-on: https://gerrit.libreoffice.org/27094 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-18lok: Skip saving unmodified doc if DontSaveIfUnmodified=truePranav Kant1-2/+48
Change-Id: Ia2687bd4bef61df1ff101cab2a19394859b7df58 Reviewed-on: https://gerrit.libreoffice.org/27212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2016-07-15Related tdf#37531: Make --cat headless/hidden like --convert-toStephan Bergmann3-3/+8
...which automatically takes care of the open problem from 08960441558743f222280637985690bb8b41b861 "Related tdf#37531: Handle conversion args sent over pipe" that --cat terminates the called soffice. Change-Id: Ief8cdf8c1335749dad1504966d635e0519fe92f7
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 08:44:33 +0000