summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2016-04-18clang-tidy performance-unnecessary-copy-initializationNoel Grandin3-4/+3
probably not much performance benefit, but it sure is good at identifying leftover intermediate variables from previous refactorings. Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657 Reviewed-on: https://gerrit.libreoffice.org/24026 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18clean-up: unused using declarations and includesJochen Nitschke1-1/+0
Searched source for using declarations. Checked if those symbols reappear in the source file, even in comments or dead code but not in #include statements. If they don't reappear, remove the declaration. Remove includes whose symbol got removed. Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0 Reviewed-on: https://gerrit.libreoffice.org/24148 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-14Use the true exit code 77 hereStephan Bergmann1-1/+1
Change-Id: Ice61e770dd3cc9ac3beb7646a6fb298c1a4e46d9
2016-04-14loplugin:passstuffbyref in variousNoel Grandin6-13/+13
Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022
2016-04-13tdf#94306 remove unused boost dependenciesJochen Nitschke2-2/+0
remove <boost/noncopyable.hpp> in pch and remove boost from makefile if it was the only boost entry. Change-Id: Icb945ae59c137571f4f63807601738eea5c3e831 Reviewed-on: https://gerrit.libreoffice.org/24061 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13lok context menu: Add module specific unit testsPranav Kant2-5/+239
For calc, now click on the image to have more diverse context menu with checkbuttons etc. Change-Id: Ibe2471348b2572523f2684144bd18664ab48a2bb Reviewed-on: https://gerrit.libreoffice.org/24006 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
2016-04-12Avoid reserved identifierStephan Bergmann1-4/+3
Change-Id: I2c9d6a750f3a7d1ce29f3e9fe315defc63c46e46
2016-04-12remove that unused old codeMarkus Mohrhard1-28/+0
Change-Id: I576f6be6d229e29d0ae35ffb00d118bfd44b5544
2016-04-12loplugin:defaultparamsStephan Bergmann1-1/+1
Change-Id: I5748482eb246b2ccf87a02df6406e2624ee66921
2016-04-12lok context menu: unit testPranav Kant3-0/+149
Change-Id: I244fbf4b98368c7c0d66cdd865e1243639727026 Reviewed-on: https://gerrit.libreoffice.org/23985 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.com>
2016-04-12cleanup: remove unused com/sun/star/uno includesJochen Nitschke1-1/+0
Sequence.h(xx), Any.h(xx) and Type.h(xx) and remove unused using-declarations from these files. Add a few missing includes provided by them. Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4 Reviewed-on: https://gerrit.libreoffice.org/23805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-08tdf#94306 replace boost::noncopyable in d...Jochen Nitschke6-19/+31
dbaccess, desktop and drawinglayer. Replace with C++11 delete copy-constructur and copy-assignment. Nothing special, only one unused include in dbaccess/source/filter/xml/xmlfilter.cxx. Change-Id: Iebabbc658215162450d4caf08d4fb2f116c456d9 Reviewed-on: https://gerrit.libreoffice.org/23918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-04-07refactor pagein, as it still seems to cause rare crashesBjoern Michaelsen1-19/+11
Change-Id: I51e6cdf79c19c3709e00dc10175527ec6583a758 Reviewed-on: https://gerrit.libreoffice.org/23872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-04-07CppunitTest_desktop_lib: avoid #include "../..." style includeMiklos Vajna2-1/+6
Change-Id: Ib5ce0dee00c9306f89ad4b43af4b34e604147a1c
2016-04-05RequestHandler::Disable(join = false) is problematicStephan Bergmann2-4/+4
...as it causes ~RequestHandler to be called with mIpcThread still running, triggering the assert in ~RequestHandler and keeping the thread potentially still running during exit. The odd SalMainPipeExchangeSignal_impl acting upong just SIGTERM (instead of turning off the IPC thread early for each invocation of LO's signal handler, say) is effectively like that ever since ee3351d78c9b6ffbc4dfe62853e81b84e65879c7 "#89023# splash screen optimization"; just change it to use RequestHandler::SetDowning instead. Change-Id: I238476706c2463130a6ede64a062d46af953ba6f
2016-04-05loplugin:constantparamNoel Grandin4-16/+6
Change-Id: I821ed77a6c6014c9a82d31a4b117ed6f1b4abf18 Reviewed-on: https://gerrit.libreoffice.org/23832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-05Consistently use "desktop.app" log area hereStephan Bergmann1-3/+3
Change-Id: Ie31f1ea788cc2b8b0d6c672d93df84adb3326a05
2016-04-05Remove whitespace randomly insertedStephan Bergmann1-1/+1
...with 221144f9c995fe30adf577c02f756b3123fb2550 "tdf#91794 OSL_DEBUG_LEVEL > 1 removed (desktop)" Change-Id: Ief7193bb5cb10e633744b545bca9416ffa37c20e
2016-04-05-Werror,-Wunused-functionStephan Bergmann1-36/+0
Change-Id: I2d0a21b0f38feafa6e3fde0245b1fdb9b5771152
2016-04-05sequence->vector in xmlscriptNoel Grandin9-45/+39
Change-Id: I4f99cd9dc659f54bd4818559dd3e0dbce1e8f5d4 Reviewed-on: https://gerrit.libreoffice.org/23795 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-04No DBUS_TIMEOUT_INFINITE before D-Bus 1.4.12Stephan Bergmann1-2/+1
Change-Id: Ie53359fb2b6a73fa3611e56314ae2df00457adc0
2016-04-04...and MSVC "warning C4701: potentially uninitialized local variable used"Stephan Bergmann1-2/+2
Change-Id: I4a7eab0cbca2da04b81867158d15c94eda16d3b2
2016-04-04Try silence bogus -Werror,-Wsometimes-uninitializedStephan Bergmann1-1/+1
Change-Id: I85528ab58e6f29464a3b4a78096e5b9575735220
2016-04-04-Werror=shadowStephan Bergmann1-10/+10
Change-Id: I231396660573e395ef7f949687c6e536a8a60b20
2016-04-04Add DBus-based IPC mechanism for xdg-appStephan Bergmann4-201/+500
first cut; triggered on LIBO_XDGAPP env var for now Change-Id: If4586aedb58499e36a5d87cc8d171400ce7e9499
2016-04-04Prepare for using other IPC mechanisms besides an osl::PipeStephan Bergmann2-44/+77
Change-Id: Ie34330508563bef25185216bdc1dc3ae84d084d4
2016-04-04cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: I68310e2abc8f0ca114adb2b52f82157a0f455202
2016-04-04Use std::size_tMiklos Vajna2-2/+2
And include <cstddef> where necessary. Change-Id: Icc1208528d6a8b04375d55ccbf3cd6ef046b454f Reviewed-on: https://gerrit.libreoffice.org/23796 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-04-04tdf#97499 Fixed containers parameters clearing #3tymyjan1-1/+1
Change-Id: I1c105de7e1df251533179fba77e3797ef1c4e2d4 Reviewed-on: https://gerrit.libreoffice.org/23752 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke1-1/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-01Remove dead -tofront processingStephan Bergmann1-2/+1
aArguments must adhere to a certain grammar, and if it doesn't (which would be the case if it started with "-tofront"), then the Parser ctor would have thrown an exception and we wouldn't reach this code anyway. Looks like a remnant from Sun webtop times, got originally introduced with c9d844f62c388d463445097f1cc453535491e171 "INTEGRATION: CWS cl03: #109140# -start -> -show", but there appears to be no other mentions of -tofront across the LO code base. Change-Id: I5097bf38753f6cc9184a934da81342b3ccf330b4
2016-04-01Clean upStephan Bergmann1-14/+9
Change-Id: I607108e5ec26992ec4763c4de3e1f53b4fbe886d
2016-04-01Rename ipc_ -> handler_Stephan Bergmann1-10/+10
Change-Id: I9509af144143de9f6ec3fc6ac925be99727c9c68
2016-04-01HAVE_FEATURE_MACOSX_SANDBOX doesn't initiate IPC in RequestHandler::EnableStephan Bergmann1-10/+2
...so cannot return with IPC_STATUS_PIPE_ERROR anyway Change-Id: If98bcc9b7cc1fbcc367e50759be0e8d6003d941b
2016-04-01Unused includeStephan Bergmann1-1/+0
Change-Id: I3541c7a09b203b6a4ee81ffc5e778c017191fe27
2016-04-01No need to #if this codeStephan Bergmann1-10/+0
...it's enough to conditionally set ipc = false in RequestHandler::Enable. Change-Id: Ie64b476d6ad5a5fbedb7542c5dab69daadf17f1e
2016-04-01tdf#97966 Drop 'static' keywordsWastack2-2/+2
Including no keywords from extern "C" blocks Change-Id: Icff7c0308843d6a7608be24d7fcf11fa079c7b72 Reviewed-on: https://gerrit.libreoffice.org/23672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke1-1/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31Clean upStephan Bergmann1-6/+4
Change-Id: I93efe38ee7148c87d2fabd6f3c77d28b85b6e511
2016-03-31HAVE_FEATURE_MACOSX_SANDBOX doesn't want to launch the PipeReaderThreadStephan Bergmann1-6/+1
Change-Id: I55ca1b91ed3b52e9b2b0f802692cbe45d50826e1
2016-03-31use SAL_N_ELEMENTS in for loopsNoel Grandin1-1/+1
for with git grep -n 'for.*sizeof' Change-Id: I6211024385e03ac5eeeb38690d2c1c699e015c2f Reviewed-on: https://gerrit.libreoffice.org/23569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-30Remove undocumented perftune.ini FastPipeCommunicationStephan Bergmann2-232/+1
...originally added to OOo in 2005 with 9277dc7501f70d80ea1302c128c2786c01b69706 and e3eecbfeb639529f3a15c0acfe4697a619d454fb "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I149686eca8bda5ea7a363cd995447576e217ec13 Reviewed-on: https://gerrit.libreoffice.org/23600 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-30Fix Android buildMiklos Vajna1-2/+2
Change-Id: I7247f19b03302b2270e0f6f32c6e6b6e760fd7bd
2016-03-29Remove obsolete commentStephan Bergmann1-1/+0
The code it commented got removed with 77c52217238b6a1b08b74852aa79163306c688a9 "INTEGRATION: CWS sb83". Change-Id: I709db766806a75823e3436a0b3d5a6eba307ecca
2016-03-29Remove undocumented perftune.ini QuickstartPreloadConfigurationStephan Bergmann2-246/+0
...originally added to OOo in 2005 with 8a9d865b32b760804adf53b0d68fd74785890915 "INTEGRATION: CWS cov2src: #126234# Join MWS COV680 m4 into SRC680". Change-Id: I7167c99e28b56c9048de32576e793e2eaa1fc6a6
2016-03-29LOK shouldn't reach this code anymoreStephan Bergmann1-99/+77
...after 79b0d4ba2cbc5a35adaa9628cc18eb0f46d01f9c "Don't launch the PipeReaderThread from LOK" Change-Id: I0a8674cc2df738e723f43e372f622dd5a02c5a7f
2016-03-29Don't launch the PipeReaderThread from LOKStephan Bergmann4-32/+20
ATTENTION: Users of LOK need to ensure somehow that no two processes operate on the same UserInstallation simultanously. Especially the lokdocview widget in gnome-documents is known to be problematic in this regard, cf. the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-March/073839.html> "LibreOfficeKit and the UserInstallation". Change-Id: I7bc2edb281c925e479b8006151d8549441c9e9e8
2016-03-29Rename OfficeIPCThread to RequestHandlerStephan Bergmann5-123/+122
Change-Id: I2076d903e83a0b8eb3aa0ce2413630e2c5415b15
2016-03-29Extract PipeReaderThread from OfficeIPCThread (a misnomer, now)Stephan Bergmann2-28/+50
Change-Id: Ie30cc14bdc772fd898d24a3e3caf41ac9718712f
2016-03-29Simplify codeStephan Bergmann1-2/+1
Change-Id: I793f6ce3297b114ebe79b9937e07291e1b238ab1
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-10 14:07:53 +0000