summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2017-01-03desktop: remove unnecessary #define _WIN32_WINNT 0x0501Michael Stahl2-7/+0
gb_OSDEFS already globally sets at least 0x0502 Change-Id: I52b75dc114eb498232faeb70ec75948ad01d3675
2017-01-02tdf#95416 Get rid of #include ../foo/bar.hxx style includesGaurav Dhingra1-2/+2
Change-Id: I9b05c261faebd3e0e5d65ca524a4379c1d5918f1 Reviewed-on: https://gerrit.libreoffice.org/32419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-02Fix inefficient usage of string::find() in condition (CWE597)Muhammet Kara1-1/+1
string::compare() will be faster when string::find's result is compared with 0, because it will not scan the whole string. Change-Id: I78596a6d796fe9779f88b7c7b91da09aa27b7035 Reviewed-on: https://gerrit.libreoffice.org/32430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-23tdf#100826: Use parent console for output if possibleMike Kaganski2-17/+90
This patch uses either passed standard handles, or parent console for output of --help and --version command line switches. Change-Id: Iabbec79d3792ae091ca06d134345c1669eb1ac13 Reviewed-on: https://gerrit.libreoffice.org/31187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-22bodge fix buildCaolán McNamara1-1/+1
Change-Id: I5ef90ad7bf39618cc65641ffa85d056adc48d555
2016-12-21convert VclButtonsType to scoped enumNoel Grandin3-5/+5
Change-Id: I9b91108c18e190060dc71546977aa8a3c11f06e1 Reviewed-on: https://gerrit.libreoffice.org/32285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
2016-12-21No apparent reason for an unnamed namespace in an include file hereStephan Bergmann1-4/+0
Change-Id: I8467fbb8b4e82e58a66990ed049a12e26aabd4f0
2016-12-21tdf#95416 Fix an include for 2 files in unopkgHuzaifa Iftikhar4-3/+3
Change-Id: Id1fa09b6db6c90cd727182133e5f9f39383aa5e5 Reviewed-on: https://gerrit.libreoffice.org/32255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-20tdf#95416 Fix an include for desktop directoryHuzaifa Iftikhar2-1/+1
Change-Id: I04a2181b05f2b15a55db306f49b47855db7753db Reviewed-on: https://gerrit.libreoffice.org/32204 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-12-17tdf#104441 Addition to output to the console helptagezi1-0/+7
There is no documentation in the help on how to open a file and automatically run a macro Change-Id: I94c5e87ae0f573a5546a83b118021744b439c7cd Reviewed-on: https://gerrit.libreoffice.org/32122 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-16lok: Fix state feedback for ToggleMergeCellsPranav Kant1-1/+0
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2016-12-16loplugin:nullptr (clang-cl)Stephan Bergmann1-3/+3
Change-Id: I557e752ca05146e2a571d027fc3d1875afd6ef26
2016-12-16-Werror,-Wnonportable-include-path (clang-cl)Stephan Bergmann1-1/+1
Change-Id: I2a64b18c707085f7d4485ba46d599e8ab0df2408
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin1-2/+2
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-14-Werror,-Wunused-variableThorsten Behrens1-1/+2
Change-Id: I32e6bad89b7cdcf0b181c0bb3a158b003fcfb767
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-1/+4
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin2-8/+2
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12loplugin:unreffunTor Lillqvist2-4/+6
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb
2016-12-12coverity#1397042 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ibb24dea2464c2e0bba289f08bba053efe6fe57fc
2016-12-12coverity#1397048 Unchecked return valueCaolán McNamara1-1/+1
Change-Id: Ie33ef6565cadcddb59c1d78a63aec666e8693f87
2016-12-11don't overwrite the crashreport info that are written before uploadMarkus Mohrhard1-4/+30
There was a race condition that the OpenGL code was initialized before the old report has been uploaded. Therefore the OpenGL setting was overwritten by the new start and we were not getting the old value. Now we store any value that wants to be added before the dump.ini is ready in a temporary map and will write them as soon as we write all the common information. This problem was introduced by the dialog requesting permission to upload the crash report. Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024 Reviewed-on: https://gerrit.libreoffice.org/31846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-09loplugin:staticmethodsTor Lillqvist1-0/+2
Change-Id: I385e54f5ddadda894102be2bb9a7dc408415ac68
2016-12-08convert SFX_HINT to scoped enumNoel Grandin1-3/+3
Notes (*) In SC, BULK_DATACHANGED was or'ed into the hint id. Replaced with a dynamic_cast check. (*) In SC, removed the hint id field from ScIndexHint, no point in storing the hint id twice (*) Fold the SfxStyleSheetHintId enum into the new SfxHintId enum, no point in storing two different hint ids (*) In some cases, multiple #define's used to map to the same SFX_HINT value (notably the SFX_HINT_USER* values). I made all of those separate values. Change-Id: I990e2fb587335ebc51c9005588c6a44f768d9de5 Reviewed-on: https://gerrit.libreoffice.org/31751 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08lokit: support password protected binary MS and OOXML documentsTomaž Vajngerl1-11/+31
Change-Id: Id7fa1f428d07271e71f3df962bd6718a35372389 Reviewed-on: https://gerrit.libreoffice.org/31730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2016-12-08No glxtest library unless USING_X11Tor Lillqvist2-0/+4
Change-Id: Ibcc0eeba9beaaeea86bdda5e0ea80e54c25621a9
2016-12-08loplugin:unreffunTor Lillqvist1-3/+4
Change-Id: I15d868892a3ea4eadd526a0d3371f9fea39910cf
2016-12-08loplugin:staticmethodsTor Lillqvist1-0/+5
Change-Id: I90bb57370853c7606304c721e294999626c2af01
2016-12-07Match conditional in Repository.mkTor Lillqvist1-0/+5
Change-Id: Ie9deeb673cd5083a2f57a502bfbf49319aa00165
2016-12-07Fix typo in comments: et -> edTakeshi Abe1-1/+1
Change-Id: I447c46cc3d66c7f482314626826dd708bf1c01c4
2016-12-07convert VCLEVENT constants to scoped enumNoel Grandin2-2/+2
Change-Id: Ic8ccb0a9715ec05182dacddab2c015b0de6a0fba Reviewed-on: https://gerrit.libreoffice.org/31675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06cleanup unused includes (related to tdf#88206)Jochen Nitschke7-7/+0
cppuhelper/compbase*.hxx and cppuhelper/implbase*.hxx compbase*.hxx includes implbase*.hxx replace compbase*.hxx if only implbase*.hxx stuff is used. Change-Id: I631a20aee411c6a32ffcf470f6e392621755f995 Reviewed-on: https://gerrit.libreoffice.org/31686 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-06loplugin:unnecessaryoverrideStephan Bergmann1-5/+0
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-05tdf#100836 "Starting the LibreOffice Software With Parameters" help updatetagezi1-69/+124
rewritten cmdHelp in accordance with the attached document in bug tdf#100836 Change-Id: I6453ee87039272388fe1bc0efd747dc706b570ff Reviewed-on: https://gerrit.libreoffice.org/31244 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin5-10/+10
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-05convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin1-1/+1
Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2016-12-05Revert "lok: in preinit stage, do not force locale"Tor Lillqvist1-2/+2
Fixes unit-prefork in online for me. Kendy suggested to also change the forced locale to en-US.UTF-8 instead of just en-US, but that caused: warn:i18nlangtag:32416:1:i18nlangtag/source/languagetag/languagetag.cxx:1369: LanguageTagImpl::convertLocaleToLang: with bAllowOnTheFlyID invalid 'en-US.UTF-8'. This reverts commit c3d25b8b74867b5b8419d09f6e362aa6c8eae34f. Change-Id: I2cd8c50a783918c380505e7a3aaf37d578e76031 Reviewed-on: https://gerrit.libreoffice.org/31489 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2016-12-05Lok: better logging and warningsAshod Nakashian1-11/+25
Change-Id: Ia933ae65197893592eeb04cb8a1a617a931ad623 Reviewed-on: https://gerrit.libreoffice.org/31606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-05Lok: disable DesktopLOKTest::testTileInvalidationCompressionAshod Nakashian1-0/+4
For some reason this test fails on TinderBox and for others while passing on Jenkins on all platforms. This might be related to the compiler version used. Disabling until resolved. Change-Id: Ic05dbb290818506c78ceaa4c416fb00e8c0dc8da Reviewed-on: https://gerrit.libreoffice.org/31607 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-03first cut at adding a GDI handles attribute to the windows crash report.Michael Meeks1-0/+1
Change-Id: I4e6fee65a1416398f6f59feb8734b3b00c0aed3b Reviewed-on: https://gerrit.libreoffice.org/31570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-02Lok: correct tile invalidation mergingAshod Nakashian2-3/+42
Rectangles that are empty (i.e. IsEmpty() returns true) were incorrectly considered to mean equivalent to "EMPTY". The latter means full-area, while the former mean zero-area. This fixes the issue by restrict full-area to rectangles with 2 billion units on the each side (roughly INT_MAX) or more, and using this new check rather than IsEmpty(). Change-Id: I12aca17267f5dd33b2932012d1d9db3545f9af6f Reviewed-on: https://gerrit.libreoffice.org/31458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-12-02svl: fix loplugin:cppunitassertequals warningsMiklos Vajna1-1/+1
Change-Id: Ice929418e46ff42517a47dfcd5888a5cce36ae51 Reviewed-on: https://gerrit.libreoffice.org/31523 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-02convert some anonymous enums to scopedNoel Grandin4-17/+15
Change-Id: Ia989376c983ff475359e4964abeb1f5a2300ff5b Reviewed-on: https://gerrit.libreoffice.org/31486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-01tdf#104126 - comphelper thread-pool, use reliable std::condition_variable.Michael Meeks1-0/+4
The existing osl::Condition is an API and reliability disaster area. Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694 Reviewed-on: https://gerrit.libreoffice.org/31163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-11-30sw: use auto when initializing with a cast to avoid duplicating the type nameMiklos Vajna1-1/+1
Change-Id: Ide7bd0f1f444824b78aa53cfe1db0129cbca1a5d Reviewed-on: https://gerrit.libreoffice.org/31397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-30lok: ensure positive values for width and heightHenry Castro1-0/+5
also check the pointer memory block allocated Change-Id: I0ded04e06f80400e64c5e58126a32ee503aeb394 Reviewed-on: https://gerrit.libreoffice.org/31388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-29Window::Invalidate must be called with SolarMutex lockedStephan Bergmann1-58/+74
...it internally calls Scheduler::Start, which asserts now since c00d8271ba443c4f0acf657c226eea4824597f95 "vcl: assert solar mutex is held for various timer / scheduler ops." Caused the assert to fire when removing an extension via "Tools - Extension Manager... - Remove". Change-Id: Ied0591b799af333b3a4c11af07f5f8f1657304d6
2016-11-28Revert "Remove extra "=" symbol for "--splash-pipe" argument"Stephan Bergmann1-1/+1
This reverts commit 87a098e3bb72910399473ee0fbe32a70cad9c737: '--splash-pipe=N' is a "private" command line argument between oosplash (desktop/unx/source/start.c) and soffice.bin (desktop/source/splash/unxsplash.cxx). No need to silently accept a bogus '--splash-pipe' (without '=' part) provided by the user.
2016-11-28sw lok: notify repair when exist a conflict of multiple users undo/redoHenry Castro1-2/+6
Change-Id: I026f4df6239fa87ee191f92127f9fa98ac2993eb Reviewed-on: https://gerrit.libreoffice.org/31161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-28lok: avoid render font with empty rectangleHenry Castro1-0/+3
Change-Id: I58e24e0de37144ae5d67857b243e6a7091f2b77a Reviewed-on: https://gerrit.libreoffice.org/31281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-28lok: in preinit stage, do not force localeHenry Castro1-2/+2
force locale load some fonts before the lokit process is jail rooted, so it causes invalid rendering special characters in doc_renderFont function Change-Id: I25f00e5bb947753b820c6966a99a6c3849413315 Reviewed-on: https://gerrit.libreoffice.org/31280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-28 05:10:52 +0000