summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2017-05-16tdf#104312, tdf#105428: use static vars in ReplaceStringHookProcAron Budea1-9/+15
And use call_once to initialize them once. Reviewed-on: https://gerrit.libreoffice.org/37318 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit f9f511317fa5f1c655d189a8507f8a5492a3b08d) Change-Id: Ic2f97a51ccc6ee400eb1af56da2c8fd88e226a9d Reviewed-on: https://gerrit.libreoffice.org/37410 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-02-23add the locale info to the crashreporter metadataMarkus Mohrhard1-0/+2
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/34561 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-1/+4
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0fda52cc4a5c78c55f96850faa734ea66891808c) Reviewed-on: https://gerrit.libreoffice.org/31937 Tested-by: Jenkins <ci@libreoffice.org>
2016-12-11don't overwrite the crashreport info that are written before uploadMarkus Mohrhard1-4/+30
There was a race condition that the OpenGL code was initialized before the old report has been uploaded. Therefore the OpenGL setting was overwritten by the new start and we were not getting the old value. Now we store any value that wants to be added before the dump.ini is ready in a temporary map and will write them as soon as we write all the common information. This problem was introduced by the dialog requesting permission to upload the crash report. Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024 Reviewed-on: https://gerrit.libreoffice.org/31846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80049d110a742060acedb89eaad763e66d7f75a5) Reviewed-on: https://gerrit.libreoffice.org/31850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-03first cut at adding a GDI handles attribute to the windows crash report.Michael Meeks1-0/+1
Change-Id: I4e6fee65a1416398f6f59feb8734b3b00c0aed3b Reviewed-on: https://gerrit.libreoffice.org/31570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8b86e9de388fff673bc86c14246eff8ed6aa591e) Reviewed-on: https://gerrit.libreoffice.org/31587 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-29Window::Invalidate must be called with SolarMutex lockedStephan Bergmann1-58/+74
...it internally calls Scheduler::Start, which asserts now since c00d8271ba443c4f0acf657c226eea4824597f95 "vcl: assert solar mutex is held for various timer / scheduler ops." Caused the assert to fire when removing an extension via "Tools - Extension Manager... - Remove". Change-Id: Ied0591b799af333b3a4c11af07f5f8f1657304d6 (cherry picked from commit e006b9cf2cfba5995b97a9a9551d362b7eb45572) Reviewed-on: https://gerrit.libreoffice.org/31366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-22lok: add command values .uno:FontSubsetHenry Castro4-0/+95
Conflicts: desktop/Library_sofficeapp.mk Change-Id: Id36a98c32f0eb5e88e4e9a714e260a71d7465c05 Reviewed-on: https://gerrit.libreoffice.org/31033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-21tdf#103146 Revamp Extension Manager Dialog, Part 3Muhammet Kara3-84/+58
Move the "Enable"/"Disable" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also remove some unnecessary code pieces for clean-up. Change-Id: Iec7820779110eea3411a774de8277ef238f562e7 Reviewed-on: https://gerrit.libreoffice.org/30973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-17that should have been LibreOfficeKit*Document*ClassChristian Lohmaier1-1/+1
Change-Id: I48f9db39be18ae9a456002de8f40fbb0fb3be707
2016-11-16Demonstrate that (extension) .xcu can contain <item> with nested <node>sStephan Bergmann1-35/+36
This sprang from an IRC conversation with uniscript about allowing .xcd in extensions, so that an extension with (localization) data for many packages would not need one .xcu file per package, but rather only a single file. That is possible with a single .xcu file using the <item> syntax, as shown here. (I had thought that originally only registrymodifications.xcu supported the <item> syntax, but can't find any traces of that; so looks like an extension with an .xcu file using <item> syntax should be supported by OOo and derivates "since ages".) Change-Id: I1101793e6b14ba9c1e7647edab76927d4d31a81c
2016-11-16tdf#92346 - Copy functionality in the viewerChamal1-1/+2
Reference class added to desktop/source/lib/lokandroid.cxx for Java_org_libreoffice_kit_Document_getTextSelection() Change-Id: I211d5709df39fd9fafdab9232af760613f6b86c0 Reviewed-on: https://gerrit.libreoffice.org/29804 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-15tdf#103146 Revamp Extension Manager Dialog, Part 2Muhammet Kara3-112/+30
Move the "Remove" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also wipe some useless code which implements custom tab behavior. Change-Id: I602fcf23631498145d8b9ead2936ee549caf3f0d Reviewed-on: https://gerrit.libreoffice.org/30867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-14lok: add character parameter to renderFontHenry Castro1-2/+8
When client side request special character, it is very useful to send a preview of the rendered font character Conflicts: desktop/source/lib/init.cxx Change-Id: I1f5727163dfcc861add121e616bdb17881c28197 Reviewed-on: https://gerrit.libreoffice.org/30784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-13drop extra semicolonsDavid Tardon1-2/+2
Change-Id: Ie6713d1bdf0010e5bc0bb70ca995c4dd36408673
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin1-2/+2
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09tdf#103146 Revamp Extension Manager Dialog, Part 1Muhammet Kara5-97/+142
Moved the "Check for Updates", and "Add" buttons to the new row, and started moving the buttons from the ExtBoxWithBtns_Impl to the new row. Needed to create new public methods to be able to update button states of ExtMgrDialog from within the ExtBoxWithBtns_Impl class. Change-Id: Iea784d0b7237da3f8aa05862dbf1faf5acf98655 Reviewed-on: https://gerrit.libreoffice.org/30560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-09loplugin:expandablemethods in dbaccessNoel Grandin10-89/+26
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin1-12/+3
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin2-8/+5
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:oncevarNoel Grandin1-3/+1
Change-Id: I44fb6858eeff14fcbd9fdfbbb0aabd1433b6a27d Reviewed-on: https://gerrit.libreoffice.org/30668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07soffice.sh: can't hurt to force system allocator for massifMichael Stahl1-1/+1
Change-Id: Ib999ed36befae52894c04eaa95be76f2a7cfdd3b
2016-11-04loplugin:oncevar in desktop..filterNoel Grandin3-13/+4
Change-Id: I21c47cacbcd68f06eea7ccbbfa6d04fc65e2b7ee Reviewed-on: https://gerrit.libreoffice.org/30564 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28convert std::unique_ptr<VclAbstractDialog> to VclPtrNoel Grandin1-1/+1
Change-Id: Ifdd2a0599efd701def02b4a4d2a1c489cb1b27fa
2016-10-28Missing dependency (--enable-telepathy)Stephan Bergmann1-0/+1
Change-Id: I13578505fc0d5de164d0dacbbf31821ea79233ab
2016-10-24revert string::find changesNoel Grandin1-1/+1
this reverts commit 610f59651563205564a0f4818b5c1d347ca02132 fix "cppcheck:stlIfStrFind" and commit 5c1bb338ef0d781648d5b33ffc9d64c2be6d9926 cppcheck:stlIfStrFind which are deficient in one way or another, the original logic, while inefficient, is still most accurate Change-Id: I4907d2569c9c2976533f8ac9f4b8b45eb1807b72
2016-10-24fix "cppcheck:stlIfStrFind"Noel Grandin1-1/+1
in commit 5c1bb338ef0d781648d5b33ffc9d64c2be6d9926, compare does not do a startswith Change-Id: If518b3f6880848a5b5463c09fb73974d972010fd
2016-10-24tdf#103395 opencl: don't initialize OpenCL when disabledTomaž Vajngerl1-3/+1
If SAL_DISABLE_OPENCL is set we don't want to do any kind of OpenCL initialization. Put an extra guard in fillOpenCLInfo (and similar methods in opencl package) to prevent that. Put the check if OpenCL can be used into one place which checks SAL_DISABLE_OPENCL and UseOpenCL in configuration. Change-Id: Icc216d4299d3a7942843117ab9b9411de8075b11 Reviewed-on: https://gerrit.libreoffice.org/30025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-24cppcheck:stlIfStrFindJulien Nabet1-1/+1
Change-Id: Ic3c1b37b0c2cf9995e0bd1017cdbaed427fb296c Reviewed-on: https://gerrit.libreoffice.org/30185 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-20Check for enable safe mode earlierSamuel Mehrbrodt2-3/+5
Change-Id: I50e48472bb840c70e9a7c11dd84f33c64d6e1422
2016-10-20Handle link click directly in FixedHyperlinkSamuel Mehrbrodt6-50/+1
Change-Id: I5b5f0648b6e6432b0928351a17d285df8c9da811
2016-10-20Use Application::IsSafeModeEnabled()Samuel Mehrbrodt1-5/+2
Change-Id: I8ca8ceae76b6479a848a618ed141ce29a9c2d84e Reviewed-on: https://gerrit.libreoffice.org/30077 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-20LOK: hold the solar mutex consistently for document method calls.Michael Meeks1-6/+70
(cherry picked from commit eb69d8cb5eb6192de89ca8310a53ae7a434a73d1) Change-Id: I200dff44b457a1632d99619981e237de73a2a8df Reviewed-on: https://gerrit.libreoffice.org/30070 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-10-20CppunitTest_desktop_lib: fix valgrind errorsMiklos Vajna1-8/+8
With this, 'make -sr CppunitTest_desktop_lib CPPUNIT_TEST_NAME="DesktopLOKTest::testPaintPartTile DesktopLOKTest::testWriterCommentInsertCursor" VALGRIND=memcheck' finishes with 'ERROR SUMMARY: 0 errors from 0 contexts'. The problem is that in sw/sc/sd code it's enough to make sure that the on-stack ViewCallback instances are destroyed after the loaded component, but in desktop/ code also the emit-callbacks-on-idle code is under test, so we need to make sure first the LOK document wrapper is destroyed, and only after that the ViewCallback instances are destroyed. Change-Id: Ie8361233461d00fd252da929fb912a1a0b835c30 Reviewed-on: https://gerrit.libreoffice.org/30072 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-19Revert "CppunitTest_desktop_lib: add ModifiedStatus callback testcase"Miklos Vajna1-62/+0
This reverts commit cdf08b3aa74bb32ea18b583a9c0c41b91d7819ac. It breaks 'make -sr CppunitTest_desktop_lib CPPUNIT_TEST_NAME="DesktopLOKTest::testPaintPartTile DesktopLOKTest::testWriterCommentInsertCursor" VALGRIND=memcheck' (it is terminated by SIGSEGV), and also it's the reason why sometimes the lo_ubsan buildbot fails, see e.g. <http://ci.libreoffice.org/job/lo_ubsan/329/console>. This has to be re-introduced once I find a way to process all binding updates at once without side-effects. Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx sfx2/source/control/bindings.cxx Change-Id: Id6c49b9b31095ef1a1a8c1cd92cbae5deb316500
2016-10-19profilesafe: Deeper integration with SafeModeArmin Le Grand1-0/+9
Added deeper integration by saving at SaveMode content of user dir completely to a user/SafeMode dir, including the whole stack of pack files. Repair happens in that safe directory, so that the user dir is resetted to default when re-started in SafeMode. All changes (including complete deletion) are played back to the user config at first restart with disabled SafeMode Change-Id: I5114c7d5d04582be62090707bc9b97afa55fc1f1 Reviewed-on: https://gerrit.libreoffice.org/30003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19CppunitTest_desktop_lib: fix stack-use-after-returnMiklos Vajna1-0/+2
The LOK callback objects registered are on-stack objects, so we must be sure that references no longer used after we return. Process idle events, so that desktop::CallbackHandler::flush() won't try to use the reference after return. Change-Id: I65d324cb9cef4fd1776d0f610d8d096717e0e833 Reviewed-on: https://gerrit.libreoffice.org/30034 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-10-18Document the --language cmd line parameterSamuel Mehrbrodt1-0/+3
Change-Id: I46369bbbed1b74f7d13eb8c2b893df8cade73b79 Reviewed-on: https://gerrit.libreoffice.org/29996 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-17Force disable OpenCL in Safe ModeSamuel Mehrbrodt1-0/+1
Change-Id: I046eb2a01c528945232cedabbf5fa08483c9e057 Reviewed-on: https://gerrit.libreoffice.org/29960 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-17Force disable OpenGL in Safe ModeSamuel Mehrbrodt2-1/+6
Change-Id: I3f19231d9a9168499d9f9ed970d4da1a69cca36a Reviewed-on: https://gerrit.libreoffice.org/29959 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-10-16typoJulien Nabet1-1/+1
Change-Id: I88c404d8e46ba87017af2167fd31dc9dd8758082
2016-10-16fix Android build (desktop)Julien Nabet1-0/+6
stol is missing in the std namespace on the broken Android toolchain, work it around. (I copycat https://cgit.freedesktop.org/libreoffice/core/commit/?id=c2673a358c78b864c1276f7956d5a348003b7a02) Change-Id: I4d85b81abf5d72c08d9aae72638823b8a0484cc1 Reviewed-on: https://gerrit.libreoffice.org/29921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-16clang-cl loplugin: desktopStephan Bergmann15-138/+113
Change-Id: If2f5bfa6c05098c5362cd6c7b546520dc01ee821 Reviewed-on: https://gerrit.libreoffice.org/29871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14loplugin:mergeclasses merge TextView with ExtTextViewNoel Grandin1-1/+1
Change-Id: If7e11dd8f6b2cb6dc19c6aa3f7e50e2e88861eac Reviewed-on: https://gerrit.libreoffice.org/29828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-14LOK: handle "EMPTY" invalid tile msg with part number in payloadMarco Cecchetti1-27/+73
What's new: 1) RectangleAndPart handles "EMPTY" payloads 2) LOK_CALLBACK_INVALIDATE_TILES msg type with "EMPTY" payload are handled in CallbackFlushHandler::queue 3) gtktiledviewer handles "EMPTY" LOK_CALLBACK_INVALIDATE_TILES msg even if the part number is included in the payload Change-Id: I21f4a71ec875d24f4bbd100e4aacf8437d745ae4
2016-10-14profilesafe: Adapted to UIArmin Le Grand2-89/+12
Adaptions to UI, added more modes what the user can do in SafeMode. Adapted locations to write pack information and added places where to enter SafeMode. Implemented basically all five possible user choices Change-Id: Ic5324a8f77ab434309e840949c3803e65a75c538 Reviewed-on: https://gerrit.libreoffice.org/29785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-13 22:19:29 +0000