summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2019-10-17Rename OUStringLiteral1 to OUStringCharStephan Bergmann1-1/+1
It started out as a wrapper around character literals, but has by now become a wrapper around arbitrary single characters. Besides updating the documentation, this change is a mechanical for i in $(git grep -Fl OUStringLiteral1); do sed -i -e s/OUStringLiteral1/OUStringChar/g "$i"; done Change-Id: I1b9eaa4b3fbc9025ce4a4bffea3db1c16188b76f Reviewed-on: https://gerrit.libreoffice.org/80892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-16Send 'INPLACE EXIT' on inplace deactivationSzymon Kłos1-1/+9
Change-Id: Ieb44fb356966df0eb92141a5f22f1df13683f6fc Reviewed-on: https://gerrit.libreoffice.org/80694 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-16loplugin:bufferadd loosen some constraintsNoel Grandin4-59/+50
and extend O*StringView to have a constructor that takes a pointer and a length Change-Id: I6120e96280f030757e855a6596efdae438b7e1e8 Reviewed-on: https://gerrit.libreoffice.org/80872 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15jsdialogs: handle dialog eventsSzymon Kłos2-2/+47
Change-Id: Icc092cd5b06168d9de8ebed891fc03491865dbad Reviewed-on: https://gerrit.libreoffice.org/80788 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-15new loplugin:bufferaddNoel Grandin4-21/+12
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15Bin a fairly pointless unconditional NSLog() callTor Lillqvist1-2/+2
Change-Id: I7c1910c3e1bf345966ec289aaf5f9c9b6cbabc22
2019-10-15move HAVE_FEATURE_DESKTOP/OPENCL to their dedicated headersLuboš Luňák4-2/+5
HAVE_FEATURE_OPENCL is included by a common Calc header and HAVE_FEATURE_DESKTOP is included by a common Writer header, causing pretty much their full rebuilds if any feature changes. Change-Id: If29bf78bd4fd70b37981e0826a577777fd255c89 Reviewed-on: https://gerrit.libreoffice.org/80776 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-14New loplugin:getstrStephan Bergmann1-2/+2
...to find matches of ... << s.getStr() (for the rtl string classes) that can be written as just ... << s Some notes: * The OUStringToOString(..., RTL_TEXTENCODING_UTF8) is left explicit in desktop/source/app/crashreport.cxx (even though that would also be done internally by the "<< OUString" operator) to clarify that these values are written out as UTF-8 (and not as what that operator << happens to use, which just also happens to be UTF-8). * OUSTRING_TO_CSTR (include/oox/helper/helper.hxx) is no longer used now. * Just don't bother to use osl_getThreadTextEncoding() in the SAL_WARN in lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx. * The toUtf8() in the SAL_DEBUG in pyuno/source/module/pyuno_module.cxx can just go, too. Change-Id: I4602f0379ef816bff310f1e51b57c56b7e3f0136 Reviewed-on: https://gerrit.libreoffice.org/80762 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-11Add FullSheetPreview support for convert-to endpoint of onlineMuhammet Kara1-5/+31
Change-Id: I31e4f3cbcf0cf49c5446d9460bd42965ce756c0d Reviewed-on: https://gerrit.libreoffice.org/80397 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/80461 Tested-by: Jenkins
2019-10-09lok: Avoid accidental removal of filter optionsMuhammet Kara1-9/+3
Change-Id: I178bcb19aa3073ea72a3bc8712e5e904665b1510 Reviewed-on: https://gerrit.libreoffice.org/80463 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-10-04Related: tdf#127529 make it harder to misunderstand this VirtualDevice ctorCaolán McNamara1-2/+2
Change-Id: I250bc68da118a994a2e0ff8ab9eb11112827756d Reviewed-on: https://gerrit.libreoffice.org/80158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04use normal VirtualDevice ctor, not the obscure SystemGraphicsData variantCaolán McNamara1-6/+4
Change-Id: I4be43f692a29b1b1ee3f96bb34133f3ef0cf4eb7 Reviewed-on: https://gerrit.libreoffice.org/80151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-04Revert "uitest: make child soffice process die when parent dies"Stephan Bergmann3-29/+1
This reverts commit d35840a2111beafe018851314a624e268e3cde6a, now that 43aef04d77aafb9d055957642e62b559231f3711 "Reliably wait for soffice to terminate" makes sure that no soffice-related processes are left behind by UITests. Using PR_SET_PDEATHSIG had the following drawbacks: * It defeats debugging if a runaway process is forcefully killed by the test framework. (And there are already higher-layer mechanisms in place for the reliable termination of runaway tinderbox builds, see the commit message of 43aef04d77aafb9d055957642e62b559231f3711 mentioned above.) * It is brittle in that it can terminate soffice-related processes too early, as the signal is sent as soon as the parent's thread that spawned the child (and not the parent process as a whole) terminates. * It is Linux-only. Change-Id: Ia07f5dbaafc824bad0dfbdb1a2aabe6d5508741b Reviewed-on: https://gerrit.libreoffice.org/80186 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-03drop some unnecessary includesCaolán McNamara1-5/+1
Change-Id: I656ed2e29988fe47e4db8fa2ea8edec022bd56c2 Reviewed-on: https://gerrit.libreoffice.org/80098 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02Unit test for removeTextContext.Michael Meeks1-0/+39
Change-Id: Ib75259f1680fac41a84caeef57718203ec9c4b86 Reviewed-on: https://gerrit.libreoffice.org/79880 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02input: ensure that removeTextContext happens in the right order.Michael Meeks1-2/+19
Unfortunately the backspace key-events we emit trigger uno accelerator handling, which happens another PostMessage further out, so cheat by doing it synchronously, and relying on the PostMessage inside to get the ordering right. Change-Id: Ibee80af7674fd5107cb1c9ba323071ac024c45ae Reviewed-on: https://gerrit.libreoffice.org/79883 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02Ensure that 'input' events are processed asynchronously too.Michael Meeks1-13/+1
Change-Id: I715eadd444e428148cfff8a61436987517004fae Reviewed-on: https://gerrit.libreoffice.org/79882 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02LOK: disable LOKit in unit-tests only after destroying allAshod Nakashian1-85/+5
When we disable LOKit at the end of a unit-test, we do so before any of the smart-pointers go out of scope. These instances are then destroyed when LOKit is no longer active, in spite of the fact that they were created while it was. This leaves some dialog/window routing notifiers dangling, which cause assertion failures and access-after-free (when they are invoked on destruction inadvertently). The latter issue was found with 'make CppunitTest_sd_tiledrendering VALGRIND=memcheck'. The fix is to move these flags to the setup and teardown stages of cpp-unit. Change-Id: Ic4481305ca1a5cca14d70a4ebbc820a3fdeea9cc Reviewed-on: https://gerrit.libreoffice.org/80028 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-02extend popup handler to cover all CommandEventsCaolán McNamara1-3/+3
Change-Id: I26360ce5c696d0e571385d83a15876eb2286e12f Reviewed-on: https://gerrit.libreoffice.org/80021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-02tdf#127711 - A runtime-switch for the MiniCrashDumpJuergen Funk1-10/+33
- in soffice.ini (sofficerc) the entry "CrashDumpEnable" default is "true" - when false then the Dump.ini and the dump-file are not written - when the switch --disable-crashdump is set, then the switch "CrashDumpEnable" set to "false" - when the entry "CrashDumpEnable" is missing, in this case is the default true, too - the checkbox under Options-General "Send crash reports to ..." is deactive and shows off (only view, not change the config) - when set the environment variable "CRASH_DUMP_ENABLE" to any char then the switch "CrashDumpEnable=false" are overrules with true and the Dump.ini and dump-file are write Change-Id: I34e7795640eb95d111e18b0ad46ec67b2c126b19 Reviewed-on: https://gerrit.libreoffice.org/79273 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-02Refactoring of the class CrashReporterJuergen Funk5-79/+89
- remove double code - using of all the methode of the CrashReporter-Class - all methode only active when crash-dump enable except the addKeyValue With this change the handling for the patch tdf#127711 A runtime-switch for the MiniCrashDump would be simpler Change-Id: I339b3b8e06f7fc2cd3c0d34ece112a6fd352913a Reviewed-on: https://gerrit.libreoffice.org/79272 Tested-by: Jenkins Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01uitest: make child soffice process die when parent diesNoel Grandin3-1/+29
using PR_SET_PDEATHSIG. Note that this can only be called by the child process in question, so we have to pass a new command line argument down to activate it. And we have to plumb it through the wrapper oosplash process. I wonder where else our testing infrastructure could benefit from this Change-Id: I55e8e9f7f4e6cc415046df04c804e51475b8a4c9 Reviewed-on: https://gerrit.libreoffice.org/79854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-01loplugin:nullptr (clang-cl)Stephan Bergmann1-3/+3
Change-Id: I9a9262a236d4257da6f65ee6b0cafbc5522c8a66 Reviewed-on: https://gerrit.libreoffice.org/79917 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-01desktop: proper error checking for crashreport ini readingJuergen Funk1-1/+3
Change-Id: I1107304a0e3f482b6a7e6110006c2f26b9cb0778 Reviewed-on: https://gerrit.libreoffice.org/79603 Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de> Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01crashreport: change addKeyValue to lower-case camelJuergen Funk2-2/+2
Change-Id: Ife5775d3a570da1fc2e4dd627456523705b64e1d Reviewed-on: https://gerrit.libreoffice.org/79601 Reviewed-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de> Tested-by: Juergen Funk (CIB) <juergen.funk_ml@cib.de>
2019-10-01lok: handling a single msg for deleting multiple charactersMarco Cecchetti2-1/+46
also includes: lok: fixing testABI failure Change-Id: I4df662a0df49a864c4b307efdd963b857bb77792 lok: missing removeTextContext implementation for Document class Change-Id: I884ad07f330afc19dfe759c08c8a17bdb4f9dcf3 Change-Id: I045d89f9fa478f37fc2917e159e044eee7e1ab31 Reviewed-on: https://gerrit.libreoffice.org/79879 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-01loplugin:stringadd in dbaccess..desktopNoel Grandin5-15/+12
Change-Id: I79966c4b5947c87658980b26bea1e0c2898f3343 Reviewed-on: https://gerrit.libreoffice.org/79887 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-30drop gtk2 supportCaolán McNamara1-1/+1
Change-Id: Ie838cabfecfef7e3225c1555536d5c9cf3b43f15 Reviewed-on: https://gerrit.libreoffice.org/77405 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop unnecessary includes and update pchCaolán McNamara1-0/+1
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937 Reviewed-on: https://gerrit.libreoffice.org/79523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26loplugin:constmethod in comphelper..desktopNoel Grandin6-12/+12
Change-Id: I3dbdc72b05c9d01cce279c783c60d191900f8b7c Reviewed-on: https://gerrit.libreoffice.org/79538 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-24Add reference marks callbackSzymon Kłos1-1/+2
Change-Id: Ic749e138356392b0c327a30cff28055f06e23e2e Reviewed-on: https://gerrit.libreoffice.org/79464 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák1-1/+2
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák4-4/+4
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-20Replace remaining occurrences of LIBO_HEADLESS with HAVE_FEATURE_UIAndras Timar4-7/+8
Change-Id: Ie2b04ee443dece851d3d96afbc932aa64369c75c Reviewed-on: https://gerrit.libreoffice.org/79084 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-20Related: tdf#127645 update dialog has a slave extension dialogCaolán McNamara2-11/+50
when the update dialog is shown, the extension dialog was created but not executed, so there isn't a dialog execution context to end, just the unexecuted dialog to "close" Change-Id: If4b522ca5f880d3ece8403b5350c846bd14a2992 Reviewed-on: https://gerrit.libreoffice.org/79281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Related: tdf#127645 return value is unusedCaolán McNamara2-12/+2
which is handy, cause its wrong anyway Change-Id: I0b52b3ac55c264dcd53acaa80f505cabd54faa15 Reviewed-on: https://gerrit.libreoffice.org/79270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19desktop: various small cleanups in lokclipboardMiklos Vajna1-5/+5
1) virtual is redundant when override is used 2) LOKTransferable::initFlavourFromMime() had different parameter names in the function declaration and definition 3) const-qualification on nInCount only had an effect in the function definition, not in the declaration Change-Id: I773f1f3cb5bac137a49c7e3b9ecb9b9bdf606268 Reviewed-on: https://gerrit.libreoffice.org/79111 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-17WIN make sure bootstrap.ini is openend read-onlyThorsten Behrens1-1/+2
As fstream opens read-write by default, and obviously usually program dir content is not modifiable.. Change-Id: I16ade5a87e50c2e94d3f4df3f59fc298b40ceb7f Reviewed-on: https://gerrit.libreoffice.org/79061 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-09-13WIN allow setting a memory limit for soffice.binJan-Marek Glogowski2-0/+55
This adds a Win32 section and two keys to the bootstrap.ini, which can be used to apply a memory limit to the soffice.bin process on Windows. Per default the limit won't affect any sub-processes, because the 2nd key adds JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK to the Jobs' flag list. To activte the limit, extend the bootstrap.ini like this: [Win32] LimitMaximumMemoryInMB=0 ExcludeChildProcessesFromLimit=true and adapt the values to your needs. Zero disables the limit. Change-Id: Ic474c6d6cdfe5ff3cfadbe6614030442171df1ae Reviewed-on: https://gerrit.libreoffice.org/78819 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-09-12desktop: mark LOKClipboard as finalMiklos Vajna1-1/+1
Otherwise the virtual member function calls in the constructor would be dangerous. Change-Id: I2fece2ca5718deafe0b88a774208c553e630b411 Reviewed-on: https://gerrit.libreoffice.org/78824 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-06Fixing "...."Andrea Gelmini2-2/+2
Change-Id: Id005a7531d546dd43de13b49bcb3e93081c5ad8d Reviewed-on: https://gerrit.libreoffice.org/78679 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I7eacff7dd5bf1e8ae70d2bca0bc852b8a45eeeec Reviewed-on: https://gerrit.libreoffice.org/78428 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-02Unnecessary to convert Locale to LanguageTag twiceEike Rathke1-2/+3
Change-Id: Ie2de1a8c5555ac1f8a46cacd052efc1a03e6f2ac Reviewed-on: https://gerrit.libreoffice.org/78395 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-09-02Resolves: tdf#126042 measure text width with the bold font it will render withCaolán McNamara1-1/+1
Change-Id: I81cc0351e652c632bd85efa6dacb36be66fcfb3c Reviewed-on: https://gerrit.libreoffice.org/78385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-01Fix '..'Andrea Gelmini2-2/+2
To complete this: https://gerrit.libreoffice.org/#/c/78312/ This is a massive replace for lines ending with ".." instead of "..." It passed "make check" on Linux. Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe Reviewed-on: https://gerrit.libreoffice.org/78356 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-08-31Fix MSVC2019 build after 629dfff3c7289f185268c7088e67931f6bbd9ce0Mike Kaganski1-0/+4
... failing like this: [CXX] desktop/source/app/sofficemain.cxx C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\um\winnt.h(656): error C4005: 'DECLARE_HANDLE': macro redefinition C:\lo\src\core\include\sal/main.h(91): note: see previous definition of 'DECLARE_HANDLE' C:\PROGRA~2\WI3CF2~1\10\Include\10.0.18362.0\shared\minwindef.h(250): error C2371: 'HINSTANCE': redefinition; different basic types C:\lo\src\core\include\sal/main.h(93): note: see declaration of 'HINSTANCE' make[1]: *** [C:/lo/src/core/solenv/gbuild/LinkTarget.mk:293: C:/lo/src/core/workdir/CxxObject/desktop/source/app/sofficemain.o] Error 2 Apparently MSVC2017 isn't affected, since the problematic commit passed CI happliy (didn't test myself if MSVC version is actually the problem, or maybe specific Windows SDK version). Change-Id: Ibcaa3a8d09bae54e436366623fe103e8c5f58f40 Reviewed-on: https://gerrit.libreoffice.org/78334 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-31Unify executables to take version resource from default.rcMike Kaganski21-118/+20
Pass file description in optional second argument to gb_Executable_add_default_nativeres. Remove duplicating version resources from officeloader.rc and launcher.rc. Change-Id: I55c4fc85c470c3dd6f03d909a39459839e70b9cd Reviewed-on: https://gerrit.libreoffice.org/78333 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-31Add version resource to executables where it was missingMike Kaganski6-0/+12
Change-Id: Iee965c3f720827b20347f6228e891562c8295d22 Reviewed-on: https://gerrit.libreoffice.org/78327 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-30Replace is_soffice_Impl hack with a better(?) hackStephan Bergmann1-0/+3
...that involves adding a second, one-off special meaning to the existing sal_detail_initialize function. This at least gets rid of the "osl_getExecutableFile contains 'soffice' substring" guesswork (and of the osl_systemPathGetFileNameOrLastDirectoryPart call there, which is what I'm actually after, for a different change to come). Change-Id: I4dd6eef1fd0411bf66943ffea415876c92d08526 Reviewed-on: https://gerrit.libreoffice.org/78291 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-29cid#1448379 silence Explicit null dereferenced false positiveCaolán McNamara1-0/+1
Change-Id: I5ff321520dd38f644b66bb78918035b512d5e67f Reviewed-on: https://gerrit.libreoffice.org/78090 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>