summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2018-03-07Use for-range loops in desktop (part2)Julien Nabet7-144/+113
+ use 1 time replace size() > 0 by !empty() Change-Id: If62a17171fc09e0bead7c0a791758705f62920d1 Reviewed-on: https://gerrit.libreoffice.org/50847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05Use for-range loops in desktop (part1)Julien Nabet20-214/+175
+ remove some useless typedef + some reindent Change-Id: Ic1e445a7096b1663ca8cbc58c40bb8f7af0c70e1 Reviewed-on: https://gerrit.libreoffice.org/50787 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-05Resolves: tdf#116188 set min version on all .ui files to 3.18Caolán McNamara5-5/+5
which is already the min for the runtime Change-Id: Ifebe099f1f94a36f65a31989689400327a823dcd Reviewed-on: https://gerrit.libreoffice.org/50776 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-05Make LibreOffice buildable on Haiku.Kacper Kasper1-0/+2
* Obviously VCL wiring is missing, but most components do build. Change-Id: Ie853ada1423a8f4c2b647be59cd47a7730c42978 Reviewed-on: https://gerrit.libreoffice.org/50293 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-05loplugin:useuniqueptr in TheExtensionManagerNoel Grandin2-7/+4
Change-Id: Ic45feadb64410b3f7833edd52af118436cd9763d Reviewed-on: https://gerrit.libreoffice.org/50715 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02delete colordata.hxxNoel Grandin1-1/+0
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01...and some more asserts during CppunitTest_desktop_dialogs_testStephan Bergmann3-8/+8
Change-Id: I0a585ff4a0538c606153cb9d527838f5b50623a8 Reviewed-on: https://gerrit.libreoffice.org/50521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28Don't do unnecessary check for trailing slashMike Kaganski1-7/+0
The check is done in utl::TempFile::SetTempNameBaseDirectory Change-Id: I62b40a4f53f68da14aae6fcdfbf4c2dc7515a2c5 Reviewed-on: https://gerrit.libreoffice.org/50501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28lok: update main threadHenry Castro1-0/+2
In the pre-initialization phase of the tiled rendering case the SvpSalInstance is created in a different process and when a new process is created (fork), the main thread identifier does not match so it is required to update it. Change-Id: I189e53f0b46c60f34a8016222079c9b1e2b3fef8 Reviewed-on: https://gerrit.libreoffice.org/50477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-28Clean up Desktop::CreateTemporaryDirectoryStephan Bergmann1-12/+5
...avoiding the confusing, and apparently unnecessary back-and-forth between system path and file URL. (Superseding <https://gerrit.libreoffice.org/#/c/50422/> "Don't overwrite system temppath with old one that failed already".) Change-Id: I247982a40d54565f5c98bda9a36209cba83c5c9f Reviewed-on: https://gerrit.libreoffice.org/50494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28sneaky uppercase OK,CANCEL,HELP responsesCaolán McNamara2-7/+7
Change-Id: I02324d31822c37daa1e5e1b8c87aa597def58957 Reviewed-on: https://gerrit.libreoffice.org/50437 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27Fix build, for real this timePranav Kant1-3/+8
Add a few missing processEventsToIdle()'s in the tests. Let's disable one of the assertion until I figure out what's going on. Change-Id: I82cbe443b4013d4402151ddae4b06044dfb394bd
2018-02-27Fix buildPranav Kant1-1/+1
Fallback from 0a1a3a64823c0509c4b5f1edc6ee51ca991d3501 Change-Id: I1a8390fd5c5d40521f7810ee57f5028d91456849
2018-02-27lok sc: Post mouse events to main threadPranav Kant1-70/+0
Change-Id: I1311938d7c01d0e3bfd239743e6cb2148da56cdf Reviewed-on: https://gerrit.libreoffice.org/50253 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-02-27postExtTextInputEvent() -> postWindowExtTextInputEvent()Pranav Kant1-6/+6
Let's avoid the confusion and name all these new APIs that can post both to document and window to have 'Window' in their name. The ones without window are the old APIs. In future, we can have postWindow{Key,Mouse}Event() to post to both document and window and deprecate the existing post{Key,Mouse}Event()s. Change-Id: I1f55386e7790e9c5b5d023b8831f3cd1e6faa2bb
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke1-1/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin3-6/+6
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara1-5/+6
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin1-1/+1
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin1-9/+7
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25convert all help responses to gtk's -11Caolán McNamara4-5/+5
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23get headless build to work again for LinuxThorsten Behrens2-2/+2
This makes --disable-gui option build successfully again - which means we again run on a headless server w/o any X11 or OpenGL libs. Change-Id: I60019af571aecdac277adbe6d34d5fff065014f9 Reviewed-on: https://gerrit.libreoffice.org/50214 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-22weld native message dialogsCaolán McNamara7-73/+79
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann1-1/+1
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21lok: support of AutoCorrect -> While Typing menu in WriterAndras Timar1-1/+2
Change-Id: I7c07f3a6269cd4b92cc50f7aaf847faf04665029 Reviewed-on: https://gerrit.libreoffice.org/50068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-21New loplugin:nestedunnamedStephan Bergmann1-5/+0
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c Reviewed-on: https://gerrit.libreoffice.org/50048 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-19fix updater on windowsMarkus Mohrhard1-1/+1
Change-Id: Ib6f2334a3f6f3f5c217a71e2967a69e354b0a473 Reviewed-on: https://gerrit.libreoffice.org/49956 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-16Revert "loplugin:changetoolsgen in dbaccess..desktop" and reapply pluginNoel Grandin2-10/+10
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit a9ca38bdf7ff9d15529b5903e640987fc14c0fa7. Change-Id: I662ef2f1100a06a68decb2c71975fbc61aeaa47d Reviewed-on: https://gerrit.libreoffice.org/49847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16native dialog initial basisCaolán McNamara1-2/+2
Change-Id: I392be563e38257390f748c70bb71c67a66778ddd Reviewed-on: https://gerrit.libreoffice.org/49677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-14desktop: allow disabling recovery via config keyMiklos Vajna1-1/+3
The documentation suggests this should disable recovery, so read the config value at the same place where we disable recovery due to the environment variable. Change-Id: I342ae58201aa1d731a5913c2f0598ddff2a8d602 Reviewed-on: https://gerrit.libreoffice.org/49706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-14lok IME: support dialogs as wellPranav Kant1-5/+31
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e Reviewed-on: https://gerrit.libreoffice.org/49714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-14lok: check if an element exists in the containerHenry Castro1-2/+3
Change-Id: I5987e90d92a2ebff654a993fb77e389bd036a8f8 Reviewed-on: https://gerrit.libreoffice.org/49693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2018-02-14loplugin:changetoolsgen in dbaccess..desktopNoel Grandin2-12/+12
Change-Id: I713a320e46f93dedd11266ac12e52110d13f451a Reviewed-on: https://gerrit.libreoffice.org/49655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-13Increase resolveUnoURL timeout from 20 to 40 secStephan Bergmann1-2/+2
(Used when a unopkg process talks to an soffice process, or a unopkg or soffice process talks to a uno process.) Jenkins lo_ubsan ASan+UBSan builds quite often fail in CustomTarget_odk/build-examples with connections from an unopkg process to a uno process (that has just been forked by the unopkg process) timing out. Lets see if increasing the timeout will fix that. Change-Id: Ifcd886f00670f86bb8975a206c89f565d409912e
2018-02-13loplugin:salcall (Extension_test-{active,passive})Stephan Bergmann2-5/+5
Change-Id: I4cb850a4ceb44dfe2807afe38f3fa131e6590932
2018-02-13Fix !LIBO_INTERNAL_ONLY code (Extension_test-active)Stephan Bergmann1-1/+1
...by reverting the broken part of 2c05d758b2b62c9df413e2514fb3cd233d0f3ec7 "add << operator for css::uno::Exception" Change-Id: I1b625dad2050b7549338f148c016a515e42adeb6
2018-02-13In comments: fix typo and normalize on "sub-command"Stephan Bergmann1-3/+3
Change-Id: I57f7d98edef10cb64b106b326869a594cc2f8d42
2018-02-12lok: enable pre-loading with Vcl's builderMichael Meeks1-1/+5
Cache vclbuilder's loaded modules globally & simplify logic. Pre-populate that cache on preload for LOK vs. a somewhat inelegant pre-canned list of dialog libraries. Change-Id: I86d936862a41495fd37908f3ee7eb2e0c363d651 Reviewed-on: https://gerrit.libreoffice.org/49550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-08sw lok: IME support + unit testPranav Kant2-1/+21
Change-Id: I557493db23dfa3529606050c86161628dbd722e7 Reviewed-on: https://gerrit.libreoffice.org/49354 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-02-01desktop: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski6-39/+0
Change-Id: I61ed9700c904b7499166d32e4ffda69811d64a8b Reviewed-on: https://gerrit.libreoffice.org/48973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-29Function already take const OUString&Mike Kaganski1-2/+2
Change-Id: I87af48158b4afaf81da8545f9bccf459f11031d6 Reviewed-on: https://gerrit.libreoffice.org/48823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-29Fix typosAndrea Gelmini1-1/+1
Change-Id: Iedd82d035454c940d76a94c7e910c81827c1389c Reviewed-on: https://gerrit.libreoffice.org/48828 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-27lok: Allow whitelisting languages that should be used by LibreOfficeKit.Jan Holesovsky1-1/+1
LOK may get way too many languages if there are dictionaries for them installed which blows the pre-init to >2G easily; let's allow limiting that. Also make the preloading of languages work with the internal spell checking dictionaries and thesauri. Change-Id: I77119970030a7386a5cccbe4fdc89b15eab56ef1 Reviewed-on: https://gerrit.libreoffice.org/48720 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-01-26coverity#1428612 silence reasonable 'Unchecked return value' warningCaolán McNamara1-1/+1
Change-Id: If22f31471e0d15b6523355a44938c864b074ac93
2018-01-26tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorekuiitr4-6/+4
Change-Id: Idc14e71c732ce031b9bec556401dc84fd0757b6b Reviewed-on: https://gerrit.libreoffice.org/48636 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25lok: Send the enabled / disabled state of .uno:TransformDialog.Jan Holesovsky1-0/+1
Change-Id: If2d8e0da6c289deb65dc8a6b38a21dfd5bbfc1bd Reviewed-on: https://gerrit.libreoffice.org/48534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25Initialize more for sharing during pre-init.Michael Meeks1-0/+17
Change-Id: I12b90504ec9161318683ebad8f8e4dd1e614da89 Reviewed-on: https://gerrit.libreoffice.org/46120 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/48510
2018-01-25lok: Preload thesauri too.Jan Holesovsky1-3/+16
Change-Id: If2bfd3a024fc61900d3c12ff976df136d4e61bf6 Reviewed-on: https://gerrit.libreoffice.org/48502 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-01-25desktop: always clear LOK error message on successMiklos Vajna1-0/+95
Change-Id: Idefdbd3d9ae19f7cf5889017b111c12620ab08c2 Reviewed-on: https://gerrit.libreoffice.org/48541 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24Remove redundant variableMike Kaganski1-4/+2
Change-Id: I062ea13827d7d9744b0965b305877633485015fa Reviewed-on: https://gerrit.libreoffice.org/48405 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-14 06:37:53 +0000