summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2017-02-28Run macro:// via LOKitKatarina Behrens2-0/+103
Change-Id: I54d3c734d86d4b44e1dfe1ad7728e2f51cd26d53 Reviewed-on: https://gerrit.libreoffice.org/34538 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e7729f458409f7fef2b7dab752205e3b230acb65)
2017-02-28Revert "sw lok: Move this test to sw/"Pranav Kant1-0/+99
This reverts commit b7640cbb4b34df2cb05c6fbe60346bca96846924. Not much idea yet but moving it to sw/ for some reason makes callback pertaining to last 'InsertAnnotation' uno command not firing and on ubsan tinderbox even the first 'InsertAnnotation' command is a noOp failing the tests there. Lets keep it in desktop/ for now where it was earlier. Conflicts: desktop/qa/desktop_lib/test_desktop_lib.cxx Change-Id: I67f5bdeffa218ae2a7afe0896f7cdde5324a5f09 (cherry picked from commit 0f6e813827fed1baefe6001b6e9655b0aeedcc46)
2017-02-28desktop: unit test to for sd ViewAnnotations commandPranav Kant2-0/+60
Change-Id: Ib830ff786f12d9edc791623dead74b3eeeabad71 (cherry picked from commit 65cfa0eed38ceeb4e96c97b76772bb191129fd83)
2017-02-28lok: listen for DeleteAnnotation state changesPranav Kant1-0/+1
Change-Id: I2ea0d237cbbfd912b012ed400a328bfb6546cdfb (cherry picked from commit 866582435fa8ea0a76ad08d07e7df3a344072c94)
2017-02-28sc lok: Unit tests for Comments APIPranav Kant2-1/+56
Change-Id: I896c8b25cab6d80d374d273eb3945716bc0694d6 Reviewed-on: https://gerrit.libreoffice.org/34365 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 0d839366acfd932b8ae1b31b72c5eca4e102834d)
2017-02-28sw lok: Move this test to sw/Pranav Kant1-102/+3
Change-Id: I9bf901a4c8ffbdd54a98ff043ea1e658aeb62839 Reviewed-on: https://gerrit.libreoffice.org/34364 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit b7640cbb4b34df2cb05c6fbe60346bca96846924)
2017-02-24add the locale info to the crashreporter metadataMarkus Mohrhard1-0/+2
We have a few crashes that seem locale dependent. Especially the font related problems. Change-Id: I0cc977413dc2328ea705c96c2d4048e4f3c58bbc Reviewed-on: https://gerrit.libreoffice.org/32764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/34561 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4cc2f2f683ee7144823503008a6216d1c01e7852)
2017-02-18Replace a terribly expensive json parsing with a peek for the value.Jan Holesovsky1-4/+20
We should reduce the amount of callbacks from the core in the first place, so that we don't have to deduplicate this much here, but this already helps a lot. Change-Id: Idf4a3681ac0f47536e00c1d97152f3f8bb99894b (cherry picked from commit 20910ea89efb01406e35e9d942613123f78b637f)
2017-02-18LOK - Calc: Increase the row limit to 10.000 rows.Marco Cecchetti1-19/+57
Change-Id: Ie91e4caf33d3b31df4c3de8dc6e78e223dc1e4b3 Reviewed-on: https://gerrit.libreoffice.org/34216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> (cherry picked from commit eb399d69aa5ad0c04affb830a522c5c1f130813f)
2017-02-18sc rowlimit: Make the cursor better fit the rendering.Marco Cecchetti1-1/+1
Change-Id: If4d02161bd8a37100d7403c05ea0840a3d2d0cf8 (cherry picked from commit 9ba5eb228d714d1e5454049cac987a673bfce1e1)
2017-02-18SvxPostItIdItem is now string typePranav Kant1-4/+4
Change-Id: Id44bf5dd623749b6e9a46f121f035aa5ce617557 (cherry picked from commit ce96c5957c38384f8911d6307605c502eca0c644)
2017-02-18lok: Allow to edit comment by postit idPranav Kant1-0/+14
Change-Id: Ice1d40b7813226fe99c423047392b3416d763dd4 Reviewed-on: https://gerrit.libreoffice.org/33614 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 8a7c459f6afb7b8f1f622a61230a0a4411a417ac)
2017-02-18lok: Unit test for comments apiPranav Kant2-0/+141
Change-Id: Ieedb50a4d376c1214ea23b56c8cab19c96c159d0 Reviewed-on: https://gerrit.libreoffice.org/33615 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 4f60b300d230fe963d133b4725eb3e93dfb500e1)
2017-02-18lok: Allow to reply to comments using postit idPranav Kant1-0/+1
Change-Id: Ic6aaa3066923d62f197bc2b0e02e8049c9d7cd2c Reviewed-on: https://gerrit.libreoffice.org/33612 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 6e463381b43d888a632e652a873f2b5abe7e5458)
2017-02-17lokit: support password protected binary MS and OOXML documentsTomaž Vajngerl1-11/+31
Change-Id: Id7fa1f428d07271e71f3df962bd6718a35372389 Reviewed-on: https://gerrit.libreoffice.org/31730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 828e77009b5a7f3925cec37f0297208f7d38376f)
2017-02-17No glxtest library unless USING_X11Tor Lillqvist2-0/+4
Change-Id: Ibcc0eeba9beaaeea86bdda5e0ea80e54c25621a9 (cherry picked from commit 986ba9a7e8b49f0c37fbd8f855e249a9f257ad08)
2017-02-17Match conditional in Repository.mkTor Lillqvist1-0/+5
Change-Id: Ie9deeb673cd5083a2f57a502bfbf49319aa00165 (cherry picked from commit 6b60ea7f9b8bee5559cf33a9e466d30cafaf0cea)
2017-02-17lok: ensure positive values for width and heightHenry Castro1-0/+5
also check the pointer memory block allocated Change-Id: I0ded04e06f80400e64c5e58126a32ee503aeb394 Reviewed-on: https://gerrit.libreoffice.org/31388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 098fb95772b3184bb81180d1bc30c9753d30e2b6)
2017-02-17sw lok: notify repair when exist a conflict of multiple users undo/redoHenry Castro1-2/+6
Change-Id: I026f4df6239fa87ee191f92127f9fa98ac2993eb Reviewed-on: https://gerrit.libreoffice.org/31161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit 2db42ab241d0852d89a470b18727c22d0fc06745)
2017-02-17lok: avoid render font with empty rectangleHenry Castro1-0/+3
Change-Id: I58e24e0de37144ae5d67857b243e6a7091f2b77a Reviewed-on: https://gerrit.libreoffice.org/31281 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> (cherry picked from commit e2d5f1ba3fd0db00276cf48b0d9be9b16dcbf7a0)
2017-02-17lok: New commandvalues command - .uno:ViewAnnotationsPranav Kant1-0/+19
Change-Id: I1c3560ab4609c64da7a77e9a65febeb569ec1a3c Reviewed-on: https://gerrit.libreoffice.org/33468 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit a623b3a449dfcddaad5b621ff1c0b7a520edf4d6)
2017-02-17lok: New feature flag to turn off tiled annotationsPranav Kant1-0/+2
Change-Id: Ie418642242ada98d4a41f30bb6cefcd57f398ef0 Reviewed-on: https://gerrit.libreoffice.org/33472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 75d8b305bbc1c2377f23361ecd64816a350baa4c)
2017-02-17lok: Listen for state change events for cell alignment commandsPranav Kant1-0/+3
We used to use HorizontalAlignment uno command for cell alignment both in online and gtktiledviewer. To make things simpler, lets use separate cell alignment uno commands for spreadsheets like we have in writer and impres. Change-Id: I2a959d1892f6b02db7a9ce51d55309216e4b3c6c Reviewed-on: https://gerrit.libreoffice.org/33444 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit a27e09079596eeae81cced01eaeabf94d6675085)
2017-02-17lok: Fix state feedback for ToggleMergeCellsPranav Kant1-1/+0
Now it broadcasts "disabled" to disable the command and true/false to tell the status of the command which automatically means "enabled" Change-Id: I3314da77fb2b84d97f64b9832d65791b84fcd7df Reviewed-on: https://gerrit.libreoffice.org/32086 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit c5ceb0134dddb79207d3b8ddb7a36ee1ca294329)
2017-02-17Lok: unittest batch APIAshod Nakashian1-0/+45
Change-Id: I33bc59756f46b51a69efd91b89813ba17eca6218 Reviewed-on: https://gerrit.libreoffice.org/33403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f6c0e851eff8c22c0ab427245c5eb78e9f396b62)
2017-02-17Lok: support for batch API callsAshod Nakashian2-0/+30
Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 1c27286b9d5331634c073cd3e327bd941e61bbb6)
2017-02-17Lok: improved tile invalidation compressionAshod Nakashian2-91/+266
Handle corner cases better and eliminate invalid rects and out-of-bounds coordinates. Change-Id: Ib9247ae4f0306cf68937cd2678f6386fe7710eec Reviewed-on: https://gerrit.libreoffice.org/31665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 3db1ce30ab235ad22aed71c22e4f6f52b7b88829)
2017-02-17Lok: better logging and warningsAshod Nakashian1-11/+25
Change-Id: Ia933ae65197893592eeb04cb8a1a617a931ad623 Reviewed-on: https://gerrit.libreoffice.org/31606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 2a5d8d7306776cc59a6311f20f32e1007dcac858)
2017-02-17Lok: disable DesktopLOKTest::testTileInvalidationCompressionAshod Nakashian1-0/+4
For some reason this test fails on TinderBox and for others while passing on Jenkins on all platforms. This might be related to the compiler version used. Disabling until resolved. Change-Id: Ic05dbb290818506c78ceaa4c416fb00e8c0dc8da Reviewed-on: https://gerrit.libreoffice.org/31607 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit a8b2e3e948c507d71fd01b219dc77838f6bf785f)
2017-02-17Lok: correct tile invalidation mergingAshod Nakashian2-3/+42
Rectangles that are empty (i.e. IsEmpty() returns true) were incorrectly considered to mean equivalent to "EMPTY". The latter means full-area, while the former mean zero-area. This fixes the issue by restrict full-area to rectangles with 2 billion units on the each side (roughly INT_MAX) or more, and using this new check rather than IsEmpty(). Change-Id: I12aca17267f5dd33b2932012d1d9db3545f9af6f Reviewed-on: https://gerrit.libreoffice.org/31458 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 9c218858f1bd83ffdd72dd943a841cffa5a93b8c)
2017-02-17Lok: compress duplicate state-changed eventsAshod Nakashian2-1/+24
STATE_CHANGED callback events that have the form of name=value are only removed when newer ones are identical. This is not very helpful since often the same name (i.e. state type) changes its value and we need to superseed older ones with new values. This patch makes sure that a STATE_CHANGED with a given name has its latest value and doesn't change multiple times while in the queue. Change-Id: Ibfa18359464d7137411e5846b1c6d415a0aad43d Reviewed-on: https://gerrit.libreoffice.org/31258 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f80140bf3a4fa2d809167825ee04ffd0a0c19c6c)
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt1-1/+4
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 0fda52cc4a5c78c55f96850faa734ea66891808c) Reviewed-on: https://gerrit.libreoffice.org/31937 Tested-by: Jenkins <ci@libreoffice.org>
2016-12-11don't overwrite the crashreport info that are written before uploadMarkus Mohrhard1-4/+30
There was a race condition that the OpenGL code was initialized before the old report has been uploaded. Therefore the OpenGL setting was overwritten by the new start and we were not getting the old value. Now we store any value that wants to be added before the dump.ini is ready in a temporary map and will write them as soon as we write all the common information. This problem was introduced by the dialog requesting permission to upload the crash report. Change-Id: I29391a1ff56bac6381218c5a4aefb58c2c03f024 Reviewed-on: https://gerrit.libreoffice.org/31846 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> (cherry picked from commit 80049d110a742060acedb89eaad763e66d7f75a5) Reviewed-on: https://gerrit.libreoffice.org/31850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-03first cut at adding a GDI handles attribute to the windows crash report.Michael Meeks1-0/+1
Change-Id: I4e6fee65a1416398f6f59feb8734b3b00c0aed3b Reviewed-on: https://gerrit.libreoffice.org/31570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 8b86e9de388fff673bc86c14246eff8ed6aa591e) Reviewed-on: https://gerrit.libreoffice.org/31587 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-29Window::Invalidate must be called with SolarMutex lockedStephan Bergmann1-58/+74
...it internally calls Scheduler::Start, which asserts now since c00d8271ba443c4f0acf657c226eea4824597f95 "vcl: assert solar mutex is held for various timer / scheduler ops." Caused the assert to fire when removing an extension via "Tools - Extension Manager... - Remove". Change-Id: Ied0591b799af333b3a4c11af07f5f8f1657304d6 (cherry picked from commit e006b9cf2cfba5995b97a9a9551d362b7eb45572) Reviewed-on: https://gerrit.libreoffice.org/31366 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-22lok: add command values .uno:FontSubsetHenry Castro4-0/+95
Conflicts: desktop/Library_sofficeapp.mk Change-Id: Id36a98c32f0eb5e88e4e9a714e260a71d7465c05 Reviewed-on: https://gerrit.libreoffice.org/31033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-11-21tdf#103146 Revamp Extension Manager Dialog, Part 3Muhammet Kara3-84/+58
Move the "Enable"/"Disable" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also remove some unnecessary code pieces for clean-up. Change-Id: Iec7820779110eea3411a774de8277ef238f562e7 Reviewed-on: https://gerrit.libreoffice.org/30973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-17that should have been LibreOfficeKit*Document*ClassChristian Lohmaier1-1/+1
Change-Id: I48f9db39be18ae9a456002de8f40fbb0fb3be707
2016-11-16Demonstrate that (extension) .xcu can contain <item> with nested <node>sStephan Bergmann1-35/+36
This sprang from an IRC conversation with uniscript about allowing .xcd in extensions, so that an extension with (localization) data for many packages would not need one .xcu file per package, but rather only a single file. That is possible with a single .xcu file using the <item> syntax, as shown here. (I had thought that originally only registrymodifications.xcu supported the <item> syntax, but can't find any traces of that; so looks like an extension with an .xcu file using <item> syntax should be supported by OOo and derivates "since ages".) Change-Id: I1101793e6b14ba9c1e7647edab76927d4d31a81c
2016-11-16tdf#92346 - Copy functionality in the viewerChamal1-1/+2
Reference class added to desktop/source/lib/lokandroid.cxx for Java_org_libreoffice_kit_Document_getTextSelection() Change-Id: I211d5709df39fd9fafdab9232af760613f6b86c0 Reviewed-on: https://gerrit.libreoffice.org/29804 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-15tdf#103146 Revamp Extension Manager Dialog, Part 2Muhammet Kara3-112/+30
Move the "Remove" button which was customly implemented from the ExtBoxWithBtns_Impl to the new row. This should also solve some accessibility issues. Also wipe some useless code which implements custom tab behavior. Change-Id: I602fcf23631498145d8b9ead2936ee549caf3f0d Reviewed-on: https://gerrit.libreoffice.org/30867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-14lok: add character parameter to renderFontHenry Castro1-2/+8
When client side request special character, it is very useful to send a preview of the rendered font character Conflicts: desktop/source/lib/init.cxx Change-Id: I1f5727163dfcc861add121e616bdb17881c28197 Reviewed-on: https://gerrit.libreoffice.org/30784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2016-11-13drop extra semicolonsDavid Tardon1-2/+2
Change-Id: Ie6713d1bdf0010e5bc0bb70ca995c4dd36408673
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin1-2/+2
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09tdf#103146 Revamp Extension Manager Dialog, Part 1Muhammet Kara5-97/+142
Moved the "Check for Updates", and "Add" buttons to the new row, and started moving the buttons from the ExtBoxWithBtns_Impl to the new row. Needed to create new public methods to be able to update button states of ExtMgrDialog from within the ExtBoxWithBtns_Impl class. Change-Id: Iea784d0b7237da3f8aa05862dbf1faf5acf98655 Reviewed-on: https://gerrit.libreoffice.org/30560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 23:12:45 +0000