summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2019-10-08Related: tdf#127645 update dialog has a slave extension dialogCaolán McNamara2-11/+50
when the update dialog is shown, the extension dialog was created but not executed, so there isn't a dialog execution context to end, just the unexecuted dialog to "close" Change-Id: If4b522ca5f880d3ece8403b5350c846bd14a2992 Reviewed-on: https://gerrit.libreoffice.org/79283 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-03Resolves: tdf#126042 measure text width with the bold font it will render withCaolán McNamara1-1/+1
Change-Id: I81cc0351e652c632bd85efa6dacb36be66fcfb3c Reviewed-on: https://gerrit.libreoffice.org/78390 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-18scrollbar is outside the widget now, not insideCaolán McNamara1-8/+0
Change-Id: Ia92658c7a534928209906b8adfb5f9451b513ff0 Reviewed-on: https://gerrit.libreoffice.org/75798 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-07-18Resolves: tdf#126304 resizing the extension manager breaks redrawCaolán McNamara1-0/+1
Change-Id: I1211c90a72048f868ec7ba7a7b6bed452ae8ac4b Reviewed-on: https://gerrit.libreoffice.org/75792 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-06-17tdf#125691: use _exit() instead of exit()...Dennis Francis1-1/+1
for ExitTimer which is used exclusively for the case when OOO_EXIT_POST_STARTUP is set, so that there is no waiting around for ThreadPool's threads to get joined. Setting OOO_EXIT_POST_STARTUP already evades any proper destruction of objects in the heap, so using _exit() instead of exit() here does not make things any worse w.r.t the purpose of this env var. Change-Id: Ib4a253d6e1a3fd8593e4a2115a51cf4c10344b3c Reviewed-on: https://gerrit.libreoffice.org/74016 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit d39846bfd16ad9873795149c370a95f42363bfd9) Reviewed-on: https://gerrit.libreoffice.org/74153 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-15remove some unused includesCaolán McNamara11-57/+10
Change-Id: I1a3512fd7fd50379ecd25389a894c2a3aadb7edb Reviewed-on: https://gerrit.libreoffice.org/74065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-14weld ExtMgrDialog and UpdateRequiredDialogCaolán McNamara12-769/+715
Change-Id: I97e5cda847fd7f98990a87d0b1ca6d6b8b3f9d0f Reviewed-on: https://gerrit.libreoffice.org/74051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13no need for awt::Toolkit::create in UpdateDialogCaolán McNamara1-11/+0
since... commit bb3daa7351f0b07e6f4331c19837081e6c3e30b8 Author: Frank Schoenheit [fs] <frank.schoenheit@sun.com> Date: Thu Oct 7 13:54:14 2010 +0200 dba34b: #i112779# no need to use a UNO control/peer for the throbber - it exists as VCL control now Change-Id: I561642d78d76ab970ee12b6b2b2fbdd0be2850e5 Reviewed-on: https://gerrit.libreoffice.org/73955 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13drop intermediate IExtensionListBox classCaolán McNamara3-31/+16
Change-Id: I415645fd61113577deef404cceb02d72d541291d Reviewed-on: https://gerrit.libreoffice.org/73974 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-13move IExtensionListBox to where its usedCaolán McNamara3-10/+27
Change-Id: I73401787032643c4881934864d2ec1e0389e2cf2 Reviewed-on: https://gerrit.libreoffice.org/73897 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d18f31c4c9d6169f48f34bc53615a5a93a822aa7) Reviewed-on: https://gerrit.libreoffice.org/73938 Tested-by: Jenkins
2019-06-02drop some unneeded includesCaolán McNamara1-1/+0
Change-Id: I13019ae1b991b5910c50e760a8a825bcf50509d2 Reviewed-on: https://gerrit.libreoffice.org/73336 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-28drop some unneeded includesCaolán McNamara1-1/+0
Change-Id: I42b2ccbb4484ab2acb8208ad88c6f22e4af09f7d Reviewed-on: https://gerrit.libreoffice.org/73114 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-27disable a few failing unit tests in MPLv2 subsetAndras Timar1-0/+3
Change-Id: If7595983f7bf2d990687a64659a63a8a66b120bd Reviewed-on: https://gerrit.libreoffice.org/73049 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-24Fix typo in help: 'urb' => 'urp'Jan-Marek Glogowski1-2/+2
Introduced in commit a4066c770fec ("Fix documented 'soffice --accept' parameter syntax"). Change-Id: Iaa8e821abeb8bdbce36091c4d0264f658c677a76 Reviewed-on: https://gerrit.libreoffice.org/72905 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-23Fix documented 'soffice --accept' parameter syntaxJan-Marek Glogowski1-5/+7
The parameter value for '--accept' is no UNO-Url, but uses a similar syntax. This was wrongly changed in commit d78f29ab3f40 ("tdf#100836 "Starting the LibreOffice Software With Parameters" help update"). So this changes the parameter value back to {accept-string}, documents its syntax and adds some common examples. Change-Id: If8159b1d982c54e3dca6d27a1c400d2450ff2d1e Reviewed-on: https://gerrit.libreoffice.org/72859 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-05-23sw: add IgnoreComments parameter to .uno:PasteMiklos Vajna2-0/+19
Which allows not hardcoding true for LOK. Change-Id: I644763ba052b148fc34283e361aa02f9bba2c5ee Reviewed-on: https://gerrit.libreoffice.org/72832 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-22New loplugin:dataStephan Bergmann2-2/+2
...following up on 1453c2c8f13bac64ecd1981af7cebf1c421808ac "prefer vector::data to &vector[0]" Change-Id: I7c113747d92d144a521d49b89384dd8bf1215c01 Reviewed-on: https://gerrit.libreoffice.org/72765 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-21tdf#125397: Fixes for threads and SolarMutex on iOSTor Lillqvist1-1/+14
We need to call SfxApplication::GetOrCreate() in lo_initialize() now. Otherwise we will crash in sfx2. No idea why it worked earlier. I think we want to avoid the "VCLXToolkit VCL main thread" ever running in the iOS app. I don't think we had it running earlier, but now for some reason it got started when creating a document from a template, and that seemed to cause a hang. Also, when creating a document from a template, lo_initialize() is called from the app's real main thread (the one that the process starts in). In that case we do want to release the SolarMutex after InitVCL() if this was the first time we called InitVCL(). Awful crack. Not really sure I fully understand all that is going on, but this change does seem to fix recent problems... All this thread and SolarMutex stuff is so incredibly fragile. Change-Id: Ib04498ad199b64f27701f89d2df7003bca316406
2019-05-20lok: chart: constrained dragging of pie segmentsMarco Cecchetti1-15/+17
The extra information for the graphic selection is now formatted according to JSON syntax so that is easier to parse. Information for allowing the client to performa constrained dragging of a pie segment is appended when needed to the graphic selection message. A polygon approximation of the pie segment in svg format is attached too to the graphic selection message. Core now is able to handle a specific msg from the client with data about the new pie segment offset computed by the client on drag end. This information is dispatched by the chart controller to a specific method: executeDispatch_LOKPieSegmentDragging. Change-Id: I42e7742508fa3a453383bf7b95e47df169f24834 Reviewed-on: https://gerrit.libreoffice.org/70568 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: dragging and resizing chart elementsMarco Cecchetti1-2/+43
This patch make possible to set the new position or size of a chart object through setting directly the property value instead of sending mouse events to the core. Change-Id: Ifc06dac6bdad78081d63e0ea0db55563a1ae57bc Reviewed-on: https://gerrit.libreoffice.org/70566 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-20lok: shape selection: perform the needed unit conversion in a clever wayMarco Cecchetti1-0/+32
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5 Reviewed-on: https://gerrit.libreoffice.org/70563 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2019-05-18remove remaining '0' responsesCaolán McNamara1-2/+2
Change-Id: I3134c8dcc92b82ab2c6008b3e39443a360f576eb Reviewed-on: https://gerrit.libreoffice.org/72499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-18Fix typoAndrea Gelmini1-1/+1
Change-Id: I052de7eabad2b406b258404efd75293b6b49625d Reviewed-on: https://gerrit.libreoffice.org/72504 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-18Fix typoAndrea Gelmini1-2/+2
Change-Id: I1394c7b15ce39d553e6476d5e19731167b220e9d Reviewed-on: https://gerrit.libreoffice.org/72503 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-16We apparently need to drop the Solar Mutex when exiting lo_runLoop() on iOSTor Lillqvist1-4/+11
It seems to be held after soffice_main() returns for the first document opened, but not subsequent ones, for some reason. So acquire it an extra time to be able to use Application::ReleaseSolarMutex()... Without this, when opening a subsequent document, the loleaflet loading progress bar just hangs. Change-Id: I4e4e7b814f0dba836b790b6f68470aab54f8bbb9
2019-05-14lok: test show/hide status of a windowSzymon Kłos1-0/+37
Change-Id: I610fa6c5b7f19a7c995e02c4aa50e55090271642 Reviewed-on: https://gerrit.libreoffice.org/72230 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-05-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I94019a8e77749f7e719eee8a1b872df6589283df Reviewed-on: https://gerrit.libreoffice.org/72258 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-14Fix typoAndrea Gelmini1-1/+1
Change-Id: I2b2680dfcac400d582124ad84399e41891afb695 Reviewed-on: https://gerrit.libreoffice.org/72259 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-14Fix typoAndrea Gelmini1-1/+1
Change-Id: Ied41845bd6c2e42e14a16c72c1e7d3a527502375 Reviewed-on: https://gerrit.libreoffice.org/72261 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-14Fix typoAndrea Gelmini1-2/+2
Change-Id: Ia8f5ca10c974a0ba2d1686b341ef2a1dd44b824d Reviewed-on: https://gerrit.libreoffice.org/72260 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-14Fix typoAndrea Gelmini1-1/+1
Change-Id: I305e152b6d6e71eba8d568b66c80b53e3bf27db0 Reviewed-on: https://gerrit.libreoffice.org/72262 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini1-1/+1
Change-Id: I130839cbd400aad3f9f0691652df19e680346481 Reviewed-on: https://gerrit.libreoffice.org/72252 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini1-1/+1
Change-Id: I81d227fa99058ea0d13576d36897f186164b6ad6 Reviewed-on: https://gerrit.libreoffice.org/72251 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix typoAndrea Gelmini1-1/+1
Change-Id: Ie7861296de4d70dc03889212a359537d45a0c7bd Reviewed-on: https://gerrit.libreoffice.org/72250 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-13Fix comment to match realityTor Lillqvist1-1/+1
lo_runLoop() *is* used in the "Unipoll" case (i.e. current Online and mobile apps). Change-Id: I01ef3d8bc8140531f697952ef142150fc905a8d4
2019-05-13fix wrong SET/QUERY flags passed to uno::ReferenceNoel Grandin5-6/+6
By creating deleted methods for the wrong calls. Avoids the compiler needing to construct a temporary Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a Reviewed-on: https://gerrit.libreoffice.org/72103 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-12regenerate PCH headersLuboš Luňák2-4/+4
Change-Id: I4894023e42cbfa32916ee3ddfb2cfb5426cfc69f Reviewed-on: https://gerrit.libreoffice.org/72195 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: I5782a3968485c919728f0db70088e3727f0b18fb Reviewed-on: https://gerrit.libreoffice.org/72182 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: Ib108b098aec8a4607cff765cc20d797b8bb79ca6 Reviewed-on: https://gerrit.libreoffice.org/72184 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-12Fix typoAndrea Gelmini1-1/+1
Change-Id: Icb3714d9bc62b70dc57c07b0fad64ca6fea7c3e7 Reviewed-on: https://gerrit.libreoffice.org/72183 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-10unipoll: let InitVCL tolerate double init.Michael Meeks1-18/+9
We need to get VCL initialized early in UniPoll mode, since the main setup doesn't occur until runPoll is invoked, and we want to call lots of virtual methods that take the SolarMutex before then - which requires VCL to be initialized. Change-Id: Id9c1b74c126cf7bb71d6560b7585d37327a9f5ef Reviewed-on: https://gerrit.libreoffice.org/72071 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-10an uno -> a unoCaolán McNamara2-3/+3
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d Reviewed-on: https://gerrit.libreoffice.org/72105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10an is used before a vowel soundCaolán McNamara8-11/+11
not before vowels with a consonant sound so its a url not an url Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2 Reviewed-on: https://gerrit.libreoffice.org/72062 Reviewed-by: Jens Carl <j.carl43@gmx.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-09CppunitTest_desktop_lib: close the document while LOK is still activeMiklos Vajna2-104/+18
Otherwise the LOK notifiers won't be released (since LOK is not active), and we leak vcl::Windows in GetLOKWindowsMap()::s_pLOKWindowsMap. In dbgutil builds, this leads to an assertion failure if the sidebar is active. Change-Id: Idedb9578478ff4a9f2e17c0cfd203da6f007bdbd Reviewed-on: https://gerrit.libreoffice.org/72065 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-09regenerate PCH headers for the 4 new levelsLuboš Luňák4-127/+63
Plus some build fixes triggered by this. Change-Id: I59b21def706598ceffd45ae5b1f0262ec9c1ad50 Reviewed-on: https://gerrit.libreoffice.org/71581 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-05-08desktop: can pass by value in LOKTransferableMiklos Vajna2-4/+3
Change-Id: Iba7c216f28700e8899d76942a4a0a8b77ed3c549 Reviewed-on: https://gerrit.libreoffice.org/71930 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-05-07unipoll: emit user input-events & uno commands directly when in unipoll mode.Michael Meeks1-4/+7
Rather than emitting asynchronously at idle. Change-Id: I6c72e9fad0b5587941e3a4a4d17d331a0d889942 Reviewed-on: https://gerrit.libreoffice.org/71809 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-06desktop: turn on clang-format for lokclipboardMiklos Vajna2-18/+19
This had manual consistent formatting. Recently it was broken, so bring back consisency by using clang-format. Change-Id: If4303e379ddc77e5190f8e8e42737b4f7d680a71 Reviewed-on: https://gerrit.libreoffice.org/71857 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-05-04unipoll: cleanup runPoll.Michael Meeks1-2/+5
Setting a custom thread name is a terrible idea for online unit tests. Change-Id: I1f5843255ab59072f806587ffcf655958380fe8e Reviewed-on: https://gerrit.libreoffice.org/71762 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-03unipoll: get SolarMutex lock counting right.Michael Meeks1-0/+1
lo_startmain drops the SolarMutex without taking it, interestingly. Change-Id: I2280e2fa6acb8739f970983032db72a8241d1c4f Reviewed-on: https://gerrit.libreoffice.org/71741 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-30 13:26:52 +0000