summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2020-04-22Get local, no-upload crash dumps working againThorsten Behrens1-1/+4
With this, CrashDumpEnable=true and CrashDumpUrl missing will create local dmp files, but never upload/present GUI for it. Change-Id: I0bae48a0accace01dc8507cccb2a7b02a4de61a0
2020-04-21Some optimisations around crashreporter status queriesThorsten Behrens2-2/+8
* make dump enable status query static * only offer crash UI if dump is enabled Change-Id: I71aff4c6ca5a73e4d1db6163cdf8dec75b9e7538
2020-04-21Revert "Disable crash reporter UI"Thorsten Behrens1-3/+2
This reverts commit 914f171f2470aea4453fee75ce1d9da5615bbb0b.
2020-04-21related tdf#127711: read crashdump URL from ini fileThorsten Behrens1-1/+10
Change-Id: I68f06aaf5b8c053d1deef2021876b1399e422dd7
2020-04-21Delete google_breakpad::ExceptionHandler before calling _exit()Mike Kaganski3-61/+50
While debugging tdf#129712 on Windows, I saw this sequence: 1. nullptr was dereferenced (the reason for tdf#129712). 2. ExceptionHandler::HandleException was called (in workdir/UnpackedTarball/breakpad/src/client/windows/handler/exception_handler.cc). 3. It called ExceptionHandler::WriteMinidumpOnHandlerThread. 4. Minidump was created in ExceptionHandler::ExceptionHandlerThreadMain. 5. Document Recovery dialog was shown in Desktop::Exception (in desktop/source/app/app.cxx). 6. After closing dialog, _exit() was called in Desktop::Exception. 7. All threads except main were terminated. 8. Another access violation was thrown in the "minimal CRT cleanup". 9. ExceptionHandler::HandleException called again. 10. ExceptionHandler::WriteMinidumpOnHandlerThread hung on WaitForSingleObject because handler thread that should release the semaphore was terminated already at step 7. The process had to be killed manually. This change destroys the breakpad handler at the start of Desktop::Exception, which de-registers itself (on Windows it uses SetUnhandledExceptionFilter). Other than preventing the hang, the rationale also is that keeping the handler after first minidump creation is wrong: even if the second minidump creation succeeded, uploading it to crashdump server would give not the actual problem, but some unrelated stack. Change-Id: If12d0c7db519693f733b5ab3b8a288cef800a149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86104 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 12b5892cf9c78dd917f2e50672cd250478e6c7d6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89690 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-21tdf#127711 - A runtime-switch for the MiniCrashDump and associated changesJuergen Funk5-81/+116
- add CrashDumpEnable to soffice.ini - also check env var CRASH_DUMP_ENABLE (overrides soffice.ini) - make sure _all_ binaries are added to symstore This is a squash of: https://gerrit.libreoffice.org/79273 https://gerrit.libreoffice.org/81989 https://gerrit.libreoffice.org/c/core/+/87260 https://gerrit.libreoffice.org/c/core/+/87261 https://gerrit.libreoffice.org/79272 https://gerrit.libreoffice.org/83171 https://gerrit.libreoffice.org/82751 https://gerrit.libreoffice.org/83066 https://gerrit.libreoffice.org/83726 https://gerrit.libreoffice.org/c/core/+/86465
2019-11-04SharePoint connection: Better handling of encoded URLsTamás Zolnai2-5/+5
Handle %7c with small letters. Make sure that the output parameter's content is not affected by decoding. Change-Id: Ie3faad2461815497c0edfb04a589fc57aeb7d66b Reviewed-on: https://gerrit.libreoffice.org/70873 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit f6dc5636c1eda8aebeac3f7b85dd61499523d6a3)
2019-11-04SharePoint connection: Handle encoded URL passed as command line argumentTamás Zolnai2-0/+27
Change-Id: I3352bf9ade88bd86f7ca3d53238364216547d52b Reviewed-on: https://gerrit.libreoffice.org/70830 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 2317ad572cc330c4c2de95065ef275f58a9c83a1)
2019-09-17WIN allow setting a memory limit for soffice.binJan-Marek Glogowski2-0/+56
This adds a Win32 section and two keys to the bootstrap.ini, which can be used to apply a memory limit to the soffice.bin process on Windows. Per default the limit won't affect any sub-processes, because the 2nd key adds JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK to the Jobs' flag list. To activte the limit, extend the bootstrap.ini like this: [Win32] LimitMaximumMemoryInMB=0 ExcludeChildProcessesFromLimit=true and adapt the values to your needs. Zero disables the limit. Reviewed-on: https://gerrit.libreoffice.org/78819 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 6df7568e46b7f307ad6ae94730809fe63a6981a6) Change-Id: Ic474c6d6cdfe5ff3cfadbe6614030442171df1ae Reviewed-on: https://gerrit.libreoffice.org/78885 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-04Disable crash reporter UISamuel Mehrbrodt1-2/+3
Change-Id: I8106ec674080ede7072581dab2e6700040de5828 (cherry picked from commit b981aa30c3eb5ddd0cf6c35e4c37ab687667f71b)
2019-01-11clang-tidy bugprone-unused-raii in RequestHandlerNoel Grandin1-1/+1
The message from clang-tidy is: warning: object destroyed immediately after creation; did you mean to name the object? The guard in RequestHandler::ExecuteCmdLineRequests comes from commit cf333a878ceed18d0343520a2c65be69fc433b1f Date: Sun Jan 21 22:10:09 2018 +0300 tdf#38915: set cProcessed condition on any process outcome and I'm sure it's intention was to set the flag on exit from the function, not immediately. Reviewed-on: https://gerrit.libreoffice.org/60183 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit 867ee21fe4c0c9216aea57850efec4de3c3fc554) Change-Id: Ibf874a5774770df00b9db7f673554e7ffda55072 Reviewed-on: https://gerrit.libreoffice.org/66168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-11Resolves: tdf#122404 unlock just the toplevels that were lockedCaolán McNamara2-34/+8
push what toplevels got locked to just unlock those ones. otherwise the just dismissed toplevel may still be present in the Application toplevel list. merge all the similar examples of this. Change-Id: I77c0d55d1e4b3bcc3b8d88fef00ba289edd1e831 Reviewed-on: https://gerrit.libreoffice.org/66080 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-28tdf#122269 don't prompt to restart if we're exiting the application anywayCaolán McNamara1-0/+1
Change-Id: I6272ae92b7e948680fb7241c387eb205adbbea01 Reviewed-on: https://gerrit.libreoffice.org/65596 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-29Resolves: tdf#121746 block toplevels from closing...Caolán McNamara2-29/+78
while the extension manager is querying via a dialog. Reuse the isBusy for this. Change-Id: I97572404ae296e87fd44711bf1e978bd5bad6280 Reviewed-on: https://gerrit.libreoffice.org/64162 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-10-30possible fix for tdf#120928 - quickstart --killtray throws exceptionbrinzing1-1/+1
Change-Id: Id4081439075f4beecc2b0e4aed035d5ee28a2cfd Reviewed-on: https://gerrit.libreoffice.org/62429 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit a41d7ee25ea5057cd887c67d33d42f4c764f9c77) Reviewed-on: https://gerrit.libreoffice.org/62440 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-04tdf#120249: escape trailing backslash in argument passed to soffice.binMike Kaganski1-1/+8
... to avoid treating \" as in-argument " instead of end of argument See https://docs.microsoft.com/en-us/windows/desktop/api/shellapi/nf-shellapi-commandlinetoargvw Change-Id: Ie283ba04117e13bc06c5b92412a945f945e67ff3 Reviewed-on: https://gerrit.libreoffice.org/61214 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit f4103a42d58535e21c48ff94ab000ab0305c62e3) Reviewed-on: https://gerrit.libreoffice.org/61222 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-14tdf#119194: save deprecated argument earlyMike Kaganski1-8/+11
Change-Id: I4b5001e1f71ac536ac0c3bda4b8c1955020ab40d Reviewed-on: https://gerrit.libreoffice.org/58815 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5ccf82642b19728e1cfe8fa11f654e90712c5757) Reviewed-on: https://gerrit.libreoffice.org/58819 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-08-11Fix fallout from 6a4c464b49dbfa2801818ead1b50bc9580824d00Tor Lillqvist1-1/+1
Change-Id: I72e4008a0aacf7e35006be685462168874954631 Reviewed-on: https://gerrit.libreoffice.org/58872 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26Allow the comphelper threadpool to be reset after construction.Michael Meeks1-0/+4
Otherwise some pre-init components can start it, and threads get stranded in the forkit process causing grief. Change-Id: Ib1846f8b329b4c6b84645999dafba1252c5129c7 Reviewed-on: https://gerrit.libreoffice.org/57635 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-23remove Linux ("UNX") systray "Quickstarter"Rene Engelhard1-1/+0
Change-Id: Ie0e8b8b7ad59ee640d6b195dfae1a7cf745056fd Reviewed-on: https://gerrit.libreoffice.org/54543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-05-23rename config_extension_update.h.in to config_extensions.h.inRene Engelhard4-3/+4
... and move HAVE_FEATURE_EXTENSIONS there, too Change-Id: I37fe52071e1db32cf5cc1e51dbd89bb4f32a39c1 Reviewed-on: https://gerrit.libreoffice.org/54072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-05-22Really don't show empty Writer document on cancelled recoveryMike Kaganski1-16/+8
Commit b5ad981518f4407243f89507b2561dd0b1ef28ee tried to make that, but either didn't work on all platforms, or was broken later. Then, commit fbe9accf36ac4c52ef5bcb84d455b4d06c317668 handled one special case. The problem is that cancelling recovery returns false. It's unclear why the distinction should be done for the cancelled recovery case: in any case, if the recovery has opened some documents, it will be handled in the code that enumerates frames ("no default document if a document was loaded by recovery..." comment). In other cases, we need to honour user command line parameters (selected module), and if none is specified, do the global default, which is currently to show Start Center. So - let the OpenDefault() do just that. Change-Id: I90f3581fc72628d1317e97074a4a1d352d630c7e Reviewed-on: https://gerrit.libreoffice.org/54604 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-17loplugin:unusedfields in dbaccess..drawinglayerNoel Grandin1-4/+4
Change-Id: I069badbce9b899d176fd3db91243139579dec6b1 Reviewed-on: https://gerrit.libreoffice.org/54456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-16tdf#114227: set better proxy params in cURL for crash reportingAron Budea3-3/+30
Take proxy server from internet settings, and pass to cURL. Allow forwarding authentication as well (explicitely setting user/password is still missing). Change-Id: I19a6c9057a11a5911a6117f71060d3f386953602 Reviewed-on: https://gerrit.libreoffice.org/51621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-10move Java from config_features to already existing config_javaRene Engelhard3-2/+3
Change-Id: I085fab2bcdc5910d1386fc20768fe7063ce3e28e Reviewed-on: https://gerrit.libreoffice.org/54071 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-09Better log about preloaded dicts.Tamás Zolnai1-2/+1
Change-Id: I906c0082f3ac3c701f7b02e5d35b998bb7ea4d59 Reviewed-on: https://gerrit.libreoffice.org/54044 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-05-05Replace Galaxy icon theme by Colibreheiko tietze1-1/+1
Galaxy goes into an extension, fallback updated Change-Id: I4b6998035857f01368b39d4f16b2639d8a665065 Reviewed-on: https://gerrit.libreoffice.org/53092 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-27loplugin:constantparamNoel Grandin3-7/+4
Change-Id: I966dcf87be021520e7cc394338b9c0574bb8afee Reviewed-on: https://gerrit.libreoffice.org/53541 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-20tdf#42949 Remove unnecessary localization headers of svtoolsGabor Kelemen1-1/+0
Found by searching for the header names and the localization function: git grep -l -e \<svtools/svtresid.hxx\> -e \<svtools/strings.hrc\> | xargs grep -c SvtResId | grep :0$ | grep -v /pch Change-Id: I861fed778660412dc73616da29503538b3fe9ccb Reviewed-on: https://gerrit.libreoffice.org/53136 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-19tdf#95843: Wait for fire_glxtest_process also in --headless modeStephan Bergmann3-0/+14
Discussed with mmeeks on IRC that fire_glxtest_process is probably called as early as possible so that its reuslt is ready by the time it is needed in the non-headless case. So best fix for headless is probably to just wait for the sub-process at an opportune point, instead of redesigning the whole mess so that fire_glxtest_process would only be called once its result is actually needed. Change-Id: I4ea9c9d54b83c9695a3b72317e68fed0c410da0e Reviewed-on: https://gerrit.libreoffice.org/53154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-16cppcheck: variableScope & unreadVariableMuhammet Kara1-3/+1
Change-Id: Iaa3adc54d547e243b977a562fa4dbc2b9b9c6592 Reviewed-on: https://gerrit.libreoffice.org/52905 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-04-15remove some unused comphelper includesJochen Nitschke2-2/+0
and fix the fallout Change-Id: I5d0c2040f57a3ac354a7e277592da31d09a5f359 Reviewed-on: https://gerrit.libreoffice.org/52894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-04-14Fix typosAndrea Gelmini1-1/+1
Change-Id: I9ea95f5b7b6cd056cc1aad146c8841877d187d55 Reviewed-on: https://gerrit.libreoffice.org/52742 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-14look for check buttons without underlinesCaolán McNamara1-0/+3
Change-Id: Ia9963190cf3dccbfa82951a3f2c0e29e00171429 Reviewed-on: https://gerrit.libreoffice.org/52847 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-12lok: sc: clicking outside a pop-up or context menu doesn't close itMarco Cecchetti1-2/+5
Change-Id: Iecf0659467264d921c7c9faddc98fd5519e7db93 Reviewed-on: https://gerrit.libreoffice.org/52617 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 1cd76097043a5ece899dd7c9468755dcd961b0eb) Reviewed-on: https://gerrit.libreoffice.org/52736 Tested-by: Jenkins <ci@libreoffice.org>
2018-04-11weld RestartDialogCaolán McNamara1-1/+2
Change-Id: Iae97806a11b6c950931a342d06b3eeea168c7559 Reviewed-on: https://gerrit.libreoffice.org/52721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-10tdf#42949 Remove unnecessary localization headers from desktopGabor Kelemen9-8/+3
Found by searching for the header names and the localization function: git grep -l -e \<dp_shared.hxx\> -e \<strings.hrc\> desktop | xargs grep -c DpResId | grep :0$ | grep -v /pch Change-Id: I6608eb94c7572040ae20ce8a3926f3a522ee66bd Reviewed-on: https://gerrit.libreoffice.org/52593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-04-07sw lok: View jumps to cursor position even if it is moved by an other view.Tamás Zolnai1-0/+2
Scrolling is done twice. Once in SwCursorShell::UpdateCursor() by SCROLLWIN flag. Here we can check the actual viewid and avoid scrolling if the cursor is move by an other user. The second instance in the LO online code, for it we need to pass the viewid identifying the view which moved the cursor. Change-Id: I033274f88ce41acbb632e2aeb0d986ab11cd2d52 Reviewed-on: https://gerrit.libreoffice.org/52220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-06weld linkeditdialogCaolán McNamara1-1/+1
which enables changing FileDialogHelper over to welded Change-Id: I988342a6574cb7ed09b2724929e8c7117474a56c Reviewed-on: https://gerrit.libreoffice.org/52388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-06Resolves: tdf#116796 Ok -> OkCancelCaolán McNamara1-1/+1
Change-Id: Ib816862a462614a47045628ffe57358a4986149b Reviewed-on: https://gerrit.libreoffice.org/52477 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-03lok - calc: add support for show/hide tabs in onlineMarco Cecchetti2-1/+24
Change-Id: Ibd061414a0c3a5fad83d03f7047831cef62076d2 Reviewed-on: https://gerrit.libreoffice.org/49083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-04-03lok: Make the bundled dictionaries work.Tamás Zolnai5-11/+31
Create the user directory temporary in the temp directory and use that to load the dictionaries (bundled extensions). Co-author; Jan Holesovsky <kendy@collabora.com> Change-Id: I5c7c824b68571048ce870fd5218cb47a333f3ad8 Reviewed-on: https://gerrit.libreoffice.org/49495 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-01remove unused processfactory.hxx includesJochen Nitschke3-3/+0
and fix fallout Change-Id: Id06bf31f2075111e426ba40c84c885ae70697bee Reviewed-on: https://gerrit.libreoffice.org/52206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-03-27Handle also []any in unoAnyToPropertyTree()Tor Lillqvist1-0/+14
We add it as a subtree where each element in the sequence has as its name its number. Change-Id: I9422777d887d899f76ad6d259631d15c2db53f03 Reviewed-on: https://gerrit.libreoffice.org/51967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-03-27.uno:Save callback for the Android ViewerMert Tümer1-3/+2
Change-Id: Ic2e16985e52869092faa2a31a59a85cb77b8e28c Signed-off-by: Mert Tümer <merttumer7@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/51506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-27Fix typo ("x86_64" -> "X86_64")Stephan Bergmann1-1/+1
...introduced with 2d2294fb82bd4f0d1d805405631aeb1acbc36cbb "Add x64 Windows here, too". As reported by Richard Webb at <https://lists.freedesktop.org/archives/libreoffice/2018-March/079870.html> "Re: Manifest.xml for 64bit LO". Change-Id: I1681908012e73e520bebd79b8149788358ea49a3 Reviewed-on: https://gerrit.libreoffice.org/51946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-27desktop lok: handle NoFileSync in saveAs()Miklos Vajna1-16/+13
Similar to TakeOwnership: detect this, remove it from FilterOptions and turn it into its own sequence element. Online uses this for its convert-to functionality. The new cost for converting a small ODT file into PDF is 84% of the original (when opting in for this flag). Change-Id: Id2fcf5dd8b40eed04e0bc37f33519fd7691a9e5a Reviewed-on: https://gerrit.libreoffice.org/51909 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-27loplugin:expressionalwayszero improvementsNoel Grandin1-1/+1
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2 Reviewed-on: https://gerrit.libreoffice.org/51868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-20drop unnecessary includesCaolán McNamara5-5/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-19remove unused ucbstreamhelper includesJochen Nitschke1-1/+0
and a few vclunohelper includes Change-Id: I4803605766d155fe5044c2a65c0444631146831c Reviewed-on: https://gerrit.libreoffice.org/51496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 21:02:24 +0000