Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I6272ae92b7e948680fb7241c387eb205adbbea01
Reviewed-on: https://gerrit.libreoffice.org/65596
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit a93713359265a9a1403c744e467eb5faa09cc747)
|
|
The scenario is like this (see the unit test):
* double-click a word to select it (the handles appear)
* click somewhere else (the selection and handles disappear)
* double-click the same word again (the handles did not appear in this
case)
The reason was that the old state was remembered and the now thought
duplicate state was discarded.
Change-Id: Ia49200f12907c520067258b7570d4e21b365a8dd
Reviewed-on: https://gerrit.libreoffice.org/66170
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
|
|
LOKit function "signDocument" can sign document without the need
to open them. This is useful to sign PDF documents after they are
created from a currently opened (ODF, DOCX) document.
This adds DocumentDigner to sfx2, which could also be used in
desktop LibreOffice without opening them and in further tests.
Reviewed-on: https://gerrit.libreoffice.org/65767
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit a8cb7cf68ff661b502e7c006fe4330098b5b0944)
Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a
|
|
Change-Id: I1918041793935b012e60fe64073480ed4b9581d5
Reviewed-on: https://gerrit.libreoffice.org/65630
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 936f6a85649c0fd71eee484e7399d445f4040586)
|
|
Change-Id: I61891d1295a342e546cab56ef80315c9f5018f90
Reviewed-on: https://gerrit.libreoffice.org/65629
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 5cd86cacc1ea69bcf94d298a385e4f711e9bce3c)
|
|
When determining if a file is an XML file for siging, we need to
read the manifest file to get an accurate detection. In case when
we were signing in the GUI the manifest file was read when the
storage was set. When we didn't sign over the GUI, the manifest
was never read: the code was only present in the GUI code -
"documentsignaturesdialog.cxx" so the detection was wrong and
isXML returned "true" for current.xml.
With this we move the manifest reading to DigitalSignatureManager,
where the manifest is read when needed.
Reviewed-on: https://gerrit.libreoffice.org/65600
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 49fcd3bbb30f93763fc5cb80fa6ac5cec5d00834)
Change-Id: If45a32af6410bc5f7c5afdb976b182bd69ab7d6b
|
|
Change-Id: Iaa962fe5a590ef16e710fdd49d02d564f10f0f9f
Reviewed-on: https://gerrit.libreoffice.org/65188
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
(cherry picked from commit 13998b050f445bac3593a8bb77b7320d1be9990d)
Reviewed-on: https://gerrit.libreoffice.org/65202
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5
|
|
Was reverted in master, too. The functionality is implemented
differently now in the iOS app, without requiring any new methods in
LibreOfficeKitClass.
This reverts commit 36beb79184e5f4153c8cc92b176b21b697594228.
Change-Id: Ic0c42848c81a9b48e50a2b01a0a5a98ef5220870
|
|
Combines the LanguageTag::Create() and Translate::get() functionality.
Also add an ABI test for the Kit class in the LibreOfficeKit unit
test, and a test for the translation function.
(In this branch there is no Translate::nget() so no such
functionality.)
Change-Id: I78c48a8bbb434d6f204869290822830288022a53
Reviewed-on: https://gerrit.libreoffice.org/64894
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: Ic305e5305890fd1efa3a3130e5216f9c672870e5
|
|
Separate generic code from Impress / Draw specific code
and implement shape selection handling in case of Writer.
This is an internal filter, so it can be called only from
the code.
Change-Id: I807e04a0949530d6029037bb964c10c80197ff33
|
|
Unlike C++, C doesn't allow reference-to-pointer types,
and we do have C code that wouldn't compile with ref-to-ptr.
Had to change to ptr-to-ptr, which is the proper way of
having output arrays.
For the same reason, we cannot use new/delete, rather we
must use malloc/free.
Another (lesser) issue was that we used the renderShapeSelection
API to echo back an array we give it as prefix. This made
the API unecessarily complex (in undocumented ways) and
forced the implementation to both worry about user-data
and managing the input memory. This logic is best moved
to the client and the API simply returns the output data.
Speaking of returning data, the API now returns the size
of the array it allocated and wrote to, so the client
can do a simple check on the return value directly.
Change-Id: Ida216c10d5b37efd1e0861e26b72cabb25c568e6
|
|
Change-Id: Ic1b30a89ae513b3b3ec71853830ef7600801dee0
|
|
It works for Impress only now.
Change-Id: I95e3e37ae7df49b567108f6d6467038b715e886d
|
|
which benefits LOOL since we can delay creating the image until
we know the dpi setting of the display we are going to write to.
Achieved by
perl -pi -w -e "s/\bImage\s*\(\s*BitmapEx\s*\((\w+)\s*\)\s*\)/Image\(\1\)/g" $( git grep -lw "BitmapEx" )
followed by
git grep -nP '\bImage\s*\(\s*BitmapEx\s*\('
followed by commenting out the BitmapEx(OUString) constructor and seeing
what needed adjusting.
Change-Id: I3224e11937d720fa484b0d659d25673a9e809267
Reviewed-on: https://gerrit.libreoffice.org/64760
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/64860
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: If3b121e44ceec8be668820a7e8a9e35c15d547ff
Reviewed-on: https://gerrit.libreoffice.org/64295
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 07e586574d5f0255ade1fe4305d56730dd7ae4c7)
|
|
When triggering rechecking of signature status, an assert fails and
brings down the program because we don't hold a SolarMutex. The
rechecking of signature status needs to broadcasts.
Change-Id: Ib500b06d2e191465df1e0da2097ddb1b6b06725a
Reviewed-on: https://gerrit.libreoffice.org/64292
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d7a88b902af983145b196990949e89420e5bc4cf)
|
|
Change-Id: I1ae105067c109a32f4acc34749b425d9e4e26514
Reviewed-on: https://gerrit.libreoffice.org/64291
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d69edca3e004ab8669b3363b4755da8bb42f62fc)
|
|
Fixes the rendering of spreadsheets in the iOS app. (The cell area was
rendered at half the scale of the row and column headers.)
(In this branch I don't bother updating the comments to mention
CoreGraphics in addition to cairo.)
Change-Id: Ife99c6a2d58e592cfea3b4ed1ab09c19fba77e72
|
|
This reverts commit 6c7e262fa9f11e160e5854231421710eec0ddee3, now that I
found the missing backport.
|
|
Until I find out why that happens.
Change-Id: Ie10e402d29280b1a770dbc86cfa794645851fb05
|
|
Change-Id: If164d0edc9343b1db5ee96a2da46c9436ddbc73f
Reviewed-on: https://gerrit.libreoffice.org/62776
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 30bb64dc2deb53409c72bc8d4c083bbc3fd99a7d)
|
|
As the certificate chain can be added after the document was
opened, we need to trigger signature verification every time the
LOK API method getSignatureState is called.
In addition update the tests so that they check the status of a
document that's not signed, a document that was signed but the
certificate chain is not available so the verification fails and
later adding the certificate chain and the verification returns
an OK status.
Change-Id: I44578d0cece5bfc4a2e43fbbcd68b5ea1ccbc38b
Reviewed-on: https://gerrit.libreoffice.org/62276
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
(cherry picked from commit 28a698db6f604137443053144dde94c9e553c0ef)
|
|
Change-Id: Ie34d8c26bfbf4192cd2067c8315030903edb3fb3
Reviewed-on: https://gerrit.libreoffice.org/62274
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit ab7fabd8b116d16def53772720f19fad4dbd6366)
|
|
Also needed to extend XCertificateCreator with a new method
"addDERCertificateToTheDatabase".
Reviewed-on: https://gerrit.libreoffice.org/62273
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 08c3c504644ee978c2ec75ba083765b6ffddf08c)
Conflicts:
desktop/qa/desktop_lib/test_desktop_lib.cxx
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx
Change-Id: I7b4df65365893bd5a0628aeec30b3156584849fe
|
|
Change-Id: Id62c0db3c9f404aaab70de0a73a20b2bb57b0393
Reviewed-on: https://gerrit.libreoffice.org/62272
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 15018316bca863c9d7329572af906850d47e0c63)
|
|
Change-Id: Ie114068d9aec5259f9f7ed395c5dfeecf8bb787d
Reviewed-on: https://gerrit.libreoffice.org/61915
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit c2ceb1f54e85ebc8b38df3f2e4d1113a2fe1cc64)
|
|
Reviewed-on: https://gerrit.libreoffice.org/61782
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit d2242cb1b88cc7d7af1990965925d19557b9f347)
Conflicts:
desktop/CppunitTest_desktop_lib.mk
Change-Id: I3ab2f3986955eb82451704fc2386b64f208da554
|
|
A lot of signing code paths trigger a GUI dialog (to select the
certificate for example) which aren't acceptable when triggering
through the LOKit. This code paths needed to be duplicated and
reworked to not trigger any GUI action.
Reviewed-on: https://gerrit.libreoffice.org/61780
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit 23a2312344ac961ead9ee14140c0b3e879bb7a41)
Conflicts:
desktop/qa/desktop_lib/test_desktop_lib.cxx
include/LibreOfficeKit/LibreOfficeKit.hxx
include/sfx2/objsh.hxx
sfx2/source/doc/docfile.cxx
sfx2/source/doc/objserv.cxx
Change-Id: I2f0d6038fb1bcd00adcdf86e432f9df8858cc21c
|
|
Change-Id: I418551113081f4602ab5c4df2c5374ba2d154e15
|
|
Change-Id: I770c605a049b7ac9c26c2773414eef8b6fc093a2
|
|
A bit different approach than trying to paint different zoom levels at
the samet time, because it is terribly hard to achieve with Calc -
things misalign, because Calc tries to fit the lines into the pixels
etc.
Instead, always paint the spreadsheet at 100%, but use cairo to scale the
actual painting.
Change-Id: I228a9dd41bf29862bdd188825d12e61e1c86cccc
|
|
Still useful for debugging, particularly in combination with
gtktiledviewer.
This reverts commit dec025d4cb51f252ecd7e981fe36800cf2bedff5.
Change-Id: Id2174486c0427adf083be199ce2dbb453beb8f22
|
|
Just like in doc_paintTile().
Now at least some of the dialogs work in the iOS app, yay.
Change-Id: I10c7eeb1f121ba68a1af723d45575890b1d598da
Reviewed-on: https://gerrit.libreoffice.org/62871
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Thus no need for any special __attribute__ ((visibility("default")))
dance.
Change-Id: I398d588a0165fd616ea0d259bbf2cab1e1a07ccb
Reviewed-on: https://gerrit.libreoffice.org/62867
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
That makes it much easier to use the same Xcode project file when
building against different versions of LibreOffice, with different ICU
data files. The configure script in the "online" directory creates a
ICU.dat symlink to the ICU data file in the LibreOffice build
directory, and that is what gets copied into the app bundle.
Change-Id: Ibe2ca85f66e2d4973d6ba3c52fc4d60e113d8f9a
Reviewed-on: https://gerrit.libreoffice.org/62780
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: Id4081439075f4beecc2b0e4aed035d5ee28a2cfd
Reviewed-on: https://gerrit.libreoffice.org/62429
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit a41d7ee25ea5057cd887c67d33d42f4c764f9c77)
Reviewed-on: https://gerrit.libreoffice.org/62441
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
(cherry picked from commit c7e4e6b41e80309c203a4eab1f5cc03b47c31faa)
|
|
Removed the need for the (limited) init() used earlier by iOS.
Due to problems solved below init() it is now posible to use
the standard init !!
init.cxx still have some special handling of paintTile, which we should try
to eliminate
Change-Id: I42234aea8ac6b8dfcf8c3c88b386b4d4a97bba74
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
If it doesn't exist lots of things go very badly. Took a while for me
to understand the mechanism, sigh.
Change-Id: I40300587a5f422876cbda68c5aa98a23ed707135
(cherry picked from commit a68bf798532c93c1fef8def82fe049ca55b5cb33)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Thus it now actually takes a buffer pointer also on iOS, like on Linux
and Android. Less confusing, more uniform.
Change-Id: I81084806d37b9aac9f2b2bc03d0c262e991eec81
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: Id42d3b84ab97ec1efd9551e4d9cc5fd16ab77c80
(cherry picked from commit 88f7147c1ab9d1feeb5c14d67ffa1b623df5dc50)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I844901f38ec1d93f4183e0678741fecdc7636139
(cherry picked from commit 65da08ea8efef28fc45694d0606e51bb425f1d65)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
We used to have this code snippet in the TiledLibreOffice app back in
the days. Then in LibreOfficeLight it was lost and forgotten (?).
Clearly we need to tell ICU abouyt the data that we include as a
separate file in iOS apps, and presumably any iOS app will be a
LibreOffficeKit-based one, so let's do the initialistion here.
Change-Id: Ib08dc9d7386789d10e8c53114e79d0b5beab7232
(cherry picked from commit a754ce416c844b6b26eff0aab3e6bac65387b433)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Change-Id: I293ede0dbac4b36a1b91b86100bc11593b402d06
(cherry picked from commit 46b2350cb303a84ffd549447d313c7ced50e7032)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
It seems that on iOS, where we don't have any Java, Python, BASIC, or
other scripting, the only thing that would use the C++/UNO bridge
functionality that invokes codeSnippet() was cppu::throwException().
codeSnippet() is part of what corresponds to the code that uses
run-time-generated machine code on other platforms. We can't generate
code at run-time on iOS, that has been known forever. Instead we have
used some manually written assembler to handle it instead. We used to
have a Perl script to generate a set of code snippets for different
cases, different numbers of parameters of the called function and
whatnot, but that went away at some stage some year ago. (It is
unclear whether that broke the C++/UNO bridge on iOS, or whether the
stuff continued to work even after that.)
Anyway, this handwritten assembly, or the manual construction of
internal data structures for exceptions, or something else, seemed to
have bit-rotten. Exceptions thrown with cppu::throwException() were
not catchable properly any longer.
Instead of digging in and trying to understand what is wrong, I chose
another solution. It turns out that the number of types of exception
objects thrown by cppu::throwException() is fairly small. During
startup of the LibreOffice code, and loading of an .odt document, only
one kind of exception is thrown this way... (The lovely
css::ucb:InteractiveAugmentedIOException.)
So we can simply have code that checks what the type of object being
thrown is, and explicitgly throws such an object then with a normal
C++ throw statement. Seems to work.
Sadly the cppu::getCaughtException() API still needs some inline
assembly in the C++/UNO brige. That seems to work though, knock on
wood.
This commit also adds a small "unit test" for iOS, copied from
cppuhelperm to ImplSVMain(). Ideally we should not copy code around of
course, but have a separate unit test app for iOS that would somehow
include relevant unit tests from source files all over the place.
Later.
Change-Id: Ib6d9d5b6fb8cc684ec15c97a312ca2f720e87069
Reviewed-on: https://gerrit.libreoffice.org/60506
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 7d6be61a62ca3724c67ab3fb93e60a2748d8a67e)
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
|
|
There is no guarantee that if something is wrong, the
Application::ShowNativeErrorBox() will manage to show anything, is
there? And this code might be invoked in a program that doesn't even
have any GUI. So at least try to show the message on stderr, too.
Change-Id: Ieb11a6f490c26c773af646ed7e9c3cf6ccb4a669
Reviewed-on: https://gerrit.libreoffice.org/62550
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
|
|
Not only by hitting the (invisble) frame or the text content.
Change-Id: I125f76a102611b628411d8c5acf70e3ed9e5e8fe
Reviewed-on: https://gerrit.libreoffice.org/51276
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
(cherry picked from commit d799436414ab7e28b6bf9a918fd3779b3fc85008)
|
|
When .uno:IconSetFormatDialog gets a parameter, it directly creates the
icon set conditional formatting with pre-selected values.
Change-Id: I75dda90e5ea9c191254acc24c564cda7b27243a5
Reviewed-on: https://gerrit.libreoffice.org/56429
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/61660
|
|
Reviewed-on: https://gerrit.libreoffice.org/57160
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit bbba0902fc1f1c6bb2a7f1e6ff2b682e2fbd3cc9)
Change-Id: I66840512b45e987cc7b08b07b65bdb24f2023a41
|