summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2014-10-28coverity#982159 silence Unchecked return value from libraryCaolán McNamara1-1/+1
Change-Id: I92ff023ea2a8503d7c4799921c644aa011685ae2
2014-10-27coverity#1209023 silence Unchecked return value from libraryCaolán McNamara1-1/+1
Change-Id: I7340b9ad9d482f6835ff7a4755df451fd146b86c
2014-10-25coverity#983652 Uncaught exceptionCaolán McNamara2-0/+2
Change-Id: Ib818955314689a3193e2026fae19161a79aa8e5b
2014-10-23Fraction: Revert "fdo#81356: convert Fraction to boost::rational<long> - wip"Jan Holesovsky1-1/+1
This reverts commit 47a2d7642d249d70b5da0c330a73f3a0032e4bba. Conflicts: cui/source/tabpages/transfrm.cxx svx/source/svdraw/svdedtv1.cxx svx/source/svdraw/svdibrow.cxx sw/source/filter/ww1/w1filter.cxx tools/source/generic/rational.cxx Change-Id: I4849916f5f277a4afef0e279b0135c76b36b9d15
2014-10-23fdo#60689: replace SUPD variableMarcos Paulo de Souza2-2/+6
Change-Id: Iad63330f8762b595ba5ee94fc20bc2c64ac92f6b Reviewed-on: https://gerrit.libreoffice.org/11937 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-10-23loplugin: cstylecastNoel Grandin2-3/+3
Change-Id: I0eaeebad6be75a1c0cccdf90955fde1a2909bdba
2014-10-22Replace DISABLE_SCRIPTING with HAVE_FEATURE_SCRIPTINGTor Lillqvist1-1/+1
Feature test macros that govern conditional compilation should be defined in config_*.h include files, not on the compilation command line. Change-Id: I40575a4762fd2564f10927b6f38a112dd9f9a3d7
2014-10-21SAL_WARN about unsupported dispatch requestsStephan Bergmann1-1/+3
Change-Id: I3ee646258ed1419245a0766c79214102b08bbca1
2014-10-17java: should throw this exceptionNoel Grandin1-1/+1
Change-Id: I0da1b5cda0ecf20d3566413864a45a49bbcb2a2d
2014-10-16java: when rethrowing, store the original exceptionNoel Grandin1-6/+6
Change-Id: I34ce000c48d2d79bfec854c8dd55d12f2bee29c7
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann4-5/+0
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-11move the removeTree function from desktop to unotoolsMichael Stahl1-52/+2
Change-Id: I98d3f4a68abfee42dac987633878b850134671d3
2014-10-10coverity#1242395 Don't call randomCaolán McNamara1-30/+0
Change-Id: Idd4adac71222e03d85446c86f1c086ce32528bd6 mmeeks: just chop that else {} block out in splashx and good riddance
2014-10-09desktop: -Werror=unused-macrosMichael Stahl1-6/+0
The documented feature test macro is _BSD_SOURCE, and anyway, feature test macros must be defined before the first libc header is included, so this one is evidently useless. Change-Id: Ib4b2db0c6151c2f3df322992b189257f5dd0ea22
2014-10-09fdo#81356: convert Fraction to boost::rational<long> - wipJuan Picca1-1/+1
* Added rational util functions used by Fraction class not available in the boost::rational class. * Replaced usage of Fraction by boost::rational<long> * Removed code that relies on: 1. fraction.IsValid() -- rational only allow valid values, ie denominator() != 0 2. rational.denominator() == 0 -- always false 3. rational.denominator() < 0 -- always false but implementation detail: http://www.boost.org/doc/libs/release/libs/rational/rational.html#Internal%20representation * Simplified code that relies on: 1. rational.denominator() != 0 -- always true * BUGS EXIST because Fraction allows the creation of invalid values but boost::rational throws the exception boost::bad_rational Change-Id: I84970a4956afb3f91ac0c8f726547466319420f9 Reviewed-on: https://gerrit.libreoffice.org/11551 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-10-09typo: Lable -> LabelAndras Timar1-29/+29
Change-Id: I8b9e9f75dd22ee5bff678c5bc0e1fa9381a103de
2014-10-08desktop: let --convert-to dump its exception message on stderrMiklos Vajna1-2/+5
Change-Id: Ic906740ddeab04a9acfee997a31a2249f23de65f
2014-10-06use comphelper::rng::uniform_*_distribution everywhereCaolán McNamara1-5/+3
and automatically seed from time on first use coverity#1242393 Don't call rand coverity#1242404 Don't call rand coverity#1242410 Don't call rand and additionally allow 0xFF as a value coverity#1242409 Don't call rand coverity#1242399 Don't call rand coverity#1242372 Don't call rand coverity#1242377 Don't call rand coverity#1242378 Don't call rand coverity#1242379 Don't call rand coverity#1242382 Don't call rand coverity#1242383 Don't call rand coverity#1242402 Don't call rand coverity#1242397 Don't call rand coverity#1242390 Don't call rand coverity#1242389 Don't call rand coverity#1242388 Don't call rand coverity#1242386 Don't call rand coverity#1242384 Don't call rand coverity#1242394 Don't call rand Change-Id: I241feab9cb370e091fd6ccaba2af941eb95bc7cf
2014-09-30desktop: std::auto_ptr -> std::unique_ptrStephan Bergmann13-23/+20
Change-Id: I450ee7134454321365d9d153522b8942a3d7d811
2014-09-29Adapt unoinfo to new Mac OS X LibreOffice.app layoutStephan Bergmann2-1/+47
Change-Id: I0e7fc27f558de2af7e860ca2ab2da1952fc85678
2014-09-29No extension cache to clean unless HAVE_FEATURE_EXTENSIONSTor Lillqvist1-0/+6
Change-Id: Id19a93b0b428849a3590e2e28e081154c443e949
2014-09-28border_width from 12 to 6, as the rest of dialogsAdolfo Jayme Barrientos1-1/+1
Second pass. Change-Id: Ic4702d2ca7a9d54ee4712dcd073006f16b2d5d1d Reviewed-on: https://gerrit.libreoffice.org/11669 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-09-24android: use JNI direct memory allocator from FennecTomaž Vajngerl1-1/+27
Change-Id: I95a9ab54222150a1f9cde30df820f3cd6915f641
2014-09-23fdo#82577: Handle WindowNoel Grandin14-39/+39
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22LOKit: add "destroy" and "saveAs" to android JNITomaž Vajngerl1-7/+43
Change-Id: I08542b736e49cb9262323e9fe6188b1976d47935
2014-09-19loplugin:saloverrideStephan Bergmann2-22/+22
Change-Id: I82f052cd62ea1561c3f77231cd285901ff1d6a80
2014-09-18fdo#82577: Handle FontNoel Grandin2-3/+3
Put the VCL Font class in the vcl namespace. Avoids clash with the X11 Font typedef. Change-Id: I1a84f7cad8b31697b9860a3418f7dff794ff6537
2014-09-17Use SAL_INFOStephan Bergmann1-4/+1
Change-Id: Ie84aa24fc7b2d58dbb4f22ef063dfd055f32ae85
2014-09-16Rename LO-specific uno ini-file (Linux: program/unorc) to "louno"Stephan Bergmann1-1/+1
...to avoid confusion with the URE uno ini-file (Linux: ure/lib/unorc). It might even work to get rid of the louno ini-file altogether and fold its contents into the fundamental ini-file, but at least desktop/source/deployment/misc/dp_misc.cxx accesses the louno ini-file directly, so would need some inspection to avoid potential regressions. Change-Id: Ib49bbc4c814d677c22e68d2dd0f11af6d8423bb6
2014-09-12desktop: sal_Bool -> boolStephan Bergmann8-15/+15
Change-Id: Ib9ca807c8fc27eda6d584a5b4696887dd044410c
2014-09-12Turn SfxItemState into a C++11 scoped enumerationStephan Bergmann1-1/+1
...to gain further confidence in the claim "that none of the existing code tries to uses combinations of these enum values" (d92602c5b13d0a60439d86c5a033d124178726ca "more fixes for SfxItemState") Change-Id: I987922d945e8738e38adfde83b869adf3ff35b13 Reviewed-on: https://gerrit.libreoffice.org/11384 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2014-09-10fdo#55380 replaced use of obsolete interfacesDaniel Sikeler1-8/+8
Change-Id: I94fed6a9361f21457b3e631efffc0db833068aef Reviewed-on: https://gerrit.libreoffice.org/11256 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-09-07microoptimisation: no need to compute string length to test emptinessLionel Elie Mamane1-1/+1
Change-Id: If5093bca0e16e0f631c8cd1a7f4dde8bbf7da077
2014-09-06SfxHint: convert home-grown RTTI to normal C++ RTTINoel Grandin1-2/+3
Also note that I fixed a bug in SvxFontMenuControl::Notify where the if statement had the check the wrong way around. Change-Id: I611e8929c65818191e36bd80f2b985820ada4411 Reviewed-on: https://gerrit.libreoffice.org/11147 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-06Make OOO_EXIT_POST_STARTUP behave more nicely when blankMatthew J. Francis1-1/+2
Change-Id: I28bc8027908225d78c9543f3813d3bfe3818451d Reviewed-on: https://gerrit.libreoffice.org/11264 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-09-05coverity#706495 Uncaught exceptionCaolán McNamara1-5/+12
Change-Id: I36a48a72e9ce305c62d9a82c8d1fbfc2ad403068
2014-09-05coverity#983652 Uncaught exceptionCaolán McNamara3-4/+14
Change-Id: I72f298c5cd0476d6e0cbf3ffaf5fdf5cd143a21c
2014-09-05coverity#706497 Uncaught exceptionCaolán McNamara1-2/+12
Change-Id: I6c2acde8c47f6f2c0b65b228737950a1d8972f8a
2014-09-05coverity#706498 Uncaught exceptionCaolán McNamara1-3/+14
Change-Id: I99a5ccd930d231324b5a35fedd70320e02e358af
2014-09-02coverity#706501 Uncaught exceptionCaolán McNamara3-8/+8
Change-Id: Ic5d95b87428284113f543427b417453dd361b354
2014-08-29Linux AArch64 portStephan Bergmann1-1/+3
Change-Id: I37044a37348b203944a8eb9d2204e619055f069d
2014-08-28Fix some *_component_getFactory function typesStephan Bergmann1-3/+3
Change-Id: I912f9d1454c049419e9ead6f0ff8d7fa7d8cd6c5
2014-08-25convert RID_WARNINGBOX_* to MessageDialog + stringCaolán McNamara6-83/+56
Change-Id: Ic6031faa475e22ee23a6c8888987127b3caf92de
2014-08-25convert RID_QUERYBOX_INSTALL_FOR_ALL with custom buttons to .uiCaolán McNamara6-38/+87
Change-Id: If7ac491cb6f256af22b48f681590adb1484350d0
2014-08-25QueryBox QBX_USERDATALOCKED -> MessageDialog + stringCaolán McNamara3-10/+8
Change-Id: If9256bc2ea23a31a902590ca5379abbaec80f080
2014-08-25set names on a bunch more threads...Michael Stahl1-0/+2
Change-Id: I4c2f2f0bcce52839033876ec991529721e06a3c8
2014-08-25everything is independent from vos these days...Michael Stahl1-4/+2
Change-Id: Iccb94dcc31d6de8c9e4e7a31b3c2e36d4198b295
2014-08-25Avoid possible memory leaks in case of exceptionsTakeshi Abe1-3/+2
Change-Id: Icc073be041ae0b0c690e869a0edaff3515d1d601
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist2-6/+6
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-22Base the convert-to detection on the actual serviceMaxim Monastirsky1-34/+14
There is no need to run a type detection on the input file (for a second time!), just to get the document service. This also simplifies the conversion of some generic formats like HTML and RTF, using Calc export filters. Previously setting both input and output filters was required. Now it's enough to set the input filter, or simply use --calc. Change-Id: I825e0fe3e7368d6649acb434b13de53a4523064a