summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2022-11-07lok: Introudce getDataArea for CalcSzymon Kłos2-1/+30
It will share information about real size of a data inside spreadsheet so we can easily check where data ends in online side. Change-Id: I376187a33c5c82d409f559d5cc826a4f36d4252e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139472 Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-11-05lok: show Math cursorMike Kaganski1-0/+5
Change-Id: I17a449f0a0662f0433de9cad1522a090434c1e30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142178 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 14ed342dd3f4cae607f7785905787f73c7b1fde2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142155 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-11-04lok: fix convert-to batch mode, quiet interactionHenry Castro1-1/+2
If it is a batch mode to convert *.csv to *.ods, use the quiet interaction to avoid unwanted filter dialogs. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I4ef82c1079888ae099084072c146b5db4cc0f2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141950 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ash@collabora.com> (cherry picked from commit f43a5ec28d36422c105da3d640bf94ad9c8a2ba6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141926 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-10-24Paint tiles on WindowsMike Kaganski1-1/+34
A step toward enabling gtktiledviewer on Windows Not the nicest solution, but it does the job initially. Change-Id: I9144c2b899eb122e918123a70279cd50a4a02df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141710 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit ebb3a72ba0c4f070c9c254c439147beea8b2d93d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141740 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-10-24lok: support embedded mediaAshod Nakashian1-0/+1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: Ie8f3ed188cec0050a10a5d49325756931b902ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141502 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-21lok: masterpage: use EditMode as parameter in invalidation callbackSzymon Kłos3-63/+100
Change-Id: I3905fc9e6376ca1cef3e438e7a5f229d3720b1f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138961 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-10-12Enable opening of downloaded fonts only in ForKit in OnlineTor Lillqvist1-1/+19
(This is the second attempt at this, I had to revert the first one as it broke desktop Collabora Office.) We want that only the ForKit process needs to have access to new font files added to a Collabora Online instance dynamically by downloading from a server. There are however many locations in the Kit process, in core and in external libraries like harfbuzz, where the code wants to open a font file. Handle this so that the ForKit process opens such a downloaded font file and doesn't close it. The file descriptor is thus inherited by Kit processes. The font file pathname passed on to other code is a fake on in the format "/:FD:/%d" where the %d is the file descriptor of the opened font file. Add checks in all places where font files are opened, look for this special pathname format, and modify the code to just dup() the already open file descriptor in that case. All this is relevant for Linux only, as Collabora Online runs on Linux. Do the above for harfbuzz, cairo, fontconfig, and freetype. In addition make sure that these libraries (except harfbuzz which needs to be a static library) when bundled, on Linux, are built as shared libraries, and won't be confused with the corresponding system libraries by making sure their sonames are different. Change-Id: Ib059cb27e1637d07bb709249abd0d984f948caa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140714 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-10-12Send build config (configure options) in LOKit version info JSONAndras Timar1-1/+3
Change-Id: I29a6cca467e5f1e9ba59528edefbb397ceb81780 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141197 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-09-27Revert "Enable opening of downloaded fonts only in ForKit in Online"Tor Lillqvist1-19/+1
The reverted commit causes horrible problems in desktop CO. Back to the drawing board. This reverts commit d8b04077bb63f05efa256f353bfd6acb409a6983. Change-Id: Idcee59b2fa2fa6e32f5fa58a3786891c43384950 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140659 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-26Enable opening of downloaded fonts only in ForKit in OnlineTor Lillqvist1-1/+19
We want that only the ForKit process needs to have access to new font files added to a Collabora Online instance dynamically by downloading from a server. There are however many locations in the Kit process, in core and in external libraries like harfbuzz, where the code wants to open a font file. Handle this so that the ForKit process opens such a downloaded font file and doesn't close it. The file descriptor is thus inherited by Kit processes. The font file pathname passed on to other code is a fake on in the format "/:FD:/%d" where the %d is the file descriptor of the opened font file. Add checks in all places where font files are opened, look for this special pathname format, and modify the code to just dup() the already open file descriptor in that case. All this is relevant for Linux only, as Collabora Online runs on Linux. Do the above for harfbuzz, cairo, fontconfig, and freetype. In addition make sure that these libraries when bundled, on Linux, are built as shared libraries, and won't be confused with the corresponding system libraries by making sure their sonames are different. Change-Id: I85ff853ac1d1f6b098a3c254a38e3fe3bca774c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2022-09-19Ignore also when a font has been substituted by itself with an empty styleTor Lillqvist1-1/+2
Change-Id: I40fbce716a11b010323ac07e0dacdc114f7d2320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140056 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-13lok: create sidebar on demandSzymon Kłos2-11/+38
Change-Id: I5393bba647aa4667643262e77acc6b6873afb571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139729 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-09-13new uno command uno:Translate with deepl apiMert Tumer1-0/+24
New Uno command added for translation right now it is only using deepl translation api There's a section in the options > language settings for setting up the api url and auth key uno:Translate is a menu button under Format tab which will bring up Language Selection dialog for translation. DeepL can accept html as the input for translation, this new feature leverages that by exporting paragraphs/selections to html and paste them back without losing the formatting (in theory) This works good in general but we may lose formatting in very complex styled sentences. Translation works in two ways; 1) Whole document when there is no selection, it assumes that we want to translate whole document. Each paragraphs is sent one by one so that the output timeout can be minimum for each paragraph. 2) Selection Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ia2d3ab2f6757faf565b939e1d670a7dedac33390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137199 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-09-07Use more idiomatic C++Tor Lillqvist1-74/+57
Change-Id: I0e9460f2500b76bec049c12413fbbee5dcb239c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139172 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-07Fix typosTor Lillqvist1-2/+2
Change-Id: Iec730c1902b726fa28de88b5b5d093c7d697645d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139159 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-07More handwaving: Assume that it is OK to substitude OpenSymbol for SymbolTor Lillqvist1-1/+5
Change-Id: I2d60721c826cb3053197a19be8a69b71cbd98e5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139158 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-06Filter out unwanted command URIsStephan Bergmann1-1/+9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 27d29f7df428885865a8e2313283839b20f2a34b) Conflicts: desktop/source/app/cmdlineargs.cxx Change-Id: I0b7e5329af8cc053d14d5c60ec14fe7f364ef993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-01Filter out well-known metric-compatible font substitutionsTor Lillqvist1-0/+45
Change-Id: I9da63c173dcc926f577052b704284065b384f960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2022-08-31lok: make sure flushPendingLOKInvalidateTiles() is calledLuboš Luňák2-0/+7
SwViewShellImp::AddPendingLOKInvalidation() collects invalidations, but this was relying on something eventually calling flushPendingLOKInvalidateTiles(), which wasn't guaranteed. If e.g. a spellchecker caused an invalidation from in idle callback and nothing else changed, then the LOK callback handling code didn't know there was something pending. So add an explicit call to ensure to notify about these pending invalidations. Change-Id: I0a9cb0d5aba2fdbbac126cd8a4a3412bef1cab25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136531 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 32cbd1c57dbaf7cff2325c126b3adfcf2150bc23) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136532 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-08-30Fix typosTor Lillqvist1-1/+1
Change-Id: I857bdb7831bd1e4158f80f09ec232d76d4db794e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139029 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139057 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-08-30Add SAL_INFOs for the recorded and pruned font substitutionsTor Lillqvist1-0/+22
Change-Id: Ice7b64c87bff6dbc0eead7bda36f3b0a678986e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139055 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-25Tell LibreOfficeKit clients what fonts in a document are missing on the machineTor Lillqvist2-0/+64
Use the OutputDevice::StartTrackingFontMappingUse() and OutputDevice::FinishTrackingFontMappingUse() functionality that was added last year. Add a new LibreOfficeKit document callback: LOK_CALLBACK_FONTS_MISSING. "Font" here means just the family name. We dont really know what style from the family is missing. Change-Id: Iec4349b5827e7d1dbdde7f8a9f8da92efde429e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138766 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-22Use comphelper::Base64::encode taking OStringBuffer where applicableMike Kaganski1-2/+2
Change-Id: I65c46ad97804827477adba7bbc4eed13cc16b606 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5b9fd9222a10ce9fcf632e940ed720f990e183da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138540 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-08-17Return std::optional instead of using bool* argumentMike Kaganski1-4/+3
Change-Id: I47f03411a6677f22291bea4dc06920ab9052349a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138399 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 364e8272329ba893af4141ac054fdc71816bd44a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138291 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-08-10lok: load template documents as regular documentsMert Tumer1-1/+5
otherwise lok cannot save them directly because libreoffice will try to open a save-as dialog For odg, change the draw8_template type draw8 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I34b0ed03adcac89eaa926f8ae6c57e6f622a90f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132633 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138074
2022-08-04Revert "mmap a "downloaded" font in Collabora Online already in the..."Tor Lillqvist1-12/+0
Font files are opened in a lot of places anyway, that commit was very far from enough. This reverts commit ba00d997ddd6867c3f2bd4909625a91bf4db590b. Change-Id: Ifca3c86f1e5d9b35a58abda52e3e214a969d99e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137790 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-08-04lok: Dont render active text edit on slide previewsSzymon Kłos1-0/+12
- extend ITiledRenderable interface to pass active text edit drawing state to the SdXImpressDocument - when painting tiles - allow text edit only for current part - pass new setting also to SdrPaintView where painting happens Change-Id: Ib4ff226961a76129f4f5ff11c90694cd46a83a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137676 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
2022-08-03desktop: avoid run graphic tests if ...Henry Castro1-1/+5
DISPLAY=hostname:displaynumber.screennumber has defined a remote display server, otherwise the initialization stuck for long time. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ieb598a023bce3d4298e02fa3ed6ae2bcfc6df015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137366 Tested-by: Jenkins (cherry picked from commit 554370661554652e7be96034e310d6863c700285) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137613 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-28lok: add dumpState feature for better in-field diagnostics.Michael Meeks2-0/+59
Always suspicious that some un-expected dialog / state can cause strange behavior in a client. An initial cut at an API to make it easier to unwind such problems by exposing the toolkit state. Change-Id: If8f17943fa4837df4f9ca659a111dcdce5c23244 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137564
2022-07-28lok: Enable sidebar in MathMike Kaganski1-1/+7
Change-Id: I1554a924eef0bfcaffa893057a37ef45321a0cf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137246 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137545 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-27lok: enable in-place editing of math equationsMike Kaganski1-1/+1
Change-Id: Ic4d187d1e2ee92eab74a6bb43e47bb4f3d47ebd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128506 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137460 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-25lok: initialize the load-languageAshod Nakashian1-0/+8
We need to use the load-language for saving the document. This is to avoid using the language of the view that is issuing the save, which causes all sorts of issues (language-translation related). This logic was implemented in 4b7b449bbdc5 but for some reason the load-language wasn't set. This patch sets the load-language. Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk> Change-Id: I0cd1574d48a99e6ee84bacf75fc0d9ebe26e526b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137391 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-07-25Send state changes of content control UNO commands to LOKAron Budea1-1/+7
Change-Id: Id6b3f9a35c129078b564f7906e03f6aa9306a5f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137373 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-07-25tdf#127236 vcl: fix missing encryption of PDF images during exportMiklos Vajna1-1/+1
Regression from commit 78e25558e86188314b9b72048b8ddca18697cb86 (tdf#106059 PDF export: create a reference XObject for JPG images with PDF data, 2017-02-23), once a PDF image was inserted to a document, an encrypted PDF export lost those images. The reason for this is that we started to preserve PDF images as vector data with the above commit, but this means we copied over PDF objects from PDF images to the export result as-is, so encryption was not performed for them. Fix this by separating the write of the PDF object headers, stream content and object footer and then calling checkAndEnableStreamEncryption() / disableStreamEncryption() for each object, even if it's not something our PDF export created but comes from a PDF image. Note that when existing PDF files are signed, PDF objects are also copied into a vcl::filter::PDFDocument, but such PDF images are never encrypted, so it's fine to have stub implementations in vcl::filter::PDFDocument. (cherry picked from commit 7d56dae3375dc0180aa6d20983b3f5f962302588) Conflicts: filter/qa/pdf.cxx svx/qa/unit/core.cxx vcl/qa/cppunit/pdfexport/pdfexport.cxx Change-Id: I2f74b9f51cd35b4319221532ca890e197bab9cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137358 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-07-21mmap a "downloaded" font in Collabora Online already in the ForKit processTor Lillqvist1-0/+12
Instead of waiting until it gets used in a Kit process. Change-Id: I8671fd637837d66002bd5645734e4fee2f07d864 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137266 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-07-07Avoid compiler warningTor Lillqvist1-1/+3
Change-Id: I322b2c0ea14bbf8ed2fe1a306c0ed28f5e5ae258 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136875 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-07-05Added option to disable ssl verification for languagetoolMert Tumer1-0/+3
This will allow to use self-signed certificates with local run languagetool APIs Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2bda575fa6174dfc0f6c24da45267ee732643db6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136811 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-06-17make VirtualDevice::SetOutputSizePixelScaleOffsetAndBuffer() LOK-onlyLuboš Luňák1-3/+3
Because it's used only for LOK, and SvpSalVirtualDevice::CreateSurface() otherwise wouldn't know whether to apply LOK DPI settings or not (since this might be called for LOK tiled painting, when it should, or it might be called from somewhere else while LOK is active, in which case this should be handled normally). Getting that mismatched can cause things like https://github.com/CollaboraOnline/online/issues/4834 . Change-Id: I1df7b8a169c8ef2e799731a6695a032948536582 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135546 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-17use recursive mutex for LOK queueLuboš Luňák2-5/+5
Callbacks may be invoked while calling getLOKPayload(), which would try to lock the mutex again. I actually originally expected this possibility, as the comment and moving the data to temporaries in CallbackFlushHandler::enqueueUpdatedTypes() shows, I just didn't realize the used mutex wasn't recursive and so would deadlock. Change-Id: I2b5c4b6b4c1a3933a32ae4641830877e085f2b6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135499 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 118bafcfd1ce4a26ec9df912197ebd466d1bd497) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135387 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-06-14lok: set LanguageTool config parameters from environmentMert Tumer1-0/+34
Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: Ic7343439536abee626c269d2a824bb36f9abc40f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135583 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-06-08LOK: send state of Protect, UnsetCellsReadOnlyPranam Lashkari1-0/+2
Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I92675ed0033088233fb442138b39a3c8d663c614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135454 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com>
2022-06-05Drop special-casing for Chart's sidebar property deckMike Kaganski1-10/+1
Introduced in commit b33b2afe6a8b4224450da7c686beb81dbf5cd24a Author Markus Mohrhard <markus.mohrhard@googlemail.com> Date Thu Jul 09 20:39:06 2015 +0200 big step towards real chart sidebar later in commit da57c32c5cb27eee38e32d10232b31d459c399df Author Tor Lillqvist <tml@collabora.com> Date Fri Feb 28 17:02:30 2020 +0200 tdf#130348: Add special case for ChartDeck, too and then in commit ff23d87cb00388095a94b90e061564fc179e1823 Author Mert Tumer <mert.tumer@collabora.com> Date Fri May 08 17:23:12 2020 +0300 mobile: fix calc chart wizard properties is not shown The normal PropertyDeck can host all the chart-specific panels, and the other decks that had "all" application context, but are not needed for charts, have their context fixed. This cleanup is needed for a following introduction of sidebar in Math. Change-Id: I5bb24d52b8dec2133213d7dddfeb91359ed4cb4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133262 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135395 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-06-02fix handling of XTransferable2 if the type is only XTransferableLuboš Luňák1-4/+6
Apparently some selections provide only XTransferable and not XTransferable2, making this entire call think that there's no selection at all. Handle that properly, and if XTransferable2 is not provided, then presumably it's not important to check for isComplex(). Change-Id: I3bbafe46a6b9ac8552c62e524137e1691b54895a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135299 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-31lok: add more efficient getSelectionType() replacementLuboš Luňák2-2/+69
The getSelectionType() function usually needs to be followed by a call to getTextSelection(), which means having them as two functions leads to duplicating to a number of calls, some of which may be somewhat expensive (pDoc->getSelection() e.g. for Calc builds another ScDocument for the selection, and then getFromTransferrable() converts that to the given format). Change-Id: Ib0a8844701d80eaaff4834dcd3633c09d6b921b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134615 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com>
2022-05-28tdf#149280 modified called after dialog was destroyedCaolán McNamara1-2/+5
just ignore it in that case Change-Id: I8f294acd9ee16d2f9c8662614fac3672f80b3376 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134902 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-05-24sw content controls, picture: add LOK APIMiklos Vajna1-2/+2
- send a LOK_CALLBACK_CONTENT_CONTROL callback with action=change-picture when a file picker should be shown - extend lok::Document::sendContentControlEvent() to be able to replace the placeholder with the selected URL - update gtktiledviewer to work with these (cherry picked from commit 9a76be53dfb801b754bf55f9d4b8c5f82991a62f) Conflicts: sw/source/uibase/uno/unotxdoc.cxx Change-Id: Ifb3750803885fc09fc82905b0cf85b2b8ca06e77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134850 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-16sw content controls, dropdown: add LOK APIMiklos Vajna2-1/+35
- expose the available list items in a new "items" key of the LOK_CALLBACK_CONTENT_CONTROL callback - add a new lok::Document::sendContentControlEvent() function to be able to select a list item from the current drop-down - add a new listbox to the gtktiledviewer toolbar to select a content control list item when the cursor is inside a dropdown - add tests for the array API of tools::JsonWriter (cherry picked from commit c7d80d229a5660a0ee702477bfbd2ca137992a7d) Change-Id: I47f1333a7815d67952f7c20a9cba1b248886f6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134385 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-06lok: don't render active textbox on all slidesSzymon Kłos1-1/+16
when we render tiles for slide previews we use viewid = 0 (first session) so when first session edits any textbox and in other session we request slide previews (eg. after new slide was added) then we received tile with additional text from the first session this is caused by: commit bee4ff508a456a1552aacdf6fc838b8b7cffb9ec desktop lok: avoid unnecessary setPart() in paintPartTile() If possible, switch views, not parts, that way started Impress text edits don't end as a side-effect. but later there was a fix which doesn't trigger closing of texbox editing when switching parts: commit ce7bf351972bbfd64ca99e8d2fb4c5f77591c9e0 impress: don't exit textbox editing when new slide was added so we don't need that in all cases... to fix issue described above: still switch views instead of parts when possible - but avoid views where editing is active Change-Id: Ib6e66a85b9ca68d6e67e3d9cb17060aa42b85220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133202 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133650 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-04-23jsdialog: used for formulabarSzymon Kłos1-0/+2
- do not block painting - use welded wrappers to send JSON - don't send tunneled dialog Change-Id: I54c3cd02ab63bad4a50a3623a32f13b0c94a3595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132757 Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-21Fix regression in the iOS app (and possibly the Android and GTK apps)Tor Lillqvist1-3/+14
The problem was caused by my remote font downloading changes. We need to be more careful in lo_initialize() and libreofficekit_hook_2() to distinguish whether the code is called from "normal" Online (with "pre-initialisation" through lok_preinit_2()) or otherwise, for instance the iOS app (where pre-initialisation is not done). Sadly, this fix makes state handling in init.cxx even more complex with one more static Boolean flag. Change-Id: I2a8fa96740eb79725aa162cf7adc86d49a8ba603 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133181 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-14 04:15:15 +0000