summaryrefslogtreecommitdiff
path: root/desktop/source
AgeCommit message (Collapse)AuthorFilesLines
15 hoursreplace usage of whitelist with allowlistThorsten Behrens1-1/+1
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Common::Misc::OpenCLWhiteList -> OpenCLAllowList Change-Id: I65636b19b13e4af1e4851f70e78053f3443d6bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98181 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
15 hoursreplace usage of blacklist with denylistThorsten Behrens5-27/+27
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
31 hoursdesktop: create instances with uno constructorsNoel Grandin19-435/+62
See tdf#74608 for motivation Change-Id: Id332d79c29c8e5f668663070d83aba596f017908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
43 hourslok: set to export PDF bookmarks by default when save-as a PDFTomaž Vajngerl1-15/+19
Change-Id: Ieb182b9a0d1f18a29a83ce369881578c06e217ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
4 dayslimit exposure of methods exposed for LibreOfficeKit purposes to just thatCaolán McNamara1-5/+29
Change-Id: I4685651a6ecf48b7cbf3048b28788b351c655c3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98212 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
4 daysnotebookbar: early initSzymon Kłos1-0/+25
Change-Id: I2a129911b6949fd0e165065fd6d02f3546613407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97232 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97206 Tested-by: Jenkins
4 daysjsdialog: execute entry set textSzymon Kłos1-0/+14
Change-Id: I9e7d7da0bc0b6494b59270c683ae4a18d927bf4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97624 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97861 Tested-by: Jenkins
6 dayslokit: add new callback type LOK_CALLBACK_INVALIDATE_SHEET_GEOMETRYDennis Francis1-0/+1
This is to notify the clients about changes in current sheet's geometry data. Use this to notify clients of various sheet geometry invalidations if the new feature flag scPrintTwipsMsgs is set. Change-Id: I478d2e646606320399905d7b15881a165a53146d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96969 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 7d0181f519f83b978b9040986738ad0cedc020ba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97956 Tested-by: Jenkins
6 dayslokit: Introduce new flag "sc_print_twips_msgs"...Dennis Francis1-0/+3
for conditioning all changes needed to allow calc messages in print twips coordinates. Change-Id: I407b4d4d4e0a1dfb2c4339cafa10b368b437c82d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96904 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 8f382dcee04588ac1e95f03f55df2b87883ce259) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96967 Tested-by: Jenkins
6 daysIntroduce ITiledRenderable::getSheetGeometryData()Dennis Francis1-0/+67
ITiledRenderable::getSheetGeometryData(bool bColumns, bool bRows, bool bSizes, bool bHidden, bool bFiltered, bool bGroups) and implement it for the Calc derivation (ScModelObj). The aim is to use it actively in LOOL instead of the interface: ITiledRenderable::getRowColumnHeaders(const tools::Rectangle& /*rRectangle*/) This is used by the LOOL to fetch the sheet geometry data for just the current view-area in the clients, so LOOL queries this everytime some client's view-area changes. Like the existing interface, the new one will provide all 'kinds' of sheet geometry info [col/row sizes(twips), hidden/filtered and grouping]. But the difference is, it generates data for the whole sheet (not view-area specific). So the method need not be queried every time the view area changes in the LOOL clients, and more importantly it enables the clients to locate any cell at any zoom level without any further help from the core. This means core needn't send various client(zoom) specific positioning messages in pixel aligned twips. It just can send all positioning messages in print twips uniformly to all clients. Conflicts: sc/source/core/data/segmenttree.cxx sc/source/ui/inc/tabview.hxx sc/source/ui/unoobj/docuno.cxx Change-Id: Ib6aee9a0c92746b1576ed244e98cb54b572778c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96892 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 9faf7b5e7abe39c287f28f83fd14a364e959c881) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96963 Tested-by: Jenkins
7 daysjsdialog: change sendDialogEvent API parameterSzymon Kłos1-2/+2
WindowId with 64bit length is needed Change-Id: Ia11530fb4666fc64d7acde653085ed258058c169 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97100 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97832 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
7 daysjsdialog: get widget depending on viewshellSzymon Kłos1-0/+4
Notebookbar always gets window id 0 what causes conflict in map and some widgets doesn't work Change-Id: I15b4e83d385e83bcf898148a871ddf540257cc81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97099 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97816 Tested-by: Jenkins
7 daysjsdialog: working number format fieldSzymon Kłos1-0/+1
Change-Id: Ibc3dcd34008767a7a38cc9b52a23935e0387f67e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97016 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97815 Tested-by: Jenkins
7 daysjsdialog: weld toolbarSzymon Kłos1-0/+13
Change-Id: If105d6716fc43f471f63f4eb60fa85498cb3dcc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96934 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97789 Tested-by: Jenkins
7 daysjsdialog: try call welded action even if window doesn't existSzymon Kłos1-6/+7
Change-Id: I8ae96d2e61899c89b5ddb8ff362d8a066ded3960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96922 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97744 Tested-by: Jenkins
9 daysSend various state changes to LOKAron Budea1-0/+12
Change-Id: I0d5dc63015364cd1586555b6dced81afa50745bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92865 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
9 daysUpcoming improved loplugin:staticanonymous -> redundantstatic: desktopStephan Bergmann8-22/+22
Change-Id: I1fadfc0fb62df56a890c6cd789435135671349a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
11 daysCall framework::Desktop::shutdown directlyStephan Bergmann1-4/+2
...instead of via the XJob hack introduced in a6862a26d6cd17f6b4e4f6577bcd778bf952e65b "tdf#134106: Get rid of XDesktopInternal again" Change-Id: Ic533e8faba1a3da65ead74d78f0ab9c4aab1ca6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
11 daysjsdialog: click action for drawing areaSzymon Kłos1-0/+13
Change-Id: I2434bec675559a97e5d251c6d6a958464b6db034 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96853 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97395 Tested-by: Jenkins
14 daystdf#134106: Get rid of XDesktopInternal againStephan Bergmann1-3/+3
For internal functionality that is not meant to be called by client code, I think it is appropriate to hide it either via XUnoTunnel (but which would have been a tad incovenient, as it would have meant to make framework::Desktop in framework/inc/services/desktop.hxx available to the code in desktop/source/app/app.cxx), or via reuse of some existing, sufficently fitting interface (as is done here with css.task.XJob). This nicely avoids the backwards compatibilty issue with remote Python scripts, as discussed in tdf#134106 "Binary URP bridge disposed during call to ServiceManager.createInstanceWithContext". Change-Id: Ic9db9401ddf0f6b696344dd1d5c6ad279ea5a832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97241 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-06-25use tools::JsonWriter for dumping property treeNoel Grandin1-1/+1
Change-Id: I8f55af19ba10b71bd621e69b27000ab7cb565309 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96677 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-24jsdialog: implement plus/minus for welded spinfieldsSzymon Kłos1-0/+17
Change-Id: I8a0bf4190c09520d7be78c44742902539cb9bf38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94483 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96914 Tested-by: Jenkins
2020-06-23most of jsdialogbuilder is not used outside vclCaolán McNamara1-4/+2
so split it into the bit that is needed and just include that. add missing license headers Change-Id: I875f91176e6881e830fee6a58368d0b28ce9a0f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96774 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-06-23jsdialog: use welding for button click eventSzymon Kłos1-0/+13
Change-Id: I0320dfb5cdc4f936eddff003bda7d16bdd1c4667 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94342 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96913 Tested-by: Jenkins
2020-06-23FixedBitmap can be in a toolkit only headerCaolán McNamara1-0/+2
Change-Id: I22bb548f7f0c1ef0de157f99915fbaf6473c284b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96861 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-22jsdialog: avoid crash in watermark dialogSzymon Kłos1-2/+5
Change-Id: Iea4a0e6ce005d6a86f9a228026471dd4b4c7b2da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94340 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96830 Tested-by: Jenkins
2020-06-20use JsonWriter for the rest of ITiledRenderableNoel Grandin1-14/+18
and fix bug in buffer reallacotion where mPos pointing at the beginning of the new buffer instead of at the correct index inside it. Change-Id: Ie1ffaa176f6165e2cec85c93adc945312eff38e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-20jsdialog: remember weld instancesSzymon Kłos1-5/+11
Change-Id: Ie55e0fcd2307679aee52751b2d2e434393850418 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94302 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96735 Tested-by: Jenkins
2020-06-20jsdialog: execute actions using weld wrapperSzymon Kłos1-36/+92
Change-Id: Ib9e1b52742b489e812e0756b364a7f7ac62f84ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94300 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94617 Tested-by: Jenkins
2020-06-18new json writer for LOKNoel Grandin1-19/+12
we shave about 3 memory copies off in the process, and make the class play nicely with our string types. Change-Id: I1f614fb35b1de499ac99e3b33ac638ad81054bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96393 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-17notebookbar: send uno items state updateSzymon Kłos1-1/+26
Change-Id: I56b9c64f11631bd28520b9294aef7d6db8da5733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96525 Tested-by: Jenkins
2020-06-09tdf#128502: Try to support multiple documents in LibreOfficeKit-using processTor Lillqvist1-3/+11
The LibreOfficeKit-specific code typically has assumed that all the "views" (SfxViewShell instances) are for the same document, because all LibreOfficeKit-based application processes (including the "kit" processes in Online and the iOS app) so far have only had one document open at a time. It is now possible to pass several document file names on the command line to gtktiledviewer and that is an easy way to demonstrate how badly it still works even with this patch. Introduce a unique numeric document id that is increased in the LibLODocument_Impl constructor. Add APIs to access that. When iterating over views, try to skip views that are not of the document visible in the "current" view, if we know what the "current" view is. Also add a couple of FIXMEs at places where it is a bit unclear (to me) whether it is correct to iterate over all views, or whether only views for the "current" document are what we would want. Change-Id: Id5ebb92a115723cdeb23907163d5b5f282016252 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95353 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-08rework treeview initial toggle button col to be like expander colCaolán McNamara1-8/+6
cause this assumption is baked into the vcl one making it hard to adapt remaining cases Change-Id: I75dd5264c65b1ffbf4d26c9a86f6d4d08b400d90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-08Use o3tl::safeCoInitializeEx and counterpart (dp_gui_extensioncmdqueue)Julien Nabet1-3/+4
Change-Id: I10f041367f94fd9391554b2b6a06b74f70aa8333 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95665 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-03Upcoming loplugin:elidestringvar: desktopStephan Bergmann5-32/+16
Change-Id: I46295b47daaa590b053433e0232e85e9c7b1f3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-29loplugin:simplifybool in dbaccess..frameworkNoel Grandin2-3/+3
Change-Id: I0d73bb7d8d3fde426edc0a10c0750758b68aceb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95099 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-29change TreeView toggle signal to provide an iter instead of a row indexCaolán McNamara2-6/+3
Change-Id: Ib611780816d170daa40f394b9798640ff6284d68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-22PaintToDevice doesn't use its Size argumentCaolán McNamara1-2/+2
Change-Id: I45ce895ac67be9aaf137e0e4c79954488f23a6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94637 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-20jsdialog: send tab namesSzymon Kłos1-0/+6
Change-Id: Iaae09ec6fc1af0de7f052b89a09ea184a023be70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94182 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94557 Tested-by: Jenkins
2020-05-20use for-range on Sequence in d*Noel Grandin20-148/+124
and fix bug in GenericClipboard::initialize, where it was looping through the arguments, but always reading the first one. I'm guessing it was never an issue because it is always called with only one argument Change-Id: I8f72b6bce8c77a69c7d75115e34630e2c308261e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-18tdf#129177: Allow extensions to specify also maximum LibreOffice versionTor Lillqvist1-0/+9
To be used by the potential packaging of language packs as extensions. Language packs are by necessity specific to a LibreOffice version as they contain message catalogs. Change-Id: I6037103dfe0949d288f8ad77fec63dd5da221c02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94425 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-05-13Avoid -Werror=unused-variable with --disable-assert-always-abortStephan Bergmann1-2/+4
...as reported by e.g. <https://ci.libreoffice.org/job/lo_tb_random_config_linux/1977/> Change-Id: I57832496faf2377a4650a4b8c43bb3c62f6977ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94140 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-13expand out some namespace aliasesNoel Grandin1-42/+40
Change-Id: I5fdb554a1b116824843f35645bc1cea3ca91e0f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10formula bar: Change completeFunction() to accept string instead of index.Jan Holesovsky1-3/+3
The 'index' is unsafe, because the set it tries to index can change in the meantime. Instead, use the function name and search for it in the set, to get the recent index. Change-Id: Id2a021c32f421057c87b6f7f4fffcc1c98009acb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93666 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93910 Tested-by: Jenkins
2020-05-10lok: add MetricFieldUIObject classHenry Castro1-0/+6
Add new action "VALUE" to set the value number for metric input controls Change-Id: I5058260c2e1562cfc6d10508d5981d185c5f2212 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92738 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93070 Tested-by: Jenkins
2020-05-10new loplugin:simplifypointertoboolNoel Grandin1-2/+2
Change-Id: Iff68e8f379614a6ab6a6e0d1bad18e70bc76d76a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91907 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-10lok: set device form factor of the client on view creationMarco Cecchetti1-11/+7
This patch allows the lok core to know about the device form facor of the client requesting the creation of new view, immediately instead of a later time. When a new view is needed a "DeviceFormFactor" parameter is forwarded to lo_documentLoadWithOptions and doc_createViewWithOptions from the client. This parameter can have one of the following values: 'desktop', 'tablet','mobile' and it is used to set a global variable accessible by SfxLokHelper::setDeviceFormFactor and SfxLokHelper::getDeviceFormFactor. This global variable is retrived in the SfxViewShell constructor for setting SfxViewShell::maLOKDeviceFormFactor attribute. In SfxViewShell we have the following 3 methods: - bool isLOKDesktop() - bool isLOKTablet() - bool isLOKMobilePhone() which replace the following boolean functions: - comphelper::LibreOfficeKit::isTablet - comphelper::LibreOfficeKit::::isMobilePhone Change-Id: I9b36f354278df8c216fcb90f6a9da8256ec9c1e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93340 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-05-08lok: MSForms: Handle event about item selection of a drop-down field.Tamás Zolnai1-0/+33
Change-Id: I095013097348c98361b6614e4ddf1e9029923c7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93659 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-05-08compact namespace in dbaccess..dtransNoel Grandin23-82/+52
Change-Id: Ie4b619dd19cc4d12d240759abea9c3ffdedd5c7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-05-07On iOS, avoid catching exceptions to just immediately exit or abort anywayTor Lillqvist1-0/+4
It is better to let the exception be uncaught and then catch that in the debugger. (Maybe even inspect its backtrace from a crash dump automatically sent from an end-user device.) Change-Id: Ice02d5cbd7f4a59eae7ce8a9fac47dec8b234a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93505 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93601 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>