summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2015-02-12Query Design: use correct name for columns that come from another query.Lionel Elie Mamane1-1/+14
Change-Id: I25b4ccdc2f50ba89687e1f4c871f286251a28e21 Reviewed-on: https://gerrit.libreoffice.org/14344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-12tdf#89070 Table filter dialog: properly initialise OTableTreeListBoxLionel Elie Mamane1-0/+1
regression from .ui conversion: commit 5c72a213c7c4b588d0c1e0884ff2c46c22425faf Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jan 21 14:41:16 2014 +0000 convert table filter page to .ui Change-Id: I7bfb7698e2a5303b492766fba564c7b9033bcc52 Change-Id: Ic7d41d64d4c15eabf7b7f83a17482c473154434a Reviewed-on: https://gerrit.libreoffice.org/14343 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-09tdf#73059 isDBReadOnly ensure connection before trying to retrieve itLionel Elie Mamane1-0/+1
Change-Id: I03f9b8ea72bd6906df61ccf05ead3670d7f90eb7 Reviewed-on: https://gerrit.libreoffice.org/14345 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-05Resolves: tdf#88825 absent datasource causes exception / abortCaolán McNamara1-14/+21
::dbtools::ensureRowSetConnection throws on failure, and it can fail of course if the database doesn't exist its not generally useful to throw through a vcl event handler as that just leads back to the dispatch loop. (cherry picked from commit 863122b9adecedfcf35ffac1354ef8a85d5b6827) Conflicts: dbaccess/source/ui/browser/sbagrid.cxx Change-Id: I8e8f4cff06de5684f163ed1b658a8794f54a7df2 Reviewed-on: https://gerrit.libreoffice.org/14330 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-27tdf#70236 propertly recognise full Access 2007 URLLionel Elie Mamane1-1/+1
Change-Id: If1f4986cfffada6a6ab507296a54589bdd5404ff Reviewed-on: https://gerrit.libreoffice.org/14213 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-01-23fdo#88475 RowSetBase: reposition cache before interrogating itLionel Elie Mamane1-0/+2
This partially reverts: commit d20232a77565f46fedc0b556f4d50addff4d3559 Author: Lionel Elie Mamane <lionel@mamane.lu> Date: Thu Dec 6 13:22:06 2012 +0100 Don't force refresh when higher up code did not request it Change-Id: I0f415c96fc05c1d776d14885751aef020c42f4ae which did not take into account that the cache is shared with the clones. This is not a cherry-pick from master, but a more conservative version of commit d7c9a1d9d65fe8b1a56c5c280d2ca6640a549d2f. Change-Id: I1fa5c3169806760d35dd07e1fc1b8d5522dd3641 Reviewed-on: https://gerrit.libreoffice.org/14104 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-01-07Resolves: fdo#87840 by default hide all feature checkboxesCaolán McNamara2-18/+19
and explicitly show the supported ones (cherry picked from commit fef5c2b81d1ac7d64e01521da792f470b03a1841) Conflicts: dbaccess/uiconfig/ui/specialsettingspage.ui Change-Id: I93d998472a82085da9bd5a8ec7ad4cb39998e198 Reviewed-on: https://gerrit.libreoffice.org/13789 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-01-05Related fdo#87840: mix between ignorecurrency and inputchecksJulien Nabet1-2/+2
Cherry-picked from: 0f9ce69b327ee14f028c26e6af275779b8047def Change-Id: I38501b371b8c63ab2e6fb019e17416e139120908 Reviewed-on: https://gerrit.libreoffice.org/13711 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-11-10Resolves fdo#82500: Operators missing in Standard FilterJulien Nabet1-2/+2
Regression from http://cgit.freedesktop.org/libreoffice/core/commit/?id=be88126e80b1f6b9a3090ba4617d9a87dfb0a0bd Cherry-picked from 3d16e8593ac1e9d90f0a033732766907476822f9 Change-Id: I4f03fbf4e6e6a0f6a901cadb87494baa92d66895 Reviewed-on: https://gerrit.libreoffice.org/12328 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-11fdo#84073: change ODBC/JDBC escapes to lowercaseJulien Nabet3-3/+3
Change-Id: I19ce3acb9575fbef8273bbd84cb4dc322e101ac8 Reviewed-on: https://gerrit.libreoffice.org/11885 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-10-11fdo#84658 on reexec, cancel modification before resetting IsModification stateLionel Elie Mamane1-0/+2
Change-Id: I878bff4d36ca1c2dd9474c937b03d0b366a6e911 Reviewed-on: https://gerrit.libreoffice.org/11824 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2014-09-25fdo#52076 unittestLionel Elie Mamane5-0/+520
Change-Id: Iae10f9728db4c90c4a55ad692b32cddeb7adc48a Reviewed-on: https://gerrit.libreoffice.org/11277 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-09-09Resolves: fdo#83501 STR_QUERY_* populate the join dialogCaolán McNamara2-0/+6
(cherry picked from commit 3fc1e691c5e14f3b7a2579b563188e814f731cf6) Change-Id: Id4cff969297009c9f9cd3323ac01c743b29ca6c4 Reviewed-on: https://gerrit.libreoffice.org/11340 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-14fdo#82151 when constructing column object, replace m_aCurrentRow by a functionLionel Elie Mamane5-30/+34
The passed m_aCurrentRow becomes out-of-date as soon as the current row changes. This also hides an implementation detail of ORowSet to ORowSet(Data)Column. Functional squelch of the following master commits: Change-Id: Ib9188743e5dd6dec240e9f5fd3fd9655c6761abc commit id: 03a2b4a80c5854bcb8520f2a43e485b98e3eba8f Change-Id: I527cc35ae120cf083f7c69a9a23526839a2bbddb commit id: 90b09303ef4f9163428107be7b8db23022ce10b7 Change-Id: If813a1544ec9a5dac6f87197982d10576c91cd8c commit id: 5be4407d0716f78acdcdf24de135af91f17e51be + keep older behaviour of confusing no value and null value. Change-Id: Ib9188743e5dd6dec240e9f5fd3fd9655c6761abc Reviewed-on: https://gerrit.libreoffice.org/10796 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12Resolves: fdo#82413 crash in format->columnCaolán McNamara1-1/+2
Change-Id: I3af776c14ec0f224884488fdc99ee26ebbba7cb8 (cherry picked from commit e2d2fa4f0663cf990c0595f8827ff9123c88d41a) Reviewed-on: https://gerrit.libreoffice.org/10876 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2014-08-12Don't leak the previous cacheLionel Elie Mamane1-0/+4
Conflicts: dbaccess/source/core/api/RowSet.cxx Change-Id: I61cb1c608a7de8efc63533085e86c6c17c05f545 Reviewed-on: https://gerrit.libreoffice.org/10795 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-23Resolves fdo#81213: Wrong table-clause generated by reportbuilderJulien Nabet1-1/+1
Oracle doesn't accept "AS" for making an alias from a table See https://bugs.freedesktop.org/show_bug.cgi?id=81213#c2 https://bugs.freedesktop.org/show_bug.cgi?id=81213#c4 https://bugs.freedesktop.org/show_bug.cgi?id=81213#c5 for more information (thank you Lionel) Cherry-picked from 568778874429595855b435792e5ebecd52956dae Change-Id: I33c86d78b2590116d4af46ffd3e54c3c791268ea Reviewed-on: https://gerrit.libreoffice.org/10469 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-07-03bnc#812796: Correctly handle static value array for OOXML charts.Kohei Yoshida2-0/+14
We need to pass the role of the data sequence in order to avoid unreliable guess work when importing static value array. Also, not all Excel's scatter plots have real numeric X values; some have textural X values in which case Excel switch to generating 1, 2, 3, ... as X values. When importing to our chart implementation, using "categories" role in such cases instead of "values-x" results in a more faithful chart rendering. (cherry picked from commit 6c4e21a234f12e1310ba06f9859e08b424acf8bf) Conflicts: chart2/source/inc/InternalDataProvider.hxx chart2/source/tools/InternalDataProvider.cxx Change-Id: If4bc1f650bb024dcd1b1b36537f457fb38404a78 Reviewed-on: https://gerrit.libreoffice.org/10040 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-07-01Resolves fdo#43277 Send Legacy Report "E-Mail as ..."=>error messageJulien Nabet1-1/+1
Cherry-picked from 501ebd0f7c867c4df5ba84fd8b6b1a197aeeea92 Change-Id: Iaaadd4fd3015214c007a86d1a83f837aa0d2bdb6 Reviewed-on: https://gerrit.libreoffice.org/9997 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2014-06-26fixes for up-casting to Reference<XInterface>Noel Grandin1-1/+1
Fix regressions introduced with 6a043e9c0acff20e1618ca8ec15c21d5d0fd0d37 "Use the new type-checking Reference constructor to reduce code noise" Change-Id: I85662856f21c810a7db497fe3b0e116f075b1687 Signed-off-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 533c6cb6bad6ef0432e8eebbfd4daf90ef71f3b4) Reviewed-on: https://gerrit.libreoffice.org/9919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-24fdo#80422 check only one radio button in a groupDavid Tardon1-3/+0
Change-Id: Ibf1ed3d33d8b2c7da4eee26943da0c09647f4bff (cherry picked from commit 012003e4681736083f6d3f987a69011ef0200ddc) Reviewed-on: https://gerrit.libreoffice.org/9872 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-23fdo#71076, fdo#71767: Preserve number formats when charts are copied.Kohei Yoshida6-7/+7
(cherry picked from commit 1d38cb365543924f9c50014e6b2227e77de1d0c9) Conflicts: sd/source/ui/view/sdview3.cxx xmloff/source/chart/SchXMLExport.cxx Change-Id: If5ae8852152012483237e7602e56a0c46ea8748a Reviewed-on: https://gerrit.libreoffice.org/9836 Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2014-06-18fdo#79427 after execute() a ResultSet is expected to be BeforeFirstLionel Elie Mamane1-19/+27
Squash the three commits in master: Change-Id: I38091d1ee2161d6e32da3a0bde60e3fc008aa83d Change-Id: Iaa881d055923702acbb96862d187af41a6ded730 Change-Id: I3e34f77ce37c239d8d3d6a8cd7514b125b049de6 1) fdo#79427 after execute() a ResultSet is expected to be BeforeFirst 2) clean up fdo#79427 fix: force BeforeFirst only at execute(), not updateRow() 3) dbaccess::ORowSet: separate impl_rebuild_throw Used by two different callers that wanted different things. Also, freeResources now always positions on BeforeFirst. It is only called with _bComplete==false by execute()-related code. Change-Id: I3cce4334c4ed49855c98fbe5960fb68685c61ed9 Reviewed-on: https://gerrit.libreoffice.org/9813 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-06-09fdo#79786 implement getFormOperations for data grid (table view)Lionel Elie Mamane1-2/+3
Change-Id: I704057b25ca11633ba62fbb834bd2e6095f348f3 Reviewed-on: https://gerrit.libreoffice.org/9686 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2014-06-04loplugin:literaltoboolconversionStephan Bergmann1-1/+1
Change-Id: Ie871fa9378bbb34eacd3205f9485a6f89f833674 (cherry picked from commit 3e336d69e32ddfac624c450b7bb990dfea1f9c3b)
2014-06-04fix index dialog regressionCaolán McNamara2-2/+2
thanks to sk94 for noticing this when trying to convert this to .ui Change-Id: If7130d53acb7c194cf0a9a4301f3573789888b86 (cherry picked from commit 3e66a5b5c6d1f602db2af5b5b44f5f41c83918f9)
2014-06-03fdo#73352 don't crash if clearWarnings throws an SQLExceptionLionel Elie Mamane1-2/+11
Change-Id: If67bda43589834e4c922056145bc60884728cb8a Reviewed-on: https://gerrit.libreoffice.org/9592 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2014-05-21fix spellingNoel Grandin1-1/+1
Change-Id: I1a4d66a78549ea49649a6bed92acb44dbd8b13e2
2014-05-20fdo#78971 There's even a git hook to prevent commits containing SAL_DEBUGStephan Bergmann1-18/+0
Change-Id: I5a46e1eed129edf3648c68c36951d6fdf9bd370d
2014-05-20enhance pass-by-ref plugin to detect large argumentsNoel Grandin2-2/+2
Detect arguments larger than 64 chars passed by value. Change-Id: I9b0ea9ccb99d115984a26eab67c9cf6afd5f6cae Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-19WaE: -Wunused-variableThomas Arnhold1-3/+0
Change-Id: Iece721dea1c8cc7601352849ca4fc0398375d320
2014-05-19hrc and src files: squeeze multiple newlinesThomas Arnhold33-149/+0
for i in `find . -name *.src -or -name *.hrc`; do FILE=$(cat -s "$i"); echo "$FILE" > "$i"; done Change-Id: I2bac5ad3e1eb3c566e5c867ccf45893a19e1561e
2014-05-18hrc files should have hrc suffixThomas Arnhold1-3/+3
Change-Id: Iadbedc145c85c5f333e4449704fd01d5e12ddde5
2014-05-17Correct common misspellings, and remove some ASCII art along the way.Chris Laplante3-5/+5
Change-Id: I42787db31769e8bde984c5f4f0aa90335e889b1c Reviewed-on: https://gerrit.libreoffice.org/9356 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
2014-05-17Comment why it's not a copy paste errorJulien Nabet1-0/+1
See http://nabble.documentfoundation.org/Question-unoType-for-getXmlToken-dbaccess-reportdesign-module-td4109071.html Thank you Lionel! Change-Id: I999bad0d6de0327bea7ba04a6c61a497d45f53a0
2014-05-15Minor utl::TempFile clean upStephan Bergmann1-1/+0
Change-Id: I20de8b2321d2656d17d25c6343d72c534d47e597
2014-05-14dbaccess: remove SAL_INFO's that only make function entryNoel Grandin28-816/+38
Change-Id: Ibdf92698446d0a7aed7c474ec7d3ea720cd2c2a6
2014-05-13Typo: shoud -> shouldJulien Nabet2-2/+2
Change-Id: I44f4fb9682a56af6654e1f7462dc37557d60e735
2014-05-13convert copy table page to .uiCaolán McNamara8-206/+348
Change-Id: Id537486dcaf0d3c6ab850a9fb50cef3d995ad51f
2014-05-12fdo#43157 Remove OSL_POSTCOND, prefer SAL_WARN_IFMichaël Lefèvre6-8/+8
Change-Id: Ia89a2dce799c7ba90bcd19919195bfd2c7a4a180 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-05-11coverity#707740 Uninitialized pointer fieldCaolán McNamara1-1/+2
Change-Id: I2e948197f5299b93e22fdf3590494fcf72be3fdb
2014-05-11coverity#707744 Uninitialized pointer fieldCaolán McNamara1-0/+1
Change-Id: I3735755f6f9e698a9c2dbedb9875a119de4b48f7
2014-05-11coverity#707746 Uninitialized pointer fieldCaolán McNamara1-1/+1
Change-Id: I10d7e69ad11a96b993c48ffeea53f8c1e9cd7853
2014-05-11Fix previous commit (dbaccess part)Julien Nabet2-5/+5
Change-Id: I0815cb6334ab47dbe9f5029fe553457de00c5ad5
2014-05-11Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part10Julien Nabet12-29/+29
Change-Id: I67acda35fa127547dcea0cd18c9dc16db7c00294
2014-05-11update_pch: add dbaThomas Arnhold6-7/+375
3m32s -> 2m43s Change-Id: I67f3d05fad90ca06754e8305387171f52b3d7095
2014-05-10Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part9Julien Nabet3-30/+30
Change-Id: I82ed4a4868cb22566706ca0f4b1321e0d45016cf
2014-05-09convert apply columns page to .ui formatCaolán McNamara9-212/+266
Change-Id: I14f12809d2e78a184ed53d6d9cee81d5f4e79ae6
2014-05-08typosThomas Arnhold2-2/+2
Change-Id: I2e7676ddec446dfdb72018a1039d6271f963376c
2014-05-08coverity#735404 Logically dead codeCaolán McNamara1-19/+1
Change-Id: I648a573bc886c790886caa45324503cd15c350cd