Age | Commit message (Collapse) | Author | Files | Lines |
|
This one is ugly, the Yacc generated header is used in lots of places;
the dependencies are already right because using the header requires
using the dbtools library which builds the YaccTarget, so just yet
another include path has to be added.
Change-Id: I031fde80ac326551d4719533305b1ae35351ca43
|
|
Instead include generated headers directly from workdir.
Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
|
|
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
|
|
|
|
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.
Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
|
|
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
|
|
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
|
|
Let foo.odb be a database file that has a macro that connects to the
Database on "Open Document" event (and needs to prompt user for
user/password).
There was a race condition between two actions:
1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController,
which tries to get dbaui::OApplicationController's mutex
2) the StarBasic macro calling dbaui::OApplicationController::connect
which needs to display a dialog (to get username and password),
and thus puts that dialog in the main thread's event queue
and waits for it ... with dbaui::OApplicationController's mutex held
Now, if "1)" is before "2)" in the event queue of the the main thread,
*but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock.
Fix:
1) Make OnFirstControllerConnected synchronous.
Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph)
that nothing else will happen with the OApplicationController as long as it is not finished.
---> it does not need to take mutex itself anymore
This avoids the "order in the asynchronous events" dependency.
2) Change dbaui::OApplicationController::ensureConnection to do the user prompting
WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning
the connection to m_xDataSourceConnection.
Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>.
ensureConnection will never return the discarded connection, though.
(I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html)
This keeps it from locking on another condition while holding the mutex.
Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32
Reviewed-on: https://gerrit.libreoffice.org/3310
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: Ib3957fbadf6bfebfaabd5bef09aaf7ab21862cd6
|
|
As opposed to only the column name
Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
|
|
Change-Id: Ibf566a11a383b77a930d46967e496752c88b39e4
|
|
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
|
|
Just use SAL_WARN, building up the message using chained << operators instead
of constructing it into a OStringBuffer (or OUStringBuffer) and then passing
that to OSL_FAIL.
Or should we have a real assert() here?
Change-Id: I2c3f64ff2b29a3d81ba444d98c2a38ef49e6d7af
|
|
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
|
|
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
|
|
Change-Id: I098a4514b9b32b1ecf96b1f2275f77bac540d557
|
|
Change-Id: I83487cddbd6b3fce1fdcdfa48623b63a0e026d90
|
|
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f
Reviewed-on: https://gerrit.libreoffice.org/3503
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac
Reviewed-on: https://gerrit.libreoffice.org/3502
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: Ide4697e6903c9550d31ea22ff0a5881878fddacf
|
|
|
|
|
|
Now all these usages were removed from LO.
Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6
Reviewed-on: https://gerrit.libreoffice.org/3326
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
|
|
Change-Id: Id12089bc7df16631737e6acaee0973fb91dd953f
Reviewed-on: https://gerrit.libreoffice.org/3431
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Change-Id: Ice80350184f7a514d5beab0a5e1da5b98d5733e4
Reviewed-on: https://gerrit.libreoffice.org/3427
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
|
|
Change-Id: I33f9df7f17158eedc4a4c0dedfd0fc4cddc6180f
|
|
Change-Id: I6250c3e3de81c33e8f4d73e2f80570521fdb6ea6
|
|
Change-Id: I287bef5b7f2baf5aaaab47141267ae2cadfe2451
|
|
Change-Id: Ieb653adbd0cb4371ec5db57e70bcc551872f647f
|
|
Change-Id: Ifd34ebfc7fe01b4a470eb072597dd3ec97c97863
|
|
Change-Id: Ie78b7ce399ba34485146ca7622c59d31f8105d02
Reviewed-on: https://gerrit.libreoffice.org/3229
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
I plan to use it to deliver all */uiconfig files, not just .ui, as a
preliminary step to get rid of postprocess/packconfig.
Change-Id: Ie7b4434b2f247165e3ab69a4d0c193418720a149
Reviewed-on: https://gerrit.libreoffice.org/3225
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
|
|
Change-Id: I5b0b7eeaa44e3e9e215b8d0bba7e7189c63c766c
|
|
Change-Id: Iaf57030a228d9c03c132976293d5e01e2fb287f4
|
|
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
|
|
.. and all of it's friends
Change-Id: I408d9308d1d1a4f8ed0055ac5f4042d729c44d1e
|
|
Change-Id: Ibb2466af4c9289cba93b8330d10db033d296bfc1
|
|
service already existed, just needed an IDL file
Change-Id: I9000cff76056efecf7ac748bcfc6dd5b8e902e65
|
|
See <https://gerrit.libreoffice.org/2444>
Change-Id: Ia45a3e30a25692cc1f5de90363bd7fe2f427e0d7
Reviewed-on: https://gerrit.libreoffice.org/3268
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
|
|
Change-Id: I97d91a758dd82d64768d75c1d2ddd279de5f6034
|
|
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).
Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
|
|
Moved portions from module i18npool, all of former i18nisolang1 library
that now is i18nlangtag. Included are languagetag, isolang and mslangid.
This i18nlangtag code is now even used by module comphelper, so
disentangling i18npool and making this an own module was needed to not
create circular module dependencies.
Change-Id: Ib887c3d6dde667403fd22d382310ba5f1a9b0015
|
|
Proposed patch for the following issue:
https://bugs.freedesktop.org/show_bug.cgi?id=62096
Change-Id: Ib83a9051ea12c53642f781e5427a6ca728049a7f
Reviewed-on: https://gerrit.libreoffice.org/3198
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Reviewed-by: Luboš Luňák <l.lunak@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
|
|
* only Get/SetCurrentTempURL were used, but only for compatibility reasons,
to remove old temporary directories (before 2001). Those should be gone
today.
* MailUIEnabled was false in the xcu file.
* SID_MAIL_SENDDOC* are handled some lines further.
Change-Id: I482719b0de9df0a77c2fef0bf25ae1fb68926375
Reviewed-on: https://gerrit.libreoffice.org/3180
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
Notes:
API CHANGE.
|
|
Just sprinkle #ifdef SOLAR_JAVA into the code instead.
In the source for jvmaccess and jvmfwk such ifdefs can be removed as
it isn't compiled unless SOLAR_JAVA.
Change-Id: Ia8614f8bd6d833582d3b79b5fb75f9153fa79606
|
|
Escaping them is not needed.
Plus escaped quotes are taken into po files and
make translater's work more uncomfortable.
Change-Id: I2ea7218120bc3d9967bdf51091ef091acbf2b73c
|
|
Change-Id: I44b816d6a270e8877e0db1408df4da3434932800
|
|
Change-Id: If24a2a8488f1b1142b12540e4b8b00eb26bd7873
|
|
not any string beginning with "*"
Change-Id: I6afe4db0ae69632990eafb288f715ae9cf7ad837
|