summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2018-03-06tdf#114596 dbaccess: fix mysterious dataloss bugMichael Stahl2-3/+5
OBookmarkContainer actually re-uses the reference count of ODatabaseSource, so converting ODatabaseSource::m_aBookmark to Reference created a cycle, which somehow causes the dataloss, because evidently something as important as storing the data must be done in the destructor. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) (cherry picked from commit 96ae2a3300811897c24cccb20f8c2faf382483df) tdf#114596 compilerplugins: add exception to [loplugin:refcounting] (cherry picked from commit e80da60895b45309fa1d018760d5f11cca4367f4) Change-Id: I4cad01dc9cdaf405c1eb31d6c0e161eb6712b78f Reviewed-on: https://gerrit.libreoffice.org/49026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit b5440ce23b17d84f7971cb7ea35512d5cac69c9f)
2018-03-06tdf#115080 menu id collisionCaolán McNamara1-5/+5
21 collides with the pattern field menu id Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56 Reviewed-on: https://gerrit.libreoffice.org/48487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 2b4ad9183d7fc0da40dc1fdd523bdc613612024c)
2017-12-18vcl: rename Window::Notify to EventNotifyMichael Stahl3-8/+7
There is annoying overloading between Window::Notify and SfxListener::Notify, and the Window one has apparently fewer implementations, so rename that and remove lots of disambiguating "using Notify" in multiply inheriting classes. Change-Id: I8b597fd9e70cf2e7103b9dfa7cc666e79e7aff49 (cherry picked from commit 6bb20609a2fd1d591cedc7fa2b9cabb589c346c7) (cherry picked from commit 03bfafb36107d18c0cccf53efdd550c0b7a81b8f)
2017-12-18use o3tl::typed_flags in ConfigurationListener::ConfigurationChangedNoel Grandin2-2/+2
Change-Id: I0ad7c02953aa53168dc242f1f374ab871728c84e (cherry picked from commit 04a84913ead2f82510d91eea2bb8526274feeeae) (cherry picked from commit acd0975a4e660096d6c575e8db022e96c7680aca)
2017-12-18convert DecodeMechanism to scoped enumNoel Grandin14-30/+30
(cherry picked from commit bfde4866e07746eafa2f0d6173c29d805cc35ad0) (cherry picked from commit 3de922d4a695e253d4ca2d42b70e0b35b52e9b7c) Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2017-12-18convert INetURLObject::EncodeMechanism to scoped enumNoel Grandin1-2/+2
(cherry picked from commit 803215142efa6437515348f63bd70ffdcf5d45f1) (cherry picked from commit 736cd289d4cdb0db61d92134bcc9d48aa7e79613) Change-Id: I50ea17c7779c7b5cacddf548f1773fd7d6c8bade
2017-12-05Fix typosAndrea Gelmini1-1/+1
Reviewed-on: https://gerrit.libreoffice.org/42726 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit e44c188a7353cc183fac8ece0cbf3611d842835e) Change-Id: I879a52820d78d9151ef64dd21612379f617f66e2 Reviewed-on: https://gerrit.libreoffice.org/45454 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 50e37a41acae8597fdb097715f8b76b16bce9f31)
2017-12-05New loplugin:dynexcspec: Add @throws documentation, dbaccessStephan Bergmann44-17/+184
Change-Id: I117be0dca3cc5e204414613123422b4b0716d8ed (cherry picked from commit 4c81fe62c16b0ebc7f86ff589880169247584c8e) (cherry picked from commit efb1db0b656d7ffe57a9b3cc23c7ebeb1b319f26)
2017-07-24Implement mail merge data source from Writer tablesMiklos Vajna14-15/+41
This is a combination of 17 commits: connectivity: add initial writer backend Similar to the calc one. As a first step the Driver and the Connection interfaces are implemented, though the later has some stubs. (cherry picked from commit 69068f2228147ca0d252762612edbcab0713cdfa) connectivity writer driver: initial DatabaseMetaData implementation With this the list of tables is visible in Data Sources. (cherry picked from commit d7ac239793905564d2754edc52611930b6ba2cdc) connectivity writer driver: add Catalog implementation But leave OWriterCatalog::refreshTables() as a stub for now. (cherry picked from commit 6fb3e3a9c1dd1aec8a1ba90fea51e32048e609bf) connectivity writer driver: add Tables implementation But leave OWriterTables::createObject() as a stub for now. (cherry picked from commit 60020f61339e5836f5a481909c1183af2734f569) connectivity writer driver: add Table implementation Gets rid of the stub warnings in OWriterTables::createObject(). (cherry picked from commit bec2da98c74dc4c02561641862de15e5d2630fa2) connectivity writer driver: add Columns implementation Gets rid of the stub warnings in OWriterTable::refreshColumns(). (cherry picked from commit a11ddfdcf3f5021cbeb0f065694d875bb748dc76) connectivity writer driver: add PreparedStatement implementation Gets rid of the stub warnings in OWriterConnection::prepareStatement(). (cherry picked from commit ac3c24bec925dd53f07b2827dab0d71c0dbaedee) Conflicts: connectivity/source/drivers/writer/WConnection.cxx connectivity writer driver: add ResultSet implementation Now column headers and table data show up on the UI. (cherry picked from commit a93c89894feb663df37609c95d4db523120c0bc1) connectivity writer driver: add Statement implementation Gets rid of the OWriterConnection::createStatement() stub warning. This is the last interface which was not supported by the writer driver, as far as I see. (cherry picked from commit cad0d8df38cf390d0615668ce2ab7c8f7ee42cde) connectivity writer driver: mention Writer in display name It was just "Document" to be consistent with Calc's "Spreadsheet", but it's confusing as we have a Text driver as well. (cherry picked from commit 5445de1432fd65fb3ef613d1dafd2bbb9b99b265) dbaccess: introduce DATASOURCE_TYPE::DST_WRITER By mostly reusing the spreadsheet code. This way the UI allows creating a data source where the backend is a Writer document (containing at least one Writer table). (cherry picked from commit 36f2df84fcfc21038b4d20df38a9e5addfcbde3f) sw mail merge: add support for the new 'writer' connectivity driver By mapping the .odt, .sxw, .doc and .docx extensions to sdbc:writer:. If we are at it, also accept xlsx next to xls. (cherry picked from commit 83b43ef2223b66484e0e90e7b614886e06f955b5) Conflicts: sw/inc/dbui.hrc sw/source/uibase/dbui/dbmgr.cxx sw mailmerge: add writer data source testcase Fails with commit 83b43ef2223b66484e0e90e7b614886e06f955b5 (sw mail merge: add support for the new 'writer' connectivity driver, 2017-07-18) reverted. (cherry picked from commit d9b0108e3af7244179bcc7b07db9d0826c3ac8a6) connectivity: merge OCalcResultSet and OWriterResultSet Into a single OComponentResultSet, as both of them just provide data source functionality based on a file loaded into an LO component, so they can share code. (cherry picked from commit e473d49acc127ece76eb31cb3610e3950f35d9d9) Conflicts: connectivity/source/drivers/component/CResultSet.cxx connectivity/source/drivers/writer/WResultSet.cxx connectivity/source/inc/writer/WResultSet.hxx connectivity: merge OCalcStatement and OWriterStatement Into a single OComponentStatement, as both of them just provide statement functionality based on a file loaded into an LO component, so they can share code. (cherry picked from commit 4073bc15d1aa1b46b2e0953d6316f2ab6a23dc87) connectivity: merge OCalcPreparedStatement and OWriterPreparedStatement Into a single OComponentPreparedStatement, as both of them just provide prepared statement functionality based on a file loaded into an LO component, so they can share code. (cherry picked from commit 196ee66d4aab62678a8cfb762379909bdda16051) connectivity: merge OCalcColumns and OWriterColumns Turns out createObject() only needs the base class OFileTable, and then these can be shared. (cherry picked from commit d3d9292a0fb414e6721b2f3b12b7e283caed946d) Change-Id: I6e8a83155dbbbc3d85794e190c2e710d01902017 Reviewed-on: https://gerrit.libreoffice.org/40231 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-06-12tdf#37859: Odb data copied to Calc showed wrong encoding in WindowsJulien Nabet1-1/+1
Blind fix since I don't have Windows. If it works, many thanks to: - Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16) - Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35) Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a Reviewed-on: https://gerrit.libreoffice.org/38253 (cherry picked from commit 39487b14956d883899311b6294f6f09ca2371366) Reviewed-on: https://gerrit.libreoffice.org/38547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3951d44110df55589ff80f5eab752817c2475c0d)
2017-05-07Collabora Office: remove Safe Mode from menus and Windows start menuAndras Timar5-10/+0
Change-Id: I9eaf6ef76597be6bc35462308f1cee61cb9bae5a
2017-02-18loplugin:vclwidgets check for assigning from VclPt<T> to T*Noel Grandin5-19/+12
Inspired by a recent bug report where we were assigning the result of VclPtr<T>::Create to a raw pointer. As a consequence, we also need to change various methods that were returning newly created Window subclasses via raw pointer, to instead return those via VclPtr Change-Id: I8118e0195a5b2b4780e646cfb0e151692e54ae2b Reviewed-on: https://gerrit.libreoffice.org/31318 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit e6ffb539ee232ea0c679928ff456c1cf97429f63)
2017-01-17unixODBC changed soname to .2 so reflect itTomáš Chvátal1-1/+6
we dlopen this library and thus we should be able to find it with any soname, so far .1 and .2 seem to be used. Also now the load order on linux is: .so.2 -> .so.1 -> .so Change-Id: Idcd284fada1acdfe8dde46c3056c21b792777280 Reviewed-on: https://gerrit.libreoffice.org/32755 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu> (cherry picked from commit 3f5584526fd4e8290dac033e1cf3d64acd25d893) Reviewed-on: https://gerrit.libreoffice.org/33226 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-10Resolves: rhbz#1409634 crash on close storing clipboard of database tableCaolán McNamara1-2/+1
Change-Id: I8e692314b4ef278f7881780d51bcecb60ca80c3f (cherry picked from commit 6c2725038b627535ba97ead89dadb96e0ff69c3c)
2017-01-05require firebird 3.0 for build (don't allow 2.5)Lionel Elie Mamane1-4/+0
Keep firebird_integer_x64le.odb around for a future 3.x firebird that will allow opening Firebird 2.5 databases, so that we can test this capacity in our tests. Change-Id: I05dbef51284bdb25132ff6cb661659430eea6a92 (cherry picked from commit 860ecb9e583627ab43097784ad98b41afd983ff6) Reviewed-on: https://gerrit.libreoffice.org/32753 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-12-13dbaccess: fix testCloneMovesPlusDeletions testMichael Stahl1-1/+6
JunitTest_dbaccess_complex spuriously fails 1% of the time with: 1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet) java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756) The problem is that line RowSet.java:750 deleteRow() manages to delete the last row in the set, because the positionRandom() is tricked to position itself on the last row (which it tries not to do), becuase the RowSet is currently positioned past-the-end on a deleted row and the ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the result in this special case. Funnily both the ORowSetBase::impl_getRowCount() and the test using positionRandom() were added in CWS rowsetdel. Yay for randomized tests! Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e (cherry picked from commit ae8bd4267ac2da58f9e476d24e1e894202e92dea) Reviewed-on: https://gerrit.libreoffice.org/31927 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-22remove some more global OUStringsNoel Grandin2-3/+0
Change-Id: Ic02754f98bfda3b7cd8c06857123d363a96e8d0e Reviewed-on: https://gerrit.libreoffice.org/31071 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-22trivial makefile cleanupsMichael Stahl5-20/+0
Change-Id: Ida5bdfa06ecd7907305f4f171ca5ab64260d0259
2016-11-21Revert "add missing component"David Tardon1-1/+0
This reverts commit 7fe1b39e8abe68357c88536923b7058807b32119.
2016-11-21Revert "add missing component"David Tardon1-1/+0
This reverts commit b55d17471f73b843943269c6cbd30f99995d8354.
2016-11-21add missing componentDavid Tardon1-0/+1
Change-Id: I53d50f8e338fcc64e24370a80ce390f7a2be34ba
2016-11-21add missing componentDavid Tardon1-0/+1
Change-Id: I8b6f6d650c011fc0611d6933894bc64a780ff8c0
2016-11-21add missing deps on ui filesDavid Tardon1-0/+4
Change-Id: I28bb2a33c02d8eadced584d3d3f2b62b2e847324
2016-11-20gbuild allow unitest to run once per lang in WITH_LANG_LISTNorbert Thiebaud1-1/+1
this is motivated by the new screenshot feature the initial proposed solution involved running make screenshot once per lang which took ~6 hours for --with-lang=ALL on tb68 a reasonnably big windows slavebot. with this patch, one can run make screenshot just once and get all the screenshot the elapsed time is 36 inutes on the same box/same config a 10x improvement. Change-Id: I4339caebf915c118aa455de2a7e56e1a4e413939 Reviewed-on: https://gerrit.libreoffice.org/30970 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-11-17loplugin:datamembershadowNoel Grandin1-2/+0
Change-Id: I0206905ce95467a560f8ed24db4403df07d3680e
2016-11-15Fix typosSamuel Mehrbrodt1-1/+1
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672 Reviewed-on: https://gerrit.libreoffice.org/30872 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15loplugin:constantparamNoel Grandin3-4/+4
Change-Id: Iced8ff99d52d55e6b6c3126affafbea6786e94f0 Reviewed-on: https://gerrit.libreoffice.org/30858 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-12coverity#1394296 Dereference before null checkCaolán McNamara2-15/+12
Change-Id: I143b7439b33695aa5bc4e32fd9386692eac37697
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin8-10/+10
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann1-2/+2
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann1-8/+1
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-09loplugin:expandablemethods in dbaccessNoel Grandin41-276/+88
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin1-1/+1
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin4-10/+8
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07style fix for cppcheck redundantConditionJochen Nitschke1-1/+1
Change-Id: I5d02c6f4c6b411c23a6de43374884a76e1c408fe Reviewed-on: https://gerrit.libreoffice.org/30667 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-07Resolves: #i119892# Missing "by" in descriptionDamjan Jovanovic1-1/+1
Fixes spelling errors in some Base messages. Reported by: Dwayne Henderson Patch by: me (cherry picked from commit 8df1c30b7f5e79c2757e7224677f9a487b1bed0a) Change-Id: I18dcf20e51e941ca8ccb47315ea453399ca0d88a
2016-11-04loplugin:oncevar in dbaccessNoel Grandin17-92/+43
Change-Id: I956063bb354fbbd002e922bb06d0b3863a2750fc Reviewed-on: https://gerrit.libreoffice.org/30565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03tdf#91222 VclBuilder constructor cleanupmelikeyurtoglu1-8/+1
Change-Id: I53bca2a9113862b8e7058937e231721c5f81a9de Signed-off-by: melikeyurtoglu <aysemelikeyurtoglu@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/30511 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-02loplugin:unusedfieldsNoel Grandin1-6/+0
Change-Id: I96634c18ba6600f8f7d5d04a162dcd7e1e312923 Reviewed-on: https://gerrit.libreoffice.org/30474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-01style fixes for cppcheck noExplicitConstructorJochen Nitschke1-1/+1
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34 Reviewed-on: https://gerrit.libreoffice.org/30460 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-31No good reason for dbaccess::OCacheSet::updateRow to be pure?Stephan Bergmann3-7/+1
Most of its virtual member functions are (though insertRow is already a curious exception), even though they are defined, so smells like a copy/paste error rather than deliberate design. And appears to have been the only reason why loplugin:unnecessaryoverride filtered out such overriding of pure base functions. Change-Id: Ib2a40af9cd3cd3dbb26c4147f7d01de4e11f5f6e
2016-10-31update vclwidgets plugin to check local variablesNoel Grandin1-2/+2
Change-Id: I91f7fc6b8419c0ed82194726eeb4c4657e998f22 Reviewed-on: https://gerrit.libreoffice.org/30428 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-30tdf#95014 initial support for 32 px icons in toolbarTomaž Vajngerl1-1/+1
This adds support for 32 pixel icons - mainly to get them into the toolbar. Most changes made are to change the behavior of having only small and large icons as a boolean choice, but not every code path was converted to non-boolean choice yet. Breeze icon theme has the 32px variants so it can be used already. Change-Id: Iadf832a87826c16b3a83522104dd6c35d61a0f87 Reviewed-on: https://gerrit.libreoffice.org/30398 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-10-30Allow using xml menus in DBTreeListBoxMaxim Monastirsky2-15/+60
Change-Id: I8dfab0ae5d64b416123ab5690b43cf2db77d92dc
2016-10-30Add resource name method to IContextMenuProviderMaxim Monastirsky6-2/+21
Change-Id: I218fd18101f8f7039052fe8a065096e4c9809adb
2016-10-30Convert RID_MENU_APP_EDIT to xmlMaxim Monastirsky3-130/+35
Change-Id: I6868624b1726b1044e741a1fc0cdabe703f84c31
2016-10-28update unnecessaryoverride plugin to find pure forwarding methodsNoel Grandin7-17/+6
which can be replaced with using declarations. Is there a more efficient way to code the search? Seems to slow the build down a little. Change-Id: I08cda21fa70dce6572e1acc71bf5e6df36bb951f Reviewed-on: https://gerrit.libreoffice.org/30157 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-28ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivativesCaolán McNamara1-1/+1
Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2 Reviewed-on: https://gerrit.libreoffice.org/30344 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-27Sub menus no longer need manual disposingMaxim Monastirsky2-2/+2
after: commit ee79a2dd7ea60e902cab3a9203e307b8a78fee23 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jul 29 14:33:22 2016 +0100 Resolves: tdf#101169 crash using column menu in base Change-Id: I7c6e54dd5574c61cffd5884d1cf1b63075073001 Reviewed-on: https://gerrit.libreoffice.org/30343 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-10-27dbaccess: OToolboxController is now unusedMaxim Monastirsky7-337/+0
This also removes the only occurrence of the "com.sun.star.frame.ToolboxController" service. However it shouldn't be considered as API CHANGE, as no 3rd-party code should rely on undocumented services, and fortunately a toolbox controller like this has no use for 3rd-party anyway. BTW there are other cases of using non-existent (unique) service names for toolbox controllers in non-sfx2 modules, rather than using the standard "com.sun.star.frame.ToolbarController". There is OToolboxController in reportdesign (which I hope to remove soon too, as it's just a wrapper around SvxColorToolBoxControl). And there was also ShapeToolbarController in chart2 which I removed in 2aea9e37d697ce51efc5fb37ba50f1bf177e0445 ("Introduce generic sub toolbar controller"). Change-Id: Iea8858be2406f32bb5a022920b4b1cee70603c09
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-01 12:47:22 +0000