summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2018-02-01tdf#114596 dbaccess: fix mysterious dataloss bugMichael Stahl2-3/+5
OBookmarkContainer actually re-uses the reference count of ODatabaseSource, so converting ODatabaseSource::m_aBookmark to Reference created a cycle, which somehow causes the dataloss, because evidently something as important as storing the data must be done in the destructor. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) (cherry picked from commit 96ae2a3300811897c24cccb20f8c2faf382483df) tdf#114596 compilerplugins: add exception to [loplugin:refcounting] (cherry picked from commit e80da60895b45309fa1d018760d5f11cca4367f4) Change-Id: I4cad01dc9cdaf405c1eb31d6c0e161eb6712b78f Reviewed-on: https://gerrit.libreoffice.org/49026 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-25tdf#115080 menu id collisionCaolán McNamara1-5/+5
21 collides with the pattern field menu id Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56 Reviewed-on: https://gerrit.libreoffice.org/48487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-10tdf#113923: don't use twice a new column in table copyJulien Nabet1-3/+13
In the case where: 1: we enabled the creation of a primary key 2: we come back here from the "Back" button of the next page, we want to avoid to list the new column generated in the next page So we must check added columns in right panel must exist in the table Change-Id: I467007941b03811381a216c1ab3de8fe729f9b9b (cherry picked from commit c2bc2c4633e92349cac390c05d245d1a812986c4) Reviewed-on: https://gerrit.libreoffice.org/47708 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org>
2017-12-28tdf#114702 don't use XMultipleResultset unless DatabaseMetaData says we canLionel Elie Mamane1-1/+3
Change-Id: Icec98d35c2f60adf4a31e492c6cb708e82e47a58 (cherry picked from commit 3c567e55e6aed9e0da892d8b9fc09f8a0c784fcc) Change-Id: If928bbe7985e36855dbf9d83fa09cdec2b48578e Reviewed-on: https://gerrit.libreoffice.org/47124 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-25tdf#103685: "Commands out of sync" when connecting to MySQL using directJulien Nabet2-35/+66
Thanks to Lionel for his great help Reviewed-on: https://gerrit.libreoffice.org/42688 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 444730a67dbd2ad6cebe666b2cd23c67d5c668f2) Change-Id: Ifcc1d72cca29c031f31da203cd1e3302ea0ea3e3 Reviewed-on: https://gerrit.libreoffice.org/42701 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-22Related tdf#112423: avoid crash when calling procedure twice (dbaccess)Julien Nabet1-0/+3
Since SbaTableQueryBrowser::implSelect returns a bool to indicate if everything is ok, should return false when we entered in a catch Change-Id: I9ae3ff3bf082278edb16a9b91701d6cf457e7179 Reviewed-on: https://gerrit.libreoffice.org/42601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-15tdf#96703: getDocumentStorage is called during initializationJulien Nabet1-1/+1
So use DocumentGuard::MethodUsedDuringInit instead of DocumentGuard::DefaultMethod to avoid com.sun.star.lang.NotInitializedException Then we'll got to tackle ODatabaseModelImpl::getOrCreateRootStorage: no source to create the storage from! Change-Id: I1f01bb46088445f3cb3264baee9ad4d45bb5fa8c Reviewed-on: https://gerrit.libreoffice.org/41837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 9a46ad2f762765348f7aef6e44774a47871362ae) Reviewed-on: https://gerrit.libreoffice.org/41852 Reviewed-by: Eike Rathke <erack@redhat.com>
2017-06-07tdf#37859: Odb data copied to Calc showed wrong encoding in WindowsJulien Nabet1-1/+1
Blind fix since I don't have Windows. If it works, many thanks to: - Urmas (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c16) - Himajin100000 (see https://bugs.documentfoundation.org/show_bug.cgi?id=37859#c35) Change-Id: I9fd84977eab8410ec022b6e34f1a636326eaf56a Reviewed-on: https://gerrit.libreoffice.org/38253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 39487b14956d883899311b6294f6f09ca2371366) Reviewed-on: https://gerrit.libreoffice.org/38513
2017-05-30Related tdf#108068: Retrieve error from Firebird engineJulien Nabet1-1/+2
Change-Id: If89a904740e54e81c2f2ae790ba8d05d830b0a5b Reviewed-on: https://gerrit.libreoffice.org/38043 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 182a62e0f199d26df0ae76ebf224c5d4b0fc3e26) Reviewed-on: https://gerrit.libreoffice.org/38179 Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-18DBACORE_RESSTRING can go nowCaolán McNamara24-88/+85
Change-Id: I0d1f5372dc6a29af62d3d85c5f771e1e8884626e
2017-05-16fix documentation nowCaolán McNamara1-2/+1
Change-Id: I1583b0f7fb0f99166606e327cdda3bbdcbe698da Reviewed-on: https://gerrit.libreoffice.org/37691 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-15remove some unnecessary lockingNoel Grandin1-1/+0
Change-Id: I7da9e82930d3fe8f927c495aeca270b8bb5cf65c Reviewed-on: https://gerrit.libreoffice.org/37602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-12remove unused uno::Reference varsNoel Grandin17-45/+11
found by temporarily marking Reference as SAL_WARN_UNUSED. Change-Id: I18809b62654467f890016adcc92576980ced393b Reviewed-on: https://gerrit.libreoffice.org/37511 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin5-9/+9
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke1-1/+0
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin7-23/+8
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin3-10/+6
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09loplugin:constantparamNoel Grandin10-31/+22
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2 Reviewed-on: https://gerrit.libreoffice.org/37390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke71-71/+0
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08loplugin:checkunusedparams in xmloffNoel Grandin1-20/+4
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2 Reviewed-on: https://gerrit.libreoffice.org/37283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin1-2/+2
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07revert OSL_ASSERT changesChris Sherlock1-1/+1
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert dbaccess module away from OSL_ASSERT to assertChris Sherlock1-1/+1
Change-Id: I14537ea5c9499df4d9ded48071b066fd8a99a0ce
2017-05-06tdf#107652: Crash relation Design windowJulien Nabet1-0/+1
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=057cde3f8aedc48401bfe864a5b03ef29dd8b641 "convert join table view menu to .ui" Change-Id: I6703f7b9b24b67dab87f0b64351d75b3051b5379 Reviewed-on: https://gerrit.libreoffice.org/37314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-05fix spelling, methode -> methodNoel Grandin1-1/+1
Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4 Reviewed-on: https://gerrit.libreoffice.org/37289 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05loplugin:checkunusedparams in svtoolsNoel Grandin3-5/+5
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7 Reviewed-on: https://gerrit.libreoffice.org/37201 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-05convert HTML_TOKEN_IDS to scoped enumNoel Grandin8-67/+65
Change-Id: I525506e0103e4f17e5b8b95f15c1285d65b93de9 Reviewed-on: https://gerrit.libreoffice.org/37220 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-02loplugin:checkunusedparams in cppcanvas and dbaccessNoel Grandin9-27/+23
Change-Id: Ia66e6326f3d1750b4e46a3f9f7127e7ed4aa99ca Reviewed-on: https://gerrit.libreoffice.org/37068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-28loplugin:salunicodeliteral: dbaccessStephan Bergmann2-8/+8
Change-Id: I294909d2596283a3249cd77c03c8e5518fdf32fb
2017-04-27tools: move errcode.hxx to the vcl moduleChris Sherlock2-2/+2
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3 Reviewed-on: https://gerrit.libreoffice.org/36854 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25remove dbaccess bitmaps from .src filesCaolán McNamara20-249/+107
Change-Id: I85e0d4bce7c2d1da2cc78c00e15e485152039c3e
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock3-3/+3
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25tools: svstream.hxx needs only errcode.hxx & not errinf.hxxChris Sherlock15-0/+15
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca Reviewed-on: https://gerrit.libreoffice.org/36896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-21gbuild: Remove MSVC 2013 legacy codeDavid Ostrovsky15-18/+0
Uwinapi is discontinued. Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01 Reviewed-on: https://gerrit.libreoffice.org/23198 Reviewed-by: David Ostrovsky <david@ostrovsky.org> Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21convert HTML_OPTION_IDS to scoped enumNoel Grandin1-14/+13
Change-Id: Ia766dc58a571e5853005fd394283d7b53f02e4a6 Reviewed-on: https://gerrit.libreoffice.org/36748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21remove unnecessary explicit linefeeds from end of SAL and OSL log callsNoel Grandin1-1/+1
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf Reviewed-on: https://gerrit.libreoffice.org/36727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-20loplugin:unusedmethodsNoel Grandin5-24/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-19clang-tidy readability-simplify-boolean-expr in dbaccess..frameworkNoel Grandin8-67/+31
Change-Id: I96e1bd4000f4ade6ccfac53c57653772b249df99 Reviewed-on: https://gerrit.libreoffice.org/36678 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-18unused idsCaolán McNamara2-10/+0
Change-Id: Ifba0092edf5839646be9745f8e9da680946db97a
2017-04-18convert query functions menu to .uiCaolán McNamara7-75/+82
Change-Id: Iba4fc93d6042d873c45c58f11b7b54638ed54d82
2017-04-18convert join table view menu to .uiCaolán McNamara4-21/+21
Change-Id: I249cf0ba1ffcc7e2736ac7270bc988a0916947dd
2017-04-18convert join menu to .uiCaolán McNamara7-33/+34
Change-Id: I4e38e431df00a8a97772c5eb0056f824beaf8912
2017-04-18convert primary key menu to .uiCaolán McNamara7-37/+34
Change-Id: I78b4f6edc33ddc908402d8ab952bfebc11e4f929
2017-04-18we surely don't want to fall through after showing a menuCaolán McNamara1-0/+2
Change-Id: Ib6577b85c444930cee298cccef445a842a541d7b
2017-04-18convert table design row menu to .uiCaolán McNamara8-114/+119
Change-Id: I8a6be28ccd7cbd2b8f18255e3da01df2dfe13fb8
2017-04-15convert column menu to .uiCaolán McNamara1-4/+4
Change-Id: I3a41b716c473a17821969f09945ac1a94b024d41 Reviewed-on: https://gerrit.libreoffice.org/36569 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-12can use gb_CppunitTest_use_configuration and still access .ui filesCaolán McNamara1-2/+1
after... commit 506cab1a01b0481d0831a7a692a26dc5a5b55e91 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 12 16:14:10 2017 +0100 take the .ui files from $BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR Change-Id: I9cffdc092206c038da32a32a2cfe629e68b5c258 Change-Id: I906d16037cdf0b9203a4120cb1a5e9846a5c7b7f Reviewed-on: https://gerrit.libreoffice.org/36482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-10loplugin:inlinefields in dbaccess::SubComponentLoaderNoel Grandin2-76/+36
Change-Id: Idc4ac037d023a7019e62ec3b7d12bc7717c11be8 Reviewed-on: https://gerrit.libreoffice.org/36345 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-10Clean up uses of SAL_U/SAL_W: dbaccessStephan Bergmann1-24/+25
Change-Id: I08816442e63ccd33148d233f21f3d761bcdde13c
2017-04-07convert RID_QUERYCOLPOPUPMENU to .ui formatCaolán McNamara6-43/+44
Change-Id: Idcf8566db964c475a0b9049f215af6fc57f0978b
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-22 06:45:34 +0000