summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2019-01-02Resolves: tdf#122285 task panel too shortCaolán McNamara2-3/+19
there are a bunch of resizes as base starts up, and base will position the splitwin on the first time its big enough to place it and gets stuck too high up, before it goes full size. We don't want this jumping around on every subsequent user size, but we do want it to get placed at the final size during the load. So post the resize event to occur on idle, and when it finally gets a chance to run we'll be at our final size and the placement is good Change-Id: Iccb169bac93a5cf8bc931945bc7e1b71c6c9dd23 Reviewed-on: https://gerrit.libreoffice.org/65587 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-12-21Resolves: tdf#121838 catch exception for missing columnCaolán McNamara1-1/+11
in database migration Change-Id: Ied42d1436f14012fb918e8e6775fcbe0f7d5fac5 Reviewed-on: https://gerrit.libreoffice.org/65546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-21tdf#122020 crash in SvTreeList::InvalidateEntryCaolán McNamara2-10/+17
a PostUserEvent of DBTreeListBox::OnResetEntry with a SvTreeListEntry* pEntry as payload, then the DBTreeListBox is disposed and then the UserEvent arrives and the, by now deleted, pEntry is processed by the disposed DBTreeListBox Change-Id: I951639eb633920aa3536cd44320f36f6b2e910aa Reviewed-on: https://gerrit.libreoffice.org/65513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18[API CHANGE] tdf#122152 set dialog parentCaolán McNamara1-1/+7
Change-Id: I15f6d577c3584d28f667a04b5571de80effe53fe Reviewed-on: https://gerrit.libreoffice.org/65274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0a9917b756cf49b117766c9236a7bf63d6d4b607) Reviewed-on: https://gerrit.libreoffice.org/65328
2018-12-18give dbaccess save query dialog a parentCaolán McNamara1-1/+1
Change-Id: I8e2c484f5237ad4fc3ec225f986336e6cbb0ba26 Reviewed-on: https://gerrit.libreoffice.org/65277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-06tdf#121935 crash on "set up connect to text files"Caolán McNamara4-18/+33
Change-Id: I73bc93ebb5010f3a376b3b121e1ac873f1be137a Reviewed-on: https://gerrit.libreoffice.org/64677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02Resolves: tdf#121810 wrong column orderCaolán McNamara2-2/+8
Change-Id: Ie82c47ea772b6eb5fc7b84426bb3c1cc98dc9c14 Reviewed-on: https://gerrit.libreoffice.org/64411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02Related: tdf#121810 pass suitable message dialog parent aroundCaolán McNamara3-4/+12
Change-Id: I1a27d82ef94f1052171f7a3f6c5c80c0ec66b547 Reviewed-on: https://gerrit.libreoffice.org/64410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-30Disable firebird migration assistant in 6.2Xisco Fauli2-6/+4
As decided in the ESC meeting on 11/29/2018 Remove the related tests as it was done for 6.1 See: https://gerrit.libreoffice.org/#/c/57508/7 Change-Id: Iadd45ede8d5f30de8701ad04e411c9de23ebba10 Reviewed-on: https://gerrit.libreoffice.org/64262 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-27suspicious has-default on help buttonsCaolán McNamara1-1/+0
Change-Id: I604e3bf6362271e767a4862a2c9d789a2c89df88 Reviewed-on: https://gerrit.libreoffice.org/64075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwCondCollPageCaolán McNamara5-10/+10
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7) Reviewed-on: https://gerrit.libreoffice.org/63770
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen7-0/+7
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 40710c488de3e4eef585c5a5276c9a0943d36f2e) Reviewed-on: https://gerrit.libreoffice.org/63769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen5-0/+6
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92) Reviewed-on: https://gerrit.libreoffice.org/63768 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19weld TreeViewCaolán McNamara5-4/+7
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17Adapt to C++2a char_tStephan Bergmann2-2/+2
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-16loplugin:buriedassign in dbaccess..ooxNoel Grandin4-8/+14
Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e Reviewed-on: https://gerrit.libreoffice.org/63468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16loplugin:staticmethods improvementNoel Grandin1-1/+1
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755 Reviewed-on: https://gerrit.libreoffice.org/63434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12loplugin:singlevalfields in accessibility..extensionsNoel Grandin4-9/+5
Change-Id: Id3a3241af83f769fc60f67e01c9129d6f4b5c2af Reviewed-on: https://gerrit.libreoffice.org/63274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski1-1/+1
Change-Id: I08ea67c1b51ee04258ce7769bfe9d97a1cb46b22 Reviewed-on: https://gerrit.libreoffice.org/63268 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski1-1/+1
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11cppCheck redundantAssignment pParseNodeZdibák Zoltán1-2/+1
Change-Id: I0e5e2d607bddd1f73fc8c256169a2fbe070f6448 Reviewed-on: https://gerrit.libreoffice.org/63256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai1-2/+2
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10Avoid getTokenCountMatteo Casalin1-5/+8
Change-Id: If4dcd0a3f316bd9812ffb12b8e64489d25ce89ca
2018-11-10Use indexed getTokenMatteo Casalin1-4/+5
Change-Id: I336924c43b6680c3742ca8c83801cbff3f346968
2018-11-10Avoid getToken to just get last tokenMatteo Casalin1-2/+2
Change-Id: I74669145a1341ff2a715cdec32676dfdd290d1f3
2018-11-10Loop only if string length is the desired oneMatteo Casalin1-9/+11
Change-Id: I5e03fceb83a22b590a62b605c4ada279b937730a
2018-11-10Avoid getTokenCount()Matteo Casalin1-8/+4
Change-Id: Ifc509b3c31f6dbfd4d620aa451fd85b82b0ddb90
2018-11-10Early bailoutMatteo Casalin1-8/+5
Change-Id: I0ffcbbfe2380755ff21532b314961c317ce0c69d
2018-11-10Avoid getTokenCount()Matteo Casalin1-8/+22
Change-Id: Ia71e4822ce863a296c7c0eb137c164538f9a0d27
2018-11-10Use indexOf instead of getTokenCount for simple checkMatteo Casalin1-1/+1
Change-Id: I0a0068649fd688f311e1ba4865a51406c4ffd672
2018-11-10Fix double ;Matteo Casalin1-1/+1
Change-Id: I8009565c5ae2580d0cdbf3b323b95d61c25c0dcd
2018-11-10Avoid getTokenCount()Matteo Casalin1-1/+1
Change-Id: I1f6468e1050924b0c6f6971ad6276932a3c91f75
2018-11-10Replace deprecated boost::optional::reset(val) with operator =Mike Kaganski4-6/+7
Change-Id: I7340a561e0df0c781fd834388deb4b9f83800f9b Reviewed-on: https://gerrit.libreoffice.org/63221 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-09Fix many Java subsequentcheck test by using JUHJan-Marek Glogowski1-6/+2
Splits gb_JunitTest_set_unoapi_test_class_and_jars into two separate defines as: - gb_JunitTest_use_unoapi_jars - gb_JunitTest_use_unoapi_test_class Then replaces many of the gb_JunitTest_use_jars lists with the new gb_JunitTest_use_unoapi_jars to fix the JUH dependencies. This probably adds some unneeded JUH dependencies to some Java tests, but that shouldn't be a problem. Change-Id: I0c4fce6b50f7c6eb8d62bfb2c50f056b97584794 Reviewed-on: https://gerrit.libreoffice.org/63119 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-09Simplify and fix Java UNO API test makefilesJan-Marek Glogowski1-18/+1
Originally I just wanted to add the juh.jar to the list of jars of the UNO API tests, but this became tedious work, so after the first few files I decided to replace the similiar makefiles with a common define for the *_unoapi* tests. This patch adds two new make defines to be used used by Java UNO and UNO API tests: - gb_JunitTest_set_unoapi_test_defaults - gb_JunitTest_set_unoapi_test_class_and_jars The first one will deduce most defaults from the test name, but still allows to optionally override most settings. If a test doesn't match the default at all, the 2nd define still shares the common jar files and the main Java UNO class, so the second define adds these to your makefile. The real fix is to add juh.jar to gb_JunitTest_use_jars. Change-Id: I4342fdac5e31f85ea18fb4268e13c287a7adc2b7 Reviewed-on: https://gerrit.libreoffice.org/63118 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-08Fix typosAndrea Gelmini1-1/+1
Change-Id: Ifd1affb7c3945de84a210dfbda894b60014f6cd6 Reviewed-on: https://gerrit.libreoffice.org/63020 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-08Convert FieldUnit to scoped enumMike Kaganski1-4/+4
Change-Id: Id2df31daa596a18c79af5fc6ea162deb6e24d5af Reviewed-on: https://gerrit.libreoffice.org/62958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-08loplugin:unusedfieldsNoel Grandin2-3/+0
Change-Id: Id16846c19c57ec437a64146d0fa771c1bfc05135 Reviewed-on: https://gerrit.libreoffice.org/63028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-08loplugin:constantparamNoel Grandin1-3/+3
Change-Id: I593ccc2fb43321caf3ff64d0c348b1bac742ad18 Reviewed-on: https://gerrit.libreoffice.org/63025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-07move SvTreeListBox to vclCaolán McNamara39-46/+46
Change-Id: I04a146d3d8a428ac1678827dc883525c40240a44 Reviewed-on: https://gerrit.libreoffice.org/62787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-06replace Application::GetMainThreadIdentifier to Application::IsMainThreadAndras Timar1-2/+2
Change-Id: I2b9ea77b48673af3575a3142feea5bed84f75d74 Reviewed-on: https://gerrit.libreoffice.org/62950 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-11-06loplugin:collapseif in dbaccess..lotuswordproNoel Grandin2-10/+4
Change-Id: Ia2a0d25c3833dfde0cd28337361f3cbd2aa29662 Reviewed-on: https://gerrit.libreoffice.org/62934 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-06convert some macros to local functionsNoel Grandin1-2/+2
Change-Id: If2c89f0f53615f6200b6cd1fb6267cc9b47df927 Reviewed-on: https://gerrit.libreoffice.org/62884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-04Replace preprocessor macro with short function definitionsMike Kaganski3-13/+21
a2058e7516a01167c2d20ed157500b38db967c64 follow-up. Change-Id: I402cbab4f78daf0de9d1bfa88698d2b071fcabaf Reviewed-on: https://gerrit.libreoffice.org/62840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04replace double-checked locking patterns with thread safe local staticsMike Kaganski1-11/+2
Change-Id: Ie1aae7ecbd065a88b371d8c0deb586f54f7eff65 Reviewed-on: https://gerrit.libreoffice.org/62835 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-20/+14
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-14/+4
Change-Id: I856345576ff5c10a41509a97ad4539272bd55568 Reviewed-on: https://gerrit.libreoffice.org/62803 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-02fix signatures of deleted copy/assign operatorsNoel Grandin1-2/+2
Change-Id: Id1a0749b78a7021be3564487fb974d7084705129 Reviewed-on: https://gerrit.libreoffice.org/62718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01gbuild: rename value OS=IOS to OS=iOSMichael Stahl1-1/+1
This gets rid of the horrible hack in gbuild.mk to accomodate the case-incorrect iOS platform makefiles that cannot be renamed without upsetting git on file systems that sadly lack the case sensitivity feature. Keep the macro defined to IOS though. Change-Id: I1022bfef4900da00e75fc1ccce786b20f8673234 Reviewed-on: https://gerrit.libreoffice.org/62705 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>