summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2013-07-12ORDER BY columns are prioritarily *SELECT* columnsLionel Elie Mamane3-34/+60
as opposed to *table* columns, and notwithstanding HSQLDB 1.8 (our embedded database) bugs. Actually, supporting ORDER BY on non-select (but table) columns is OPTIONAL for DBMSs (but quite common) Conflicts: connectivity/source/parse/sqliterator.cxx Change-Id: I6725dfda36b09429a78262bff6f3d3e3dd9032b6 Reviewed-on: https://gerrit.libreoffice.org/4836 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-11delete in destructor checkbox created in constructorLionel Elie Mamane1-0/+1
Change-Id: Ifceae4c7ffe15bfc62ce34f4463fd4e071403359 fixes: debug build aborts when closing that window Reviewed-on: https://gerrit.libreoffice.org/4835 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2013-07-10don't use empty table nameLionel Elie Mamane1-2/+5
Change-Id: I9c8c3882f659747d53a047481ccabf1785835c99 Reviewed-on: https://gerrit.libreoffice.org/4792 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-07-04database suggestname: no '/' for queriesLionel Elie Mamane1-0/+4
In particular, this keeps the new query wizard from silently failing by default when the underlying table name has a slash: it would generate a name proposal based on the table name, and then use suggestName to get a similar, yet guaranteed allowed name. In this case, the "guaranteed allowed" part was failing, since suggestName failed to strip slashes, which are forbidden in query names. Change-Id: I53d3976979ee45f5659765ed5dd3371b78837b5b Reviewed-on: https://gerrit.libreoffice.org/4709 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-03i#112615 table names are allowed slashesLionel Elie Mamane1-1/+15
Change-Id: I1b69c4575d79ba1b6a6e9cd83abaf18bad54fd79 Reviewed-on: https://gerrit.libreoffice.org/4677 Reviewed-by: Petr Mladek <pmladek@suse.cz> Tested-by: Petr Mladek <pmladek@suse.cz>
2013-07-02fdo#66464 initialise static join info at construct timeLionel Elie Mamane1-5/+11
to ensure that isReadOnly returns something sensible as soon as construct() finishes Change-Id: I5f9bef049297c5232df0ecdb9084add968a0052f Reviewed-on: https://gerrit.libreoffice.org/4669 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2013-06-14fix limit bug: selecting "All" has no effect to sqlZolnai Tamás2-3/+3
LimitBox set its value to -1 if the current text is "All" but just when it loses its focus so dispatching its value to the controller must be after this setting. (see limitboxcontroller.cxx) Plus some clean up in LimitBox.cxx Change-Id: Ic1d314a5a67c2b261b2e9c50973f51de2bfb8db8 (cherry picked from commit 00eafaa9493e99dfc81ec102b1ae936b84e44d0d)
2013-06-05fdo#64447 when changing setup mode, trigger changed DatasourceType eventLionel Elie Mamane1-0/+1
Change-Id: I961118331f534de103b83766a2c21a6bec479241 Reviewed-on: https://gerrit.libreoffice.org/4161 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-05-30fdo#64984 - EDITING: Creating table with GUI - table could not be savedNoel Grandin1-3/+8
This bug was introduced by my commit 002aab309055b7feeeeeb25c1835b6abe6646729 "fdo#46808, convert sdb::tools::ConnectionTools to new style" (cherry picked from commit 73a809cba87eefbb495c5ba53f89b48d671f8230) Change-Id: Ib10f97bbe46d20db663047d2f35ec4850df839fa
2013-05-25translatable="yes" for some elements in .ui filesAndras Timar2-3/+3
Conflicts: starmath/uiconfig/smath/ui/alignmentdialog.ui starmath/uiconfig/smath/ui/spacingdialog.ui Change-Id: I915cd6e73f907850f17b102c7860a827b91eef37
2013-05-25Revert "fdo#46808, Convert awt::UnoControlDialogModel to new style"Stephan Bergmann1-2/+1
This reverts commit 6c61b20a8d4a6dcac28801cde82a211fb7e30654. As discussed at <http://lists.freedesktop.org/archives/libreoffice/2013-May/052449.html> "Re: fdo#46808, Convert awt::UnoControlDialogModel to new style problem" why the odd change in 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again" appears to fix things again: The problem is that the implementation of the css.awt.UnoControlDialogModel involves UNO aggregation (IMPL_CREATE_INSTANCE_WITH_GEOMETRY(UnoControlDialogModel) in toolkit/soruce/helper/registerservices.cxx creating a OGeometryControlModel<UnoControlDialogModel> instance that aggregates a UnoControlDialogModel instance). That means that queryInterface can return a reference to something that is technically a different object, and that's what's happening here, and explains why calling setPropertyValue in two different ways on what logically appears to be a single object can end up calling two different implementations (of two different physical objects). (UNO aggregation is known to be broken and should not be used. Nevertheless, there's still code that does---code that is a horrible mess and hard to clean up.) That all this worked as intended in the past is just sheer luck, but any way of substantially touching it is asking for trouble. I'm going to revert 6c61b20a8d4a6dcac28801cde82a211fb7e30654 again. I wasn't able to revert without also reverting be50ad28f5bbdaeff527f646481ce263843c2401 "fdo#46808, Convert awt::XUnoControlDialog to new style," as the two were tightly dependant. Also reverts all the follow-up fixes cb4b6dde8fda2a5848e11063028bf44d72f85431 "-Werror,-Wuninitialized" (sans the const-ness fix in UpdateHandler::insertControlModel), 697a007c61b9cabceb9767fad87cd5822b300452 "Fix exception specifications," 2ce6828bbbf6ba181bb2276adeec279e74151ef6 "fix awt::UnoControlModelDialog crash," and 2e2a4827ce6708f0e8677dba9cc92e1479a44086 "scripting: get CreateUnoDialog() work again." Conflicts: basctl/source/dlged/dlged.cxx filter/source/t602/t602filter.cxx xmlscript/test/imexp.cxx Change-Id: I5d133468062f3ca36300db52fbd699be1ac72998 (cherry picked from commit e36f83d81c462e1a5959b160886e481a8d449494)
2013-05-21allow to create new database using the wizard again (fdo#62937)Petr Mladek1-7/+3
To be honest, I do not userstand the code much. Julien pointed out that the setParentTitle and onTypeSelected were newer called. The condition looked like an optimisation and it helped to remove it. It would be great to put it back. It might be enough to hand the intial values. Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da
2013-05-21fdo#46808, Convert awt::UnoControlDialogModel to new styleNoel Grandin1-1/+2
Change-Id: I4b912034ef3f4855b87d6d6f18ff13bd1ecc8f72
2013-05-19make OSingleSelectQueryComposer use *system* parse contextLionel Elie Mamane3-3/+6
and pass it to the parser and PredicateInput constructors. This makes the whole story consistent; before system locale settings were already manually passed to parseNodeToPredicateStr, which led to some things being parsed as en_US and others as system locale. Change-Id: Ib9571b10d79183571e8ab3f79660b41594dc2d1c
2013-05-15Spelling "separate" (etc) correctly is hardTor Lillqvist1-1/+1
2013-05-14SolarMutex does not belong into the URE interfaceStephan Bergmann2-12/+11
...so move it from osl/mutex.hxx to its own comphelper/solarmutex.hxx. It looks like a newbie mistake that 59e7685d8d812ee8773f57475cbe3aa2a0bdfc81 "Create an abstract interface to be used to implement a SolarMutex" put it here in the first place. I do not consider this an incompatible change really, as no external URE client code should have used SolarMutex anyway. (Also included some clean up, like removing unused {Clearable,Resettable}SolarGuard, and spelling out SolarGuard in the few places it is used.) Change-Id: I121ffb5b7cefbc19e88b5405e5a85ffc895be852
2013-05-14fdo#46808, fix call to sdb::tools::ConnectionToolsNoel Grandin1-6/+1
In my previous conversion to new style I forgot to pass arguments into the service constructor. Change-Id: Ibbf750315b3e62869b1eb4c520808327002f2dcc
2013-05-14Initialise the default-constructed ConnectionToolsLionel Elie Mamane1-0/+3
Regression from the "convert to new style", which led to ignoring aArguments Change-Id: I09477578f77b253b8c6435d52e1e636d2e212023
2013-05-13Fix namingStephan Bergmann2-9/+9
Change-Id: Id167385e832b1cd78d0612fc2a7611aa76bf0601
2013-05-12Fix possible inefficient checking for variables emptinessJulien Nabet1-1/+1
Change-Id: I95a6784d5448b63b0cdde436484915692f8633be
2013-05-10Potty mouthChris Sherlock1-2/+2
Change-Id: I276fa2fa24b5553a748e6e628129d54419e69c9a Reviewed-on: https://gerrit.libreoffice.org/3843 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-05-07connectivity: remove Package_generatedMichael Stahl2-4/+2
This one is ugly, the Yacc generated header is used in lots of places; the dependencies are already right because using the header requires using the dbtools library which builds the YaccTarget, so just yet another include path has to be added. Change-Id: I031fde80ac326551d4719533305b1ae35351ca43
2013-05-07officecfg: remove Package_cppheaderMichael Stahl1-0/+4
Instead include generated headers directly from workdir. Change-Id: I9d2bcc07175d2bbc16d3cc548c2245e7a4fb0c65
2013-05-07dbaccess: remove Package_incMichael Stahl45-1412/+33
Change-Id: I8e6748eef04f25603851a33d049cb9585fa04cc6
2013-05-06fix typos (wich instead of which)Philipp Riemer1-1/+1
2013-05-06remove usage of RTL_CONSTASCII_USTRINGPARAMLuboš Luňák2-3/+3
Mechanical removal of usage together with OUString ctor, done by compiler plugin. Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06Java cleanup, remove unnecessary @SuppressWarnings annotationsNoel Grandin4-4/+0
Change-Id: Ib5df091fc4a6233b526c44ae42dbdbacb0bef7c6
2013-05-01convert message box return types to an enumCaolán McNamara2-13/+13
Change-Id: I20889dc94aac1119c1ee9da873ce911887c1c335
2013-04-29fdo#63391 deadlock on opening .odb file that auto-connects to the databaseLionel Elie Mamane4-22/+63
Let foo.odb be a database file that has a macro that connects to the Database on "Open Document" event (and needs to prompt user for user/password). There was a race condition between two actions: 1) the asynchronous treatment of "OnFirstControllerConnected" in dbaui::OApplicationController, which tries to get dbaui::OApplicationController's mutex 2) the StarBasic macro calling dbaui::OApplicationController::connect which needs to display a dialog (to get username and password), and thus puts that dialog in the main thread's event queue and waits for it ... with dbaui::OApplicationController's mutex held Now, if "1)" is before "2)" in the event queue of the the main thread, *but* "1)" is executed *after* "2)" has taken the lock, there is a deadlock. Fix: 1) Make OnFirstControllerConnected synchronous. Make sure (by taking mutex in dbaui::OApplicationController::attachFrame, its ancestor in the call graph) that nothing else will happen with the OApplicationController as long as it is not finished. ---> it does not need to take mutex itself anymore This avoids the "order in the asynchronous events" dependency. 2) Change dbaui::OApplicationController::ensureConnection to do the user prompting WITHOUT HOLDING the mutex, and use the mutex "only" to protect actually assigning the connection to m_xDataSourceConnection. Theoretically, in some race condition, we could connect twice and then discard one connection <shrug>. ensureConnection will never return the discarded connection, though. (I think I got that right with respect to http://www.cs.umd.edu/~pugh/java/memoryModel/DoubleCheckedLocking.html) This keeps it from locking on another condition while holding the mutex. Change-Id: Iab1bbec5d5df12bb89d027d43e498c78c92ffc32 Reviewed-on: https://gerrit.libreoffice.org/3310 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-26remove never-generated "predicate_check" entryLionel Elie Mamane1-1/+0
Change-Id: Ib3957fbadf6bfebfaabd5bef09aaf7ab21862cd6
2013-04-26QueryDesign: in criteria, remove column_ref when table *and* column name matchLionel Elie Mamane1-0/+2
As opposed to only the column name Change-Id: I261d13f23214f950daa55a5b63cd486e59a0e127
2013-04-26String -> OUStringLionel Elie Mamane2-3/+3
Change-Id: Ibf566a11a383b77a930d46967e496752c88b39e4
2013-04-26Java cleanup, remove unused importsNoel Grandin1-1/+0
Change-Id: I697017f196a7f7e5684011ae23941e54051c45dd
2013-04-25Fix compilation error when OSL_DEBUG_LEVEL > 0Tor Lillqvist1-9/+6
Just use SAL_WARN, building up the message using chained << operators instead of constructing it into a OStringBuffer (or OUStringBuffer) and then passing that to OSL_FAIL. Or should we have a real assert() here? Change-Id: I2c3f64ff2b29a3d81ba444d98c2a38ef49e6d7af
2013-04-25update pchThomas Arnhold1-0/+1
Change-Id: I67e73438312f2a672e71762ee6707ec5d425bb47
2013-04-25dbaccess: {DECLARE,IMPLEMENT}_CONSTASCII_USTRING are no longer neededMiklos Vajna40-732/+327
Change-Id: Id404f8f3a5bdbf32c207ee81c6f6be9c9d328679
2013-04-25add missing deps on sqlbison.hxxDavid Tardon1-1/+2
Change-Id: I098a4514b9b32b1ecf96b1f2275f77bac540d557
2013-04-25fdo#46808, Convert form::ControlFontDialog to new styleNoel Grandin1-17/+3
Change-Id: I83487cddbd6b3fce1fdcdfa48623b63a0e026d90
2013-04-24gbuild: drop empty use_packages callsDavid Tardon3-9/+0
Change-Id: I8e9f70eb5d929c98b4379416c2259a74e31d587f Reviewed-on: https://gerrit.libreoffice.org/3503 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24gbuild: drop uses of removed packagesDavid Tardon5-8/+0
Change-Id: I400fad08c0ae7b6b34bad63693f54856867e4dac Reviewed-on: https://gerrit.libreoffice.org/3502 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-23Access Query Properties Dialog from toolbar tooZolnai Tamás1-0/+1
Change-Id: Ide4697e6903c9550d31ea22ff0a5881878fddacf
2013-04-23fdo#46808, convert svx::DbGridControl to XComponentContextNoel Grandin3-18/+16
2013-04-22Move to MPLv2 license headers, with ESC decision and author's permission.Michael Meeks15-335/+60
2013-04-20fdo#63154: Change Min/Max/Abs for std::min/max/absMarcos Paulo de Souza1-1/+1
Now all these usages were removed from LO. Change-Id: I8a7233db20abdcdbb18428ad4004c78cc516a0e6 Reviewed-on: https://gerrit.libreoffice.org/3326 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2013-04-19Remove any remaining remnants of unused component_canUnload featureStephan Bergmann1-1/+1
Change-Id: I635fd006b5ba9f5fb0091748ee2ff9bc3c1a2d2a
2013-04-19Java cleanup, remove unnecessary castsNoel Grandin2-4/+4
Change-Id: Id12089bc7df16631737e6acaee0973fb91dd953f Reviewed-on: https://gerrit.libreoffice.org/3431 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-04-17Update pchAurimas Fišeras1-1/+1
Change-Id: Ice80350184f7a514d5beab0a5e1da5b98d5733e4 Reviewed-on: https://gerrit.libreoffice.org/3427 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-04-16merge duplicated CreateFontDescriptor methodsCaolán McNamara4-86/+4
Change-Id: I33f9df7f17158eedc4a4c0dedfd0fc4cddc6180f
2013-04-15FontWeigth->FontWeightCaolán McNamara1-1/+1
Change-Id: I6250c3e3de81c33e8f4d73e2f80570521fdb6ea6
2013-04-15fdo#60724 successfull -> successfulThomas Arnhold4-5/+5
Change-Id: I287bef5b7f2baf5aaaab47141267ae2cadfe2451
generated by cgit v1.2.3 (git 2.39.1) at 2024-04-27 10:39:34 +0000