summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2019-08-28warn on load when a document binds an event to a macroCaolán McNamara3-8/+26
a) treat shared/Scripts equivalently to document scripts This doesn't automatically warn/block running those scripts when used in a freshly loaded document on its own however because DocumentMacroMode::checkMacrosOnLoading will see at... if ( m_xData->m_rDocumentAccess.documentStorageHasMacros() || hasMacroLibrary() ) that the document contains no macros and flip the allow macros flag to true so that potentially new uses of macros added by the user during the edit are allowed to run b) so, add an additional flag to indicate existence of use of macros in a document c) for odf import, set it when a script:event-listener tag is encountered d) for html import when registerScriptEvents or SwFormatINetFormat::SetMacroTable is called e) for doc import when Read_F_Macro or StoreMacroCmds is called as well for good measure f) for xls import when registerScriptEvent or ScMacroInfo::SetMacro is called g) for oox import when VbaProject::attachMacros is called Change-Id: Ic1203d8ec7dfc217aa217135033ae9db2888e19b Reviewed-on: https://gerrit.libreoffice.org/77387 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2019-07-22tdf#123020 dbahsql: Support string delimiterTamas Bunth1-2/+18
Support multi-word table names while migrating HSQLDB data. Change-Id: I5129f995ea90a3fdbcbcb844774cf074f3ffddb2 Reviewed-on: https://gerrit.libreoffice.org/75734 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit b5890bf269214a47833bc9514b80650455e77ef6) Reviewed-on: https://gerrit.libreoffice.org/75820 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 47d6c43c19aa6ea05f0f65db58e5cdcf1c603660) Reviewed-on: https://gerrit.libreoffice.org/75853 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-17tdf#126268: Check for the sign value at the right placeXisco Fauli1-2/+2
This commit contains 25277bcb727994072239c9c2549c271fdd62150e and 2e26ef34bf1a2e5d1293e45cf3b1415d9514b056 for backporting Code introduced in 6039d2463b4cc503b963811b3b1471de3291ee09 Unittest removed in libreoffice-6-2 branch See 7991a4d718c282f1fd999e76f683e333b5c220af Change-Id: Id0e249e47a91b274a247fb7e8b71353114149650 Reviewed-on: https://gerrit.libreoffice.org/75375 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/75420 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/75761 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-06-25Resolves: tdf#125168 label mnemonic appearing in database urlCaolán McNamara1-1/+1
Change-Id: I39531ae2a656c16c7355d73b76cb918d3535f7b0 Reviewed-on: https://gerrit.libreoffice.org/74604 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-06-13tdf#125381: Manage URLs beginning with an "~" in cutPrefix (dbaccess/dsntypes)Julien Nabet1-3/+6
On Windows or with other renderings than gtk3, the urls may begin with an ~ In this case, cutPrefix returns only empty string When trying to access Index management for odb files related to dBase indexes don't display because cutPrefix returns empty url in dbaccess/source/ui/dlg/detailpages.cxx line 200 198 ::dbaccess::ODsnTypeCollection* pTypeCollection = pTypesItem ? pTypesItem->getCollection() : nullptr; 199 if (pTypeCollection && pUrlItem && pUrlItem->GetValue().getLength()) 200 m_sDsn = pTypeCollection->cutPrefix(pUrlItem->GetValue()); Change-Id: I47360e205ddea7b060a31da697bbe9857ad3f4c0 Reviewed-on: https://gerrit.libreoffice.org/72568 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit d34ed0008f12cfe47dd239672f1941f3c54d97fd) Reviewed-on: https://gerrit.libreoffice.org/73709 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> (cherry picked from commit 27bd20cf5333a5df29286794b7384520fbc55012) Reviewed-on: https://gerrit.libreoffice.org/73876
2019-06-12has_default needs can_defaultCaolán McNamara1-0/+1
Change-Id: Id841d214b8d88a986c07d2827b281e5805c3c941 Reviewed-on: https://gerrit.libreoffice.org/73812 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-05-31dbaccess: fix more memory leaks caused by circular ReferenceMichael Stahl3-13/+18
Followup to 96ae2a3300811897c24cccb20f8c2faf382483df; more overridden acquire() creating cycles in dbaccess. (regression from 2660d24a07866e083c5135ea263030f3e3a2e729) Reviewed-on: https://gerrit.libreoffice.org/73158 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 7d582d1f9767c0ebd5e319f2fd11711e60cd72fa) Change-Id: I134343b3afbcd5ee3f71212ec18e551455eaee5b Reviewed-on: https://gerrit.libreoffice.org/73253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-29tdf#114596 dbaccess: fix mysterious dataloss bug (part 2)Xisco Fauli2-4/+5
Same problem as in 96ae2a3300811897c24cccb20f8c2faf382483df Regression from 497e40ad03c27837978551ba15491c3fb2a0bf53 Change-Id: I00e7bf3559e688e7fbc5429ace2b5c18221c9890 Reviewed-on: https://gerrit.libreoffice.org/73146 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins (cherry picked from commit 58f121ef2e680697e10453add43bab9b771d153a) Reviewed-on: https://gerrit.libreoffice.org/73153
2019-05-18tdf#125267: relax the requirement of fixed value of current filterKatarina Behrens1-1/+4
In a filepicker, user can select any file filter ('All files' for example) and still choose to open .odb file. Specific UIName of the current filter ('ODF Database' in this case) shouldn't therefore be a hard requirement, the correct file extension is enough. Change-Id: I641a267c545c66aa4d34954922783cc5ff7efd24 Reviewed-on: https://gerrit.libreoffice.org/72377 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit dc17f247daeb281dda531ff335873d563db5b653) Reviewed-on: https://gerrit.libreoffice.org/72453 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-03-12Resolves: tdf#123975 support tri-state for PrimaryKey uiCaolán McNamara2-3/+34
typically indeterminate is an initial state which is not returnable to, this is not the case for PrimaryKey Change-Id: I82f318e18ad9beabd9ca6e3003a736fee9a5e931 Reviewed-on: https://gerrit.libreoffice.org/69060 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-07Make Firebird the (unconditional) default for new databasesStephan Bergmann2-13/+2
60db3d2cc3bc4f124bd4d819fbd0285e7f19c8c4 "dbu: Set Firebird to default in wizard.." had done so only "..in case experimental feature is checked in", but Firebird has been made non-experimental meanwhile as documented at <https:// wiki.documentfoundation.org/index.php?title=ReleaseNotes/6.2&oldid=169290#Base>. <https://bugs.documentfoundation.org/show_bug.cgi?id=123099> "Creating new 'HSQLDB Embedded' database immediately brings up migration-to-Firebird dialog" discusses that changing the default to Firebird may be beneficial, so lets do that unconditionally now. But 60db3d2cc3bc4f124bd4d819fbd0285e7f19c8c4 had apparently made a mistake, setting the value returned from OGeneralPageWizard::getDatasourceName to "sdbc:embedded:firebird" even though the corresponding "Connect to an exisiting database" list in the new database wizard doesn't even support that (instead of "sdbc:firebird:", which matches "Firebird File" in that list). Fixed that now. (Curiously, ODsnTypeCollection::getEmbeddedDatabase would read a DefaultEmbeddedDatabase value from the configuration before resorting to the hardcoded default, but `git log -SDefaultEmbeddedDatabase` makes it look like there has never been any code to actually write that setting.) Change-Id: I49b7430f5f8288a6a166ed9184cb438208d56ca1 Reviewed-on: https://gerrit.libreoffice.org/67449 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 98c0b20864af965c3bb99a32f8ea57be7402e534) Reviewed-on: https://gerrit.libreoffice.org/67460 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-02-05tdf#119502: dbahsql: tables without primary keyTamas Bunth2-13/+26
No "PRIMARY KEY" keyword is needed, when composing a parsed sql which did not contain any primary key definition. Change-Id: Ife8b898806edba41a52d47dc04b1170606ea8aae Reviewed-on: https://gerrit.libreoffice.org/67379 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit aa974a1b3798e04424623ad331e9f5a0ae01a34b) Reviewed-on: https://gerrit.libreoffice.org/67419 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-02-05Fix conversion of non-BMP charsStephan Bergmann1-22/+43
...which are apparently encoded as two consecutive \uXXXX\uXXXX escape sequences representing a UTF-16 surrogate pair Change-Id: Ic47a678dee5e28ab4dc43e115ae5c4efefb1db96 Reviewed-on: https://gerrit.libreoffice.org/67245 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 6a736800ac87a6b23a90827aa7b431920a6b9a36) Reviewed-on: https://gerrit.libreoffice.org/67391 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-05tdf#121069, tdf#121469 migrate special charactersTamas Bunth4-38/+45
dbahsql: Decode UTF8 characters stored as unicode code point values in schema file. Change-Id: I90db2345a6de9bee7aae8ae6a7c046a03eebc0a7 Reviewed-on: https://gerrit.libreoffice.org/67197 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit 2ec13411b7e7b18d1ea28faee9ad93e0b7b21dde) Reviewed-on: https://gerrit.libreoffice.org/67351 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-29dbaccess: fix Tdf119625Test with read-only $SRCDIRMichael Stahl2-3/+6
The buildLowLevelConnection() will try to modify the read-only storage and throw IOException. Change-Id: I9b8ec840bebcac3c8a69bc6921d32e692d9d9e86 Reviewed-on: https://gerrit.libreoffice.org/67027 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit f4be87e0583775fa5074aefa4bef4124b0c2d894) Reviewed-on: https://gerrit.libreoffice.org/67061 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-29dbaccess: don't try to migrate read-only fileMichael Stahl1-4/+9
It's going to throw IOException anyway. This fixes CppunitTest_dbaccess_hsqldb_test on read-only file system. Change-Id: Ifc8a4791ab9a1a8d3e0f1e67d65e10dac458147c Reviewed-on: https://gerrit.libreoffice.org/67028 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> (cherry picked from commit 577a9708ea9594d60b66c1c71d24175c66d24096) Reviewed-on: https://gerrit.libreoffice.org/67062 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-01-23tdf#122885: fix crash when converting odb file to FirebirdJulien Nabet1-1/+1
4 0x00007fffdfddf846 in (anonymous namespace)::lcl_makeStringFromBigint(std::__debug::vector<unsigned char, std::allocator<unsigned char> > const&) (bytes=std::__debug::vector of length 3, capacity 3 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:104 5 0x00007fffdfde04e2 in dbahsql::HsqlRowInputStream::readOneRow(std::__debug::vector<dbahsql::ColumnDefinition, std::allocator<dbahsql::ColumnDefinition> > const&) (this=0x7fffffff0350, nColTypes=std::__debug::vector of length 9, capacity 9 = {...}) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/rowinputbinary.cxx:312 6 0x00007fffdfdf39f0 in dbahsql::HsqlBinaryNode::readRow(dbahsql::HsqlRowInputStream&, std::__debug::vector<dbahsql::ColumnDefinition, std::allocator<dbahsql::ColumnDefinition> > const&, int) (this=0x7ffffffefc74, input=..., aColTypes=std::__debug::vector of length 9, capacity 9 = {...}, nIndexCount=2) at /home/julien/lo/libreoffice/dbaccess/source/filter/hsqldb/hsqlbinarynode.cxx:56 See complete bt here: https://bugs.documentfoundation.org/attachment.cgi?id=148530 Change-Id: I0b0373a81d9299fd7bf3107d2262f5836e52e459 Reviewed-on: https://gerrit.libreoffice.org/66752 (cherry picked from commit 301ff4dfb82dfd961b993aec151784bd478b4f97) Reviewed-on: https://gerrit.libreoffice.org/66754 Tested-by: Jenkins Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-10Resolves: tdf#122467 drop down field name is too narrowCaolán McNamara1-9/+11
ellipise only when we have to Change-Id: I79820dc84fc9ac0a755700c70bca9edbb14cf371 Reviewed-on: https://gerrit.libreoffice.org/66001 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-01-02Resolves: tdf#122285 task panel too shortCaolán McNamara2-3/+19
there are a bunch of resizes as base starts up, and base will position the splitwin on the first time its big enough to place it and gets stuck too high up, before it goes full size. We don't want this jumping around on every subsequent user size, but we do want it to get placed at the final size during the load. So post the resize event to occur on idle, and when it finally gets a chance to run we'll be at our final size and the placement is good Change-Id: Iccb169bac93a5cf8bc931945bc7e1b71c6c9dd23 Reviewed-on: https://gerrit.libreoffice.org/65587 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-12-21Resolves: tdf#121838 catch exception for missing columnCaolán McNamara1-1/+11
in database migration Change-Id: Ied42d1436f14012fb918e8e6775fcbe0f7d5fac5 Reviewed-on: https://gerrit.libreoffice.org/65546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-21tdf#122020 crash in SvTreeList::InvalidateEntryCaolán McNamara2-10/+17
a PostUserEvent of DBTreeListBox::OnResetEntry with a SvTreeListEntry* pEntry as payload, then the DBTreeListBox is disposed and then the UserEvent arrives and the, by now deleted, pEntry is processed by the disposed DBTreeListBox Change-Id: I951639eb633920aa3536cd44320f36f6b2e910aa Reviewed-on: https://gerrit.libreoffice.org/65513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-18[API CHANGE] tdf#122152 set dialog parentCaolán McNamara1-1/+7
Change-Id: I15f6d577c3584d28f667a04b5571de80effe53fe Reviewed-on: https://gerrit.libreoffice.org/65274 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 0a9917b756cf49b117766c9236a7bf63d6d4b607) Reviewed-on: https://gerrit.libreoffice.org/65328
2018-12-18give dbaccess save query dialog a parentCaolán McNamara1-1/+1
Change-Id: I8e2c484f5237ad4fc3ec225f986336e6cbb0ba26 Reviewed-on: https://gerrit.libreoffice.org/65277 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-06tdf#121935 crash on "set up connect to text files"Caolán McNamara4-18/+33
Change-Id: I73bc93ebb5010f3a376b3b121e1ac873f1be137a Reviewed-on: https://gerrit.libreoffice.org/64677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02Resolves: tdf#121810 wrong column orderCaolán McNamara2-2/+8
Change-Id: Ie82c47ea772b6eb5fc7b84426bb3c1cc98dc9c14 Reviewed-on: https://gerrit.libreoffice.org/64411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-12-02Related: tdf#121810 pass suitable message dialog parent aroundCaolán McNamara3-4/+12
Change-Id: I1a27d82ef94f1052171f7a3f6c5c80c0ec66b547 Reviewed-on: https://gerrit.libreoffice.org/64410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-30Disable firebird migration assistant in 6.2Xisco Fauli2-6/+4
As decided in the ESC meeting on 11/29/2018 Remove the related tests as it was done for 6.1 See: https://gerrit.libreoffice.org/#/c/57508/7 Change-Id: Iadd45ede8d5f30de8701ad04e411c9de23ebba10 Reviewed-on: https://gerrit.libreoffice.org/64262 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-27suspicious has-default on help buttonsCaolán McNamara1-1/+0
Change-Id: I604e3bf6362271e767a4862a2c9d789a2c89df88 Reviewed-on: https://gerrit.libreoffice.org/64075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwCondCollPageCaolán McNamara5-10/+10
and put back original SvTreeListBox a11y factory use Change-Id: I4ad8ce29d8fed6ec5d44e9a1d641919a89226b79 Reviewed-on: https://gerrit.libreoffice.org/63501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 47897fdd936d9b6e9ac8cb6110c79352ab080df7) Reviewed-on: https://gerrit.libreoffice.org/63770
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[B-E]*Gabor Kelemen7-0/+7
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Iabe571aa8f00492902c499094bea8365a3e17fca Reviewed-on: https://gerrit.libreoffice.org/63623 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 40710c488de3e4eef585c5a5276c9a0943d36f2e) Reviewed-on: https://gerrit.libreoffice.org/63769 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#42949 Fix IWYU warnings in include/vcl/[ab]*Gabor Kelemen5-0/+6
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If18c80fc64e55d797953e24e40e5d5e62bd9c625 Reviewed-on: https://gerrit.libreoffice.org/63453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 492ea7e08571e466e37f870b7642a79df55c2e92) Reviewed-on: https://gerrit.libreoffice.org/63768 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-19weld TreeViewCaolán McNamara5-4/+7
a) use GtkTreeStores for GtkTreeViews b) ironically can't store GtkTreeStore contents in .ui apparently c) set show_expanders for all non-trees and unconverted cases d) on-demand subtrees Change-Id: I3c1036a222daba2c129b1a22ffeb3fe35005ae31 Reviewed-on: https://gerrit.libreoffice.org/63558 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-17Adapt to C++2a char_tStephan Bergmann2-2/+2
u8 literals incompatibly change their type (as implemented by recent Clang trunk) Change-Id: Ia4f7b91f5d86656a056303d2754981ab2093a739 Reviewed-on: https://gerrit.libreoffice.org/63494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-16Fix typosAndrea Gelmini1-1/+1
Change-Id: I25660634dcb9ebb31292275e31ed7a047e4ddd25 Reviewed-on: https://gerrit.libreoffice.org/63474 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-16loplugin:buriedassign in dbaccess..ooxNoel Grandin4-8/+14
Change-Id: Ic0ca695a1d9d05418213475a68e233953136cc8e Reviewed-on: https://gerrit.libreoffice.org/63468 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-16loplugin:staticmethods improvementNoel Grandin1-1/+1
Change-Id: I8889ce8a7d2309b54454cfe4c6421282e1c6e755 Reviewed-on: https://gerrit.libreoffice.org/63434 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-12loplugin:singlevalfields in accessibility..extensionsNoel Grandin4-9/+5
Change-Id: Id3a3241af83f769fc60f67e01c9129d6f4b5c2af Reviewed-on: https://gerrit.libreoffice.org/63274 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski1-1/+1
Change-Id: I08ea67c1b51ee04258ce7769bfe9d97a1cb46b22 Reviewed-on: https://gerrit.libreoffice.org/63268 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski1-1/+1
Change-Id: I1027242192dfd2be4918094d59f2a8f8c8fec041 Reviewed-on: https://gerrit.libreoffice.org/63266 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-11cppCheck redundantAssignment pParseNodeZdibák Zoltán1-2/+1
Change-Id: I0e5e2d607bddd1f73fc8c256169a2fbe070f6448 Reviewed-on: https://gerrit.libreoffice.org/63256 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-10clang-tidy: (WIP) bugprone-too-small-loop-variable findings 2Tamás Zolnai1-2/+2
Change-Id: I1ddf3fe0e5fad265ae14712a23469b684253079d Reviewed-on: https://gerrit.libreoffice.org/63241 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-10Avoid getTokenCountMatteo Casalin1-5/+8
Change-Id: If4dcd0a3f316bd9812ffb12b8e64489d25ce89ca
2018-11-10Use indexed getTokenMatteo Casalin1-4/+5
Change-Id: I336924c43b6680c3742ca8c83801cbff3f346968
2018-11-10Avoid getToken to just get last tokenMatteo Casalin1-2/+2
Change-Id: I74669145a1341ff2a715cdec32676dfdd290d1f3
2018-11-10Loop only if string length is the desired oneMatteo Casalin1-9/+11
Change-Id: I5e03fceb83a22b590a62b605c4ada279b937730a
2018-11-10Avoid getTokenCount()Matteo Casalin1-8/+4
Change-Id: Ifc509b3c31f6dbfd4d620aa451fd85b82b0ddb90
2018-11-10Early bailoutMatteo Casalin1-8/+5
Change-Id: I0ffcbbfe2380755ff21532b314961c317ce0c69d
2018-11-10Avoid getTokenCount()Matteo Casalin1-8/+22
Change-Id: Ia71e4822ce863a296c7c0eb137c164538f9a0d27
2018-11-10Use indexOf instead of getTokenCount for simple checkMatteo Casalin1-1/+1
Change-Id: I0a0068649fd688f311e1ba4865a51406c4ffd672
2018-11-10Fix double ;Matteo Casalin1-1/+1
Change-Id: I8009565c5ae2580d0cdbf3b323b95d61c25c0dcd
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-22 14:26:36 +0000