summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2016-06-06tdf#96516 fixup: when removing entry, entry count does not stay constantLionel Elie Mamane1-2/+1
Change-Id: I192a2d14787581545e66c46a84507f6dfd191c57 Reviewed-on: https://gerrit.libreoffice.org/25891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-31tdf#96516 do not increment position counter when an entry is removedLionel Elie Mamane1-1/+3
Change-Id: I81a4455df1fd5962d0362f4e5fa3396764a0ae5a Reviewed-on: https://gerrit.libreoffice.org/25548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-05-30Resolves: tdf#97854 crash on deleting inner join relationshipCaolán McNamara6-63/+64
seems to be a regression from... commit 356bc0f697299e5fb6156ce25dc69845eaa6f9e6 Author: Michael Meeks <michael.meeks@collabora.com> Date: Wed Jul 1 19:03:55 2015 +0100 tdf#92434 - fix iteration, and remember to disposeAndClear. which is part of the VclPtr stuff so hold the connection by VclPtr when removing it from m_vTableConnection and only call dispose on it when _bDelete is true, not always. Change-Id: I38e65c6928499dc1e8bbf6b71e9901a4eaa5d913 (cherry picked from commit e55f83e1731e1031c63d8463b57c434cceb126e3) plus (easier to read as individual commits) Related: tdf#97854 confirm that on !bDelete there's a ref to the connection so that its not deleted on removal from the vector Change-Id: I6c1f7691ee415abf0f419fdd7fcf2341fe2bd1f3 (cherry picked from commit 3185d9b8fbaad56fc7170a277569b5e441d946f4) Reviewed-on: https://gerrit.libreoffice.org/25508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-04-12tdf#99073 fix double-click tree node expansion in baseNoel Grandin1-1/+1
fallout from commit cf0c04a428754dfd5aa477cebc5441bc74e27005 "convert Link<> to typed" Change-Id: I3452b76320c5355aaf84a0bd67c99b281bb46d0f (cherry picked from commit e4f02b250402d48793fe1bb79d419c0e1a822cb5) Reviewed-on: https://gerrit.libreoffice.org/23838 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-24off-by-one error: columns are numbered from one, but the array from 0Lionel Elie Mamane1-1/+1
Change-Id: I14ef451999fa1f9d57757a9e231fc66be4e53f3a Reviewed-on: https://gerrit.libreoffice.org/23405 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-15vcl: move graph.[hx]xx to graphic.[hc]xxChris Sherlock4-4/+4
It's IMO a bit confusing to see a "graph" header that doesn't strictly deal with graphs, but graphics. Backporting to 5.1 series to allow for easier backporting of other potential hotfixes. Change-Id: Ic37c6cd78e23d05939486f98667144c4453bb0a3 Reviewed-on: https://gerrit.libreoffice.org/22949 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2016-03-15tdf#97978: add support for opening mde and accde files in basepasqualm1-2/+2
This patch modifies the base 'open existing database' wizard so accde and mde files can be chosen as targets for access and access 2007 databases. Both file types are the runtime-only equivalents to accdb and mdb files so base can use them in the same way as does with the former Change-Id: I5b6002089a2d3c19498ff6e05bae3facc5a4e2d0 Reviewed-on: https://gerrit.libreoffice.org/22957 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/23178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-02-18Fix missing iterator include on MSVC 14.0David Ostrovsky3-0/+3
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586 Reviewed-on: https://gerrit.libreoffice.org/22448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org> (cherry picked from commit a3c70e760fa4203b7e6692f82d1d8a14214af3da) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2016-01-12New saving behaviorMaxim Monastirsky6-72/+7
Changes in this commit: - AlwaysAllowSave config is gone. Saving is always permitted, unless in a read only document. Also changed the behavior in dbaccess to match sfx2. - The toolbar save button is always enabled, to always give access to the dropdown. That's the case even in a read only document, except that it changes to DROPDOWNONLY, and the save as command icon+tooltip. In table/query designers we still disable the button in read only state. - When the document is modified, the toolbar button gets a special icon to indicate that. Reviewed-on: https://gerrit.libreoffice.org/20839 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 22328a224df4619218b88205838307f70612207e) loplugin:unreffun (cherry picked from commit ea708936c4684668f9aefc3ce9ec2001dbd4bdf2) Change-Id: I56c169bf48b78faaf53c2989ce8624f8297ffb6e Tango: Update Save icons and support “savemodified” status Change-Id: I03589895437907b9048542f07128801577fe62dc (cherry picked from commit a7198d38f0294ab5db04a7f4457565ea8b2c32f1) Reviewed-on: https://gerrit.libreoffice.org/21260 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-12-15Fix Treelist shouldn't use VCLEVENT_LISTBOX_SELECTJulien Nabet1-1/+1
warn:legacy.osl:21997:1:accessibility/source/extended/accessiblelistbox.cxx:103: Debug: Treelist shouldn't use VCLEVENT_LISTBOX_SELECT To reproduce: - Launch Base and create a brand new HsqlDb file or open an existing one - Select Tables pane - Click Table Design => the message appears in console Change-Id: If7fa99890bbec8795a62b83dbe193247adffb733 Reviewed-on: https://gerrit.libreoffice.org/20411 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 5738a6fb4aa62f20416f164c2f4b9c170f1ebfb4) Reviewed-on: https://gerrit.libreoffice.org/20412 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2015-12-05tdf#96234: Type Formatting, Primary key checkbox may be checkedJulien Nabet1-5/+27
Right click on a field in Type Formatting (Base, paste a table from Calc for eg) makes a popup which takes into account now if the field is a primary key or not. Handles multi-fields primary key, too: the selected fields must be exactly those in the primary key, no more, no less. Change-Id: I545b946bccd3fc02f4f6c3bdb99f914d181a3d40 (cherry picked from commit b0658929bea09386f524879228b35996375537f4) Reviewed-on: https://gerrit.libreoffice.org/20409 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-12-03tdf#96012 enable simple mode for the multilistboxLionel Elie Mamane1-1/+1
Change-Id: Ia4d4c56318bc7d32d317abbda27eda9d3413ba75 Reviewed-on: https://gerrit.libreoffice.org/20362 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-11-30tdf#96135 - Crash : When Field Format Window CloseNoel Grandin1-0/+1
regression from commit db17d3c17c40d6b0e92392cf3c6e343d1d17b771 "new loplugin: memoryvar" Change-Id: Id37226646a561579a375110bf684140d1fa8cb92 (cherry picked from commit 2ba8476f650400c5285041e956d70d2c1c0bcf76)
2015-11-24-Werror,-Wunused-private-fieldStephan Bergmann6-11/+6
Change-Id: I595f0c2b05b96fbf2055a37e335f8c700044a699
2015-11-20loplugin:unusedfields in dbaccessNoel Grandin23-214/+141
Change-Id: I563c3727c1719fe21acced269e5469c2de7112e8
2015-11-20Remove last redundant toolbar:style propertiesSamuel Mehrbrodt3-5/+5
Change-Id: I42fa834464fd4cd7f0c1f11e310c1145fb1f071b
2015-11-20add mapKeysToSequence/mapValuesToSequence methods to comphelperNoel Grandin2-16/+3
and use them Change-Id: If4dc9df63db37185228aeaaab2979498d61304ec Reviewed-on: https://gerrit.libreoffice.org/20055 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-19Remove redundant toolbar:style attributesSamuel Mehrbrodt1-1/+1
These have been defined in the widgets Change-Id: If46a6862872286a454804846128bd8658f60af9b
2015-11-19loplugin:sallogareasStephan Bergmann1-2/+2
Change-Id: I2220ab194384fb397716bf3227d38716ba54f537
2015-11-19use comphelper::containerToSequenceNoel Grandin3-11/+4
in chart2, we remove a local equivalent of the method Change-Id: I25129a3d1ea1dd724eb9cd38a57be37a78b3d100
2015-11-17Toolbar: Remove empty attributesSamuel Mehrbrodt12-92/+92
Change-Id: Id78cae55eb89520bd87713f9ea6c009c922f2870
2015-11-16use initialiser list for Sequence<OUString>Noel Grandin2-6/+3
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02 Reviewed-on: https://gerrit.libreoffice.org/19978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15Fast PCH generator and optimized PCH filesAshod Nakashian5-858/+605
Ported update_pch.sh to Python with improved performance and features. The new script is invoked from the same update_pch.sh which calls it for each library in parallel, although it can be invoked directly. The ported script (update_pch) updates all PCH files in ~15 seconds where the old script took ~4500 seconds. In addition, the new script supports 3-tiered headers (system, module, and local) and is very flexible to support other improvement. It has a per-library optimal configuration settings that can be updated using another new scripts (update_pch_autotune.sh) which finds optimal per-PCH settings. PCH files have been generated using the new scripts which builds significantly faster (2-3x, depending on module and configuration) and the intermediate binaries are noticably smaller (by several GBs). The new script stamps each generated PCH file with the command that generated it to make it trivial for users to update them, and also adds the command to invoke another script (update_pch_bisect) that helps find missing headers or conflicting headers that may break the build after updating the PCH. Finally update_pch has built-in unit-tests for makefile parsing and other core functionality. Change-Id: Ib933b50e50374d7e2e7e3e95ba8799b0cc8a27fa Reviewed-on: https://gerrit.libreoffice.org/19965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin1-2/+1
using variations of: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\; \s*OUString\* pArray.*; .*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g" Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3 Reviewed-on: https://gerrit.libreoffice.org/19971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin12-30/+15
replaced using: git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<\s*OUString\s*> (\w+)\(\s*1\s*\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I20ad0489da887a9712982531c3b127339bb8b3b9 Reviewed-on: https://gerrit.libreoffice.org/19969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser for Sequence<OUString>Noel Grandin12-24/+12
performed using: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\); .*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g" Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f Reviewed-on: https://gerrit.libreoffice.org/19968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15use initialiser syntax for Sequence<OUString>Noel Grandin8-20/+10
replaced using the script: git grep -lP 'Sequence.*OUString.*\(1\)' | xargs perl -0777 -pi -e "s/Sequence< OUString > (\w+)\(1\); .*\[0\] = (\S+);/Sequence< OUString > \1 { \2 };/g" Change-Id: I23688a91562051a8eed11fc2a85599545c285c34 Reviewed-on: https://gerrit.libreoffice.org/19967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-115th step to remove tools/rtti.hxxOliver Specht20-37/+0
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11new loplugin: memoryvarNoel Grandin1-3/+3
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann220-1031/+1031
Change-Id: I2bba104b1bff30910864e45b5b032533099742ff
2015-11-09Prevent += called on temporary O[U]String instancesStephan Bergmann2-21/+17
...found regression e31205f3ec1f941ab5a188bfde6329edf2acc55b "EditUndoRemoveChars::GetStr must return a reference" and dubious code 0e23f7b0839df68d277186b4df54ba391ac3406a "Lets assume this doesn't want to update m_pForcedPrefix->GetText() anyway" in addition to the apparent sillies directly fixed in this commit. Introduces HAVE_CXX11_REF_QUALIFIER. Change-Id: I564e98254fd53c1dd9b34193d7057c59721ee24c
2015-11-09Lets assume this doesn't want to update m_pForcedPrefix->GetText() anywayStephan Bergmann1-1/+1
The line was like that ever since the code was introduced with 13d20309158340fca42c44e7a9a460ddbeee5126 "edit control for connection urls," and Window::GetText() likely never in the past returned a reference to a string. Change-Id: Ideb5c6a279ac25c2439187a9182f988696818012
2015-11-09new loplugin: oncevarNoel Grandin2-6/+4
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann26-58/+58
Change-Id: I14bdbad2469d05eb25514d7ab995acb8c6ef7bd1
2015-11-05java: remove ((unnecessary)) parenthesesNoel Grandin1-1/+1
Change-Id: I39fbe3a260c8dbfc203662c54eec4db064b88195
2015-11-05java: make inner classes static where possibleNoel Grandin1-1/+1
Change-Id: Icc6444ad15d9f4b50858d8c1b1d3adeaeac40926
2015-11-04loplugin:stringconstantNoel Grandin14-23/+23
Change-Id: Id5a07591a1d3a7264a0a979f25e8c2c859ec0492 Reviewed-on: https://gerrit.libreoffice.org/19767 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni1-6/+6
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-10-30use uno::Reference::set method instead of assignmentNoel Grandin15-21/+21
Change-Id: I3d45914e349a4268204af84b95b53ccce7b9d544
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin1-1/+1
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-30loplugin:unusedmethodsNoel Grandin2-7/+0
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f Reviewed-on: https://gerrit.libreoffice.org/19636 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-28dbaccess KeySet: on insert, set NULL only when there is no default valueLionel Elie Mamane1-1/+1
Change-Id: I4f9ea6760a7e47d28fe378c8429fb286d6e7f33e
2015-10-27Reduce scope of #include <tools/stream.hxx>Matteo Casalin8-4/+11
Change-Id: I0752cbb0cb2e0f89607d81d9eda7ce7091449fd6
2015-10-27loplugin:unusedmethodsNoel Grandin2-58/+0
Change-Id: I161cd52606c11b6008f5d8b1d8ee391692f91861 Reviewed-on: https://gerrit.libreoffice.org/19231 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-27inline SfxMediumRef typedefNoel Grandin1-1/+1
Change-Id: Id6dc03a5957adf657d12db7941273593a9f7c10f
2015-10-26remove extra spaces around ::Noel Grandin2-3/+3
just makes it harder to grep for methods Change-Id: I0925db2f9284972fcf7e1e3adf90cbe21f69eb15
2015-10-21more removal of com::sun::star typedefsNoel Grandin3-4/+3
Change-Id: Ia73f1b4f1dcfa3f0936359e744afe76e02dcd2eb
2015-10-21Fix indentation.Jan Holesovsky1-11/+12
Change-Id: Id33e58b6e298ff7b3a421a5cd96df1372a4a7923
2015-10-20tdf#89592: use initializer listmarstay1-27/+12
Change-Id: I5b2dece19512399f6646a8f7acf022d4230a760a Reviewed-on: https://gerrit.libreoffice.org/19430 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-20tdf#93724 KeySet insert: properly set default values: NULL & right typeLionel Elie Mamane1-1/+12
Change-Id: I933eed918e18b6923d4e0d24748297cf0dd0088d